34056 2010-01-24 06:05:42 -0800 Object Serialization assumes deserialization will always occur in the context of a webpage 2010-01-24 14:54:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 oliver webkit-unassigned darin mitz oldest_to_newest 184066 0 oliver 2010-01-24 06:05:42 -0800 Object Serialization assumes deserialization will always occur in the context of a webpage 184067 1 47296 oliver 2010-01-24 06:11:27 -0800 Created attachment 47296 Patch 184074 2 47296 darin 2010-01-24 09:26:52 -0800 Comment on attachment 47296 Patch r=me 184075 3 darin 2010-01-24 09:27:28 -0800 Could you add a comment to the change log explaining why there is no regression test? 184082 4 mitz 2010-01-24 10:32:02 -0800 <rdar://problem/7573833> 184116 5 oliver 2010-01-24 14:54:27 -0800 Committed r53785: <http://trac.webkit.org/changeset/53785> 47296 2010-01-24 06:11:27 -0800 2010-01-24 09:26:52 -0800 Patch bug-34056-20100124061125.patch text/plain 5544 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTM3MzcxZi4uN2Q4ZTI0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMC0wMS0yNCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE9iamVjdCBTZXJpYWxpemF0aW9uIGFzc3VtZXMgZGVzZXJpYWxpemF0aW9u IHdpbGwgYWx3YXlzIG9jY3VyIGluIHRoZSBjb250ZXh0IG9mIGEgd2VicGFnZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQwNTYKKyAgICAgICAgcmRh cjovLzc1NzM4MzMKKworICAgICAgICBBZGRlZCBDbGFzc0luZm8gdG8gSlNET01HbG9iYWxPYmpl Y3QgYW5kIG1ha2UgdGhlIHdpbmRvdyBhbmQgd29ya2VyIGNsYXNzIGluZm8KKyAgICAgICAgaW5o ZXJpdCBmcm9tIGl0LiAgV2l0aCB0aGlzIGluIHBsYWNlIHdlJ3JlIGFibGUgdG8gZGV0ZXJtaW5l IHdoZXRoZXIgYSBnaXZlbgorICAgICAgICBnbG9iYWwgb2JqZWN0IGlzIGEgRE9NR2xvYmFsT2Jq ZWN0LCBhbmQgdGhlbiB1c2UgdGhhdCBpbmZvcm1hdGlvbiB0byBhdm9pZAorICAgICAgICBhdHRl bXB0aW5nIHRvIGRlc2VyaWFsaXplIHR5cGVzIHRoYXQgcmVxdWlyZSB0aGUgcHJlc2VuY2Ugb2Yg dGhlIERPTS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Oik6CisgICAgICAgICogYmluZGluZ3MvanMvSlNET01HbG9iYWxP YmplY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NR2xvYmFsT2JqZWN0OjpjbGFzc0luZm8p OgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjopOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dEJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TZXJpYWxpemVk U2NyaXB0VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVzZXJpYWxpemluZ1RyZWVXYWxr ZXI6OkRlc2VyaWFsaXppbmdUcmVlV2Fsa2VyKToKKyAgICAgICAgKFdlYkNvcmU6OkRlc2VyaWFs aXppbmdUcmVlV2Fsa2VyOjpjb252ZXJ0SWZUZXJtaW5hbCk6CisKIDIwMTAtMDEtMjMgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWog U3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01HbG9iYWxP YmplY3QuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9iamVjdC5jcHAKaW5k ZXggODMxMGZkMS4uZTBiNWI4OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RP TUdsb2JhbE9iamVjdC5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2JhbE9i amVjdC5jcHAKQEAgLTQwLDYgKzQwLDggQEAgdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCitjb25zdCBDbGFzc0luZm8gSlNET01HbG9iYWxPYmplY3Q6OnNfaW5m byA9IHsgIkRPTUdsb2JhbE9iamVjdCIsIDAsIDAsIDAgfTsKKwogSlNET01HbG9iYWxPYmplY3Q6 OkpTRE9NR2xvYmFsT2JqZWN0KE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZT4gc3RydWN0dXJl LCBKU0RPTUdsb2JhbE9iamVjdDo6SlNET01HbG9iYWxPYmplY3REYXRhKiBkYXRhLCBKU09iamVj dCogdGhpc1ZhbHVlKQogICAgIDogSlNHbG9iYWxPYmplY3Qoc3RydWN0dXJlLCBkYXRhLCB0aGlz VmFsdWUpCiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2Jq ZWN0LmggYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NR2xvYmFsT2JqZWN0LmgKaW5kZXggYTVk NDEwZS4uOGViNTVjMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUdsb2Jh bE9iamVjdC5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01HbG9iYWxPYmplY3QuaApA QCAtNjcsNiArNjcsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgRE9NV3JhcHBl cldvcmxkKiB3b3JsZCgpIHsgcmV0dXJuIGQoKS0+bV93b3JsZC5nZXQoKTsgfQogCisgICAgICAg IHZpcnR1YWwgY29uc3QgSlNDOjpDbGFzc0luZm8qIGNsYXNzSW5mbygpIGNvbnN0IHsgcmV0dXJu ICZzX2luZm87IH0KKyAgICAgICAgc3RhdGljIGNvbnN0IEpTQzo6Q2xhc3NJbmZvIHNfaW5mbzsK KwogICAgIHByb3RlY3RlZDoKICAgICAgICAgc3RydWN0IEpTRE9NR2xvYmFsT2JqZWN0RGF0YSA6 IHB1YmxpYyBKU0M6OkpTR2xvYmFsT2JqZWN0OjpKU0dsb2JhbE9iamVjdERhdGEgewogICAgICAg ICAgICAgSlNET01HbG9iYWxPYmplY3REYXRhKERPTVdyYXBwZXJXb3JsZCogd29ybGQsIERlc3Ry dWN0b3IgZGVzdHJ1Y3RvciA9IGRlc3Ryb3lKU0RPTUdsb2JhbE9iamVjdERhdGEpCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAgYi9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAKaW5kZXggMTc2MDY2ZS4uNWIzYjZkZiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwCisrKyBiL1dl YkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcApAQCAtNDEsNyArNDEsNyBAQCB1 c2luZyBuYW1lc3BhY2UgSlNDOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNvbnN0IENsYXNz SW5mbyBKU0RPTVdpbmRvd0Jhc2U6OnNfaW5mbyA9IHsgIldpbmRvdyIsIDAsIDAsIDAgfTsKK2Nv bnN0IENsYXNzSW5mbyBKU0RPTVdpbmRvd0Jhc2U6OnNfaW5mbyA9IHsgIldpbmRvdyIsICZKU0RP TUdsb2JhbE9iamVjdDo6c19pbmZvLCAwLCAwIH07CiAKIEpTRE9NV2luZG93QmFzZTo6SlNET01X aW5kb3dCYXNlRGF0YTo6SlNET01XaW5kb3dCYXNlRGF0YShQYXNzUmVmUHRyPERPTVdpbmRvdz4g d2luZG93LCBKU0RPTVdpbmRvd1NoZWxsKiBzaGVsbCkKICAgICA6IEpTRE9NR2xvYmFsT2JqZWN0 RGF0YShzaGVsbC0+d29ybGQoKSwgZGVzdHJveUpTRE9NV2luZG93QmFzZURhdGEpCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dEJhc2UuY3BwIGIvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU1dvcmtlckNvbnRleHRCYXNlLmNwcAppbmRleCBmMGM0ZWZhLi4yNDkx ZjRkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dEJhc2Uu Y3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXb3JrZXJDb250ZXh0QmFzZS5jcHAKQEAg LTQyLDcgKzQyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBBU1NFUlRfQ0xBU1NfRklUU19J Tl9DRUxMKEpTV29ya2VyQ29udGV4dEJhc2UpOwogCi1jb25zdCBDbGFzc0luZm8gSlNXb3JrZXJD b250ZXh0QmFzZTo6c19pbmZvID0geyAiV29ya2VyQ29udGV4dCIsIDAsIDAsIDAgfTsKK2NvbnN0 IENsYXNzSW5mbyBKU1dvcmtlckNvbnRleHRCYXNlOjpzX2luZm8gPSB7ICJXb3JrZXJDb250ZXh0 IiwgJkpTRE9NR2xvYmFsT2JqZWN0OjpzX2luZm8sIDAsIDAgfTsKIAogSlNXb3JrZXJDb250ZXh0 QmFzZTo6SlNXb3JrZXJDb250ZXh0QmFzZShOb25OdWxsUGFzc1JlZlB0cjxKU0M6OlN0cnVjdHVy ZT4gc3RydWN0dXJlLCBQYXNzUmVmUHRyPFdvcmtlckNvbnRleHQ+IGltcGwpCiAgICAgOiBKU0RP TUdsb2JhbE9iamVjdChzdHJ1Y3R1cmUsIG5ldyBKU0RPTUdsb2JhbE9iamVjdERhdGEobm9ybWFs V29ybGQoKmltcGwtPnNjcmlwdCgpLT5nbG9iYWxEYXRhKCkpKSwgdGhpcykKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcCBiL1dlYkNvcmUv YmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAppbmRleCBiMzhhMDA5Li4yM2Ez NzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TZXJpYWxpemVkU2NyaXB0VmFsdWUuY3Bw CkBAIC02MTQsNiArNjE0LDggQEAgc3RydWN0IERlc2VyaWFsaXppbmdUcmVlV2Fsa2VyIDogcHVi bGljIEJhc2VXYWxrZXIgewogCiAgICAgRGVzZXJpYWxpemluZ1RyZWVXYWxrZXIoRXhlY1N0YXRl KiBleGVjLCBib29sIG11c3RDb3B5KQogICAgICAgICA6IEJhc2VXYWxrZXIoZXhlYykKKyAgICAg ICAgLCBtX2dsb2JhbE9iamVjdChleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCkpCisgICAgICAg ICwgbV9pc0RPTUdsb2JhbE9iamVjdChtX2dsb2JhbE9iamVjdC0+aW5oZXJpdHMoJkpTRE9NR2xv YmFsT2JqZWN0OjpzX2luZm8pKQogICAgICAgICAsIG1fbXVzdENvcHkobXVzdENvcHkpCiAgICAg ewogICAgIH0KQEAgLTY5NCw4ICs2OTYsMTIgQEAgc3RydWN0IERlc2VyaWFsaXppbmdUcmVlV2Fs a2VyIDogcHVibGljIEJhc2VXYWxrZXIgewogICAgICAgICAgICAgY2FzZSBTZXJpYWxpemVkU2Ny aXB0VmFsdWVEYXRhOjpEYXRlVHlwZToKICAgICAgICAgICAgICAgICByZXR1cm4gbmV3IChtX2V4 ZWMpIERhdGVJbnN0YW5jZShtX2V4ZWMsIHZhbHVlLmFzRG91YmxlKCkpOwogICAgICAgICAgICAg Y2FzZSBTZXJpYWxpemVkU2NyaXB0VmFsdWVEYXRhOjpGaWxlVHlwZToKKyAgICAgICAgICAgICAg ICBpZiAoIW1faXNET01HbG9iYWxPYmplY3QpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBq c051bGwoKTsKICAgICAgICAgICAgICAgICByZXR1cm4gdG9KUyhtX2V4ZWMsIHN0YXRpY19jYXN0 PEpTRE9NR2xvYmFsT2JqZWN0Kj4obV9leGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCkpLCBGaWxl OjpjcmVhdGUodmFsdWUuYXNTdHJpbmcoKS5jcm9zc1RocmVhZFN0cmluZygpKSk7CiAgICAgICAg ICAgICBjYXNlIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZURhdGE6OkZpbGVMaXN0VHlwZTogeworICAg ICAgICAgICAgICAgIGlmICghbV9pc0RPTUdsb2JhbE9iamVjdCkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIGpzTnVsbCgpOwogICAgICAgICAgICAgICAgIFJlZlB0cjxGaWxlTGlzdD4gcmVz dWx0ID0gRmlsZUxpc3Q6OmNyZWF0ZSgpOwogICAgICAgICAgICAgICAgIFNlcmlhbGl6ZWRGaWxl TGlzdCogc2VyaWFsaXplZEZpbGVMaXN0ID0gdmFsdWUuYXNGaWxlTGlzdCgpOwogICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGxlbmd0aCA9IHNlcmlhbGl6ZWRGaWxlTGlzdC0+bGVuZ3RoKCk7CkBA IC03NDYsNiArNzUyLDggQEAgc3RydWN0IERlc2VyaWFsaXppbmdUcmVlV2Fsa2VyIDogcHVibGlj IEJhc2VXYWxrZXIgewogICAgIH0KIAogcHJpdmF0ZToKKyAgICBKU0dsb2JhbE9iamVjdCogbV9n bG9iYWxPYmplY3Q7CisgICAgYm9vbCBtX2lzRE9NR2xvYmFsT2JqZWN0OwogICAgIGJvb2wgbV9t dXN0Q29weTsKIH07CiAK