34052 2010-01-24 02:09:50 -0800 [Qt] Clean up code to determine palette from page client in RenderThemeQt 2010-01-25 06:21:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 34053 1 hausmann webkit-unassigned oldest_to_newest 184056 0 hausmann 2010-01-24 02:09:50 -0800 [Qt] Clean up code to determine palette from page client in RenderThemeQt 184057 1 47291 hausmann 2010-01-24 02:10:46 -0800 Created attachment 47291 Patch 184261 2 47291 kenneth 2010-01-25 06:09:08 -0800 Comment on attachment 47291 Patch > + void setPaletteFromPageClientIfExists(QPalette &palette) const; Please fix the style here before committing. 184265 3 hausmann 2010-01-25 06:21:41 -0800 Committed r53801: <http://trac.webkit.org/changeset/53801> 47291 2010-01-24 02:10:46 -0800 2010-01-25 06:09:07 -0800 Patch bug-34052-20100124111044.patch text/plain 2510 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjE4NDZlNy4uNmUxOWE3ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gQ2xlYW4gdXAgY29kZSB0byBkZXRlcm1pbmUg cGFsZXR0ZSBmcm9tIHBhZ2UgY2xpZW50IGluIFJlbmRlclRoZW1lUXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MDUyCisKKyAgICAgICAgVXNlIHRo ZSBSZW5kZXJUaGVtZSdzIGFzc29jaWF0ZWQgcGFnZSBpbnN0ZWFkIG9mIGdvaW5nIHRocm91Z2gg dGhlCisgICAgICAgIHJlbmRlciB0cmVlIGFuZCB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRo ZW1lUXQ6OnNldFBhbGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRoZW1lUXQ6OmluaXRpYWxpemVDb21tb25RU3R5bGVPcHRpb25zKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0Lmg6CisKKzIwMTAtMDEtMjQgIFNpbW9uIEhh dXNtYW5uICA8aGF1c21hbm5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdIFJlZHVjZSB0aGUgc2l6ZSBvZiB0aGUgbGlicmFy eSB3aGVuIGNvbXBpbGluZyBmb3IgTWFlbW81CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNDA1MAogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1JlbmRlclRoZW1lUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0 LmNwcAppbmRleCBlMWE5NTdkLi5kNmNjY2YxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhl bWVRdC5jcHAKQEAgLTc2OCwxMyArNzY4LDEyIEBAIGJvb2wgUmVuZGVyVGhlbWVRdDo6c3VwcG9y dHNGb2N1cyhDb250cm9sUGFydCBhcHBlYXJhbmNlKSBjb25zdAogICAgIH0KIH0KIAotc3RhdGlj IGlubGluZSB2b2lkIHNldFBhbGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKFFQYWxldHRlICZw YWxldHRlLCBjb25zdCBSZW5kZXJPYmplY3QgKm8pCit2b2lkIFJlbmRlclRoZW1lUXQ6OnNldFBh bGV0dGVGcm9tUGFnZUNsaWVudElmRXhpc3RzKFFQYWxldHRlICZwYWxldHRlKSBjb25zdAogewog ICAgIC8vIElmIHRoZSB3ZWJ2aWV3IGhhcyBhIGN1c3RvbSBwYWxldHRlLCB1c2UgaXQKLSAgICBQ YWdlKiBwYWdlID0gby0+ZG9jdW1lbnQoKS0+cGFnZSgpOwotICAgIGlmICghcGFnZSkKKyAgICBp ZiAoIW1fcGFnZSkKICAgICAgICAgcmV0dXJuOwotICAgIENocm9tZSogY2hyb21lID0gcGFnZS0+ Y2hyb21lKCk7CisgICAgQ2hyb21lKiBjaHJvbWUgPSBtX3BhZ2UtPmNocm9tZSgpOwogICAgIGlm ICghY2hyb21lKQogICAgICAgICByZXR1cm47CiAgICAgQ2hyb21lQ2xpZW50KiBjaHJvbWVDbGll bnQgPSBjaHJvbWUtPmNsaWVudCgpOwpAQCAtODAzLDcgKzgwMiw3IEBAIENvbnRyb2xQYXJ0IFJl bmRlclRoZW1lUXQ6OmluaXRpYWxpemVDb21tb25RU3R5bGVPcHRpb25zKFFTdHlsZU9wdGlvbiYg b3B0aW9uLCBSCiAgICAgaWYgKGlzSG92ZXJlZChvKSkKICAgICAgICAgb3B0aW9uLnN0YXRlIHw9 IFFTdHlsZTo6U3RhdGVfTW91c2VPdmVyOwogCi0gICAgc2V0UGFsZXR0ZUZyb21QYWdlQ2xpZW50 SWZFeGlzdHMob3B0aW9uLnBhbGV0dGUsIG8pOworICAgIHNldFBhbGV0dGVGcm9tUGFnZUNsaWVu dElmRXhpc3RzKG9wdGlvbi5wYWxldHRlKTsKICAgICBSZW5kZXJTdHlsZSogc3R5bGUgPSBvLT5z dHlsZSgpOwogICAgIGlmICghc3R5bGUpCiAgICAgICAgIHJldHVybiBOb0NvbnRyb2xQYXJ0Owpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmggYi9XZWJDb3Jl L3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuaAppbmRleCBlZTg1NGE0Li45NWQ0ZDhjIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuaAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuaApAQCAtMTQwLDYgKzE0MCw4IEBAIHByaXZhdGU6 CiAgICAgdm9pZCBzZXRCdXR0b25QYWRkaW5nKFJlbmRlclN0eWxlKikgY29uc3Q7CiAgICAgdm9p ZCBzZXRQb3B1cFBhZGRpbmcoUmVuZGVyU3R5bGUqKSBjb25zdDsKIAorICAgIHZvaWQgc2V0UGFs ZXR0ZUZyb21QYWdlQ2xpZW50SWZFeGlzdHMoUVBhbGV0dGUgJnBhbGV0dGUpIGNvbnN0OworCiAg ICAgUVN0eWxlKiBxU3R5bGUoKSBjb25zdDsKICAgICBRU3R5bGUqIGZhbGxiYWNrU3R5bGUoKTsK IAo=