34043 2010-01-23 12:27:54 -0800 [GTK] When selection changes selections in other WebView are not collapsed 2010-02-02 05:32:43 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mrobinson webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 184015 0 mrobinson 2010-01-23 12:27:54 -0800 When the X11 selection changes, the selection in the WebView will collapse. If the new selection is in another WebView though, both selections will still be active. To reproduce: 1. In Epiphany, open two tabs. 2. Select some text in one tab. 3. Select some text in the next. 4. Note that the selection still exists in both tabs. 184016 1 47275 mrobinson 2010-01-23 12:36:08 -0800 Created attachment 47275 Patch for this issue I've attached a patch for this issue which sends a bit more information to the clear callback. 185727 2 mrobinson 2010-01-28 21:42:46 -0800 kov raised some concerns over IRC that this might break tests that seek that verify that one selection can exist per-frame. This change doesn't actually "fix" that behavior. The selection will only be collapsed if it is in another WebView or another application. I think fixing this to work between frame might deserve another patch. 186934 3 47275 commit-queue 2010-02-02 05:32:37 -0800 Comment on attachment 47275 Patch for this issue Clearing flags on attachment: 47275 Committed r54230: <http://trac.webkit.org/changeset/54230> 186935 4 commit-queue 2010-02-02 05:32:43 -0800 All reviewed patches have been landed. Closing bug. 47275 2010-01-23 12:36:08 -0800 2010-02-02 05:32:37 -0800 Patch for this issue 0001-Collapse-selection-of-other-WebViews.patch text/plain 4097 mrobinson RnJvbSBhZmM4MTMwYjY1NTRmMGFmMjY0MjE2MmRlNDhlYjQ0ZjQ5MGFiODI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IFNhdCwgMjMgSmFuIDIwMTAgMTA6MTY6NDcgLTA4MDAKU3ViamVj dDogW1BBVENIXSBDb2xsYXBzZSBzZWxlY3Rpb24gb2Ygb3RoZXIgV2ViVmlld3MuCgotLS0KIFdl YktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsr KysrKysrKysrKysrCiBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1Bhc3RlYm9hcmRIZWxwZXJH dGsuY3BwIHwgICAyNCArKysrKysrKysrKy0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzMCBp bnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0No YW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGI1OTZhOGYuLmZlNWY2MTYgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDEtMjMgIE1hcnRpbiBSb2JpbnNvbiAgPG1hcnRpbi5q YW1lcy5yb2JpbnNvbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW0dUS10gV2hlbiBzZWxlY3Rpb24gY2hhbmdlcyBzZWxlY3Rpb25z IGluIG90aGVyIFdlYlZpZXcgYXJlIG5vdCBjb2xsYXBzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MDQzCisKKyAgICAgICAgQ29sbGFwc2UgdGhl IHNlbGVjdGlvbiBvZiBhIFdlYlZpZXcgZXZlbiB3aGVuIHRoZSBuZXcgc2VsZWN0aW9uIG93bmVy IGlzCisgICAgICAgIGEgbmV3IFdlYlZpZXcuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9Q YXN0ZWJvYXJkSGVscGVyR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Y2xlYXJDbGlwYm9hcmRD b250ZW50c0NhbGxiYWNrKTogT25seSBjbGVhciB0aGUgRGF0YU9iamVjdCB3ZSBhcmUgc2V0dGlu ZworICAgICAgICBpcyBub3QgdGhlIHNhbWUgYXMgdGhlIG9uZSByZWZlcmVuY2VkIGluIHRoaXMg Y2FsbGJhY2suIFVzZSB0aGUgc2FtZSBiZWhhdmlvciBmb3IKKyAgICAgICAgY29sbGFwc2luZyB0 aGUgc2VsZWN0aW9uLgorICAgICAgICAoV2ViS2l0OjpQYXN0ZWJvYXJkSGVscGVyR3RrOjp3cml0 ZUNsaXBib2FyZENvbnRlbnRzKTogSW5zdGVhZCBvZiByZWNvcmRpbmcgYSBib29sZWFuCisgICAg ICAgIHJlY29yZCB0aGUgYWN0dWFsIGRhdGEgdXNlZCB3aGlsZSB3cml0aW5nIHRvIHRoZSBjbGlw Ym9hcmQuCisKIDIwMTAtMDEtMTkgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0Bn bWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcCBiL1dlYktp dC9ndGsvV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAKaW5kZXggODQwNmFk YS4uYjhlYjkyZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJv YXJkSGVscGVyR3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1Bhc3RlYm9h cmRIZWxwZXJHdGsuY3BwCkBAIC0xMDUsNyArMTA1LDggQEAgc3RhdGljIEd0a1RhcmdldExpc3Qq IHRhcmdldExpc3RGb3JEYXRhT2JqZWN0KERhdGFPYmplY3RHdGsqIGRhdGFPYmplY3QpCiAgICAg cmV0dXJuIGxpc3Q7CiB9CiAKLXN0YXRpYyBib29sIHNldHRpbmdDbGlwYm9hcmQgPSBmYWxzZTsK K3N0YXRpYyBEYXRhT2JqZWN0R3RrKiBzZXR0aW5nQ2xpcGJvYXJkRGF0YU9iamVjdCA9IDA7Citz dGF0aWMgZ3BvaW50ZXIgc2V0dGluZ0NsaXBib2FyZERhdGEgPSAwOwogc3RhdGljIHZvaWQgZ2V0 Q2xpcGJvYXJkQ29udGVudHNDYWxsYmFjayhHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCwgR3RrU2Vs ZWN0aW9uRGF0YSAqc2VsZWN0aW9uRGF0YSwgZ3VpbnQgaW5mbywgZ3BvaW50ZXIgZGF0YSkKIHsK ICAgICBEYXRhT2JqZWN0R3RrKiBkYXRhT2JqZWN0ID0gRGF0YU9iamVjdEd0azo6Zm9yQ2xpcGJv YXJkKGNsaXBib2FyZCk7CkBAIC0xMTUsMTcgKzExNiwxNiBAQCBzdGF0aWMgdm9pZCBnZXRDbGlw Ym9hcmRDb250ZW50c0NhbGxiYWNrKEd0a0NsaXBib2FyZCogY2xpcGJvYXJkLCBHdGtTZWxlY3Rp b25EYQogCiBzdGF0aWMgdm9pZCBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2soR3RrQ2xp cGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludGVyIGRhdGEpCiB7Ci0gICAgLy8gR1RLIHdpbGwgY2Fs bCB0aGUgY2xlYXIgY2xpcGJvYXJkIGNhbGxiYWNrIHdoaWxlIHNldHRpbmcgY2xpcGJvYXJkIGRh dGEuCi0gICAgLy8gV2UgZG9uJ3QgYWN0dWFsbHkgd2FudCB0byBjbGVhciB0aGUgRGF0YU9iamVj dCBkdXJpbmcgdGhhdCB0aW1lLgotICAgIGlmIChzZXR0aW5nQ2xpcGJvYXJkKQotICAgICAgICBy ZXR1cm47Ci0KICAgICBEYXRhT2JqZWN0R3RrKiBkYXRhT2JqZWN0ID0gRGF0YU9iamVjdEd0azo6 Zm9yQ2xpcGJvYXJkKGNsaXBib2FyZCk7CiAgICAgQVNTRVJUKGRhdGFPYmplY3QpOwotICAgIGRh dGFPYmplY3QtPmNsZWFyKCk7CiAKLSAgICAvLyBUaGlzIHdpbGwgYmUgdHJ1ZSBmb3IgY2xpcGJv YXJkcyBvdGhlciB0aGFuIFgxMSBwcmltYXJ5LgotICAgIGlmICghZGF0YSkKKyAgICAvLyBPbmx5 IGNsZWFyIHRoZSBEYXRhT2JqZWN0IGZvciB0aGlzIGNsaXBib2FyZCBpZiB3ZSBhcmUgbm90IGN1 cnJlbnRseSBzZXR0aW5nIGl0LgorICAgIGlmIChkYXRhT2JqZWN0ICE9IHNldHRpbmdDbGlwYm9h cmREYXRhT2JqZWN0KQorICAgICAgICBkYXRhT2JqZWN0LT5jbGVhcigpOworCisgICAgLy8gT25s eSBjb2xsYXBzZSB0aGUgc2VsZWN0aW9uIGlmIHRoaXMgaXMgYW4gWDExIHByaW1hcnkgY2xpcGJv YXJkCisgICAgLy8gYW5kIHdlIGFyZW4ndCBjdXJyZW50bHkgc2V0dGluZyB0aGUgY2xpcGJvYXJk IGZvciB0aGlzIFdlYlZpZXcuCisgICAgaWYgKCFkYXRhIHx8IGRhdGEgPT0gc2V0dGluZ0NsaXBi b2FyZERhdGEpCiAgICAgICAgIHJldHVybjsKIAogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcg PSByZWludGVycHJldF9jYXN0PFdlYktpdFdlYlZpZXcqPihkYXRhKTsKQEAgLTE1NCw3ICsxNTQs OCBAQCB2b2lkIFBhc3RlYm9hcmRIZWxwZXJHdGs6OndyaXRlQ2xpcGJvYXJkQ29udGVudHMoR3Rr Q2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludAogICAgIEd0a1RhcmdldEVudHJ5KiB0YWJsZSA9 IGd0a190YXJnZXRfdGFibGVfbmV3X2Zyb21fbGlzdChsaXN0LCAmbnVtYmVyT2ZUYXJnZXRzKTsK IAogICAgIGlmIChudW1iZXJPZlRhcmdldHMgPiAwICYmIHRhYmxlKSB7Ci0gICAgICAgIHNldHRp bmdDbGlwYm9hcmQgPSB0cnVlOworICAgICAgICBzZXR0aW5nQ2xpcGJvYXJkRGF0YU9iamVjdCA9 IGRhdGFPYmplY3Q7CisgICAgICAgIHNldHRpbmdDbGlwYm9hcmREYXRhID0gZGF0YTsKIAogICAg ICAgICAvLyBQcm90ZWN0IHRoZSB3ZWIgdmlldyBmcm9tIGJlaW5nIGRlc3Ryb3llZCBiZWZvcmUg b25lIG9mIHRoZSBjbGlwYm9hcmQgY2FsbGJhY2tzCiAgICAgICAgIC8vIGlzIGNhbGxlZC4gQmFs YW5jZWQgaW4gYm90aCBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrIGFuZApAQCAtMTY4LDcg KzE2OSw4IEBAIHZvaWQgUGFzdGVib2FyZEhlbHBlckd0azo6d3JpdGVDbGlwYm9hcmRDb250ZW50 cyhHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCwgZ3BvaW50CiAgICAgICAgIGlmICghc3VjY2VlZGVk KQogICAgICAgICAgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CiAKLSAgICAgICAgc2V0dGlu Z0NsaXBib2FyZCA9IGZhbHNlOworICAgICAgICBzZXR0aW5nQ2xpcGJvYXJkRGF0YU9iamVjdCA9 IDA7CisgICAgICAgIHNldHRpbmdDbGlwYm9hcmREYXRhID0gMDsKICAgICB9IGVsc2UKICAgICAg ICAgZ3RrX2NsaXBib2FyZF9jbGVhcihjbGlwYm9hcmQpOwogCi0tIAoxLjYuMy4zCgo=