34034 2010-01-22 21:04:47 -0800 Race condition in video setup can force videos into software mode 2010-01-23 08:09:11 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser eric.carlson oldest_to_newest 183937 0 simon.fraser 2010-01-22 21:04:47 -0800 Sometimes video elements can go into software mode, if the the cursor happens to be over the video element around page load time. The issue is that when the mouse is over the content area, we do an eager layout, which in turn updates compositing layers. RenderLayerCompositor::updateBacking() calls video->acceleratedRenderingStateChanged(), but before any data has loaded, so all the videos start in software mode. Once in softare mode, they don't get pushed into hardware mode later. 183938 1 simon.fraser 2010-01-22 21:05:09 -0800 <rdar://problem/7524278> 183945 2 47264 simon.fraser 2010-01-22 21:29:26 -0800 Created attachment 47264 Patch 183950 3 47264 eric.carlson 2010-01-22 22:01:20 -0800 Comment on attachment 47264 Patch While not new to this patch, I think there is still have a problem if mediaPlayerGraphicsLayer() ever returns NULL. The rendering mode will be set to MediaRenderingMovieLayer, but the QTMovieLayer won't get attached until the rendering state changes. r=me 183952 4 simon.fraser 2010-01-22 22:02:41 -0800 I filed bug 34036 to address that problem. 183990 5 simon.fraser 2010-01-23 08:09:11 -0800 http://trac.webkit.org/changeset/53768 47264 2010-01-22 21:29:26 -0800 2010-01-22 22:01:20 -0800 Patch bug-34034-20100122212925.patch text/plain 3734 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWQ2YjMyZi4uZjIxMzcyYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMyBAQAogMjAxMC0wMS0yMiAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSYWNlIGNvbmRpdGlvbiBpbiB2aWRlbyBzZXR1cCBjYW4gZm9y Y2UgdmlkZW9zIGludG8gc29mdHdhcmUgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzQwMzQKKworICAgICAgICBXZSB1c2VkIHRvIGNhbGwgc2V0 VXBWaWRlb1JlbmRlcmluZygpIHVuY29uZGl0aW9uYWxseSBmcm9tCisgICAgICAgIGFjY2VsZXJh dGVkUmVuZGVyaW5nU3RhdGVDaGFuZ2VkKCk7IHRoaXMgY291bGQgaGFwcGVuIGJlZm9yZSB0aGUg bW92aWUgaGFkIGFueQorICAgICAgICBkYXRhLCBhbmQgdGh1cyBmb3JjZSB0aGUgbW92aWUgaW50 byBzb2Z0d2FyZSByZW5kZXJpbmcgbW9kZS4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSByZXR1 cm5pbmcgZWFybHkgZnJvbSBzZXRVcFZpZGVvUmVuZGVyaW5nKCkgaWYgaXNSZWFkeUZvclJlbmRl cmluZygpIHJldHVybnMgZmFsc2UsCisgICAgICAgIHdoaWNoIGFsc28gYWxsb3dzIHVzIHRvIHJl bW92ZSBzb21lIG90aGVyIGNoZWNrcyBmb3IgYmVpbmcgcmVhZHkgdG8gcmVuZGVyLgorICAgICAg ICAKKyAgICAgICAgVGltaW5nIGRlcGVuZGVudCwgaGFyZCB0byBtYWtlIGEgdGVzdCBmb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NMYXllckNBLm1tOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNBOjpzZXRDb250ZW50c1RvTWVkaWEpOiBPcHRp bWl6ZSB0byBkbyBhbiBlYXJseSByZXR1cm4KKyAgICAgICAgaWYgcGFzc2luZyBpbiB0aGUgc2Ft ZSBsYXllciB0aGF0IGlzIGFscmVhZHkgYmVpbmcgdXNlZC4KKyAgICAgICAgCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRVcFZpZGVvUmVuZGVyaW5nKTogUmV0 dXJuIHdpdGhvdXQgZG9pbmcgYW55dGhpbmcKKyAgICAgICAgaWYgbm90IHJlYWR5IHRvIHJlbmRl ci4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKTog Tm8gbmVlZCB0byBjYWxsIGlzUmVhZHlGb3JSZW5kZXJpbmcoKQorICAgICAgICBhbnkgbW9yZSwg c2luY2Ugc2V0VXBWaWRlb1JlbmRlcmluZygpIGRvZXMgdGhhdC4KKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0VmlzaWJsZSk6IE5vIG5lZWQgdG8gY2hlY2sgdGhlIHJl YWR5IHN0YXRlOyB0aGlzCisgICAgICAgIGlzIGVxdWl2YWxlbnQgdG8gdGhlIGNoZWNrIGluc2lk ZSBvZiBzZXRVcFZpZGVvUmVuZGVyaW5nKCkuCisKKzIwMTAtMDEtMjIgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5z dGVpbi4KIAogICAgICAgICBSRUdSRVNTSU9OIChyNTMxMTApOiBGaW5kIE15IGlQaG9uZSBtZXNz YWdlIGRpYWxvZyBpcyBvZmZzZXQgZnJvbSBvcmlnaW5hbCBwb3NpdGlvbiBvbmNlIGl0IGdldHMg Zm9jdXMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNz TGF5ZXJDQS5tbSBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzTGF5ZXJD QS5tbQppbmRleCA4MDFmNTgzLi43YmY1N2Q0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9HcmFwaGljc0xheWVyQ0EubW0KKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvR3JhcGhpY3NMYXllckNBLm1tCkBAIC03OTQsOCArNzk0LDEwIEBAIHZvaWQg R3JhcGhpY3NMYXllckNBOjpzZXRDb250ZW50c1RvSW1hZ2UoSW1hZ2UqIGltYWdlKQogCiB2b2lk IEdyYXBoaWNzTGF5ZXJDQTo6c2V0Q29udGVudHNUb01lZGlhKFBsYXRmb3JtTGF5ZXIqIG1lZGlh TGF5ZXIpCiB7Ci0gICAgaWYgKG1lZGlhTGF5ZXIgIT0gbV9jb250ZW50c0xheWVyLmdldCgpKQot ICAgICAgICBub3RlU3VibGF5ZXJzQ2hhbmdlZCgpOworICAgIGlmIChtZWRpYUxheWVyID09IG1f Y29udGVudHNMYXllcikKKyAgICAgICAgcmV0dXJuOworCisgICAgbm90ZVN1YmxheWVyc0NoYW5n ZWQoKTsKIAogICAgIG1fY29udGVudHNMYXllciA9IG1lZGlhTGF5ZXI7CiAgICAgbm90ZUxheWVy UHJvcGVydHlDaGFuZ2VkKENvbnRlbnRzTWVkaWFMYXllckNoYW5nZWQpOwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0g Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5t bQppbmRleCA3MDFmNzc5Li4zYzc5YmYzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQpAQCAtNDk5LDYgKzQ5 OSw5IEBAIE1lZGlhUGxheWVyUHJpdmF0ZTo6TWVkaWFSZW5kZXJpbmdNb2RlIE1lZGlhUGxheWVy UHJpdmF0ZTo6cHJlZmVycmVkUmVuZGVyaW5nTW9kCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl OjpzZXRVcFZpZGVvUmVuZGVyaW5nKCkKIHsKKyAgICBpZiAoIWlzUmVhZHlGb3JSZW5kZXJpbmco KSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgTWVkaWFSZW5kZXJpbmdNb2RlIGN1cnJlbnRNb2Rl ID0gY3VycmVudFJlbmRlcmluZ01vZGUoKTsKICAgICBNZWRpYVJlbmRlcmluZ01vZGUgcHJlZmVy cmVkTW9kZSA9IHByZWZlcnJlZFJlbmRlcmluZ01vZGUoKTsKICAgICBpZiAoY3VycmVudE1vZGUg PT0gcHJlZmVycmVkTW9kZSAmJiBjdXJyZW50TW9kZSAhPSBNZWRpYVJlbmRlcmluZ05vbmUpCkBA IC05NjcsNyArOTcwLDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcygp CiAgICAgICAgIH0KICAgICB9CiAKLSAgICBpZiAoaXNSZWFkeUZvclJlbmRlcmluZygpICYmICFo YXNTZXRVcFZpZGVvUmVuZGVyaW5nKCkpCisgICAgaWYgKCFoYXNTZXRVcFZpZGVvUmVuZGVyaW5n KCkpCiAgICAgICAgIHNldFVwVmlkZW9SZW5kZXJpbmcoKTsKIAogICAgIGlmIChzZWVraW5nKCkp CkBAIC0xMDY0LDEwICsxMDY3LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnNldFZpc2li bGUoYm9vbCBiKQogewogICAgIGlmIChtX3Zpc2libGUgIT0gYikgewogICAgICAgICBtX3Zpc2li bGUgPSBiOwotICAgICAgICBpZiAoYikgewotICAgICAgICAgICAgaWYgKG1fcmVhZHlTdGF0ZSA+ PSBNZWRpYVBsYXllcjo6SGF2ZU1ldGFkYXRhKQotICAgICAgICAgICAgICAgIHNldFVwVmlkZW9S ZW5kZXJpbmcoKTsKLSAgICAgICAgfSBlbHNlCisgICAgICAgIGlmIChiKQorICAgICAgICAgICAg c2V0VXBWaWRlb1JlbmRlcmluZygpOworICAgICAgICBlbHNlCiAgICAgICAgICAgICB0ZWFyRG93 blZpZGVvUmVuZGVyaW5nKCk7CiAgICAgfQogfQo=