34026 2010-01-22 15:25:04 -0800 [V8] Making V8 generated classes' GetTemplate() function public 2010-02-01 17:00:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32638 1 japhet kkanetkar commit-queue eric oldest_to_newest 183833 0 japhet 2010-01-22 15:25:04 -0800 All the logic for depending directly on V8<class>::GetTemplate() is in place for all but a couple classes (and those patches are in flight). Make GetTemplate() public. Also, while editing CodeGenetaorV8.pm, we should get rid of all the #includes of V8CustomBinding.h, since the generated bindings shouldn't need it any longer. 185988 1 47740 kkanetkar 2010-01-29 15:48:00 -0800 Created attachment 47740 GetTemplate() public and removed refs to V8CustomBinding.h 186529 2 47740 japhet 2010-02-01 12:45:00 -0800 Comment on attachment 47740 GetTemplate() public and removed refs to V8CustomBinding.h Looks good, thanks! 186530 3 47740 commit-queue 2010-02-01 12:45:27 -0800 Comment on attachment 47740 GetTemplate() public and removed refs to V8CustomBinding.h Rejecting patch 47740 from review queue. japhet@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 186534 4 japhet 2010-02-01 12:51:48 -0800 I'll r+ this again once the commit-queue has been restarted :) 186545 5 eric 2010-02-01 13:28:25 -0800 the commit-queue has been restarted and will now recognize nate as a reviewer. 186548 6 47740 japhet 2010-02-01 13:30:47 -0800 Comment on attachment 47740 GetTemplate() public and removed refs to V8CustomBinding.h r+ again then! 186706 7 47740 commit-queue 2010-02-01 17:00:26 -0800 Comment on attachment 47740 GetTemplate() public and removed refs to V8CustomBinding.h Clearing flags on attachment: 47740 Committed r54179: <http://trac.webkit.org/changeset/54179> 186707 8 commit-queue 2010-02-01 17:00:32 -0800 All reviewed patches have been landed. Closing bug. 47740 2010-01-29 15:48:00 -0800 2010-02-01 17:00:26 -0800 GetTemplate() public and removed refs to V8CustomBinding.h bug2patch2.txt text/plain 5048 kkanetkar SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDA4MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEtMjkgIEthdml0YSBLYW5ldGthciAgPGtrYW5ldGthckBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBNYWtpbmcgVjggZ2VuZXJhdGVkIGNsYXNzZXMnIEdldFRlbXBsYXRlKCkgZnVu Y3Rpb24gcHVibGljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNDAyNgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG06IEdlbmVyYXRlZCBjb2RlIG5lZWQgbm90IGRlcGVuZCBvbiBWOEN1c3RvbUJpbmRpbmcuaCwg bWFkZSBHZXRUZW1wbGF0ZSgpIHNpZ25hdHVyZSBwdWJsaWMuCisKIDIwMTAtMDEtMjkgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFu IEJlcm5zdGVpbi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JWOC5wbQkocmV2aXNpb24gNTQwODEpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC05NTUsNyArOTU1LDYgQEAKICAgICAg ICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgaW1wLT5zZXRBdHRyaWJ1dGUoJHtu YW1lc3BhY2V9Ojoke2NvbnRlbnRBdHRyaWJ1dGVOYW1lfUF0dHIsICRyZXN1bHQiKTsKICAgICAg ICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJFdmVudExpc3RlbmVy IikgewogICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIu aCJ9ID0gMTsKLSAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IlY4Q3VzdG9tQmluZGluZy5oIn0g PSAxOwogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICB0cmFuc2Zlckhp ZGRlbkRlcGVuZGVuY3koaW5mby5Ib2xkZXIoKSwgaW1wLT4kYXR0ck5hbWUoKSwgdmFsdWUsIFY4 JHtpbnRlcmZhY2VOYW1lfTo6Y2FjaGVJbmRleCk7XG4iKTsKICAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50RGVjbHMsICIgICAgaW1wLT5zZXQkaW1wbFNldHRlckZ1bmN0aW9uTmFtZShWOERP TVdyYXBwZXI6OmdldEV2ZW50TGlzdGVuZXIoaW1wLCB2YWx1ZSwgdHJ1ZSwgTGlzdGVuZXJGaW5k T3JDcmVhdGUpIik7CiAgICAgICAgIH0gZWxzZSB7CkBAIC0xNDk3LDEwICsxNDk2LDggQEAKIAog ICAgICAgICAjIEdlbmVyYXRlIHNwZWNpYWwgY29kZSBmb3IgdGhlIGNvbnN0cnVjdG9yIGF0dHJp YnV0ZXMuCiAgICAgICAgIGlmICgkYXR0clR5cGUgPX4gL0NvbnN0cnVjdG9yJC8pIHsKLSAgICAg ICAgICAgIGlmICgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJD dXN0b21HZXR0ZXIifSB8fAotICAgICAgICAgICAgICAgICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tR2V0dGVyIn0pIHsKLSAgICAgICAgICAgICAg ICAkaW1wbEluY2x1ZGVzeyJWOEN1c3RvbUJpbmRpbmcuaCJ9ID0gMTsKLSAgICAgICAgICAgIH0g ZWxzZSB7CisgICAgICAgICAgICBpZiAoISgkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVk QXR0cmlidXRlcy0+eyJDdXN0b21HZXR0ZXIifSB8fAorICAgICAgICAgICAgICAgICRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tR2V0dGVyIn0pKSB7 CiAgICAgICAgICAgICAgICAgJGhhc0NvbnN0cnVjdG9ycyA9IDE7CiAgICAgICAgICAgICB9CiAg ICAgICAgICAgICBuZXh0OwpAQCAtMTUxNSwyNSArMTUxMiwyMiBAQAogICAgICAgICAjIGltcGxl bWVudGF0aW9uLgogICAgICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0 dHJpYnV0ZXMtPnsiQ3VzdG9tIn0gfHwKICAgICAgICAgICAgICRhdHRyaWJ1dGUtPnNpZ25hdHVy ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tIn0pIHsKLSAgICAgICAgICAgICRpbXBs SW5jbHVkZXN7IlY4Q3VzdG9tQmluZGluZy5oIn0gPSAxOwogICAgICAgICAgICAgbmV4dDsKICAg ICAgICAgfQogCiAgICAgICAgICMgR2VuZXJhdGUgdGhlIGFjY2Vzc29yLgotICAgICAgICBpZiAo JGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tR2V0dGVy In0gfHwKLSAgICAgICAgICAgICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1 dGVzLT57IlY4Q3VzdG9tR2V0dGVyIn0pIHsKLSAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IlY4 Q3VzdG9tQmluZGluZy5oIn0gPSAxOwotICAgICAgICB9IGVsc2UgeworICAgICAgICBpZiAoISgk YXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21HZXR0ZXIi fSB8fAorICAgICAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiVjhDdXN0b21HZXR0ZXIifSkpIHsKICAgICAgICAgICAgIEdlbmVyYXRlTm9ybWFsQXR0 ckdldHRlcigkYXR0cmlidXRlLCAkZGF0YU5vZGUsICRjbGFzc0luZGV4LCAkaW1wbENsYXNzTmFt ZSwgJGludGVyZmFjZU5hbWUpOwogICAgICAgICB9Ci0gICAgICAgIGlmICgkYXR0cmlidXRlLT5z aWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21TZXR0ZXIifSB8fAotICAgICAg ICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiVjhDdXN0 b21TZXR0ZXIifSkgewotICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siVjhDdXN0b21CaW5kaW5n LmgifSA9IDE7Ci0gICAgICAgIH0gZWxzaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57IlJlcGxhY2VhYmxlIn0pIHsKLSAgICAgICAgICAgICRkYXRhTm9kZS0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkV4dGVuZHNET01HbG9iYWxPYmplY3QifSB8fCBkaWUgIlJl cGxhY2VhYmxlIGF0dHJpYnV0ZSBjYW4gb25seSBiZSB1c2VkIGluIGludGVyZmFjZSB0aGF0IGRl ZmluZXMgRXh0ZW5kc0RPTUdsb2JhbE9iamVjdCBhdHRyaWJ1dGUhIjsKLSAgICAgICAgICAgICMg R2VuZXJhdGVSZXBsYWNlYWJsZUF0dHJTZXR0ZXIoJGltcGxDbGFzc05hbWUpOwotICAgICAgICB9 IGVsc2lmICgkYXR0cmlidXRlLT50eXBlICF+IC9ecmVhZG9ubHkvICYmICEkYXR0cmlidXRlLT5z aWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOFJlYWRPbmx5In0pIHsKLSAgICAgICAg ICAgIEdlbmVyYXRlTm9ybWFsQXR0clNldHRlcigkYXR0cmlidXRlLCAkZGF0YU5vZGUsICRjbGFz c0luZGV4LCAkaW1wbENsYXNzTmFtZSwgJGludGVyZmFjZU5hbWUpOworICAgICAgICBpZiAoISgk YXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21TZXR0ZXIi fSB8fAorICAgICAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiVjhDdXN0b21TZXR0ZXIifSkpIHsKKyAgICAgICAgICAgIGlmICgkYXR0cmlidXRlLT5z aWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJSZXBsYWNlYWJsZSJ9KSB7CisgICAgICAg ICAgICAgICAgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRXh0ZW5kc0RPTUdsb2Jh bE9iamVjdCJ9IHx8IGRpZSAiUmVwbGFjZWFibGUgYXR0cmlidXRlIGNhbiBvbmx5IGJlIHVzZWQg aW4gaW50ZXJmYWNlIHRoYXQgZGVmaW5lcyBFeHRlbmRzRE9NR2xvYmFsT2JqZWN0IGF0dHJpYnV0 ZSEiOworICAgICAgICAgICAgICAgICMgR2VuZXJhdGVSZXBsYWNlYWJsZUF0dHJTZXR0ZXIoJGlt cGxDbGFzc05hbWUpOworICAgICAgICAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+dHlwZSAhfiAv XnJlYWRvbmx5LyAmJiAhJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMt PnsiVjhSZWFkT25seSJ9KSB7CisgICAgICAgICAgICAgICAgR2VuZXJhdGVOb3JtYWxBdHRyU2V0 dGVyKCRhdHRyaWJ1dGUsICRkYXRhTm9kZSwgJGNsYXNzSW5kZXgsICRpbXBsQ2xhc3NOYW1lLCAk aW50ZXJmYWNlTmFtZSk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKQEAgLTE1 NDcsOSArMTU0MSw3IEBACiAgICAgZm9yZWFjaCBteSAkZnVuY3Rpb24gKEB7JGRhdGFOb2RlLT5m dW5jdGlvbnN9KSB7CiAgICAgICAgICMgaGFjayBmb3IgYWRkRXZlbnRMaXN0ZW5lci9SZW1vdmVF dmVudExpc3RlbmVyCiAgICAgICAgICMgRklYTUU6IGF2b2lkIG5hbWluZyBjb25mbGljdAotICAg ICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0 b20ifSB8fCAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3Vz dG9tIn0pIHsKLSAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJWOEN1c3RvbUJpbmRpbmcu aCJ9ID0gMTsKLSAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgKCEoJGZ1bmN0aW9uLT5zaWdu YXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b20ifSB8fCAkZnVuY3Rpb24tPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlY4Q3VzdG9tIn0pKSB7CiAgICAgICAgICAgICBH ZW5lcmF0ZUZ1bmN0aW9uQ2FsbGJhY2soJGZ1bmN0aW9uLCAkZGF0YU5vZGUsICRjbGFzc0luZGV4 LCAkaW1wbENsYXNzTmFtZSk7CiAgICAgICAgIH0KIAo=