<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>34008</bug_id>
          
          <creation_ts>2010-01-22 10:41:40 -0800</creation_ts>
          <short_desc>Assertion failure in KURL::setProtocol when running DOM Fuzzer</short_desc>
          <delta_ts>2010-01-22 14:12:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>29692</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="Alexey Proskuryakov">ap</assigned_to>
          <cc>ajwong</cc>
    
    <cc>darin</cc>
    
    <cc>dglazkov</cc>
    
    <cc>levin</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>183698</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-01-22 10:41:40 -0800</bug_when>
    <thetext>Patch forthcoming. This is harmless in release builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183701</commentid>
    <comment_count>1</comment_count>
      <attachid>47212</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-01-22 10:51:31 -0800</bug_when>
    <thetext>Created attachment 47212
proposed fix

We have similar issues with other KURL setters, but my primary goal here is to prevent the assertion failure when running DOM Fuzzer. Also, establishing correct behavior for each setter is not trivial, and is well worth a separate patch for each.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183705</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-22 11:05:46 -0800</bug_when>
    <thetext>Attachment 47212 did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/206004</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183726</commentid>
    <comment_count>3</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-22 11:40:33 -0800</bug_when>
    <thetext>Google has their own KURL -- I wish that were not so -- so I guess someone has to fix that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183732</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-01-22 11:52:15 -0800</bug_when>
    <thetext>I can change KURLGoogle:setProtocol() to always return true, but Chromium would still have regressions in tests. Do we have the same &quot;feel free to break it&quot; agreement about KURLGoogle that we have about v8 bindings?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183734</commentid>
    <comment_count>5</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-01-22 11:55:03 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; I can change KURLGoogle:setProtocol() to always return true, but Chromium would
&gt; still have regressions in tests. Do we have the same &quot;feel free to break it&quot;
&gt; agreement about KURLGoogle that we have about v8 bindings?

I think so :(
I&apos;ve cc&apos;ed Albert who gets to handle this today.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183742</commentid>
    <comment_count>6</comment_count>
      <attachid>47212</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-01-22 12:17:09 -0800</bug_when>
    <thetext>Comment on attachment 47212
proposed fix

It seems strange to move the &quot;ignore everything after the first colon&quot; behavior inside KURL::setProtocol. On the other hand, since it needs to be shared with location.protocol, I guess that was the handiest place to put it.

In HTMLAnchorElement::setProtocol you could do an early return if setProtocol returns false. This would avoid the question of why you can ignore the return value here, and it would slightly improve speed in the error case. But I suppose it&apos;s not all that great.

I think that at some point should rename from protocol to scheme in the URL class itself and related functions such as protocol/schemeIsJavaScript. Even if the DOM API calls it protocol, the URL specifications call it scheme and I think that&apos;s a clearer term.

invalid-protocol.js seems to have a UTF-8 BOM at the top of the file. I think a better way to do this would be to make the script-tests wrapper specify UTF-8 for the test script or use code to make the strings instead of using literal strings. But if you think we need to stick with the BOM then I think you should add a comment to the file letting people know the BOM is there and should not be removed.

r=me assuming you make a cut at writing the Google-specific code too or at least notify someone about fixing the Chromium build</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183765</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-01-22 13:01:22 -0800</bug_when>
    <thetext>Committed &lt;http://trac.webkit.org/changeset/53712&gt;. I made KURLGoogle.cpp changes that will hopefully prevent build failure, but not test failures.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183803</commentid>
    <comment_count>8</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2010-01-22 14:12:41 -0800</bug_when>
    <thetext>Sorry, forgot to do anything about the UTF-8 BOM. But this isn&apos;t the first script test that includes one.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47212</attachid>
            <date>2010-01-22 10:51:31 -0800</date>
            <delta_ts>2010-01-22 12:17:09 -0800</delta_ts>
            <desc>proposed fix</desc>
            <filename>ProtocolAssertion.txt</filename>
            <type>text/plain</type>
            <size>10872</size>
            <attacher name="Alexey Proskuryakov">ap</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MzcwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMzIgQEAKKzIwMTAtMDEtMjIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs
ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM0MDA4CisgICAgICAgIEFz
c2VydGlvbiBmYWlsdXJlIGluIEtVUkw6OnNldFByb3RvY29sIHdoZW4gcnVubmluZyBET00gRnV6
emVyCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vV2luZG93L2ludmFsaWQtcHJvdG9jb2wuaHRt
bAorCisgICAgICAgICogYmluZGluZ3MvanMvSlNMb2NhdGlvbkN1c3RvbS5jcHA6IChXZWJDb3Jl
OjpKU0xvY2F0aW9uOjpzZXRQcm90b2NvbCk6IFJhaXNlIGFuIGV4Y2VwdGlvbgorICAgICAgICBp
ZiBLVVJMOjpzZXRQcm90b2NvbCBmYWlscy4KKworICAgICAgICAqIGh0bWwvSFRNTEFuY2hvckVs
ZW1lbnQuY3BwOiAoV2ViQ29yZTo6SFRNTEFuY2hvckVsZW1lbnQ6OnNldFByb3RvY29sKTogTW92
ZSBhcmd1bWVudAorICAgICAgICB0d2Vha2luZyBsb2dpYyBpbnRvIEtVUkwuIFRoaXMgd2F5LCB0
aGUgJzonIHRyaWNrIGFwcGxpZXMgdG8gYm90aCBKU0xvY2F0aW9uIGFuZAorICAgICAgICBIVE1M
QW5jaG9yRWxlbWVudCwgbWF0Y2hpbmcgSUUgKGJ1dCBub3QgRmlyZWZveCkuIElFIGJlaGF2aW9y
IGlzIG1vcmUgcGVybWlzc2l2ZSwgYW5kIGV2ZW4KKyAgICAgICAgbW9yZSBsb2dpY2FsIGluIG15
IG9waW5pb24uCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOiAoV2ViQ29yZTo6
RnJhbWVMb2FkZXI6Omljb25VUkwpOiBBc3NlcnQgdGhhdCBzZXR0aW5nIHByb3RvY29sCisgICAg
ICAgIHN1Y2NlZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL0tVUkwuY3BwOiAoV2ViQ29yZTo6
S1VSTDo6c2V0UHJvdG9jb2wpOiBSZW1vdmUgZXZlcnl0aGluZyBwYXN0ICc6JywgaWYgcHJlc2Vu
dC4KKyAgICAgICAgUmV0dXJuIGZhbHNlIGlmIHRoZSBwcm90b2NvbCB0byBzZXQgaXMgbm90IHZh
bGlkLgorICAgICAgICAoV2ViQ29yZTo6aXNWYWxpZFByb3RvY29sKTogTWFkZSB0aGlzIHdvcmsg
Y29ycmVjdGx5IGZvciBlbXB0eSBzdHJpbmdzLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5o
OiBpc1ZhbGlkUHJvdG9jb2woKSBpcyBub3cgc3RhdGljIGluIEtVUkwuY3BwLCBpdCdzIG9ubHkg
dXNlZCBpbiBzZXRQcm90b2NvbCgpLgorCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2NrZXRI
YW5kc2hha2UuY3BwOiAoV2ViQ29yZTo6V2ViU29ja2V0SGFuZHNoYWtlOjpodHRwVVJMRm9yQXV0
aGVudGljYXRpb25BbmRDb29raWVzKToKKyAgICAgICAgQXNzZXJ0IHRoYXQgc2V0dGluZyBwcm90
b2NvbCBzdWNjZWVkZWQuCisKIDIwMTAtMDEtMjIgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJp
c2hAZm9yd2FyZGJpYXMuaW4+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4u
CkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTTG9jYXRpb25DdXN0b20uY3BwCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvSlNMb2NhdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9u
IDUzNjgxKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0xvY2F0aW9uQ3VzdG9tLmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMjQsNiArMjQsNyBAQAogI2luY2x1ZGUgIkpTTG9jYXRpb25DdXN0b20u
aCIKIAogI2luY2x1ZGUgIkRPTVdpbmRvdy5oIgorI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIK
ICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyLmgiCiAjaW5jbHVkZSAi
SlNET01CaW5kaW5nLmgiCkBAIC0yMTQsNyArMjE1LDEwIEBAIHZvaWQgSlNMb2NhdGlvbjo6c2V0
UHJvdG9jb2woRXhlY1N0YXRlKiAKICAgICBBU1NFUlQoZnJhbWUpOwogCiAgICAgS1VSTCB1cmwg
PSBmcmFtZS0+bG9hZGVyKCktPnVybCgpOwotICAgIHVybC5zZXRQcm90b2NvbCh2YWx1ZS50b1N0
cmluZyhleGVjKSk7CisgICAgaWYgKCF1cmwuc2V0UHJvdG9jb2wodmFsdWUudG9TdHJpbmcoZXhl
YykpKSB7CisgICAgICAgIHNldERPTUV4Y2VwdGlvbihleGVjLCBTWU5UQVhfRVJSKTsKKyAgICAg
ICAgcmV0dXJuOworICAgIH0KIAogICAgIG5hdmlnYXRlSWZBbGxvd2VkKGV4ZWMsIGZyYW1lLCB1
cmwsICFmcmFtZS0+c2NyaXB0KCktPmFueVBhZ2VJc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSgpLCBm
YWxzZSk7CiB9CkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5jcHAJKHJldmlzaW9uIDUz
NjgxKQorKysgV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcAkod29ya2luZyBjb3B5
KQpAQCAtNDk3LDIwICs0OTcsOCBAQCBTdHJpbmcgSFRNTEFuY2hvckVsZW1lbnQ6OnByb3RvY29s
KCkgY29uCiAKIHZvaWQgSFRNTEFuY2hvckVsZW1lbnQ6OnNldFByb3RvY29sKGNvbnN0IFN0cmlu
ZyYgdmFsdWUpCiB7Ci0gICAgaW50IHNlcGFyYXRvciA9IHZhbHVlLmZpbmQoJzonKTsKLQotICAg
IGlmICghc2VwYXJhdG9yKQotICAgICAgICByZXR1cm47Ci0gICAgaWYgKHZhbHVlLmlzRW1wdHko
KSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgS1VSTCB1cmwgPSBocmVmKCk7Ci0gICAgLy8gRm9s
bG93aW5nIEZpcmVmb3ggMy41LjIgd2hpY2ggcmVtb3ZlcyBhbnl0aGluZyBhZnRlciB0aGUgZmly
c3QgIjoiCi0gICAgU3RyaW5nIG5ld1Byb3RvY29sID0gdmFsdWUuc3Vic3RyaW5nKDAsIHNlcGFy
YXRvcik7Ci0gICAgaWYgKCFpc1ZhbGlkUHJvdG9jb2wobmV3UHJvdG9jb2wpKQotICAgICAgICBy
ZXR1cm47Ci0gICAgdXJsLnNldFByb3RvY29sKG5ld1Byb3RvY29sKTsKLQorICAgIHVybC5zZXRQ
cm90b2NvbCh2YWx1ZSk7CiAgICAgc2V0SHJlZih1cmwuc3RyaW5nKCkpOwogfQogCkluZGV4OiBX
ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2Fk
ZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiA1MzY4MSkKKysrIFdlYkNvcmUvbG9hZGVyL0Zy
YW1lTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjIwLDcgKzYyMCw4IEBAIEtVUkwgRnJh
bWVMb2FkZXI6Omljb25VUkwoKQogICAgICAgICByZXR1cm4gS1VSTCgpOwogCiAgICAgS1VSTCB1
cmw7Ci0gICAgdXJsLnNldFByb3RvY29sKG1fVVJMLnByb3RvY29sKCkpOworICAgIGJvb2wgY291
bGRTZXRQcm90b2NvbCA9IHVybC5zZXRQcm90b2NvbChtX1VSTC5wcm90b2NvbCgpKTsKKyAgICBB
U1NFUlRfVU5VU0VEKGNvdWxkU2V0UHJvdG9jb2wsIGNvdWxkU2V0UHJvdG9jb2wpOwogICAgIHVy
bC5zZXRIb3N0KG1fVVJMLmhvc3QoKSk7CiAgICAgaWYgKG1fVVJMLmhhc1BvcnQoKSkKICAgICAg
ICAgdXJsLnNldFBvcnQobV9VUkwucG9ydCgpKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vS1VS
TC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAkocmV2aXNpb24g
NTM2ODEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y
MTQsNiArMjE0LDcgQEAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNoYXIgY2hhcmFjdGVyQ2xhcwog
c3RhdGljIGludCBjb3B5UGF0aFJlbW92aW5nRG90cyhjaGFyKiBkc3QsIGNvbnN0IGNoYXIqIHNy
YywgaW50IHNyY1N0YXJ0LCBpbnQgc3JjRW5kKTsKIHN0YXRpYyB2b2lkIGVuY29kZVJlbGF0aXZl
U3RyaW5nKGNvbnN0IFN0cmluZyYgcmVsLCBjb25zdCBUZXh0RW5jb2RpbmcmLCBDaGFyQnVmZmVy
JiBvdXB1dCk7CiBzdGF0aWMgU3RyaW5nIHN1YnN0aXR1dGVCYWNrc2xhc2hlcyhjb25zdCBTdHJp
bmcmKTsKK3N0YXRpYyBib29sIGlzVmFsaWRQcm90b2NvbChjb25zdCBTdHJpbmcmKTsKIAogc3Rh
dGljIGlubGluZSBib29sIGlzU2NoZW1lRmlyc3RDaGFyKGNoYXIgYykgeyByZXR1cm4gY2hhcmFj
dGVyQ2xhc3NUYWJsZVtzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihjKV0gJiBTY2hlbWVGaXJz
dENoYXI7IH0KIHN0YXRpYyBpbmxpbmUgYm9vbCBpc1NjaGVtZUZpcnN0Q2hhcihVQ2hhciBjKSB7
IHJldHVybiBjIDw9IDB4ZmYgJiYgKGNoYXJhY3RlckNsYXNzVGFibGVbY10gJiBTY2hlbWVGaXJz
dENoYXIpOyB9CkBAIC02NTksMTcgKzY2MCwyMiBAQCBTdHJpbmcgS1VSTDo6cGF0aCgpIGNvbnN0
CiAgICAgcmV0dXJuIGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyhtX3N0cmluZy5zdWJzdHJpbmco
bV9wb3J0RW5kLCBtX3BhdGhFbmQgLSBtX3BvcnRFbmQpKTsgCiB9CiAKLXZvaWQgS1VSTDo6c2V0
UHJvdG9jb2woY29uc3QgU3RyaW5nJiBzKQorYm9vbCBLVVJMOjpzZXRQcm90b2NvbChjb25zdCBT
dHJpbmcmIHMpCiB7Ci0gICAgLy8gRklYTUU6IE5vbi1BU0NJSSBjaGFyYWN0ZXJzIG11c3QgYmUg
ZW5jb2RlZCBhbmQgZXNjYXBlZCB0byBtYXRjaCBwYXJzZSgpIGV4cGVjdGF0aW9ucywKLSAgICAv
LyBhbmQgdG8gYXZvaWQgY2hhbmdpbmcgbW9yZSB0aGFuIGp1c3QgdGhlIHByb3RvY29sLgorICAg
IC8vIEZpcmVmb3ggYW5kIElFIHJlbW92ZSBldmVyeXRoaW5nIGFmdGVyIHRoZSBmaXJzdCAnOicu
CisgICAgaW50IHNlcGFyYXRvclBvc2l0aW9uID0gcy5maW5kKCc6Jyk7CisgICAgU3RyaW5nIG5l
d1Byb3RvY29sID0gcy5zdWJzdHJpbmcoMCwgc2VwYXJhdG9yUG9zaXRpb24pOworCisgICAgaWYg
KCFpc1ZhbGlkUHJvdG9jb2wobmV3UHJvdG9jb2wpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAK
ICAgICBpZiAoIW1faXNWYWxpZCkgewotICAgICAgICBwYXJzZShzICsgIjoiICsgbV9zdHJpbmcp
OwotICAgICAgICByZXR1cm47CisgICAgICAgIHBhcnNlKG5ld1Byb3RvY29sICsgIjoiICsgbV9z
dHJpbmcpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICBwYXJzZShzICsgbV9z
dHJpbmcuc3Vic3RyaW5nKG1fc2NoZW1lRW5kKSk7CisgICAgcGFyc2UobmV3UHJvdG9jb2wgKyBt
X3N0cmluZy5zdWJzdHJpbmcobV9zY2hlbWVFbmQpKTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAog
dm9pZCBLVVJMOjpzZXRIb3N0KGNvbnN0IFN0cmluZyYgcykKQEAgLTE2MzAsNiArMTYzNiw5IEBA
IGJvb2wgcHJvdG9jb2xJc0phdmFTY3JpcHQoY29uc3QgU3RyaW5nJiAKIAogYm9vbCBpc1ZhbGlk
UHJvdG9jb2woY29uc3QgU3RyaW5nJiBwcm90b2NvbCkKIHsKKyAgICAvLyBSRkMzOTg2OiBBTFBI
QSAqKCBBTFBIQSAvIERJR0lUIC8gIisiIC8gIi0iIC8gIi4iICkKKyAgICBpZiAocHJvdG9jb2wu
aXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKCFpc1NjaGVtZUZpcnN0
Q2hhcihwcm90b2NvbFswXSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB1bnNpZ25lZCBw
cm90b2NvbExlbmd0aCA9IHByb3RvY29sLmxlbmd0aCgpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9y
bS9LVVJMLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgJKHJldmlzaW9u
IDUzNjgxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0
NCw3ICsxNDQsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBwcm90b2NvbEluSFRUUEZhbWlseSgpIGNv
bnN0OwogICAgIGJvb2wgaXNMb2NhbEZpbGUoKSBjb25zdDsKIAotICAgIHZvaWQgc2V0UHJvdG9j
b2woY29uc3QgU3RyaW5nJik7CisgICAgYm9vbCBzZXRQcm90b2NvbChjb25zdCBTdHJpbmcmKTsK
ICAgICB2b2lkIHNldEhvc3QoY29uc3QgU3RyaW5nJik7CiAKICAgICB2b2lkIHJlbW92ZVBvcnQo
KTsKQEAgLTI2Niw3ICsyNjYsNiBAQCBjb25zdCBLVVJMJiBibGFua1VSTCgpOwogCiBib29sIHBy
b3RvY29sSXMoY29uc3QgU3RyaW5nJiB1cmwsIGNvbnN0IGNoYXIqIHByb3RvY29sKTsKIGJvb2wg
cHJvdG9jb2xJc0phdmFTY3JpcHQoY29uc3QgU3RyaW5nJiB1cmwpOwotYm9vbCBpc1ZhbGlkUHJv
dG9jb2woY29uc3QgU3RyaW5nJiBwcm90b2NvbCk7CiAKIGJvb2wgaXNEZWZhdWx0UG9ydEZvclBy
b3RvY29sKHVuc2lnbmVkIHNob3J0IHBvcnQsIGNvbnN0IFN0cmluZyYgcHJvdG9jb2wpOwogYm9v
bCBwb3J0QWxsb3dlZChjb25zdCBLVVJMJik7IC8vIEJsYWNrbGlzdCBwb3J0cyB0aGF0IHNob3Vs
ZCBuZXZlciBiZSB1c2VkIGZvciBXZWIgcmVzb3VyY2VzLgpJbmRleDogV2ViQ29yZS93ZWJzb2Nr
ZXRzL1dlYlNvY2tldEhhbmRzaGFrZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS93ZWJzb2Nr
ZXRzL1dlYlNvY2tldEhhbmRzaGFrZS5jcHAJKHJldmlzaW9uIDUzNjgxKQorKysgV2ViQ29yZS93
ZWJzb2NrZXRzL1dlYlNvY2tldEhhbmRzaGFrZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1NSw3
ICszNTUsOCBAQCB2b2lkIFdlYlNvY2tldEhhbmRzaGFrZTo6c2V0U2VydmVyU2V0Q29vCiBLVVJM
IFdlYlNvY2tldEhhbmRzaGFrZTo6aHR0cFVSTEZvckF1dGhlbnRpY2F0aW9uQW5kQ29va2llcygp
IGNvbnN0CiB7CiAgICAgS1VSTCB1cmwgPSBtX3VybC5jb3B5KCk7Ci0gICAgdXJsLnNldFByb3Rv
Y29sKG1fc2VjdXJlID8gImh0dHBzIiA6ICJodHRwIik7CisgICAgYm9vbCBjb3VsZFNldFByb3Rv
Y29sID0gdXJsLnNldFByb3RvY29sKG1fc2VjdXJlID8gImh0dHBzIiA6ICJodHRwIik7CisgICAg
QVNTRVJUX1VOVVNFRChjb3VsZFNldFByb3RvY29sLCBjb3VsZFNldFByb3RvY29sKTsKICAgICBy
ZXR1cm4gdXJsOwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MzcwNCkKKysrIExheW91dFRlc3Rz
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAxLTIyICBB
bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBhbmQg
YnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvaW52YWxpZC1wcm90
b2NvbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9pbnZh
bGlkLXByb3RvY29sLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy9zY3Jp
cHQtdGVzdHMvaW52YWxpZC1wcm90b2NvbC5qczogQWRkZWQuCisKIDIwMTAtMDEtMjIgIEFkYW0g
Um9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCiAgICAgICAgIENoZWNrIGluIGV4cGVjdGVkIGZh
aWx1cmUgcmVzdWx0cyBmb3IgdGV4dC16b29tLnhodG1sIG9uIFdpbmRvd3MKSW5kZXg6IExheW91
dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9pbnZhbGlkLXByb3RvY29sLWV4cGVjdGVkLnR4dAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvaW52YWxpZC1wcm90b2NvbC1l
eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cv
aW52YWxpZC1wcm90b2NvbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTgg
QEAKK1Rlc3QgVVJMIHByb3RvY29sIHNldHRlci4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2Vl
IGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUi
LgorCisKK1BBU1MgbG9jYXRpb24ucHJvdG9jb2wgPSAnJyB0aHJldyBleGNlcHRpb24gRXJyb3I6
IFNZTlRBWF9FUlI6IERPTSBFeGNlcHRpb24gMTIuCitQQVNTIGxvY2F0aW9uLnByb3RvY29sID0g
JzonIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogU1lOVEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMi4K
K1BBU1MgbG9jYXRpb24ucHJvdG9jb2wgPSAnw6knIHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogU1lO
VEFYX0VSUjogRE9NIEV4Y2VwdGlvbiAxMi4KK1BBU1MgbG9jYXRpb24ucHJvdG9jb2wgPSAnWycg
dGhyZXcgZXhjZXB0aW9uIEVycm9yOiBTWU5UQVhfRVJSOiBET00gRXhjZXB0aW9uIDEyLgorUEFT
UyBsb2NhdGlvbi5wcm90b2NvbCA9ICcwJyB0aHJldyBleGNlcHRpb24gRXJyb3I6IFNZTlRBWF9F
UlI6IERPTSBFeGNlcHRpb24gMTIuCitQQVNTIGEucHJvdG9jb2wgaXMgJ2h0dHA6JworUEFTUyBh
LmhyZWYgaXMgJ2h0dHBzOi8vd3d3LmFwcGxlLmNvbS8nCitQQVNTIGEuaHJlZiBpcyAnaHR0cDov
L3d3dy5hcHBsZS5jb20vJworUEFTUyBhLmhyZWYgaXMgJ2h0dHBzOi8vd3d3LmFwcGxlLmNvbS8n
CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRl
eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2ludmFsaWQtcHJvdG9jb2wuaHRtbAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvaW52YWxpZC1wcm90b2NvbC5o
dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2ludmFsaWQt
cHJvdG9jb2wuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhU
TUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5r
IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUu
Y3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwv
c2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYg
aWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9pbnZhbGlkLXBy
b3RvY29sLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMt
dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRl
c3RzL2Zhc3QvZG9tL1dpbmRvdy9zY3JpcHQtdGVzdHMvaW52YWxpZC1wcm90b2NvbC5qcwo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvc2NyaXB0LXRlc3RzL2ludmFs
aWQtcHJvdG9jb2wuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k
b3cvc2NyaXB0LXRlc3RzL2ludmFsaWQtcHJvdG9jb2wuanMJKHJldmlzaW9uIDApCkBAIC0wLDAg
KzEsMjkgQEAKK++7v2Rlc2NyaXB0aW9uKCJUZXN0IFVSTCBwcm90b2NvbCBzZXR0ZXIuIik7CisK
K3ZhciBhID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOworYS5zZXRBdHRyaWJ1dGUoImhy
ZWYiLCAiaHR0cDovL3d3dy5hcHBsZS5jb20vIik7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk
KGEpOworCitzaG91bGRUaHJvdygibG9jYXRpb24ucHJvdG9jb2wgPSAnJyIpOworc2hvdWxkVGhy
b3coImxvY2F0aW9uLnByb3RvY29sID0gJzonIik7CitzaG91bGRUaHJvdygibG9jYXRpb24ucHJv
dG9jb2wgPSAnw6knIik7CitzaG91bGRUaHJvdygibG9jYXRpb24ucHJvdG9jb2wgPSAnWyciKTsK
K3Nob3VsZFRocm93KCJsb2NhdGlvbi5wcm90b2NvbCA9ICcwJyIpOworCisvLyBJRSByYWlzZXMg
ZXhjZXB0aW9ucyBmb3IgYW5jaG9ycywgdG9vIC0gYnV0IEZpcmVmb3ggZG9lcyBub3QuIEluIGVp
dGhlciBjYXNlLCBwcm90b2NvbCBzaG91bGRuJ3QgY2hhbmdlLgordHJ5IHsgYS5wcm90b2NvbCA9
ICcnIH0gY2F0Y2ggKGV4KSB7IH0KK3RyeSB7IGEucHJvdG9jb2wgPSAnw6knIH0gY2F0Y2ggKGV4
KSB7IH0KK3RyeSB7IGEucHJvdG9jb2wgPSAnWycgfSBjYXRjaCAoZXgpIHsgfQordHJ5IHsgYS5w
cm90b2NvbCA9ICcwJyB9IGNhdGNoIChleCkgeyB9CitzaG91bGRCZSgiYS5wcm90b2NvbCIsICIn
aHR0cDonIik7CisKK2EucHJvdG9jb2wgPSAiaHR0cHMiOworc2hvdWxkQmUoImEuaHJlZiIsICIn
aHR0cHM6Ly93d3cuYXBwbGUuY29tLyciKTsKKworYS5wcm90b2NvbCA9ICJodHRwOiI7CitzaG91
bGRCZSgiYS5ocmVmIiwgIidodHRwOi8vd3d3LmFwcGxlLmNvbS8nIik7CisKK2EucHJvdG9jb2wg
PSAiaHR0cHM6Ly9mb29iYXIiOworc2hvdWxkQmUoImEuaHJlZiIsICInaHR0cHM6Ly93d3cuYXBw
bGUuY29tLyciKTsKKworc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK
</data>
<flag name="review"
          id="29620"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>