34001 2010-01-22 06:35:29 -0800 check-webkit-style breaks on files with unknown types 2010-01-22 15:58:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 petri.latvala webkit-unassigned abarth webkit.review.bot oldest_to_newest 183630 0 petri.latvala 2010-01-22 06:35:29 -0800 Reproduction: 1. Edit WebCore/WebCoreSources.bkl 2. Run check-webkit-style The result after r53675: Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/home/adrinael/src/git/webkit/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' This is because dispatcher.dispatch_processor returns None for file_type value FileType.NONE 183631 1 47199 petri.latvala 2010-01-22 06:39:46 -0800 Created attachment 47199 Quick fix by not calling process_file if the processor is None. 183632 2 webkit.review.bot 2010-01-22 06:43:19 -0800 Attachment 47199 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 183633 3 47200 petri.latvala 2010-01-22 06:45:34 -0800 Created attachment 47200 Quick fix by not calling process_file if the processor is None. (fixed) Oops, that was embarassing. Fixed. 183856 4 47200 abarth 2010-01-22 15:58:52 -0800 Comment on attachment 47200 Quick fix by not calling process_file if the processor is None. (fixed) Clearing flags on attachment: 47200 Committed r53730: <http://trac.webkit.org/changeset/53730> 183857 5 abarth 2010-01-22 15:58:57 -0800 All reviewed patches have been landed. Closing bug. 47199 2010-01-22 06:39:46 -0800 2010-01-22 06:45:34 -0800 Quick fix by not calling process_file if the processor is None. check-style-fix.diff text/plain 1289 petri.latvala ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOGFkZTFhLi45MmEzMmJlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MjIgIFBldHJpIExhdHZhbGEgIDxwZXRyaS5sYXR2YWxhQG5vbW92b2suY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHls ZSBicmVha3Mgb24gZmlsZXMgd2l0aCB1bmtub3duIHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDAwMQorCisgICAgICAgIEZvciBmaWxlcyB3 aXRoIHR5cGUgRmlsZVR5cGUuTk9ORSwgZGlzcGF0Y2hfcHJvY2Vzc29yIHJldHVybnMgTm9uZS4K KworCSogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OiBEb24ndCBjYWxsIHByb2Nl c3NfZmlsZSB3aXRoIGEgcHJvY2Vzc29yIG9mIHZhbHVlIE5vbmUuCisKIDIwMTAtMDEtMjIgIEtl bnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1h Y2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2VyLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2VyLnB5CmluZGV4IDY4YzVhYmUuLjE4ZDQ1N2IgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKQEAgLTg4MCw2ICs4ODAsOSBAQCBjbGFzcyBT dHlsZUNoZWNrZXIob2JqZWN0KToKICAgICAgICAgcHJvY2Vzc29yID0gZGlzcGF0Y2hlci5kaXNw YXRjaF9wcm9jZXNzb3IoZmlsZV9wYXRoLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBoYW5kbGVfc3R5bGVfZXJyb3IsCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcmJvc2l0eSkKKyAgICAgICAgaWYg cHJvY2Vzc29yIGlzIE5vbmU6CisgICAgICAgICAgICByZXR1cm4KKwogICAgICAgICBwcm9jZXNz X2ZpbGUocHJvY2Vzc29yLCBmaWxlX3BhdGgsIGhhbmRsZV9zdHlsZV9lcnJvcikKIAogICAgIGRl ZiBjaGVja19wYXRjaChzZWxmLCBwYXRjaF9zdHJpbmcpOgo= 47200 2010-01-22 06:45:34 -0800 2010-01-22 15:58:52 -0800 Quick fix by not calling process_file if the processor is None. (fixed) check-style-fix2.diff text/plain 1296 petri.latvala ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOGFkZTFhLi4wYWMwOTg2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MjIgIFBldHJpIExhdHZhbGEgIDxwZXRyaS5sYXR2YWxhQG5vbW92b2suY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHls ZSBicmVha3Mgb24gZmlsZXMgd2l0aCB1bmtub3duIHR5cGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNDAwMQorCisgICAgICAgIEZvciBmaWxlcyB3 aXRoIHR5cGUgRmlsZVR5cGUuTk9ORSwgZGlzcGF0Y2hfcHJvY2Vzc29yIHJldHVybnMgTm9uZS4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weTogRG9uJ3QgY2Fs bCBwcm9jZXNzX2ZpbGUgd2l0aCBhIHByb2Nlc3NvciBvZiB2YWx1ZSBOb25lLgorCiAyMDEwLTAx LTIyICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlci5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv c3R5bGUvY2hlY2tlci5weQppbmRleCA2OGM1YWJlLi4xOGQ0NTdiIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CkBAIC04ODAsNiArODgwLDkgQEAg Y2xhc3MgU3R5bGVDaGVja2VyKG9iamVjdCk6CiAgICAgICAgIHByb2Nlc3NvciA9IGRpc3BhdGNo ZXIuZGlzcGF0Y2hfcHJvY2Vzc29yKGZpbGVfcGF0aCwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaGFuZGxlX3N0eWxlX2Vycm9yLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2ZXJib3NpdHkpCisgICAg ICAgIGlmIHByb2Nlc3NvciBpcyBOb25lOgorICAgICAgICAgICAgcmV0dXJuCisKICAgICAgICAg cHJvY2Vzc19maWxlKHByb2Nlc3NvciwgZmlsZV9wYXRoLCBoYW5kbGVfc3R5bGVfZXJyb3IpCiAK ICAgICBkZWYgY2hlY2tfcGF0Y2goc2VsZiwgcGF0Y2hfc3RyaW5nKToK