33977 2010-01-21 16:04:30 -0800 [Chromium] WebNode::toElement refcounts incorrectly 2010-01-21 22:22:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned commit-queue fishd yaar oldest_to_newest 183363 0 jamesr 2010-01-21 16:04:30 -0800 The following results in the refcount on 'foo' decreasing by one, when it should stay the same: { WebNode n = foo; WebElement e = n.toElement<WebElement>(); } This is because WebNode::toElement() does not increment the refcount on 'foo', but the WebElement destructor does decrement the refcount. 183365 1 47155 jamesr 2010-01-21 16:07:57 -0800 Created attachment 47155 Fixes the bug by using WebNode::assign() I have to use the WebNode:: qualifier because some T's that are used in this function (like WebElement) define incompatible 1-arg versions of ::assign(), for example WebElement::assign(const WebElement& e). This confuses visual studio terribly. I'm not sure if this is an issue with the compiler, but we always want to use the WebNode::assign() version anyway. 183486 2 47155 commit-queue 2010-01-21 22:22:00 -0800 Comment on attachment 47155 Fixes the bug by using WebNode::assign() Clearing flags on attachment: 47155 Committed r53678: <http://trac.webkit.org/changeset/53678> 183487 3 commit-queue 2010-01-21 22:22:07 -0800 All reviewed patches have been landed. Closing bug. 47155 2010-01-21 16:07:57 -0800 2010-01-21 22:22:00 -0800 Fixes the bug by using WebNode::assign() patch.diff text/plain 1719 jamesr ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDAwYThjMzIuLmU5NTA2NjIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI3IEBACisyMDEwLTAxLTIxICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVtcHMg dGhlIHJlZmNvdW50IHdoZW4gV2ViTm9kZTo6dG9FbGVtZW50L3RvQ29uc3RFbGVtZW50IGFyZSBj YWxsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z Mzk3NworICAgICAgICAKKyAgICAgICAgRW5zdXJlcyB0aGF0IHdoZW4gYSB3cmFwcGVyIGFyb3Vu ZCBhIFdlYk5vZGUgaXMgY3JlYXRlIHZpYSB0aGUKKyAgICAgICAgdG9FbGVtZW50KCkgb3IgdG9D b25zdEVsZW1lbnQoKSBjYWxscyB0aGF0IHRoZSByZWZjb3VudCBvbiB0aGUgV2ViTm9kZQorICAg ICAgICBpcyBpbmNyZWFzZWQsIGJ5IGZvcmNpbmcgYSBjYWxsIHRvIFdlYk5vZGU6OmFzc2lnbigp LiAgVGhpcyBpcyBuZWVkZWQKKyAgICAgICAgc28gdGhhdCB0aGUgZm9sbG93aW5nIGNvZGU6Cisg ICAgICAgIHsKKyAgICAgICAgICBXZWJOb2RlIG4gPSBzb21lTm9kZSgpOworICAgICAgICAgIFdl YkVsZW1lbnQgZSA9IG4udG9FbGVtZW50PFdlYkVsZW1lbnQ+KCk7CisgICAgICAgIH0KKyAgICAg ICAgZG9lcyBub3QgZGVjcmVhc2UgdGhlIG92ZXJhbGwgcmVmY291bnQgb24gdGhlIE5vZGUgdGhh dCBzb21lTm9kZSgpCisgICAgICAgIHJldHVybnMuCisKKyAgICAgICAgVGhpcyBjYXVzZWQgY3Jh c2hlcyBpbiB0aGUgJ1NhdmUgcGFnZSBhcy4uJyBmZWF0dXJlLgorCisgICAgICAgICogcHVibGlj L1dlYk5vZGUuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViTm9kZTo6dG9FbGVtZW50KToKKyAgICAg ICAgKFdlYktpdDo6V2ViTm9kZTo6dG9Db25zdEVsZW1lbnQpOgorCiAyMDEwLTAxLTE0ICBKZXJl bXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9s aXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJOb2RlLmgg Yi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk5vZGUuaAppbmRleCBiMjU1NWYxLi5hYjljNzY3 IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYk5vZGUuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYk5vZGUuaApAQCAtMTA0LDE0ICsxMDQsMTQgQEAgcHVibGlj OgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IFQgdG9FbGVtZW50KCkKICAgICB7CiAgICAgICAg IFQgcmVzOwotICAgICAgICByZXMubV9wcml2YXRlID0gbV9wcml2YXRlOworICAgICAgICByZXMu V2ViTm9kZTo6YXNzaWduKCp0aGlzKTsKICAgICAgICAgcmV0dXJuIHJlczsKICAgICB9CiAKICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjb25zdCBUIHRvQ29uc3RFbGVtZW50KCkgY29uc3QKICAg ICB7CiAgICAgICAgIFQgcmVzOwotICAgICAgICByZXMubV9wcml2YXRlID0gbV9wcml2YXRlOwor ICAgICAgICByZXMuV2ViTm9kZTo6YXNzaWduKCp0aGlzKTsKICAgICAgICAgcmV0dXJuIHJlczsK ICAgICB9CiAK