33969 2010-01-21 13:19:15 -0800 Unnecessary call to HistoryItem::targetItem in HistoryController::pushState 2010-01-21 14:25:33 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd beidson oldest_to_newest 183295 0 fishd 2010-01-21 13:19:15 -0800 Unnecessary call to HistoryItem::targetItem in HistoryController::pushState createTreeItem is called with m_frame, and createTreeItem sets isTargetItem to true if the Frame passed to it is equal to m_frame. so calling targetItem on the result returned from createTreeItem(m_frame,...) is unnecessary. 183298 1 47142 fishd 2010-01-21 13:21:53 -0800 Created attachment 47142 v1 patch 183318 2 fishd 2010-01-21 14:25:33 -0800 Landed as http://trac.webkit.org/changeset/53650 47142 2010-01-21 13:21:53 -0800 2010-01-21 13:45:30 -0800 v1 patch fix_1.txt text/plain 1638 fishd SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzY0MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMjEgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV bm5lY2Vzc2FyeSBjYWxsIHRvIEhpc3RvcnlJdGVtOjp0YXJnZXRJdGVtIGluIEhpc3RvcnlDb250 cm9sbGVyOjpwdXNoU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzOTY5CisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnB1c2hTdGF0ZSk6IFJlbW92 ZSB1bm5lY2Vzc2FyeSBjb2RlLgorCiAyMDEwLTAxLTIxICBFcmljIFVocmhhbmUgIDxlcmljdUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpJbmRleDog V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNTM2MzkpCisrKyBXZWJD b3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzMiwx NCArNjMyLDEzIEBAIHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnB1c2hTdGF0ZShQYXNzUmUKIAog ICAgIC8vIEdldCBhIEhpc3RvcnlJdGVtIHRyZWUgZm9yIHRoZSBjdXJyZW50IGZyYW1lIHRyZWUu CiAgICAgUmVmUHRyPEhpc3RvcnlJdGVtPiBpdGVtID0gY3JlYXRlSXRlbVRyZWUobV9mcmFtZSwg ZmFsc2UpOworICAgIEFTU0VSVChpdGVtLT5pc1RhcmdldEl0ZW0oKSk7CiAgICAgCiAgICAgLy8g T3ZlcnJpZGUgZGF0YSBpbiB0aGUgdGFyZ2V0IGl0ZW0gdG8gcmVmbGVjdCB0aGUgcHVzaFN0YXRl KCkgYXJndW1lbnRzLgotICAgIEhpc3RvcnlJdGVtKiB0YXJnZXRJdGVtID0gaXRlbS0+dGFyZ2V0 SXRlbSgpOwotICAgIEFTU0VSVCh0YXJnZXRJdGVtLT5pc1RhcmdldEl0ZW0oKSk7Ci0gICAgdGFy Z2V0SXRlbS0+c2V0RG9jdW1lbnQobV9mcmFtZS0+ZG9jdW1lbnQoKSk7Ci0gICAgdGFyZ2V0SXRl bS0+c2V0VGl0bGUodGl0bGUpOwotICAgIHRhcmdldEl0ZW0tPnNldFN0YXRlT2JqZWN0KHN0YXRl T2JqZWN0KTsKLSAgICB0YXJnZXRJdGVtLT5zZXRVUkxTdHJpbmcodXJsU3RyaW5nKTsKKyAgICBp dGVtLT5zZXREb2N1bWVudChtX2ZyYW1lLT5kb2N1bWVudCgpKTsKKyAgICBpdGVtLT5zZXRUaXRs ZSh0aXRsZSk7CisgICAgaXRlbS0+c2V0U3RhdGVPYmplY3Qoc3RhdGVPYmplY3QpOworICAgIGl0 ZW0tPnNldFVSTFN0cmluZyh1cmxTdHJpbmcpOwogICAgIAogICAgIHBhZ2UtPmJhY2tGb3J3YXJk TGlzdCgpLT5wdXNoU3RhdGVJdGVtKGl0ZW0ucmVsZWFzZSgpKTsKIH0K