33968 2010-01-21 12:42:20 -0800 Canvas: Exception erroneously thrown for drawImage() when image.complete=false 2010-07-01 10:34:44 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=32712 HTML5 P2 Normal --- 1 hendry webkit-unassigned adele commit-queue kling mdelaney7 oldest_to_newest 183284 0 hendry 2010-01-21 12:42:20 -0800 Just tried http://roulette.dabase.com/ on r53596 and it also fails to render, while Gecko and Presto can. I can work around on this problem by adding a timeout. There is some bizaare DOM ready bug I guess. 244275 1 kling 2010-06-29 07:16:56 -0700 Both the site and WebKit are at fault here. The page is using $(document).ready() instead of $(window).load() - $d(document).ready() fires as soon as the DOM is ready instead of waiting for subresources (images in this case) to finish loading. However, since the image element passed to drawImage() has complete=false, nothing should be done (HTML5 4.8.11), so the exception is thrown in error. Patch coming in a moment. 244294 2 60021 kling 2010-06-29 07:51:59 -0700 Created attachment 60021 Proposed patch Implement correct behavior for drawImage() with incomplete image or video. Autotest included. Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage 245346 3 kling 2010-07-01 07:57:40 -0700 For future visitors to this bug, the page at http://roulette.dabase.com/ has now been updated to use $(window).load() :-) 245414 4 60021 commit-queue 2010-07-01 10:29:41 -0700 Comment on attachment 60021 Proposed patch Clearing flags on attachment: 60021 Committed r62273: <http://trac.webkit.org/changeset/62273> 245415 5 commit-queue 2010-07-01 10:29:46 -0700 All reviewed patches have been landed. Closing bug. 60021 2010-06-29 07:51:59 -0700 2010-07-01 10:29:41 -0700 Proposed patch bug-33968.diff text/plain 6014 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4Y2FmYTZmLi41MmE1MjM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDYt MjkgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYW52YXM6IEV4Y2VwdGlvbiBl cnJvbmVvdXNseSB0aHJvd24gZm9yIGRyYXdJbWFnZSgpIHdoZW4gaW1hZ2UuY29tcGxldGU9ZmFs c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzOTY4 CisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IHRvIHZlcmlmeSB0aGF0IENSQzJEIGRvZXMgbm90aGlu ZyB3aGVuIGNhbGxpbmcgZHJhd0ltYWdlKCkKKyAgICAgICAgd2l0aCBhbiBpbmNvbXBsZXRlIGlt YWdlIG9yIHZpZGVvLgorCisgICAgICAgIFNwZWMgbGluazoKKyAgICAgICAgaHR0cDovL3d3dy53 aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay8jZG9tLWNvbnRleHQtMmQtZHJh d2ltYWdlCisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZHJhd0ltYWdlLWluY29tcGxl dGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy9jYW52YXMtZHJh d0ltYWdlLWluY29tcGxldGUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jYW52YXMvc2Ny aXB0LXRlc3RzL2NhbnZhcy1kcmF3SW1hZ2UtaW5jb21wbGV0ZS5qczogQWRkZWQuCisKIDIwMTAt MDYtMjkgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkIHRlc3QgZXhwZWN0YXRpb25zIHVwZGF0ZS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1kcmF3SW1hZ2UtaW5jb21wbGV0ZS1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZHJhd0ltYWdlLWluY29tcGxldGUt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmU3NGJhYjEK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtZHJhd0lt YWdlLWluY29tcGxldGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTkgQEAKK1Rlc3QgdGhhdCBk cmF3SW1hZ2UoKSBkb2VzIG5vdGhpbmcgd2l0aCBhbiBpbmNvbXBsZXRlIGltYWdlIG9yIHZpZGVv CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGN0eC5kcmF3SW1hZ2UoaW1n LCAwLCAwKSBpcyB1bmRlZmluZWQKK1BBU1MgaW1nZGF0YVswXSBpcyAyNTUKK1BBU1MgaW1nZGF0 YVsxXSBpcyAwCitQQVNTIGltZ2RhdGFbMl0gaXMgMAorUEFTUyBpbWdkYXRhWzNdIGlzIDI1NQor UEFTUyBjdHguZHJhd0ltYWdlKHZpZGVvLCAwLCAwKSBpcyB1bmRlZmluZWQKK1BBU1MgaW1nZGF0 YVswXSBpcyAyNTUKK1BBU1MgaW1nZGF0YVsxXSBpcyAwCitQQVNTIGltZ2RhdGFbMl0gaXMgMAor UEFTUyBpbWdkYXRhWzNdIGlzIDI1NQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1kcmF3SW1hZ2UtaW5jb21wbGV0ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv Y2FudmFzLWRyYXdJbWFnZS1pbmNvbXBsZXRlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uNGU2MjJiNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL2NhbnZhcy1kcmF3SW1hZ2UtaW5jb21wbGV0ZS5odG1sCkBAIC0wLDAgKzEsMTMgQEAK KzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgor PGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvY2Fu dmFzLWRyYXdJbWFnZS1pbmNvbXBsZXRlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3NjcmlwdC10ZXN0cy9jYW52YXMt ZHJhd0ltYWdlLWluY29tcGxldGUuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9zY3JpcHQt dGVzdHMvY2FudmFzLWRyYXdJbWFnZS1pbmNvbXBsZXRlLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjI4OWJkZTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy9zY3JpcHQtdGVzdHMvY2FudmFzLWRyYXdJbWFnZS1pbmNvbXBsZXRlLmpzCkBA IC0wLDAgKzEsMzIgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0IHRoYXQgZHJhd0ltYWdlKCkgZG9lcyBu b3RoaW5nIHdpdGggYW4gaW5jb21wbGV0ZSBpbWFnZSBvciB2aWRlbyIpOworCitpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1Rl eHQoKTsKKwordmFyIGNhbnZhcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOwor dmFyIGN0eCA9IGNhbnZhcy5nZXRDb250ZXh0KCcyZCcpOworY3R4LmZpbGxTdHlsZSA9ICdyZWQn OworY3R4LmZpbGxSZWN0KDAsMCwxNTAsMTUwKTsKKwordmFyIGltZyA9IG5ldyBJbWFnZSgpOwor aW1nLnNyYyA9ICcuLi8uLi9odHRwL3Rlc3RzL21pc2MvcmVzb3VyY2VzL2ltYWdlLXNsb3cucGwn OworCit2YXIgdmlkZW8gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ2aWRlbyIpOworCitzaG91 bGRCZSgiY3R4LmRyYXdJbWFnZShpbWcsIDAsIDApIiwgInVuZGVmaW5lZCIpOworCit2YXIgaW1n ZGF0YSA9IGN0eC5nZXRJbWFnZURhdGEoMCwgMCwgMSwgMSkuZGF0YTsKK3Nob3VsZEJlKCJpbWdk YXRhWzBdIiwgIjI1NSIpOworc2hvdWxkQmUoImltZ2RhdGFbMV0iLCAiMCIpOworc2hvdWxkQmUo ImltZ2RhdGFbMl0iLCAiMCIpOworc2hvdWxkQmUoImltZ2RhdGFbM10iLCAiMjU1Iik7CisKK3No b3VsZEJlKCJjdHguZHJhd0ltYWdlKHZpZGVvLCAwLCAwKSIsICJ1bmRlZmluZWQiKTsKKworaW1n ZGF0YSA9IGN0eC5nZXRJbWFnZURhdGEoMCwgMCwgMSwgMSkuZGF0YTsKK3Nob3VsZEJlKCJpbWdk YXRhWzBdIiwgIjI1NSIpOworc2hvdWxkQmUoImltZ2RhdGFbMV0iLCAiMCIpOworc2hvdWxkQmUo ImltZ2RhdGFbMl0iLCAiMCIpOworc2hvdWxkQmUoImltZ2RhdGFbM10iLCAiMjU1Iik7CisKK3Zh ciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMmRmZjU4Li43YTc2YTBhIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEwLTA2LTI5ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FudmFz OiBFeGNlcHRpb24gZXJyb25lb3VzbHkgdGhyb3duIGZvciBkcmF3SW1hZ2UoKSB3aGVuIGltYWdl LmNvbXBsZXRlPWZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMzk2OAorCisgICAgICAgIERvIG5vdGhpbmcgaW4gZHJhd0ltYWdlKCkgaWYgY2Fs bGVkIHdpdGggYW4gaW1hZ2Ugd2hvc2UgJ2NvbXBsZXRlJworICAgICAgICBhdHRyaWJ1dGUgaXMg ZmFsc2UsIG9yIGEgdmlkZW8gd2hvc2UgcmVhZHlTdGF0ZSBpcyBlaXRoZXIgSEFWRV9OT1RISU5H CisgICAgICAgIG9yIEhBVkVfTUVUQURBVEEuCisKKyAgICAgICAgU3BlYyBsaW5rOgorICAgICAg ICBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyNkb20t Y29udGV4dC0yZC1kcmF3aW1hZ2UKKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy9jYW52YXMt ZHJhd0ltYWdlLWluY29tcGxldGUuaHRtbAorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFz UmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmlu Z0NvbnRleHQyRDo6ZHJhd0ltYWdlKToKKwogMjAxMC0wNi0yOSAgWXVyeSBTZW1pa2hhdHNreSAg PHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkOiBDaHJvbWl1bSBXaW4g YW5kIE1hYyBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl cmluZ0NvbnRleHQyRC5jcHAKaW5kZXggYjYyNjdmNy4uNzcyZjU5YSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBiL1dlYkNv cmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNDUsNiArNDUs NyBAQAogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkhUTUxDYW52YXNF bGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTEltYWdlRWxlbWVudC5oIgorI2luY2x1ZGUgIkhUTUxN ZWRpYUVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MTmFtZXMuaCIKICNpbmNsdWRlICJJbWFnZUJ1 ZmZlci5oIgogI2luY2x1ZGUgIkltYWdlRGF0YS5oIgpAQCAtMTAyMiw2ICsxMDIzLDkgQEAgdm9p ZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdJbWFnZShIVE1MSW1hZ2VFbGVtZW50KiBp bWFnZSwgY29uc3QgRmxvYXRSZWMKICAgICAgICAgfHwgIWlzZmluaXRlKHNyY1JlY3QueCgpKSB8 fCAhaXNmaW5pdGUoc3JjUmVjdC55KCkpIHx8ICFpc2Zpbml0ZShzcmNSZWN0LndpZHRoKCkpIHx8 ICFpc2Zpbml0ZShzcmNSZWN0LmhlaWdodCgpKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYg KCFpbWFnZS0+Y29tcGxldGUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgRmxvYXRSZWN0IGlt YWdlUmVjdCA9IEZsb2F0UmVjdChGbG9hdFBvaW50KCksIHNpemUoaW1hZ2UpKTsKICAgICBpZiAo IWltYWdlUmVjdC5jb250YWlucyhub3JtYWxpemVSZWN0KHNyY1JlY3QpKSB8fCBzcmNSZWN0Lndp ZHRoKCkgPT0gMCB8fCBzcmNSZWN0LmhlaWdodCgpID09IDApIHsKICAgICAgICAgZWMgPSBJTkRF WF9TSVpFX0VSUjsKQEAgLTExNTgsNiArMTE2MiwxMCBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRDo6ZHJhd0ltYWdlKEhUTUxWaWRlb0VsZW1lbnQqIHZpZGVvLCBjb25zdCBGbG9hdFJl YwogICAgIH0KICAgICAKICAgICBlYyA9IDA7CisKKyAgICBpZiAodmlkZW8tPnJlYWR5U3RhdGUo KSA9PSBIVE1MTWVkaWFFbGVtZW50OjpIQVZFX05PVEhJTkcgfHwgdmlkZW8tPnJlYWR5U3RhdGUo KSA9PSBIVE1MTWVkaWFFbGVtZW50OjpIQVZFX01FVEFEQVRBKQorICAgICAgICByZXR1cm47CisK ICAgICBGbG9hdFJlY3QgdmlkZW9SZWN0ID0gRmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgc2l6ZSh2 aWRlbykpOwogICAgIGlmICghdmlkZW9SZWN0LmNvbnRhaW5zKG5vcm1hbGl6ZVJlY3Qoc3JjUmVj dCkpIHx8IHNyY1JlY3Qud2lkdGgoKSA9PSAwIHx8IHNyY1JlY3QuaGVpZ2h0KCkgPT0gMCkgewog ICAgICAgICBlYyA9IElOREVYX1NJWkVfRVJSOwo=