33967 2010-01-21 12:37:39 -0800 [GTK] Mute/unmute button on <video> elements are backwards 2010-04-22 08:36:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 mh+webkit webkit-unassigned commit-queue darin eric.carlson gustavo xan.lopez oldest_to_newest 183281 0 mh+webkit 2010-01-21 12:37:39 -0800 The button was added as part of #26304. When the sound is muted, the icon displays the "audio-volume-high" icon, and on the contrary, when the sound is unmuted, the "audio-volume-muted" icon is displayed. While when you read the latter this way it can sound normal, it actually makes no sense, because it doesn't reflect the current state of the sound. The patch I'm attaching will fix the obvious problem, but I think the variable names should be changed to something that makes it more obvious, like "m_mutedButton" and "m_unmutedButton" (which would reverse their meaning). What do you think ? 183282 1 47138 mh+webkit 2010-01-21 12:39:06 -0800 Created attachment 47138 Patch With the patch 183381 2 47138 eric 2010-01-21 16:46:04 -0800 Comment on attachment 47138 Patch I don't like these variable names. m_pauseButton will cause pause to happen, or shows the fact that it's currently paused? The way this is written, it seems mute is being used the opposite. 183383 3 47138 eric 2010-01-21 16:46:47 -0800 Comment on attachment 47138 Patch Every change requires a ChangeLog. see http://webkit.org/coding/contributing.html 183524 4 mh+webkit 2010-01-22 00:10:52 -0800 (In reply to comment #3) > (From update of attachment 47138 [details]) > Every change requires a ChangeLog. see > http://webkit.org/coding/contributing.html I know that ;) I first wanted to know how this should be fixed. We seem to agree on the fact that the variable names are ambiguous. How about renaming them to a past participle form as proposed in comment #0 ? (m_mutedButton, m_pausedButton, etc.) 187613 5 eric.carlson 2010-02-03 20:16:47 -0800 Or you could change the name to indicate the action they will take: m_willMuteButton, m_willPauseButton, etc. 189990 6 xan.lopez 2010-02-12 02:30:44 -0800 (In reply to comment #5) > Or you could change the name to indicate the action they will take: > m_willMuteButton, m_willPauseButton, etc. I think considering how they are used: return paintMediaButton(paintInfo.context, r, mediaElement->muted() ? m_unmuteButton.get() : m_muteButton.get(), m_panelColor, m_mediaIconSize); the names of the buttons are already OK (and consistent with the other buttons). It's just that what they do when clicked is the opposite to the status they should reflect, since they reverse themselves. So if we do what comment #0 suggests at the end, or similar, we'd make one thing clear but the other unclear (ie, the state would match the name but not the action). So IMHO it's fine to just commit what the patch does, perhaps adding a small comment explaining it. 190057 7 eric.carlson 2010-02-12 08:04:07 -0800 (In reply to comment #6) > I think considering how they are used: > > return paintMediaButton(paintInfo.context, r, mediaElement->muted() ? > m_unmuteButton.get() : m_muteButton.get(), m_panelColor, m_mediaIconSize); > > the names of the buttons are already OK (and consistent with the other > buttons). It's just that what they do when clicked is the opposite to the > status they should reflect, since they reverse themselves. So if we do what > comment #0 suggests at the end, or similar, we'd make one thing clear but the > other unclear (ie, the state would match the name but not the action). > > So IMHO it's fine to just commit what the patch does, perhaps adding a small > comment explaining it. I am also fine with adding comments to the code and leaving the names as-is. 215728 8 54030 diegoe 2010-04-21 23:33:05 -0700 Created attachment 54030 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [GTK] Mute/unmute button on <video> elements are backwards https://bugs.webkit.org/show_bug.cgi?id=33967 Fix mute/unmute buttons icons-action relation and explain why their variable names and corresponding icons seem to be misleading but are actually right. Original patch by Mike Hommey. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling): 215731 9 54031 diegoe 2010-04-21 23:36:12 -0700 Created attachment 54031 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> review! 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> Reviewed by NOBODY (OOPS!). [GTK] Mute/unmute button on <video> elements are backwards https://bugs.webkit.org/show_bug.cgi?id=33967 Fix mute/unmute buttons icons-action relation and explain why their variable names and corresponding icons seem to be misleading but are actually right. Original patch by Mike Hommey. * platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::initMediaStyling): 215888 10 54031 commit-queue 2010-04-22 08:36:51 -0700 Comment on attachment 54031 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> Clearing flags on attachment: 54031 Committed r58097: <http://trac.webkit.org/changeset/58097> 215889 11 commit-queue 2010-04-22 08:36:57 -0700 All reviewed patches have been landed. Closing bug. 47138 2010-01-21 12:39:06 -0800 2010-01-21 16:46:46 -0800 Patch diff text/plain 1167 mh+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcCBiL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAppbmRleCAwYzE1N2NmLi45MGQ2 MGVjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCkBAIC05MCw4ICs5 MCw4IEBAIHZvaWQgUmVuZGVyVGhlbWVHdGs6OmluaXRNZWRpYVN0eWxpbmcoR3RrU3R5bGUqIHN0 eWxlLCBib29sIGZvcmNlKQogICAgICAgICBtX3NlZWtGb3J3YXJkQnV0dG9uLmNsZWFyKCk7CiAK ICAgICAgICAgbV9mdWxsc2NyZWVuQnV0dG9uID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNv bigiZ3RrLWZ1bGxzY3JlZW4iLCBtX21lZGlhSWNvblNpemUpOwotICAgICAgICBtX211dGVCdXR0 b24gPSBJbWFnZTo6bG9hZFBsYXRmb3JtVGhlbWVJY29uKCJhdWRpby12b2x1bWUtbXV0ZWQiLCBt X21lZGlhSWNvblNpemUpOwotICAgICAgICBtX3VubXV0ZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxh dGZvcm1UaGVtZUljb24oImF1ZGlvLXZvbHVtZS1oaWdoIiwgbV9tZWRpYUljb25TaXplKTsKKyAg ICAgICAgbV9tdXRlQnV0dG9uID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbigiYXVkaW8t dm9sdW1lLWhpZ2giLCBtX21lZGlhSWNvblNpemUpOworICAgICAgICBtX3VubXV0ZUJ1dHRvbiA9 IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImF1ZGlvLXZvbHVtZS1tdXRlZCIsIG1fbWVk aWFJY29uU2l6ZSk7CiAgICAgICAgIG1fcGxheUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1U aGVtZUljb24ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4ocGxheUJ1dHRvbkljb25OYW1l KSwgbV9tZWRpYUljb25TaXplKTsKICAgICAgICAgbV9wYXVzZUJ1dHRvbiA9IEltYWdlOjpsb2Fk UGxhdGZvcm1UaGVtZUljb24oImd0ay1tZWRpYS1wYXVzZSIsIG1fbWVkaWFJY29uU2l6ZSkucmVs ZWFzZVJlZigpOwogICAgICAgICBtX3NlZWtCYWNrQnV0dG9uID0gSW1hZ2U6OmxvYWRQbGF0Zm9y bVRoZW1lSWNvbihyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihzZWVrQmFja0J1dHRvbklj b25OYW1lKSwgbV9tZWRpYUljb25TaXplKTsK 54030 2010-04-21 23:33:05 -0700 2010-04-21 23:37:02 -0700 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> 2010-04-21-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 3074 diegoe RnJvbSAxYTZhMjFlOTE4NDYwOTIwODMzZWVlYjZiNDJjYTMxZTg2MmNkOTkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkZXNjYWxhbnRlQGln YWxpYS5jb20+CkRhdGU6IFRodSwgMjIgQXByIDIwMTAgMDE6Mjc6NTAgLTA1MDAKU3ViamVjdDog W1BBVENIXSAyMDEwLTA0LTIxICBEaWVnbyBFc2NhbGFudGUgVXJyZWxvICA8ZGVzY2FsYW50ZUBp Z2FsaWEuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg W0dUS10gTXV0ZS91bm11dGUgYnV0dG9uIG9uIDx2aWRlbz4gZWxlbWVudHMgYXJlIGJhY2t3YXJk cwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk2NwoK ICAgICAgICBGaXggbXV0ZS91bm11dGUgYnV0dG9ucyBpY29ucy1hY3Rpb24gcmVsYXRpb24gYW5k IGV4cGxhaW4gd2h5IHRoZWlyCiAgICAgICAgdmFyaWFibGUgbmFtZXMgYW5kIGNvcnJlc3BvbmRp bmcgaWNvbnMgc2VlbSB0byBiZSBtaXNsZWFkaW5nIGJ1dCBhcmUKICAgICAgICBhY3R1YWxseSBy aWdodC4gT3JpZ2luYWwgcGF0Y2ggYnkgTWlrZSBIb21tZXkuCgogICAgICAgICogcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6 OmluaXRNZWRpYVN0eWxpbmcpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRl clRoZW1lR3RrLmNwcCB8ICAgIDcgKysrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ2MDcxYi4uYzA3NzA5MyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxMC0wNC0yMSAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlhLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RL XSBNdXRlL3VubXV0ZSBidXR0b24gb24gPHZpZGVvPiBlbGVtZW50cyBhcmUgYmFja3dhcmRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk2NworCisg ICAgICAgIEZpeCBtdXRlL3VubXV0ZSBidXR0b25zIGljb25zLWFjdGlvbiByZWxhdGlvbiBhbmQg ZXhwbGFpbiB3aHkgdGhlaXIKKyAgICAgICAgdmFyaWFibGUgbmFtZXMgYW5kIGNvcnJlc3BvbmRp bmcgaWNvbnMgc2VlbSB0byBiZSBtaXNsZWFkaW5nIGJ1dCBhcmUKKyAgICAgICAgYWN0dWFsbHkg cmlnaHQuIE9yaWdpbmFsIHBhdGNoIGJ5IE1pa2UgSG9tbWV5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l R3RrOjppbml0TWVkaWFTdHlsaW5nKToKKwogMjAxMC0wNC0yMCAgU2hpbmljaGlybyBIYW1hamkg IDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy IGFuZCBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvUmVuZGVyVGhlbWVHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVH dGsuY3BwCmluZGV4IDkzNzk0ZmYuLjYxZTQ3MDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5jcHAKQEAgLTkyLDggKzkyLDExIEBAIHZvaWQgUmVuZGVyVGhlbWVHdGs6Omlu aXRNZWRpYVN0eWxpbmcoR3RrU3R5bGUqIHN0eWxlLCBib29sIGZvcmNlKQogICAgICAgICBtX3Nl ZWtGb3J3YXJkQnV0dG9uLmNsZWFyKCk7CiAKICAgICAgICAgbV9mdWxsc2NyZWVuQnV0dG9uID0g SW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbigiZ3RrLWZ1bGxzY3JlZW4iLCBtX21lZGlhSWNv blNpemUpOwotICAgICAgICBtX211dGVCdXR0b24gPSBJbWFnZTo6bG9hZFBsYXRmb3JtVGhlbWVJ Y29uKCJhdWRpby12b2x1bWUtbXV0ZWQiLCBtX21lZGlhSWNvblNpemUpOwotICAgICAgICBtX3Vu bXV0ZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImF1ZGlvLXZvbHVtZS1o aWdoIiwgbV9tZWRpYUljb25TaXplKTsKKwkvLyBOb3RlIHRoYXQgdGhlIG11dGVCdXR0b24gYW5k IHVubXV0ZUJ1dHRvbiB0YWtlIGljb25zIHJlZmxlY3RpbmcKKwkvLyB0aGUgKmN1cnJlbnQqIHN0 YXRlLiBIZW5jZSwgdGhlIHVubXV0ZUJ1dHRvbiByZXByZXNlbnRzIHRoZSAqbXV0ZWQqCisJLy8g c3RhdHVzLCB0aGUgbXV0ZUJ1dHRvbiByZXByZXNlbnRzIHRoZSB0aGVuIGN1cnJlbnQgKnVubXV0 ZWQqIHN0YXR1cy4KKyAgICAgICAgbV9tdXRlQnV0dG9uID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVRo ZW1lSWNvbigiYXVkaW8tdm9sdW1lLWhpZ2giLCBtX21lZGlhSWNvblNpemUpOworICAgICAgICBt X3VubXV0ZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImF1ZGlvLXZvbHVt ZS1tdXRlZCIsIG1fbWVkaWFJY29uU2l6ZSk7CiAgICAgICAgIG1fcGxheUJ1dHRvbiA9IEltYWdl Ojpsb2FkUGxhdGZvcm1UaGVtZUljb24ocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4ocGxh eUJ1dHRvbkljb25OYW1lKSwgbV9tZWRpYUljb25TaXplKTsKICAgICAgICAgbV9wYXVzZUJ1dHRv biA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImd0ay1tZWRpYS1wYXVzZSIsIG1fbWVk aWFJY29uU2l6ZSkucmVsZWFzZVJlZigpOwogICAgICAgICBtX3NlZWtCYWNrQnV0dG9uID0gSW1h Z2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbihyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihz ZWVrQmFja0J1dHRvbkljb25OYW1lKSwgbV9tZWRpYUljb25TaXplKTsKLS0gCjEuNy4wLjQ= 54031 2010-04-21 23:36:12 -0700 2010-04-22 08:36:50 -0700 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com> 2010-04-21-Diego-Escalante-Urrelo-descalanteigalia.patch text/plain 3095 diegoe RnJvbSAxMzdiNDA3MDViYThiMTVhN2MwMDk5MTkzMDBkNTY5MWNmOTNiNmQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEaWVnbyBFc2NhbGFudGUgVXJyZWxvIDxkZXNjYWxhbnRlQGln YWxpYS5jb20+CkRhdGU6IFRodSwgMjIgQXByIDIwMTAgMDE6Mjc6NTAgLTA1MDAKU3ViamVjdDog W1BBVENIXSAyMDEwLTA0LTIxICBEaWVnbyBFc2NhbGFudGUgVXJyZWxvICA8ZGVzY2FsYW50ZUBp Z2FsaWEuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg W0dUS10gTXV0ZS91bm11dGUgYnV0dG9uIG9uIDx2aWRlbz4gZWxlbWVudHMgYXJlIGJhY2t3YXJk cwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk2NwoK ICAgICAgICBGaXggbXV0ZS91bm11dGUgYnV0dG9ucyBpY29ucy1hY3Rpb24gcmVsYXRpb24gYW5k IGV4cGxhaW4gd2h5IHRoZWlyCiAgICAgICAgdmFyaWFibGUgbmFtZXMgYW5kIGNvcnJlc3BvbmRp bmcgaWNvbnMgc2VlbSB0byBiZSBtaXNsZWFkaW5nIGJ1dCBhcmUKICAgICAgICBhY3R1YWxseSBy aWdodC4gT3JpZ2luYWwgcGF0Y2ggYnkgTWlrZSBIb21tZXkuCgogICAgICAgICogcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6 OmluaXRNZWRpYVN0eWxpbmcpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRl clRoZW1lR3RrLmNwcCB8ICAgIDcgKysrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ2MDcxYi4uYzA3NzA5MyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxMC0wNC0yMSAgRGllZ28gRXNjYWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlhLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RL XSBNdXRlL3VubXV0ZSBidXR0b24gb24gPHZpZGVvPiBlbGVtZW50cyBhcmUgYmFja3dhcmRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk2NworCisg ICAgICAgIEZpeCBtdXRlL3VubXV0ZSBidXR0b25zIGljb25zLWFjdGlvbiByZWxhdGlvbiBhbmQg ZXhwbGFpbiB3aHkgdGhlaXIKKyAgICAgICAgdmFyaWFibGUgbmFtZXMgYW5kIGNvcnJlc3BvbmRp bmcgaWNvbnMgc2VlbSB0byBiZSBtaXNsZWFkaW5nIGJ1dCBhcmUKKyAgICAgICAgYWN0dWFsbHkg cmlnaHQuIE9yaWdpbmFsIHBhdGNoIGJ5IE1pa2UgSG9tbWV5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1l R3RrOjppbml0TWVkaWFTdHlsaW5nKToKKwogMjAxMC0wNC0yMCAgU2hpbmljaGlybyBIYW1hamkg IDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy IGFuZCBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvUmVuZGVyVGhlbWVHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVH dGsuY3BwCmluZGV4IDkzNzk0ZmYuLjMxYWYxYTkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5jcHAKQEAgLTkyLDggKzkyLDExIEBAIHZvaWQgUmVuZGVyVGhlbWVHdGs6Omlu aXRNZWRpYVN0eWxpbmcoR3RrU3R5bGUqIHN0eWxlLCBib29sIGZvcmNlKQogICAgICAgICBtX3Nl ZWtGb3J3YXJkQnV0dG9uLmNsZWFyKCk7CiAKICAgICAgICAgbV9mdWxsc2NyZWVuQnV0dG9uID0g SW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbigiZ3RrLWZ1bGxzY3JlZW4iLCBtX21lZGlhSWNv blNpemUpOwotICAgICAgICBtX211dGVCdXR0b24gPSBJbWFnZTo6bG9hZFBsYXRmb3JtVGhlbWVJ Y29uKCJhdWRpby12b2x1bWUtbXV0ZWQiLCBtX21lZGlhSWNvblNpemUpOwotICAgICAgICBtX3Vu bXV0ZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImF1ZGlvLXZvbHVtZS1o aWdoIiwgbV9tZWRpYUljb25TaXplKTsKKyAgICAgICAgLy8gTm90ZSB0aGF0IHRoZSBtdXRlQnV0 dG9uIGFuZCB1bm11dGVCdXR0b24gdGFrZSBpY29ucyByZWZsZWN0aW5nCisgICAgICAgIC8vIHRo ZSAqY3VycmVudCogc3RhdGUuIEhlbmNlLCB0aGUgdW5tdXRlQnV0dG9uIHJlcHJlc2VudHMgdGhl ICptdXRlZCoKKyAgICAgICAgLy8gc3RhdHVzLCB0aGUgbXV0ZUJ1dHRvbiByZXByZXNlbnRzIHRo ZSB0aGVuIGN1cnJlbnQgKnVubXV0ZWQqIHN0YXR1cy4KKyAgICAgICAgbV9tdXRlQnV0dG9uID0g SW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbigiYXVkaW8tdm9sdW1lLWhpZ2giLCBtX21lZGlh SWNvblNpemUpOworICAgICAgICBtX3VubXV0ZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1U aGVtZUljb24oImF1ZGlvLXZvbHVtZS1tdXRlZCIsIG1fbWVkaWFJY29uU2l6ZSk7CiAgICAgICAg IG1fcGxheUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24ocmVpbnRlcnByZXRf Y2FzdDxjb25zdCBjaGFyKj4ocGxheUJ1dHRvbkljb25OYW1lKSwgbV9tZWRpYUljb25TaXplKTsK ICAgICAgICAgbV9wYXVzZUJ1dHRvbiA9IEltYWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oImd0 ay1tZWRpYS1wYXVzZSIsIG1fbWVkaWFJY29uU2l6ZSkucmVsZWFzZVJlZigpOwogICAgICAgICBt X3NlZWtCYWNrQnV0dG9uID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVRoZW1lSWNvbihyZWludGVycHJl dF9jYXN0PGNvbnN0IGNoYXIqPihzZWVrQmFja0J1dHRvbkljb25OYW1lKSwgbV9tZWRpYUljb25T aXplKTsKLS0gCjEuNy4wLjQ=