33966 2010-01-21 12:34:28 -0800 r53595 breaks Database in Chromium 2010-01-21 13:04:19 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P1 Major --- 0 ericu webkit-unassigned ajwong dglazkov dimich michaeln oldest_to_newest 183280 0 ericu 2010-01-21 12:34:28 -0800 I missed out a few chromium-specific files; without them, the database APIs are inaccessible. I'll post the patch shortly. 183283 1 47139 ericu 2010-01-21 12:39:21 -0800 Created attachment 47139 Patch adding 3 missing files; this should fix all the storage tests for Chromium. 183289 2 47139 dimich 2010-01-21 12:54:09 -0800 Comment on attachment 47139 Patch adding 3 missing files; this should fix all the storage tests for Chromium. r=me Will land manually in a moment, ChangeLog needs some re-phrasing. 183293 3 dimich 2010-01-21 13:04:19 -0800 Landed: http://trac.webkit.org/changeset/53641 47139 2010-01-21 12:39:21 -0800 2010-01-21 12:54:09 -0800 Patch adding 3 missing files; this should fix all the storage tests for Chromium. official_fix.patch text/plain 3729 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzYzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMjEgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgZmlsZXMgbWlzc2luZyBmcm9tIHI1MzU5NSwgd2l0aG91dCB3aGljaCBDaHJvbWl1bSBoYXMg bm8gZGF0YWJhc2UuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzM5NjYKKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcDoKKyAgICAgICAgKiBiaW5k aW5ncy92OC9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg6CisKIDIwMTAtMDEtMjAgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJl cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9SdW50aW1lRW5hYmxlZEZl YXR1cmVzLmNwcAkocmV2aXNpb24gNTM2MzMpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1J1bnRp bWVFbmFibGVkRmVhdHVyZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw2IEBACiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0Rh dGFiYXNlRW5hYmxlZCA9IGZhbHNlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0xv Y2FsU3RvcmFnZUVuYWJsZWQgPSB0cnVlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpp c1Nlc3Npb25TdG9yYWdlRW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVy ZXM6OmlzTm90aWZpY2F0aW9uc0VuYWJsZWQgPSBmYWxzZTsKSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCShyZXZpc2lvbiA1MzYzMykKKysrIFdl YkNvcmUvYmluZGluZ3MvdjgvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCSh3b3JraW5nIGNvcHkp CkBAIC0zNiw5ICszNiw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vIEEgY2xhc3MgdGhhdCBz dG9yZXMgc3RhdGljIGVuYWJsZXJzIGZvciBhbGwgZXhwZXJpbWVudGFsIGZlYXR1cmVzCiBjbGFz cyBSdW50aW1lRW5hYmxlZEZlYXR1cmVzIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgdm9pZCBzZXRE YXRhYmFzZUVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNEYXRhYmFzZUVuYWJsZWQgPSBpc0Vu YWJsZWQ7IH0KLSAgICBzdGF0aWMgYm9vbCBkYXRhYmFzZUVuYWJsZWQoKSB7IHJldHVybiBpc0Rh dGFiYXNlRW5hYmxlZDsgfQotCiAgICAgc3RhdGljIHZvaWQgc2V0TG9jYWxTdG9yYWdlRW5hYmxl ZChib29sIGlzRW5hYmxlZCkgeyBpc0xvY2FsU3RvcmFnZUVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0K ICAgICBzdGF0aWMgYm9vbCBsb2NhbFN0b3JhZ2VFbmFibGVkKCkgeyByZXR1cm4gaXNMb2NhbFN0 b3JhZ2VFbmFibGVkOyB9CiAKQEAgLTU4LDcgKzU1LDYgQEAgcHJpdmF0ZToKICAgICAvLyBOZXZl ciBpbnN0YW50aWF0ZS4KICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzKCkgeyB9CiAKLSAgICBz dGF0aWMgYm9vbCBpc0RhdGFiYXNlRW5hYmxlZDsKICAgICBzdGF0aWMgYm9vbCBpc0xvY2FsU3Rv cmFnZUVuYWJsZWQ7CiAgICAgc3RhdGljIGJvb2wgaXNTZXNzaW9uU3RvcmFnZUVuYWJsZWQ7CiAg ICAgc3RhdGljIGJvb2wgaXNOb3RpZmljYXRpb25zRW5hYmxlZDsKSW5kZXg6IFdlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko cmV2aXNpb24gNTM2MzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMjEgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgZmlsZXMgbWlzc2luZyBmcm9tIHI1MzU5NSwgd2l0aG91dCB3aGljaCBDaHJvbWl1 bSBoYXMgbm8gZGF0YWJhc2UuCisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5NjYKKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAg ICAgICAgKiBzcmMvV2ViUnVudGltZUZlYXR1cmVzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UnVudGltZUZlYXR1cmVzOjplbmFibGVEYXRhYmFzZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlJ1 bnRpbWVGZWF0dXJlczo6aXNEYXRhYmFzZUVuYWJsZWQpOgorCiAyMDEwLTAxLTIwICBWaXRhbHkg UmVwZXNoa28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJSdW50aW1lRmVhdHVy ZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViUnVudGltZUZlYXR1 cmVzLmNwcAkocmV2aXNpb24gNTM2MzMpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJ1bnRp bWVGZWF0dXJlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRl ICJjb25maWcuaCIKICNpbmNsdWRlICJXZWJSdW50aW1lRmVhdHVyZXMuaCIKIAorI2luY2x1ZGUg IkRhdGFiYXNlLmgiCiAjaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIgogI2luY2x1 ZGUgIldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5oIgogI2luY2x1ZGUgIldlYlNvY2tldC5oIgpA QCAtNDIsMTQgKzQzLDE0IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogdm9pZCBXZWJSdW50aW1lRmVh dHVyZXM6OmVuYWJsZURhdGFiYXNlKGJvb2wgZW5hYmxlKQogewogI2lmIEVOQUJMRShEQVRBQkFT RSkKLSAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXREYXRhYmFzZUVuYWJsZWQoZW5hYmxl KTsKKyAgICBEYXRhYmFzZTo6c2V0SXNBdmFpbGFibGUoZW5hYmxlKTsKICNlbmRpZgogfQogCiBi b29sIFdlYlJ1bnRpbWVGZWF0dXJlczo6aXNEYXRhYmFzZUVuYWJsZWQoKQogewogI2lmIEVOQUJM RShEQVRBQkFTRSkKLSAgICByZXR1cm4gUnVudGltZUVuYWJsZWRGZWF0dXJlczo6ZGF0YWJhc2VF bmFibGVkKCk7CisgICAgcmV0dXJuIERhdGFiYXNlOjppc0F2YWlsYWJsZSgpOwogI2Vsc2UKICAg ICByZXR1cm4gZmFsc2U7CiAjZW5kaWYK