33960 2010-01-21 11:09:03 -0800 Restore MediaPlayer totalBytesKnown and totalBytes methods 2010-01-24 20:31:45 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 eric.carlson eric.carlson hausmann ossy vestbo oldest_to_newest 183251 0 eric.carlson 2010-01-21 11:09:03 -0800 http://trac.webkit.org/changeset/53625 removed these methods from the MediaPlayer interface because they aren't necessary to implement the HTMLMediaElement interface, but they were used by the default Qt media controller. Using bytes loaded as an indication of the amount loaded in a slider that scrubs though a movie in *time* is probably a bad idea because very few movies have constant bit-rate these days, but the methods should be restored so the controller can function. 183288 1 47141 eric.carlson 2010-01-21 12:53:56 -0800 Created attachment 47141 Possible patch Possible patch. Not flagging r? until Simon and/or Tor Arne chime in about whether or not they want it. 183580 2 vestbo 2010-01-22 03:20:11 -0800 I'm fine with removing these for the Qt port too, they were implemented just to have a complete overview of the MediaPlayerPrivate interface when I was doing the Phonon port. For phonon there's actually no way to get these things anyways when the media is loaded by Phonon by passing a URL. I'm hoping we'll will be able to load the media in WebCore in the future, in which case these kind of things would be in platform-independent code. Eric, do you know anything about the possibly of feeding QuickTime data instead of passing it a URL? I tried poking at NewMovieFromUserProc but didn't get too far. 183683 3 eric.carlson 2010-01-22 10:03:01 -0800 (In reply to comment #2) > > Eric, do you know anything about the possibly of feeding QuickTime data instead > of passing it a URL? I tried poking at NewMovieFromUserProc but didn't get too > far. The only way to do this is to write a QuickTime datahandler component, which is a PITA but doable. The bigger problems are that it won't work in 64-bit, and WebKit's resource loader isn't ideally suited for loading media data right now - data is loaded sequentially, can't load more than 2GB, all data kept in memory, etc. 47141 2010-01-21 12:53:56 -0800 2010-01-21 12:53:56 -0800 Possible patch fix_patch_1.txt text/plain 6425 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzYzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTAtMDEtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVzdG9yZSBNZWRpYVBsYXllciB0b3RhbEJ5dGVzS25vd24gYW5kIHRvdGFsQnl0ZXMgbWV0 aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5 NjAKKworICAgICAgICBSZXN0b3JlIHRvdGFsQnl0ZXNLbm93biBhbmQgdG90YWxCeXRlcyBtZXRo b2RzIHRvIG5vbi1BcHBsZSBwb3J0cy4KKyAgICAgICAgVGhlc2UgbWV0aG9kcyBhcmUgbm90IGxv bmdlciB1c2VkIGJ5IEhUTUxNZWRpYUVsZW1lbnQsIGJ1dCB0aGVtIFF0CisgICAgICAgIG1lZGlh IGNvbnRyb2xsZXIgZG9lcyBhbmQgb3RoZXIgcGxhdGZvcm1zIG1heSB3YW50IHRvIHVzZSB0aGVt IGFzIHdlbGwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpOdWxsTWVkaWFQbGF5ZXJQcml2YXRlOjp0b3RhbEJ5dGVzS25v d24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXI6OnRvdGFsQnl0ZXNLbm93bik6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllcjo6dG90YWxCeXRlcyk6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9NZWRpYVBsYXllclByaXZhdGUuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUludGVyZmFjZTo6dG90YWxCeXRlc0tub3duKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dG90YWxCeXRlc0tub3duKToKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmg6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dG90YWxCeXRlc0tub3duKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVQaG9ub24uaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9NZWRpYVBsYXllclByaXZhdGVXaW5j ZS5oOgorCiAyMDEwLTAxLTIxICBBbmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCShyZXZpc2lvbiA1MzYyNSkKKysrIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Niw2 ICs5Niw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGZsb2F0IG1heFRpbWVTZWVrYWJsZSgpIGNv bnN0IHsgcmV0dXJuIDA7IH0KICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8VGltZVJhbmdlcz4gYnVm ZmVyZWQoKSBjb25zdCB7IHJldHVybiBUaW1lUmFuZ2VzOjpjcmVhdGUoKTsgfQogCisgICAgdmly dHVhbCBib29sIHRvdGFsQnl0ZXNLbm93bigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAg dmlydHVhbCB1bnNpZ25lZCB0b3RhbEJ5dGVzKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHZp cnR1YWwgdW5zaWduZWQgYnl0ZXNMb2FkZWQoKSBjb25zdCB7IHJldHVybiAwOyB9CiAKQEAgLTQy NSw2ICs0MjYsMTYgQEAgdW5zaWduZWQgTWVkaWFQbGF5ZXI6OmJ5dGVzTG9hZGVkKCkKICAgICBy ZXR1cm4gbV9wcml2YXRlLT5ieXRlc0xvYWRlZCgpOwogfQogCitib29sIE1lZGlhUGxheWVyOjp0 b3RhbEJ5dGVzS25vd24oKQoreworICAgIHJldHVybiBtX3ByaXZhdGUtPnRvdGFsQnl0ZXNLbm93 bigpOworfQorCit1bnNpZ25lZCBNZWRpYVBsYXllcjo6dG90YWxCeXRlcygpCit7CisgICAgcmV0 dXJuIG1fcHJpdmF0ZS0+dG90YWxCeXRlcygpOworfQorCiB2b2lkIE1lZGlhUGxheWVyOjpzZXRT aXplKGNvbnN0IEludFNpemUmIHNpemUpCiB7IAogICAgIG1fc2l6ZSA9IHNpemU7CkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCShyZXZpc2lvbiA1MzYyNSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAkod29ya2luZyBjb3B5KQpA QCAtMTczLDYgKzE3Myw4IEBAIHB1YmxpYzoKICAgICBmbG9hdCBtYXhUaW1lU2Vla2FibGUoKTsK IAogICAgIHVuc2lnbmVkIGJ5dGVzTG9hZGVkKCk7CisgICAgYm9vbCB0b3RhbEJ5dGVzS25vd24o KTsKKyAgICB1bnNpZ25lZCB0b3RhbEJ5dGVzKCk7CiAgICAgCiAgICAgZmxvYXQgdm9sdW1lKCkg Y29uc3Q7CiAgICAgdm9pZCBzZXRWb2x1bWUoZmxvYXQpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9NZWRpYVBsYXllclByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyUHJpdmF0ZS5oCShyZXZpc2lvbiA1MzYyNSkKKysr IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXJQcml2YXRlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTgzLDYgKzgzLDggQEAgcHVibGljOgogICAgIHZpcnR1YWwgZmxvYXQgbWF4VGlt ZVNlZWthYmxlKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxUaW1lUmFuZ2Vz PiBidWZmZXJlZCgpIGNvbnN0ID0gMDsKIAorICAgIHZpcnR1YWwgYm9vbCB0b3RhbEJ5dGVzS25v d24oKSBjb25zdCB7IHJldHVybiB0b3RhbEJ5dGVzKCkgPiAwOyB9CisgICAgdmlydHVhbCB1bnNp Z25lZCB0b3RhbEJ5dGVzKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgdW5zaWduZWQgYnl0ZXNM b2FkZWQoKSBjb25zdCA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2l6ZShjb25zdCBJbnRT aXplJikgPSAwOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCShyZXZpc2lvbiA1MzYy NSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4OCw2ICs1ODgsMTIgQEAgdW5zaWduZWQg TWVkaWFQbGF5ZXJQcml2YXRlOjpieXRlc0xvYWRlZAogICAgIHJldHVybiAxOyAvLyB0b3RhbEJ5 dGVzKCkgKiBtYXhUaW1lIC8gZHVyOwogfQogCitib29sIE1lZGlhUGxheWVyUHJpdmF0ZTo6dG90 YWxCeXRlc0tub3duKCkgY29uc3QKK3sKKyAgICBMT0dfVkVSQk9TRShNZWRpYSwgInRvdGFsQnl0 ZXNLbm93biIpOworICAgIHJldHVybiB0b3RhbEJ5dGVzKCkgPiAwOworfQorCiB1bnNpZ25lZCBN ZWRpYVBsYXllclByaXZhdGU6OnRvdGFsQnl0ZXMoKSBjb25zdAogewogICAgIExPR19WRVJCT1NF KE1lZGlhLCAidG90YWxCeXRlcyIpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n dGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgJKHJldmlz aW9uIDUzNjI1KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDcgQEAgY2xhc3Mg TWVkaWFQbGF5ZXJQcml2YXRlIDogcHVibGljIE1lZGlhUAogICAgICAgICAgICAgUGFzc1JlZlB0 cjxUaW1lUmFuZ2VzPiBidWZmZXJlZCgpIGNvbnN0OwogICAgICAgICAgICAgZmxvYXQgbWF4VGlt ZVNlZWthYmxlKCkgY29uc3Q7CiAgICAgICAgICAgICB1bnNpZ25lZCBieXRlc0xvYWRlZCgpIGNv bnN0OworICAgICAgICAgICAgYm9vbCB0b3RhbEJ5dGVzS25vd24oKSBjb25zdDsKICAgICAgICAg ICAgIHVuc2lnbmVkIHRvdGFsQnl0ZXMoKSBjb25zdDsKIAogICAgICAgICAgICAgdm9pZCBzZXRW aXNpYmxlKGJvb2wpOwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBs YXllclByaXZhdGVQaG9ub24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uLmNwcAkocmV2aXNpb24gNTM2MjUpCisr KyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI3Nyw2ICsyNzcsMTIgQEAgdW5zaWduZWQgTWVkaWFQbGF5 ZXJQcml2YXRlOjpieXRlc0xvYWRlZAogICAgIHJldHVybiAwOwogfQogCitib29sIE1lZGlhUGxh eWVyUHJpdmF0ZTo6dG90YWxCeXRlc0tub3duKCkgY29uc3QKK3sKKyAgICAvL25vdEltcGxlbWVu dGVkKCk7CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB1bnNpZ25lZCBNZWRpYVBsYXllclByaXZh dGU6OnRvdGFsQnl0ZXMoKSBjb25zdAogewogICAgIC8vbm90SW1wbGVtZW50ZWQoKTsKSW5kZXg6 IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUGhvbm9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclBy aXZhdGVQaG9ub24uaAkocmV2aXNpb24gNTM2MjUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L01lZGlhUGxheWVyUHJpdmF0ZVBob25vbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUs NiArMTA1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBQYXNzUmVmUHRyPFRpbWVS YW5nZXM+IGJ1ZmZlcmVkKCkgY29uc3Q7CiAgICAgICAgIGZsb2F0IG1heFRpbWVTZWVrYWJsZSgp IGNvbnN0OwogICAgICAgICB1bnNpZ25lZCBieXRlc0xvYWRlZCgpIGNvbnN0OworICAgICAgICBi b29sIHRvdGFsQnl0ZXNLbm93bigpIGNvbnN0OwogICAgICAgICB1bnNpZ25lZCB0b3RhbEJ5dGVz KCkgY29uc3Q7CiAKICAgICAgICAgdm9pZCBzZXRWaXNpYmxlKGJvb2wpOwpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW5jZS9NZWRpYVBsYXllclByaXZhdGVXaW5jZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luY2UvTWVkaWFQbGF5ZXJQcml2 YXRlV2luY2UuaAkocmV2aXNpb24gNTM2MjUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3dpbmNlL01lZGlhUGxheWVyUHJpdmF0ZVdpbmNlLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDYg KzcxLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBQYXNzUmVmUHRyPFRpbWVSYW5n ZXM+IGJ1ZmZlcmVkKCkgY29uc3Q7CiAgICAgICAgIGZsb2F0IG1heFRpbWVTZWVrYWJsZSgpIGNv bnN0OwogICAgICAgICB1bnNpZ25lZCBieXRlc0xvYWRlZCgpIGNvbnN0OworICAgICAgICBib29s IHRvdGFsQnl0ZXNLbm93bigpIGNvbnN0OwogICAgICAgICB1bnNpZ25lZCB0b3RhbEJ5dGVzKCkg Y29uc3Q7CiAKICAgICAgICAgdm9pZCBzZXRWaXNpYmxlKGJvb2wpOwo=