33955 2010-01-21 08:23:09 -0800 webkit-patch should retry on invalid password 2010-01-22 16:12:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joenotcharles webkit-unassigned abarth eric oldest_to_newest 183197 0 47120 joenotcharles 2010-01-21 08:23:09 -0800 Created attachment 47120 put bugzilla login in a loop Making a typo in your password and having to restart the whole process is really annoying. webkit-patch should ask for credentials in a loop so that it automatically asks again on failure. (The user can always use Ctrl-C to break out.) 183233 1 47120 abarth 2010-01-21 10:02:04 -0800 Comment on attachment 47120 put bugzilla login in a loop In general we prefer to add unit tests when changing code in webkitpy, but bugzilla.py is difficult to test currently. Thanks for the patch. 183864 2 abarth 2010-01-22 16:12:22 -0800 Committed r53733: <http://trac.webkit.org/changeset/53733> 47120 2010-01-21 08:23:09 -0800 2010-01-21 10:02:03 -0800 put bugzilla login in a loop auth.patch text/plain 3099 joenotcharles ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMGRkNTVjLi5hMjExZmY4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDEt MjEgIEpvZSBNYXNvbiAgPGptYXNvbkByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzayBmb3IgYnVncy53ZWJraXQub3JnIGF1dGhlbnRp Y2F0aW9uIGluIGEgbG9vcC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEu cHk6CisKIDIwMTAtMDEtMTQgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9idWd6aWxsYS5weQppbmRleCBhNjY2MTNjLi5kZDZjZWVkIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHkKQEAgLTEsNSArMSw2IEBACiAjIENvcHly aWdodCAoYykgMjAwOSwgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJp Z2h0IChjKSAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0 IChjKSAyMDEwIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogIyAKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTM3OSwyMiArMzgwLDIyIEBA IGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZWQg PSBUcnVlCiAgICAgICAgICAgICByZXR1cm4KIAotICAgICAgICAodXNlcm5hbWUsIHBhc3N3b3Jk KSA9IENyZWRlbnRpYWxzKHNlbGYuYnVnX3NlcnZlcl9ob3N0LCBnaXRfcHJlZml4PSJidWd6aWxs YSIpLnJlYWRfY3JlZGVudGlhbHMoKQotCi0gICAgICAgIGxvZygiTG9nZ2luZyBpbiBhcyAlcy4u LiIgJSB1c2VybmFtZSkKLSAgICAgICAgc2VsZi5icm93c2VyLm9wZW4oc2VsZi5idWdfc2VydmVy X3VybCArICJpbmRleC5jZ2k/R29BaGVhZEFuZExvZ0luPTEiKQotICAgICAgICBzZWxmLmJyb3dz ZXIuc2VsZWN0X2Zvcm0obmFtZT0ibG9naW4iKQotICAgICAgICBzZWxmLmJyb3dzZXJbJ0J1Z3pp bGxhX2xvZ2luJ10gPSB1c2VybmFtZQotICAgICAgICBzZWxmLmJyb3dzZXJbJ0J1Z3ppbGxhX3Bh c3N3b3JkJ10gPSBwYXNzd29yZAotICAgICAgICByZXNwb25zZSA9IHNlbGYuYnJvd3Nlci5zdWJt aXQoKQotCi0gICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKCI8dGl0bGU+KC4rPyk8L3RpdGxlPiIs IHJlc3BvbnNlLnJlYWQoKSkKLSAgICAgICAgIyBJZiB0aGUgcmVzdWx0aW5nIHBhZ2UgaGFzIGEg dGl0bGUsIGFuZCBpdCBjb250YWlucyB0aGUgd29yZCAiaW52YWxpZCIgYXNzdW1lIGl0J3MgdGhl IGxvZ2luIGZhaWx1cmUgcGFnZS4KLSAgICAgICAgaWYgbWF0Y2ggYW5kIHJlLnNlYXJjaCgiSW52 YWxpZCIsIG1hdGNoLmdyb3VwKDEpLCByZS5JR05PUkVDQVNFKToKLSAgICAgICAgICAgICMgRklY TUU6IFdlIGNvdWxkIGFkZCB0aGUgYWJpbGl0eSB0byB0cnkgYWdhaW4gb24gZmFpbHVyZS4KLSAg ICAgICAgICAgIHJhaXNlIEV4Y2VwdGlvbigiQnVnemlsbGEgbG9naW4gZmFpbGVkOiAlcyIgJSBt YXRjaC5ncm91cCgxKSkKLQotICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZWQgPSBUcnVlCisgICAg ICAgIHdoaWxlIG5vdCBzZWxmLmF1dGhlbnRpY2F0ZWQ6CisgICAgICAgICAgICAodXNlcm5hbWUs IHBhc3N3b3JkKSA9IENyZWRlbnRpYWxzKHNlbGYuYnVnX3NlcnZlcl9ob3N0LCBnaXRfcHJlZml4 PSJidWd6aWxsYSIpLnJlYWRfY3JlZGVudGlhbHMoKQorCisgICAgICAgICAgICBsb2coIkxvZ2dp bmcgaW4gYXMgJXMuLi4iICUgdXNlcm5hbWUpCisgICAgICAgICAgICBzZWxmLmJyb3dzZXIub3Bl bihzZWxmLmJ1Z19zZXJ2ZXJfdXJsICsgImluZGV4LmNnaT9Hb0FoZWFkQW5kTG9nSW49MSIpCisg ICAgICAgICAgICBzZWxmLmJyb3dzZXIuc2VsZWN0X2Zvcm0obmFtZT0ibG9naW4iKQorICAgICAg ICAgICAgc2VsZi5icm93c2VyWydCdWd6aWxsYV9sb2dpbiddID0gdXNlcm5hbWUKKyAgICAgICAg ICAgIHNlbGYuYnJvd3NlclsnQnVnemlsbGFfcGFzc3dvcmQnXSA9IHBhc3N3b3JkCisgICAgICAg ICAgICByZXNwb25zZSA9IHNlbGYuYnJvd3Nlci5zdWJtaXQoKQorCisgICAgICAgICAgICBtYXRj aCA9IHJlLnNlYXJjaCgiPHRpdGxlPiguKz8pPC90aXRsZT4iLCByZXNwb25zZS5yZWFkKCkpCisg ICAgICAgICAgICAjIElmIHRoZSByZXN1bHRpbmcgcGFnZSBoYXMgYSB0aXRsZSwgYW5kIGl0IGNv bnRhaW5zIHRoZSB3b3JkICJpbnZhbGlkIiBhc3N1bWUgaXQncyB0aGUgbG9naW4gZmFpbHVyZSBw YWdlLgorICAgICAgICAgICAgaWYgbWF0Y2ggYW5kIHJlLnNlYXJjaCgiSW52YWxpZCIsIG1hdGNo Lmdyb3VwKDEpLCByZS5JR05PUkVDQVNFKToKKyAgICAgICAgICAgICAgICBsb2coIkJ1Z3ppbGxh IGxvZ2luIGZhaWxlZDogJXMiICUgbWF0Y2guZ3JvdXAoMSkpCisgICAgICAgICAgICBlbHNlOgor ICAgICAgICAgICAgICAgIHNlbGYuYXV0aGVudGljYXRlZCA9IFRydWUKIAogICAgIGRlZiBfZmls bF9hdHRhY2htZW50X2Zvcm0oc2VsZiwgZGVzY3JpcHRpb24sIHBhdGNoX2ZpbGVfb2JqZWN0LCBj b21tZW50X3RleHQ9Tm9uZSwgbWFya19mb3JfcmV2aWV3PUZhbHNlLCBtYXJrX2Zvcl9jb21taXRf cXVldWU9RmFsc2UsIGJ1Z19pZD1Ob25lKToKICAgICAgICAgc2VsZi5icm93c2VyWydkZXNjcmlw dGlvbiddID0gZGVzY3JpcHRpb24K