33953 2010-01-21 08:15:37 -0800 [Android] Android lacks V8 equivalent of JavaStringJSC.h 2010-02-01 02:52:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 32154 1 steveblock webkit-unassigned android-webkit-unforking steveblock oldest_to_newest 183192 0 steveblock 2010-01-21 08:15:37 -0800 The JSC-specific implementation of JavaString was moved to JavaStringJSC.h in http://trac.webkit.org/changeset/53449 Android requires a V8 implementation of JavaString 185803 1 47698 steveblock 2010-01-29 03:35:54 -0800 Created attachment 47698 Patch 186256 2 47698 ariya.hidayat 2010-01-31 15:57:06 -0800 Comment on attachment 47698 Patch > + const char* cs = getCharactersFromJStringInEnv(e, s); > + { > + m_utf8String = WebCore::CString(cs, size); > + } Minor nitpick: since we don't need JSLock here, do we need to put that line in its own block? Otherwise, LGTM. 186344 3 steveblock 2010-02-01 02:52:10 -0800 > Minor nitpick: since we don't need JSLock here, do we need to put that line in > its own block? Fixed Landed manually as http://trac.webkit.org/changeset/54132 Closing bug as resolved fixed. 47698 2010-01-29 03:35:54 -0800 2010-01-31 15:57:06 -0800 Patch bug-33953-20100129113552.patch text/plain 3719 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDA1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDEtMjkgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgaW1wbGVtZW50YXRpb24gb2YgSmF2YVN0cmluZyBmb3IgVjguCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk1MworCisgICAgICAgIE5vIG5l dyB0ZXN0cywgYnVpbGQgZml4IG9ubHkuCisKKyAgICAgICAgKiBicmlkZ2Uvam5pL0pOSUJyaWRn ZS5oOiBNb2RpZmllZC4gSW5jbHVkZSBKYXZhU3RyaW5nVjguaCBmb3IgVjgKKyAgICAgICAgKiBi cmlkZ2Uvam5pL3Y4OiBBZGRlZC4KKyAgICAgICAgKiBicmlkZ2Uvam5pL3Y4L0phdmFTdHJpbmdW OC5oOiBBZGRlZC4KKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OkphdmFTdHJpbmdJbXBsOjppbml0 KToKKyAgICAgICAgKEpTQzo6QmluZGluZ3M6OkphdmFTdHJpbmdJbXBsOjpVVEY4U3RyaW5nKToK KyAgICAgICAgKEpTQzo6QmluZGluZ3M6OkphdmFTdHJpbmdJbXBsOjp1Y2hhcnMpOgorICAgICAg ICAoSlNDOjpCaW5kaW5nczo6SmF2YVN0cmluZ0ltcGw6Omxlbmd0aCk6CisKIDIwMTAtMDEtMjkg IFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9icmlkZ2Uvam5pL0pOSUJyaWRn ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJpZGdlL2puaS9KTklCcmlkZ2UuaAkocmV2aXNp b24gNTQwNTIpCisrKyBXZWJDb3JlL2JyaWRnZS9qbmkvSk5JQnJpZGdlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTI5LDEwICsyOSwxMyBAQAogCiAjaWYgRU5BQkxFKE1BQ19KQVZBX0JSSURHRSkKIAor I2luY2x1ZGUgIkJyaWRnZS5oIgogI2luY2x1ZGUgIkpOSVV0aWxpdHkuaCIKIAogI2lmIFVTRShK U0MpCiAjaW5jbHVkZSAiSmF2YVN0cmluZ0pTQy5oIgorI2VsaWYgVVNFKFY4KQorI2luY2x1ZGUg IkphdmFTdHJpbmdWOC5oIgogI2VuZGlmCiAKIG5hbWVzcGFjZSBKU0MgewpJbmRleDogV2ViQ29y ZS9icmlkZ2Uvam5pL3Y4L0phdmFTdHJpbmdWOC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJp ZGdlL2puaS92OC9KYXZhU3RyaW5nVjguaAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvYnJpZGdl L2puaS92OC9KYXZhU3RyaW5nVjguaAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2MyBAQAorLyoK KyAqIENvcHlyaWdodCAyMDEwLCBUaGUgQW5kcm9pZCBPcGVuIFNvdXJjZSBQcm9qZWN0CisgKgor ICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhh dCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICog ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyLgorICogICogUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9k dWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50 YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRp b24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhP TERFUlMgYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVT LCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBV UlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIE9X TkVSIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVD VCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBE QU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICog UFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04g QU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1Qg TElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNF KSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUs IEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8K KworI2lmbmRlZiBKYXZhU3RyaW5nVjhfaAorI2RlZmluZSBKYXZhU3RyaW5nVjhfaAorCisjaW5j bHVkZSAiQ1N0cmluZy5oIgorI2luY2x1ZGUgIkpOSVV0aWxpdHkuaCIKKworCituYW1lc3BhY2Ug SlNDIHsKKworbmFtZXNwYWNlIEJpbmRpbmdzIHsKKworY2xhc3MgSmF2YVN0cmluZ0ltcGwgewor cHVibGljOgorICAgIHZvaWQgaW5pdCgpIHt9CisKKyAgICB2b2lkIGluaXQoSk5JRW52KiBlLCBq c3RyaW5nIHMpCisgICAgeworICAgICAgICBpbnQgc2l6ZSA9IGUtPkdldFN0cmluZ0xlbmd0aChz KTsKKyAgICAgICAgY29uc3QgY2hhciogY3MgPSBnZXRDaGFyYWN0ZXJzRnJvbUpTdHJpbmdJbkVu dihlLCBzKTsKKyAgICAgICAgeworICAgICAgICAgICAgbV91dGY4U3RyaW5nID0gV2ViQ29yZTo6 Q1N0cmluZyhjcywgc2l6ZSk7CisgICAgICAgIH0KKyAgICAgICAgcmVsZWFzZUNoYXJhY3RlcnNG b3JKU3RyaW5nSW5FbnYoZSwgcywgY3MpOworICAgIH0KKworICAgIGNvbnN0IGNoYXIqIFVURjhT dHJpbmcoKSBjb25zdCB7IHJldHVybiBtX3V0ZjhTdHJpbmcuZGF0YSgpOyB9CisgICAgY29uc3Qg amNoYXIqIHVjaGFycygpIGNvbnN0IHsgcmV0dXJuIDA7IH0gLy8gTm90IGltcGxlbWVudGVkCisg ICAgaW50IGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIG1fdXRmOFN0cmluZy5sZW5ndGgoKTsgfQor Citwcml2YXRlOgorICAgIFdlYkNvcmU6OkNTdHJpbmcgbV91dGY4U3RyaW5nOworfTsKKworfSAv LyBuYW1lc3BhY2UgQmluZGluZ3MKKworfSAvLyBuYW1lc3BhY2UgSlNDCisKKyNlbmRpZiAvLyBK YXZhU3RyaW5nVjhfaAo=