33952 2010-01-21 07:46:05 -0800 build failure on RVCT 2010-01-21 21:23:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 joenotcharles webkit-unassigned commit-queue darin hausmann webkit.review.bot oldest_to_newest 183190 0 joenotcharles 2010-01-21 07:46:05 -0800 RVCT 4.0 fails to compile in FEComponentTransfer.cpp - "ambiguous overload in function pow" (provided args are (int,float), possible overloads include (int,int), (float,float) and (double,double). This patch casts the args to double to match the return value. 183191 1 47118 joenotcharles 2010-01-21 08:09:52 -0800 Created attachment 47118 build fix 183261 2 47118 darin 2010-01-21 11:40:29 -0800 Comment on attachment 47118 build fix I'm unclear on what's ambiguous here and why RVCT is complaining. Where's the ambiguity? In C++, the expression i / 255.0 is unambiguously a double, so I can't see how adding a cast to that expression is helpful. Further, pow(double, int) also does not seem ambiguous. > - double val = 255.0 * (transferFunction.amplitude * pow((i / 255.0), transferFunction.exponent) + transferFunction.offset); > + double val = 255.0 * (transferFunction.amplitude * pow((static_cast<double>(i) / 255.0), static_cast<double>(transferFunction.exponent)) + transferFunction.offset); The change is OK. It's better to keep casts to a minimum if possible, so an approach that used local variables instead might be cleaner. I'm going to say review+ because there's not a lot of downside here, but I think this is probably not a great change given a lack of understanding of what's ambiguous combined with the relatively ugly solution. 183262 3 darin 2010-01-21 11:41:40 -0800 I really don't see anything passing int, float here. Maybe double, float. Seems like yet another RVCT compiler bug. Is there any better way to support this flawed compiler? 183264 4 joenotcharles 2010-01-21 11:46:03 -0800 You're right, it's double,float, so only the second cast is needed. I'll update the patch. 183269 5 47134 joenotcharles 2010-01-21 11:55:17 -0800 Created attachment 47134 updated patch 183270 6 webkit.review.bot 2010-01-21 12:02:38 -0800 Attachment 47134 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/filters/FEComponentTransfer.cpp:144: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 183274 7 47136 joenotcharles 2010-01-21 12:12:20 -0800 Created attachment 47136 style fix Grr. Knew I forgot something. 183314 8 47136 darin 2010-01-21 14:11:59 -0800 Comment on attachment 47136 style fix > + Copyright (C) Research In Motion Limited 2010. All rights reserved. I think there is a guideline about how big a chance is sufficient to assert copyright. This is probably small enough that it's not sufficient. Change looks great. r=me 183471 9 47136 commit-queue 2010-01-21 21:23:18 -0800 Comment on attachment 47136 style fix Clearing flags on attachment: 47136 Committed r53674: <http://trac.webkit.org/changeset/53674> 183472 10 commit-queue 2010-01-21 21:23:23 -0800 All reviewed patches have been landed. Closing bug. 47118 2010-01-21 08:09:52 -0800 2010-01-21 11:55:17 -0800 build fix build-fix.patch text/plain 1492 joenotcharles ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cNCmluZGV4 IDdiZmM3ZTYuLmFiZmM3ZjAgMTAwNjQ0DQotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZw0KKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTMgQEANCisyMDEwLTAxLTIxICBKb2UgTWFz b24gIDxqbWFzb25AcmltLmNvbT4NCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLg0KKw0KKyAgICAgICAgQ2FzdCBwb3cgYXJndW1lbnRzIHRvIGRvdWJsZSB0byByZXNvbHZl IGFtYmlndW91cyBvdmVybG9hZCAoY29tcGlsZSBmaXgNCisgICAgICAgIGZvciBSQ1ZUIDQuMCku DQorDQorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFu c2Zlci5jcHA6DQorICAgICAgICAoV2ViQ29yZTo6Z2FtbWEpOg0KKw0KIDIwMTAtMDEtMTUgIE5h dGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4NCiANCiAgICAgICAgIFJldmlld2VkIGJ5 IERpbWl0cmkgR2xhemtvdi4NCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2ZpbHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHANCmluZGV4IDFkOWNmZmYuLjc4MTRh YmEgMTAwNjQ0DQotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVDb21w b25lbnRUcmFuc2Zlci5jcHANCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVy cy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcA0KQEAgLTE0MCw3ICsxNDAsNyBAQCBzdGF0aWMgdm9p ZCBsaW5lYXIodW5zaWduZWQgY2hhciogdmFsdWVzLCBjb25zdCBDb21wb25lbnRUcmFuc2ZlckZ1 bmN0aW9uJiB0cmFucw0KIHN0YXRpYyB2b2lkIGdhbW1hKHVuc2lnbmVkIGNoYXIqIHZhbHVlcywg Y29uc3QgQ29tcG9uZW50VHJhbnNmZXJGdW5jdGlvbiYgdHJhbnNmZXJGdW5jdGlvbikNCiB7DQog ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCAyNTY7ICsraSkgew0KLSAgICAgICAgZG91Ymxl IHZhbCA9IDI1NS4wICogKHRyYW5zZmVyRnVuY3Rpb24uYW1wbGl0dWRlICogcG93KChpIC8gMjU1 LjApLCB0cmFuc2ZlckZ1bmN0aW9uLmV4cG9uZW50KSArIHRyYW5zZmVyRnVuY3Rpb24ub2Zmc2V0 KTsNCisgICAgICAgIGRvdWJsZSB2YWwgPSAyNTUuMCAqICh0cmFuc2ZlckZ1bmN0aW9uLmFtcGxp dHVkZSAqIHBvdygoc3RhdGljX2Nhc3Q8ZG91YmxlPihpKSAvIDI1NS4wKSwgc3RhdGljX2Nhc3Q8 ZG91YmxlPih0cmFuc2ZlckZ1bmN0aW9uLmV4cG9uZW50KSkgKyB0cmFuc2ZlckZ1bmN0aW9uLm9m ZnNldCk7DQogICAgICAgICB2YWwgPSBzdGQ6Om1heCgwLjAsIHN0ZDo6bWluKDI1NS4wLCB2YWwp KTsNCiAgICAgICAgIHZhbHVlc1tpXSA9IHN0YXRpY19jYXN0PHVuc2lnbmVkIGNoYXI+KHZhbCk7 DQogICAgIH0NCg== 47134 2010-01-21 11:55:17 -0800 2010-01-21 12:12:20 -0800 updated patch build2.patch text/plain 1954 joenotcharles ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Njc1Y2Q5MS4uMWI0MTg5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0yMSAgSm9lIE1hc29uICA8 am1hc29uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUHJvbW90ZSBwb3cgYXJndW1lbnQgdG8gZG91YmxlIHRvIHJlc29sdmUgYW1iaWd1 b3VzIG92ZXJsb2FkIChjb21waWxlIGZpeCBmb3IgUlZDVCA0LjApCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk1MgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmdhbW1hKToKKwogMjAxMC0wMS0wNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCmluZGV4IDFkOWNmZmYu LmVhZjE4ZTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9G RUNvbXBvbmVudFRyYW5zZmVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAKQEAgLTMsNiArMyw3IEBACiAgICAgICAgICAg ICAgICAgICAyMDA0LCAyMDA1IFJvYiBCdWlzIDxidWlzQGtkZS5vcmc+CiAgICAgICAgICAgICAg ICAgICAyMDA1IEVyaWMgU2VpZGVsIDxlcmljQHdlYmtpdC5vcmc+CiAgICAgICAgICAgICAgICAg ICAyMDA5IERpcmsgU2NodWx6ZSA8a3JpdEB3ZWJraXQub3JnPgorICAgIENvcHlyaWdodCAoQykg UmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAxMC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KIAog ICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtMTQwLDcgKzE0MSw4IEBAIHN0YXRpYyB2b2lkIGxpbmVhcih1 bnNpZ25lZCBjaGFyKiB2YWx1ZXMsIGNvbnN0IENvbXBvbmVudFRyYW5zZmVyRnVuY3Rpb24mIHRy YW5zCiBzdGF0aWMgdm9pZCBnYW1tYSh1bnNpZ25lZCBjaGFyKiB2YWx1ZXMsIGNvbnN0IENvbXBv bmVudFRyYW5zZmVyRnVuY3Rpb24mIHRyYW5zZmVyRnVuY3Rpb24pCiB7CiAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IDI1NjsgKytpKSB7Ci0gICAgICAgIGRvdWJsZSB2YWwgPSAyNTUuMCAq ICh0cmFuc2ZlckZ1bmN0aW9uLmFtcGxpdHVkZSAqIHBvdygoaSAvIDI1NS4wKSwgdHJhbnNmZXJG dW5jdGlvbi5leHBvbmVudCkgKyB0cmFuc2ZlckZ1bmN0aW9uLm9mZnNldCk7CisgICAgICAgIGRv dWJsZSBleHBvbmVudCA9IHRyYW5zZmVyRnVuY3Rpb24uZXhwb25lbnQ7ICAgIC8vIFJDVlQgZG9l c24ndCBsaWtlIHBhc3NpbmcgYSBkb3VibGUgYW5kIGEgZmxvYXQgdG8gcG93LCBzbyBwcm9tb3Rl IHRoaXMgdG8gZG91YmxlCisgICAgICAgIGRvdWJsZSB2YWwgPSAyNTUuMCAqICh0cmFuc2ZlckZ1 bmN0aW9uLmFtcGxpdHVkZSAqIHBvdygoaSAvIDI1NS4wKSwgZXhwb25lbnQpICsgdHJhbnNmZXJG dW5jdGlvbi5vZmZzZXQpOwogICAgICAgICB2YWwgPSBzdGQ6Om1heCgwLjAsIHN0ZDo6bWluKDI1 NS4wLCB2YWwpKTsKICAgICAgICAgdmFsdWVzW2ldID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hh cj4odmFsKTsKICAgICB9Cg== 47136 2010-01-21 12:12:20 -0800 2010-01-21 21:23:17 -0800 style fix build3.patch text/plain 1951 joenotcharles ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Njc1Y2Q5MS4uMWI0MTg5YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0yMSAgSm9lIE1hc29uICA8 am1hc29uQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUHJvbW90ZSBwb3cgYXJndW1lbnQgdG8gZG91YmxlIHRvIHJlc29sdmUgYW1iaWd1 b3VzIG92ZXJsb2FkIChjb21waWxlIGZpeCBmb3IgUlZDVCA0LjApCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk1MgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9GRUNvbXBvbmVudFRyYW5zZmVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmdhbW1hKToKKwogMjAxMC0wMS0wNyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0ZFQ29tcG9uZW50VHJhbnNmZXIuY3BwCmluZGV4IDFkOWNmZmYu LmY5YWEwMTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9G RUNvbXBvbmVudFRyYW5zZmVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Zp bHRlcnMvRkVDb21wb25lbnRUcmFuc2Zlci5jcHAKQEAgLTMsNiArMyw3IEBACiAgICAgICAgICAg ICAgICAgICAyMDA0LCAyMDA1IFJvYiBCdWlzIDxidWlzQGtkZS5vcmc+CiAgICAgICAgICAgICAg ICAgICAyMDA1IEVyaWMgU2VpZGVsIDxlcmljQHdlYmtpdC5vcmc+CiAgICAgICAgICAgICAgICAg ICAyMDA5IERpcmsgU2NodWx6ZSA8a3JpdEB3ZWJraXQub3JnPgorICAgIENvcHlyaWdodCAoQykg UmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAxMC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KIAog ICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtMTQwLDcgKzE0MSw4IEBAIHN0YXRpYyB2b2lkIGxpbmVhcih1 bnNpZ25lZCBjaGFyKiB2YWx1ZXMsIGNvbnN0IENvbXBvbmVudFRyYW5zZmVyRnVuY3Rpb24mIHRy YW5zCiBzdGF0aWMgdm9pZCBnYW1tYSh1bnNpZ25lZCBjaGFyKiB2YWx1ZXMsIGNvbnN0IENvbXBv bmVudFRyYW5zZmVyRnVuY3Rpb24mIHRyYW5zZmVyRnVuY3Rpb24pCiB7CiAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IDI1NjsgKytpKSB7Ci0gICAgICAgIGRvdWJsZSB2YWwgPSAyNTUuMCAq ICh0cmFuc2ZlckZ1bmN0aW9uLmFtcGxpdHVkZSAqIHBvdygoaSAvIDI1NS4wKSwgdHJhbnNmZXJG dW5jdGlvbi5leHBvbmVudCkgKyB0cmFuc2ZlckZ1bmN0aW9uLm9mZnNldCk7CisgICAgICAgIGRv dWJsZSBleHBvbmVudCA9IHRyYW5zZmVyRnVuY3Rpb24uZXhwb25lbnQ7IC8vIFJDVlQgZG9lc24n dCBsaWtlIHBhc3NpbmcgYSBkb3VibGUgYW5kIGEgZmxvYXQgdG8gcG93LCBzbyBwcm9tb3RlIHRo aXMgdG8gZG91YmxlCisgICAgICAgIGRvdWJsZSB2YWwgPSAyNTUuMCAqICh0cmFuc2ZlckZ1bmN0 aW9uLmFtcGxpdHVkZSAqIHBvdygoaSAvIDI1NS4wKSwgZXhwb25lbnQpICsgdHJhbnNmZXJGdW5j dGlvbi5vZmZzZXQpOwogICAgICAgICB2YWwgPSBzdGQ6Om1heCgwLjAsIHN0ZDo6bWluKDI1NS4w LCB2YWwpKTsKICAgICAgICAgdmFsdWVzW2ldID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhcj4o dmFsKTsKICAgICB9Cg==