33946 2010-01-21 06:22:19 -0800 Object.getOwnPropertyDescriptor always returns undefined for JS API objects 2010-01-21 12:46:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 33947 1 kent.hansen kent.hansen commit-queue oldest_to_newest 183180 0 kent.hansen 2010-01-21 06:22:19 -0800 When Object.getOwnPropertyDescriptor is passed an object that was created using the C API JSObjectMake() function, it doesn't return a valid property descriptor, even if the property is defined in the JSClass. 183206 1 47125 kent.hansen 2010-01-21 08:38:37 -0800 Created attachment 47125 Proposed patch Implements the approach suggested by Geoffrey in https://bugs.webkit.org/show_bug.cgi?id=33603#c11. Descriptors always have enumerable=false, even though that might not be true. It's no worse than before, since Object.prototype.propertyIsEnumerable would also return false (since it calls getOwnPropertyDescriptor(), which wasn't implemented). Like I mention in a comment, it can be made more consistent by calling getPropertyNames and checking if the name is in the result, but I've opted not to add that overhead unless it's requested. In a full-blown solution (using access descriptors), the implementation would extract the attributes from the JSStaticValues/JSStaticFunctions if possible, but it doesn't look like the functionality can be completely supported without introducing a new callback in JSClassDefinition (i.e., to get attributes of non-static properties). 183223 2 47125 ggaren 2010-01-21 09:44:40 -0800 Comment on attachment 47125 Proposed patch Nice. r=me 183286 3 47125 commit-queue 2010-01-21 12:46:09 -0800 Comment on attachment 47125 Proposed patch Clearing flags on attachment: 47125 Committed r53638: <http://trac.webkit.org/changeset/53638> 183287 4 commit-queue 2010-01-21 12:46:13 -0800 All reviewed patches have been landed. Closing bug. 47125 2010-01-21 08:38:37 -0800 2010-01-21 12:46:08 -0800 Proposed patch getOwnPropertyDescriptorCallbackObject.diff text/plain 6588 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NhbGxiYWNrT2JqZWN0LmggYi9KYXZh U2NyaXB0Q29yZS9BUEkvSlNDYWxsYmFja09iamVjdC5oCmluZGV4IGUxM2RiZDIuLjJlMjU5OTEg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NhbGxiYWNrT2JqZWN0LmgKKysrIGIv SmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaApAQCAtNjEsNiArNjEsNyBAQCBw cml2YXRlOgogCiAgICAgdmlydHVhbCBib29sIGdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUq LCBjb25zdCBJZGVudGlmaWVyJiwgUHJvcGVydHlTbG90Jik7CiAgICAgdmlydHVhbCBib29sIGdl dE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqLCB1bnNpZ25lZCwgUHJvcGVydHlTbG90Jik7Cisg ICAgdmlydHVhbCBib29sIGdldE93blByb3BlcnR5RGVzY3JpcHRvcihFeGVjU3RhdGUqLCBjb25z dCBJZGVudGlmaWVyJiwgUHJvcGVydHlEZXNjcmlwdG9yJik7CiAgICAgCiAgICAgdmlydHVhbCB2 b2lkIHB1dChFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgSlNWYWx1ZSwgUHV0UHJvcGVy dHlTbG90Jik7CiAKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NhbGxiYWNrT2Jq ZWN0RnVuY3Rpb25zLmggYi9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDYWxsYmFja09iamVjdEZ1bmN0 aW9ucy5oCmluZGV4IDQwMDBmNjMuLjRiMjhhOTkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L0FQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvQVBJ L0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaApAQCAtMTY4LDYgKzE2OCwyNSBAQCBib29sIEpT Q2FsbGJhY2tPYmplY3Q8QmFzZT46OmdldE93blByb3BlcnR5U2xvdChFeGVjU3RhdGUqIGV4ZWMs IHVuc2lnbmVkIHByb3BlcgogfQogCiB0ZW1wbGF0ZSA8Y2xhc3MgQmFzZT4KK2Jvb2wgSlNDYWxs YmFja09iamVjdDxCYXNlPjo6Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKEV4ZWNTdGF0ZSogZXhl YywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eURlc2NyaXB0b3ImIGRl c2NyaXB0b3IpCit7CisgICAgUHJvcGVydHlTbG90IHNsb3Q7CisgICAgaWYgKGdldE93blByb3Bl cnR5U2xvdChleGVjLCBwcm9wZXJ0eU5hbWUsIHNsb3QpKSB7CisgICAgICAgIC8vIElkZWFsbHkg d2Ugc2hvdWxkIHJldHVybiBhbiBhY2Nlc3MgZGVzY3JpcHRvciwgYnV0IHJldHVybmluZyBhIHZh bHVlIGRlc2NyaXB0b3IgaXMgYmV0dGVyIHRoYW4gbm90aGluZy4KKyAgICAgICAgSlNWYWx1ZSB2 YWx1ZSA9IHNsb3QuZ2V0VmFsdWUoZXhlYywgcHJvcGVydHlOYW1lKTsKKyAgICAgICAgaWYgKCFl eGVjLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgICAgIGRlc2NyaXB0b3Iuc2V0VmFsdWUodmFs dWUpOworICAgICAgICAvLyBXZSBkb24ndCBrbm93IHdoZXRoZXIgdGhlIHByb3BlcnR5IGlzIGNv bmZpZ3VyYWJsZSwgYnV0IGFzc3VtZSBpdCBpcy4KKyAgICAgICAgZGVzY3JpcHRvci5zZXRDb25m aWd1cmFibGUodHJ1ZSk7CisgICAgICAgIC8vIFdlIGRvbid0IGtub3cgd2hldGhlciB0aGUgcHJv cGVydHkgaXMgZW51bWVyYWJsZSAod2UgY291bGQgY2FsbCBnZXRPd25Qcm9wZXJ0eU5hbWVzKCkg dG8gZmluZCBvdXQpLCBidXQgYXNzdW1lIGl0IGlzbid0LgorICAgICAgICBkZXNjcmlwdG9yLnNl dEVudW1lcmFibGUoZmFsc2UpOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAgICBy ZXR1cm4gQmFzZTo6Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGV4ZWMsIHByb3BlcnR5TmFtZSwg ZGVzY3JpcHRvcik7Cit9CisKK3RlbXBsYXRlIDxjbGFzcyBCYXNlPgogdm9pZCBKU0NhbGxiYWNr T2JqZWN0PEJhc2U+OjpwdXQoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9w ZXJ0eU5hbWUsIEpTVmFsdWUgdmFsdWUsIFB1dFByb3BlcnR5U2xvdCYgc2xvdCkKIHsKICAgICBK U0NvbnRleHRSZWYgY3R4ID0gdG9SZWYoZXhlYyk7CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29y ZS9BUEkvdGVzdHMvdGVzdGFwaS5qcyBiL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBp LmpzCmluZGV4IDgyNzU2YjUuLjIwZmE4NmIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0FQ SS90ZXN0cy90ZXN0YXBpLmpzCisrKyBiL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBp LmpzCkBAIC0xMTMsNiArMTEzLDM1IEBAIGlmIChmb3VuZFJlZ3VsYXJUeXBlKQogZWxzZQogICAg IGZhaWwoIk15T2JqZWN0LnJlZ3VsYXJUeXBlIHdhcyBub3QgZW51bWVyYXRlZCIpOwogCit2YXIg YWx3YXlzT25lRGVzY3JpcHRvciA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoTXlP YmplY3QsICJhbHdheXNPbmUiKTsKK3Nob3VsZEJlKCd0eXBlb2YgYWx3YXlzT25lRGVzY3JpcHRv cicsICJvYmplY3QiKTsKK3Nob3VsZEJlKCdhbHdheXNPbmVEZXNjcmlwdG9yLnZhbHVlJywgTXlP YmplY3QuYWx3YXlzT25lKTsKK3Nob3VsZEJlKCdhbHdheXNPbmVEZXNjcmlwdG9yLmNvbmZpZ3Vy YWJsZScsIHRydWUpOworc2hvdWxkQmUoJ2Fsd2F5c09uZURlc2NyaXB0b3IuZW51bWVyYWJsZScs IGZhbHNlKTsgLy8gQWN0dWFsbHkgaXQgaXMuCit2YXIgY2FudEZpbmREZXNjcmlwdG9yID0gT2Jq ZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihNeU9iamVjdCwgImNhbnRGaW5kIik7CitzaG91 bGRCZSgndHlwZW9mIGNhbnRGaW5kRGVzY3JpcHRvcicsICJvYmplY3QiKTsKK3Nob3VsZEJlKCdj YW50RmluZERlc2NyaXB0b3IudmFsdWUnLCBNeU9iamVjdC5jYW50RmluZCk7CitzaG91bGRCZSgn Y2FudEZpbmREZXNjcmlwdG9yLmNvbmZpZ3VyYWJsZScsIHRydWUpOworc2hvdWxkQmUoJ2NhbnRG aW5kRGVzY3JpcHRvci5lbnVtZXJhYmxlJywgZmFsc2UpOwordHJ5IHsKKyAgICAvLyBJZiBnZXRP d25Qcm9wZXJ0eURlc2NyaXB0b3IoKSByZXR1cm5lZCBhbiBhY2Nlc3MgZGVzY3JpcHRvciwgdGhp cyB3b3VsZG4ndCB0aHJvdy4KKyAgICBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKE15 T2JqZWN0LCAidGhyb3dPbkdldCIpOworfSBjYXRjaCAoZSkgeworICAgIHBhc3MoImdldHRpbmcg cHJvcGVydHkgZGVzY3JpcHRvciBvZiB0aHJvd09uR2V0IHRocmV3IGV4Y2VwdGlvbiIpOworfQor dmFyIG15UHJvcGVydHlOYW1lRGVzY3JpcHRvciA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2Ny aXB0b3IoTXlPYmplY3QsICJteVByb3BlcnR5TmFtZSIpOworc2hvdWxkQmUoJ3R5cGVvZiBteVBy b3BlcnR5TmFtZURlc2NyaXB0b3InLCAib2JqZWN0Iik7CitzaG91bGRCZSgnbXlQcm9wZXJ0eU5h bWVEZXNjcmlwdG9yLnZhbHVlJywgTXlPYmplY3QubXlQcm9wZXJ0eU5hbWUpOworc2hvdWxkQmUo J215UHJvcGVydHlOYW1lRGVzY3JpcHRvci5jb25maWd1cmFibGUnLCB0cnVlKTsKK3Nob3VsZEJl KCdteVByb3BlcnR5TmFtZURlc2NyaXB0b3IuZW51bWVyYWJsZScsIGZhbHNlKTsgLy8gQWN0dWFs bHkgaXQgaXMuCit0cnkgeworICAgIC8vIGlmIGdldE93blByb3BlcnR5RGVzY3JpcHRvcigpIHJl dHVybmVkIGFuIGFjY2VzcyBkZXNjcmlwdG9yLCB0aGlzIHdvdWxkbid0IHRocm93LgorICAgIE9i amVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoTXlPYmplY3QsICJoYXNQcm9wZXJ0eUxpZSIp OworfSBjYXRjaCAoZSkgeworICAgIHBhc3MoImdldHRpbmcgcHJvcGVydHkgZGVzY3JpcHRvciBv ZiBoYXNQcm9wZXJ0eUxpZSB0aHJldyBleGNlcHRpb24iKTsKK30KK3Nob3VsZEJlKCdPYmplY3Qu Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKE15T2JqZWN0LCAiZG9lc05vdEV4aXN0IiknLCB1bmRl ZmluZWQpOworCiBteU9iamVjdCA9IG5ldyBNeU9iamVjdCgpOwogCiBzaG91bGRCZSgiZGVsZXRl IE15T2JqZWN0LnJlZ3VsYXJUeXBlIiwgdHJ1ZSk7CkBAIC0xNTUsNiArMTg0LDMwIEBAIHNob3Vs ZEJlKCJkZXJpdmVkLmJhc2VPbmx5ID0gMCIsIDEpOwogc2hvdWxkQmUoImRlcml2ZWQuZGVyaXZl ZE9ubHkgPSAwIiwgMikKIHNob3VsZEJlKCJkZXJpdmVkLnByb3RvRHVwID0gMCIsIDIpOwogCitz aG91bGRCZSgnT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihkZXJpdmVkLCAiYmFzZVBy b3RvIiknLCB1bmRlZmluZWQpOworc2hvdWxkQmUoJ09iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2Ny aXB0b3IoZGVyaXZlZCwgImJhc2VQcm90b0R1cCIpJywgdW5kZWZpbmVkKTsKK3ZhciBiYXNlRHVw RGVzY3JpcHRvciA9IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoZGVyaXZlZCwgImJh c2VEdXAiKTsKK3Nob3VsZEJlKCd0eXBlb2YgYmFzZUR1cERlc2NyaXB0b3InLCAib2JqZWN0Iik7 CitzaG91bGRCZSgnYmFzZUR1cERlc2NyaXB0b3IudmFsdWUnLCBkZXJpdmVkLmJhc2VEdXApOwor c2hvdWxkQmUoJ2Jhc2VEdXBEZXNjcmlwdG9yLmNvbmZpZ3VyYWJsZScsIHRydWUpOworc2hvdWxk QmUoJ2Jhc2VEdXBEZXNjcmlwdG9yLmVudW1lcmFibGUnLCBmYWxzZSk7Cit2YXIgYmFzZU9ubHlE ZXNjcmlwdG9yID0gT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcihkZXJpdmVkLCAiYmFz ZU9ubHkiKTsKK3Nob3VsZEJlKCd0eXBlb2YgYmFzZU9ubHlEZXNjcmlwdG9yJywgIm9iamVjdCIp Oworc2hvdWxkQmUoJ2Jhc2VPbmx5RGVzY3JpcHRvci52YWx1ZScsIGRlcml2ZWQuYmFzZU9ubHkp Oworc2hvdWxkQmUoJ2Jhc2VPbmx5RGVzY3JpcHRvci5jb25maWd1cmFibGUnLCB0cnVlKTsKK3No b3VsZEJlKCdiYXNlT25seURlc2NyaXB0b3IuZW51bWVyYWJsZScsIGZhbHNlKTsKK3Nob3VsZEJl KCdPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKGRlcml2ZWQsICJwcm90b09ubHkiKScs IHVuZGVmaW5lZCk7Cit2YXIgcHJvdG9EdXBEZXNjcmlwdG9yID0gT2JqZWN0LmdldE93blByb3Bl cnR5RGVzY3JpcHRvcihkZXJpdmVkLCAicHJvdG9EdXAiKTsKK3Nob3VsZEJlKCd0eXBlb2YgcHJv dG9EdXBEZXNjcmlwdG9yJywgIm9iamVjdCIpOworc2hvdWxkQmUoJ3Byb3RvRHVwRGVzY3JpcHRv ci52YWx1ZScsIGRlcml2ZWQucHJvdG9EdXApOworc2hvdWxkQmUoJ3Byb3RvRHVwRGVzY3JpcHRv ci5jb25maWd1cmFibGUnLCB0cnVlKTsKK3Nob3VsZEJlKCdwcm90b0R1cERlc2NyaXB0b3IuZW51 bWVyYWJsZScsIGZhbHNlKTsKK3ZhciBkZXJpdmVkT25seURlc2NyaXB0b3IgPSBPYmplY3QuZ2V0 T3duUHJvcGVydHlEZXNjcmlwdG9yKGRlcml2ZWQsICJkZXJpdmVkT25seSIpOworc2hvdWxkQmUo J3R5cGVvZiBkZXJpdmVkT25seURlc2NyaXB0b3InLCAib2JqZWN0Iik7CitzaG91bGRCZSgnZGVy aXZlZE9ubHlEZXNjcmlwdG9yLnZhbHVlJywgZGVyaXZlZC5kZXJpdmVkT25seSk7CitzaG91bGRC ZSgnZGVyaXZlZE9ubHlEZXNjcmlwdG9yLmNvbmZpZ3VyYWJsZScsIHRydWUpOworc2hvdWxkQmUo J2Rlcml2ZWRPbmx5RGVzY3JpcHRvci5lbnVtZXJhYmxlJywgZmFsc2UpOworCiBzaG91bGRCZSgi dW5kZWZpbmVkIGluc3RhbmNlb2YgTXlPYmplY3QiLCBmYWxzZSk7CiBFdmlsRXhjZXB0aW9uT2Jq ZWN0Lmhhc0luc3RhbmNlID0gZnVuY3Rpb24gZigpIHsgcmV0dXJuIGYoKTsgfTsKIEV2aWxFeGNl cHRpb25PYmplY3QuX19wcm90b19fID0gdW5kZWZpbmVkOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNhM2UwODMu LjVhNzExMWEgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMS0yMSAgS2VudCBI YW5zZW4gIDxrZW50LmhhbnNlbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvciBh bHdheXMgcmV0dXJucyB1bmRlZmluZWQgZm9yIEpTIEFQSSBvYmplY3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzk0NgorCisgICAgICAgIElkZWFs bHkgdGhlIGdldE93blByb3BlcnR5RGVzY3JpcHRvcigpIHJlaW1wbGVtZW50YXRpb24gc2hvdWxk IHJldHVybiBhbgorICAgICAgICBhY2Nlc3MgZGVzY3JpcHRvciB0aGF0IHdyYXBzIHRoZSBwcm9w ZXJ0eSBnZXR0ZXIgYW5kIHNldHRlciBjYWxsYmFja3MsIGJ1dAorICAgICAgICB0aGF0IGFwcHJv YWNoIGlzIG11Y2ggbW9yZSBpbnZvbHZlZCB0aGFuIHJldHVybmluZyBhIHZhbHVlIGRlc2NyaXB0 b3IuCisgICAgICAgIEtlZXAgaXQgc2ltcGxlIGZvciBub3cuCisKKyAgICAgICAgKiBBUEkvSlND YWxsYmFja09iamVjdC5oOgorICAgICAgICAqIEFQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25z Lmg6CisgICAgICAgIChKU0M6Ojo6Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKToKKyAgICAgICAg KiBBUEkvdGVzdHMvdGVzdGFwaS5qczoKKwogMjAxMC0wMS0yMCAgTWFyayBSb3dlICA8bXJvd2VA YXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4K