33935 2010-01-20 18:51:48 -0800 Use xmlStrdup instead of strdup for consistency in Libxml2. 2019-02-06 09:03:25 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned ap cdumez commit-queue oldest_to_newest 183027 0 skyul 2010-01-20 18:51:48 -0800 Use xmlStrdup instead of strdup for consistency. This is the first step to remove the direct use of strdup from WebKit. reinterpret_cast is required convert between xmlChar* and char* because xmlChar is typedef to unsigned char. 183029 1 47091 skyul 2010-01-20 18:57:58 -0800 Created attachment 47091 Use xmlStrdup instead of strdup in Libxml2 183071 2 47091 ap 2010-01-20 21:03:24 -0800 Comment on attachment 47091 Use xmlStrdup instead of strdup in Libxml2 r=me 183078 3 47091 commit-queue 2010-01-20 21:58:35 -0800 Comment on attachment 47091 Use xmlStrdup instead of strdup in Libxml2 Clearing flags on attachment: 47091 Committed r53604: <http://trac.webkit.org/changeset/53604> 183079 4 commit-queue 2010-01-20 21:58:41 -0800 All reviewed patches have been landed. Closing bug. 1502965 5 lforschler 2019-02-06 09:03:25 -0800 Mass moving XML DOM bugs to the "DOM" Component. 47091 2010-01-20 18:57:58 -0800 2010-01-20 21:58:35 -0800 Use xmlStrdup instead of strdup in Libxml2 xmlStrdup.patch text/plain 2601 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMjAgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVc2UgeG1sU3RyZHVwIGluc3RlYWQgb2Ygc3RyZHVwIGZvciBjb25zaXN0ZW5jeSBpbiBMaWJ4 bWwyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5 MzUKKworICAgICAgICBSZW1vdmUgdGhlIGRpcmVjdCB1c2Ugb2Ygc3RyZHVwLgorCisgICAgICAg ICogZG9tL1hNTFRva2VuaXplckxpYnhtbDIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGVuZGlu Z0NhbGxiYWNrczo6YXBwZW5kRXJyb3JDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpQZW5k aW5nQ2FsbGJhY2tzOjopOgorICAgICAgICAoV2ViQ29yZTo6WE1MVG9rZW5pemVyOjplcnJvcik6 CisKIDIwMTAtMDEtMjAgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYkNvcmUvZG9t L1hNTFRva2VuaXplckxpYnhtbDIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1hNTFRv a2VuaXplckxpYnhtbDIuY3BwCShyZXZpc2lvbiA1MzU5MikKKysrIFdlYkNvcmUvZG9tL1hNTFRv a2VuaXplckxpYnhtbDIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksMTEgKzE2OSwxMSBAQCBw dWJsaWM6CiAgICAgICAgIG1fY2FsbGJhY2tzLmFwcGVuZChjYWxsYmFjayk7ICAgICAgICAKICAg ICB9CiAgICAgCi0gICAgdm9pZCBhcHBlbmRFcnJvckNhbGxiYWNrKFhNTFRva2VuaXplcjo6RXJy b3JUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIGludCBsaW5lTnVtYmVyLCBpbnQgY29s dW1uTnVtYmVyKQorICAgIHZvaWQgYXBwZW5kRXJyb3JDYWxsYmFjayhYTUxUb2tlbml6ZXI6OkVy cm9yVHlwZSB0eXBlLCBjb25zdCB4bWxDaGFyKiBtZXNzYWdlLCBpbnQgbGluZU51bWJlciwgaW50 IGNvbHVtbk51bWJlcikKICAgICB7CiAgICAgICAgIFBlbmRpbmdFcnJvckNhbGxiYWNrKiBjYWxs YmFjayA9IG5ldyBQZW5kaW5nRXJyb3JDYWxsYmFjazsKICAgICAgICAgCi0gICAgICAgIGNhbGxi YWNrLT5tZXNzYWdlID0gc3RyZHVwKG1lc3NhZ2UpOworICAgICAgICBjYWxsYmFjay0+bWVzc2Fn ZSA9IHhtbFN0cmR1cChtZXNzYWdlKTsKICAgICAgICAgY2FsbGJhY2stPnR5cGUgPSB0eXBlOwog ICAgICAgICBjYWxsYmFjay0+bGluZU51bWJlciA9IGxpbmVOdW1iZXI7CiAgICAgICAgIGNhbGxi YWNrLT5jb2x1bW5OdW1iZXIgPSBjb2x1bW5OdW1iZXI7CkBAIC0zMTYsMTYgKzMxNiwxNiBAQCBw cml2YXRlOiAgICAKICAgICBzdHJ1Y3QgUGVuZGluZ0Vycm9yQ2FsbGJhY2s6IHB1YmxpYyBQZW5k aW5nQ2FsbGJhY2sgewogICAgICAgICB2aXJ0dWFsIH5QZW5kaW5nRXJyb3JDYWxsYmFjaygpIAog ICAgICAgICB7Ci0gICAgICAgICAgICBmcmVlKG1lc3NhZ2UpOworICAgICAgICAgICAgeG1sRnJl ZShtZXNzYWdlKTsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgdmlydHVhbCB2b2lkIGNh bGwoWE1MVG9rZW5pemVyKiB0b2tlbml6ZXIpIAogICAgICAgICB7Ci0gICAgICAgICAgICB0b2tl bml6ZXItPmhhbmRsZUVycm9yKHR5cGUsIG1lc3NhZ2UsIGxpbmVOdW1iZXIsIGNvbHVtbk51bWJl cik7CisgICAgICAgICAgICB0b2tlbml6ZXItPmhhbmRsZUVycm9yKHR5cGUsIHJlaW50ZXJwcmV0 X2Nhc3Q8Y2hhcio+KG1lc3NhZ2UpLCBsaW5lTnVtYmVyLCBjb2x1bW5OdW1iZXIpOwogICAgICAg ICB9CiAgICAgICAgIAogICAgICAgICBYTUxUb2tlbml6ZXI6OkVycm9yVHlwZSB0eXBlOwotICAg ICAgICBjaGFyKiBtZXNzYWdlOworICAgICAgICB4bWxDaGFyKiBtZXNzYWdlOwogICAgICAgICBp bnQgbGluZU51bWJlcjsKICAgICAgICAgaW50IGNvbHVtbk51bWJlcjsKICAgICB9OwpAQCAtOTEw LDcgKzkxMCw3IEBAIHZvaWQgWE1MVG9rZW5pemVyOjplcnJvcihFcnJvclR5cGUgdHlwZSwKICNl bmRpZgogICAgIAogICAgIGlmIChtX3BhcnNlclBhdXNlZCkKLSAgICAgICAgbV9wZW5kaW5nQ2Fs bGJhY2tzLT5hcHBlbmRFcnJvckNhbGxiYWNrKHR5cGUsIG0sIGxpbmVOdW1iZXIoKSwgY29sdW1u TnVtYmVyKCkpOworICAgICAgICBtX3BlbmRpbmdDYWxsYmFja3MtPmFwcGVuZEVycm9yQ2FsbGJh Y2sodHlwZSwgcmVpbnRlcnByZXRfY2FzdDxjb25zdCB4bWxDaGFyKj4obSksIGxpbmVOdW1iZXIo KSwgY29sdW1uTnVtYmVyKCkpOwogICAgIGVsc2UKICAgICAgICAgaGFuZGxlRXJyb3IodHlwZSwg bSwgbGluZU51bWJlcigpLCBjb2x1bW5OdW1iZXIoKSk7CiAK