33932 2010-01-20 18:27:30 -0800 [Chromium] Implement texSubImage2D taking WebGLArray 2010-01-21 23:26:27 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth cmarrin commit-queue dglazkov fishd oliver oldest_to_newest 183014 0 kbr 2010-01-20 18:27:30 -0800 It seems that the texSubImage2D variant taking a WebGLArray as argument was not implemented in either https://bugs.webkit.org/show_bug.cgi?id=31562 or https://bugs.webkit.org/show_bug.cgi?id=33241 . This needs to be done. 183020 1 47090 kbr 2010-01-20 18:34:32 -0800 Created attachment 47090 Patch Chromium-specific issue, but test case verified on WebKit as well. 183025 2 47090 oliver 2010-01-20 18:40:14 -0800 Comment on attachment 47090 Patch r=me 183030 3 oliver 2010-01-20 19:04:45 -0800 ken do you have commit bit yet? 183235 4 kbr 2010-01-21 10:05:18 -0800 (In reply to comment #3) > ken do you have commit bit yet? Yes; I was waiting to see whether the bots would all clear the patch but it looks like a few are offline. Just cq+'d it. 183291 5 47090 commit-queue 2010-01-21 13:01:47 -0800 Comment on attachment 47090 Patch Clearing flags on attachment: 47090 Committed r53640: <http://trac.webkit.org/changeset/53640> 183292 6 commit-queue 2010-01-21 13:02:00 -0800 All reviewed patches have been landed. Closing bug. 183508 7 abarth 2010-01-21 23:26:27 -0800 > Yes; I was waiting to see whether the bots would all clear the patch but it > looks like a few are offline. Just cq+'d it. The bots only run on patches that have review?. Once you r+ a patch, the bots ignore it. 47090 2010-01-20 18:34:32 -0800 2010-01-21 13:01:46 -0800 Patch texsubimage2d.patch text/plain 6821 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTM1OTEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMjAgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gSW1wbGVtZW50IHRleFN1YkltYWdlMkQg dGFraW5nIFdlYkdMQXJyYXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzOTMyCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OnRleFN1YkltYWdlMkQpOgorCiAy MDEwLTAxLTIwICBWaXRhbHkgUmVwZXNoa28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3Ny Yy9HcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHJldmlzaW9uIDUzNTcxKQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwODQsOSAr MjA4NCw4IEBAIGludCBHcmFwaGljc0NvbnRleHQzRDo6dGV4U3ViSW1hZ2UyRCh1bnMKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCB0eXBlLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZvaWQqIHBpeGVscykKIHsKLSAgICAvLyBGSVhN RTogaW1wbGVtZW50LgotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIC0xOworICAg IGdsVGV4U3ViSW1hZ2UyRCh0YXJnZXQsIGxldmVsLCB4b2Zmc2V0LCB5b2Zmc2V0LCB3aWR0aCwg aGVpZ2h0LCBmb3JtYXQsIHR5cGUsIHBpeGVscyk7CisgICAgcmV0dXJuIDA7CiB9CiAKIGludCBH cmFwaGljc0NvbnRleHQzRDo6dGV4U3ViSW1hZ2UyRCh1bnNpZ25lZCB0YXJnZXQsCkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAxLTIwICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29v Z2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbQ2hyb21pdW1dIEltcGxlbWVudCB0ZXhTdWJJbWFnZTJEIHRha2luZyBXZWJHTEFycmF5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzkzMgorCisg ICAgICAgICogZmFzdC9jYW52YXMvd2ViZ2wvdGV4LXN1Yi1pbWFnZS0yZC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL3RleC1zdWItaW1hZ2UtMmQuaHRt bDogQWRkZWQuCisKIDIwMTAtMDEtMjAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7guCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC90ZXgtc3ViLWltYWdlLTJkLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC90ZXgtc3ViLWltYWdlLTJk LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dl YmdsL3RleC1zdWItaW1hZ2UtMmQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDcgQEAKK1Rlc3RzIHRleFN1YkltYWdlMkQgdXBsb2FkIHBhdGggZnJvbSBXZWJHTFVuc2lnbmVk Qnl0ZUFycmF5CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworUmVncmVzc2lvbiB0ZXN0 IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5MzIgOiBbQ2hy b21pdW1dIEltcGxlbWVudCB0ZXhTdWJJbWFnZTJEIHRha2luZyBXZWJHTEFycmF5CitQQVNTIAor CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC90ZXgtc3ViLWltYWdlLTJkLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvdGV4LXN1Yi1p bWFnZS0yZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2Vi Z2wvdGV4LXN1Yi1pbWFnZS0yZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEyNSBAQAor PGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVz b3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3NzIi8+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3Vy Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvd2Vi Z2wtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3V0aWxzM2QuanMi PiA8L3NjcmlwdD4KKzxzY3JpcHQgaWQ9InZzaGFkZXIiIHR5cGU9Ingtc2hhZGVyL3gtdmVydGV4 Ij4KK2F0dHJpYnV0ZSB2ZWMzIGdfUG9zaXRpb247CithdHRyaWJ1dGUgdmVjMiBnX1RleENvb3Jk MDsKKwordmFyeWluZyB2ZWMyIHRleENvb3JkOworCit2b2lkIG1haW4oKQoreworICAgIGdsX1Bv c2l0aW9uID0gdmVjNChnX1Bvc2l0aW9uLngsIGdfUG9zaXRpb24ueSwgZ19Qb3NpdGlvbi56LCAx LjApOworICAgIHRleENvb3JkID0gZ19UZXhDb29yZDA7Cit9Cis8L3NjcmlwdD4KKworPHNjcmlw dCBpZD0iZnNoYWRlciIgdHlwZT0ieC1zaGFkZXIveC1mcmFnbWVudCI+Cit1bmlmb3JtIHNhbXBs ZXIyRCB0ZXg7Cit2YXJ5aW5nIHZlYzIgdGV4Q29vcmQ7CisKK3ZvaWQgbWFpbigpCit7CisgICAg ZmxvYXQgaW50ZW5zaXR5ID0gdGV4dHVyZTJEKHRleCwgdGV4Q29vcmQpLmE7CisgICAgZ2xfRnJh Z0NvbG9yID0gdmVjNChpbnRlbnNpdHksIGludGVuc2l0eSwgaW50ZW5zaXR5LCAxLjApOworfQor PC9zY3JpcHQ+CisKKzwvaGVhZD4KKzxib2R5PgorPGNhbnZhcyBpZD0iZXhhbXBsZSIgd2lkdGg9 IjI1NnB4IiBoZWlnaHQ9IjFweCI+PC9jYW52YXM+Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9k aXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGVz dHMgdGV4U3ViSW1hZ2UyRCB1cGxvYWQgcGF0aCBmcm9tIFdlYkdMVW5zaWduZWRCeXRlQXJyYXkn KTsKKworZGVidWcoJ1JlZ3Jlc3Npb24gdGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzOTMyIj5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzM5MzI8L2E+IDogPGNvZGU+W0Nocm9taXVtXSBJbXBsZW1lbnQgdGV4 U3ViSW1hZ2UyRCB0YWtpbmcgV2ViR0xBcnJheTwvY29kZT4nKTsKKwordmFyIGdsID0gaW5pdFdl YkdMKCJleGFtcGxlIiwgInZzaGFkZXIiLCAiZnNoYWRlciIsIFsgImdfUG9zaXRpb24iLCAiZ19U ZXhDb29yZDAiIF0sIFsgMCwgMCwgMCwgMSBdLCAxKTsKK3ZhciB0ZXh0dXJlV2lkdGggPSAyNTY7 Cit2YXIgdGV4dHVyZUhlaWdodCA9IDE7CisKK2dsLnZpZXdwb3J0KDAsIDAsIHRleHR1cmVXaWR0 aCwgdGV4dHVyZUhlaWdodCk7CisKK3RleHR1cmVMb2MgPSBnbC5nZXRVbmlmb3JtTG9jYXRpb24o Z2wucHJvZ3JhbSwgInRleCIpOworCit2YXIgdmVydGljZXMgPSBuZXcgV2ViR0xGbG9hdEFycmF5 KFsKKyAgICAgMS4wLCAgMS4wLCAwLjAsCisgICAgLTEuMCwgIDEuMCwgMC4wLAorICAgIC0xLjAs IC0xLjAsIDAuMCwKKyAgICAgMS4wLCAgMS4wLCAwLjAsCisgICAgLTEuMCwgLTEuMCwgMC4wLAor ICAgICAxLjAsIC0xLjAsIDAuMF0pOwordmFyIHRleENvb3JkcyA9IG5ldyBXZWJHTEZsb2F0QXJy YXkoWworICAgIDEuMCwgMS4wLAorICAgIDAuMCwgMS4wLAorICAgIDAuMCwgMC4wLAorICAgIDEu MCwgMS4wLAorICAgIDAuMCwgMC4wLAorICAgIDEuMCwgMC4wXSk7Cit2YXIgdGV4Q29vcmRPZmZz ZXQgPSB2ZXJ0aWNlcy5ieXRlTGVuZ3RoOworCit2YXIgdmJvID0gZ2wuY3JlYXRlQnVmZmVyKCk7 CitnbC5iaW5kQnVmZmVyKGdsLkFSUkFZX0JVRkZFUiwgdmJvKTsKK2dsLmJ1ZmZlckRhdGEoZ2wu QVJSQVlfQlVGRkVSLAorICAgICAgICAgICAgICB0ZXhDb29yZE9mZnNldCArIHRleENvb3Jkcy5i eXRlTGVuZ3RoLAorICAgICAgICAgICAgICBnbC5TVEFUSUNfRFJBVyk7CitnbC5idWZmZXJTdWJE YXRhKGdsLkFSUkFZX0JVRkZFUiwgMCwgdmVydGljZXMpOworZ2wuYnVmZmVyU3ViRGF0YShnbC5B UlJBWV9CVUZGRVIsIHRleENvb3JkT2Zmc2V0LCB0ZXhDb29yZHMpOworCitnbC5lbmFibGVWZXJ0 ZXhBdHRyaWJBcnJheSgwKTsKK2dsLnZlcnRleEF0dHJpYlBvaW50ZXIoMCwgMywgZ2wuRkxPQVQs IGZhbHNlLCAwLCAwKTsKK2dsLmVuYWJsZVZlcnRleEF0dHJpYkFycmF5KDEpOworZ2wudmVydGV4 QXR0cmliUG9pbnRlcigxLCAyLCBnbC5GTE9BVCwgZ2wuRkFMU0UsIDAsIHRleENvb3JkT2Zmc2V0 KTsKKwordmFyIHRleHR1cmUgPSBnbC5jcmVhdGVUZXh0dXJlKCk7CitnbC5iaW5kVGV4dHVyZShn bC5URVhUVVJFXzJELCB0ZXh0dXJlKTsKK2dsLnRleFBhcmFtZXRlcmkoZ2wuVEVYVFVSRV8yRCwg Z2wuVEVYVFVSRV9XUkFQX1MsIGdsLkNMQU1QX1RPX0VER0UpOworZ2wudGV4UGFyYW1ldGVyaShn bC5URVhUVVJFXzJELCBnbC5URVhUVVJFX1dSQVBfVCwgZ2wuQ0xBTVBfVE9fRURHRSk7CitnbC50 ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUlOX0ZJTFRFUiwgZ2wuTkVB UkVTVCk7CitnbC50ZXhQYXJhbWV0ZXJpKGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUFHX0ZJ TFRFUiwgZ2wuTkVBUkVTVCk7CisvLyBBbGxvY2F0ZSB0aGUgdGV4dHVyZSBvYmplY3QKK2dsLnRl eEltYWdlMkQoZ2wuVEVYVFVSRV8yRCwgMCwgZ2wuQUxQSEEsIHRleHR1cmVXaWR0aCwgdGV4dHVy ZUhlaWdodCwgMCwgZ2wuQUxQSEEsIGdsLlVOU0lHTkVEX0JZVEUsIG51bGwpOworLy8gUHJlcGFy ZSB0aGUgaW1hZ2UgZGF0YQordmFyIGFycmF5ID0gbmV3IFdlYkdMVW5zaWduZWRCeXRlQXJyYXko dGV4dHVyZVdpZHRoKTsKK2ZvciAodmFyIGkgPSAwOyBpIDwgdGV4dHVyZVdpZHRoOyBpKyspCisg ICAgYXJyYXlbaV0gPSBpOworLy8gRmlsbCB0aGUgdGV4dHVyZSBvYmplY3Qgd2l0aCBkYXRhIC0t IHRoaXMgaXMgYWN0dWFsbHkgdGhlIGNvZGUgcGF0aCBiZWluZyB0ZXN0ZWQKK2dsLnRleFN1Yklt YWdlMkQoZ2wuVEVYVFVSRV8yRCwgMCwgMCwgMCwgdGV4dHVyZVdpZHRoLCB0ZXh0dXJlSGVpZ2h0 LCBnbC5BTFBIQSwgZ2wuVU5TSUdORURfQllURSwgYXJyYXkpOworCisvLyBDbGVhciBhbmQgc2V0 IHVwCitnbC5jbGVhcihnbC5DT0xPUl9CVUZGRVJfQklUIHwgZ2wuREVQVEhfQlVGRkVSX0JJVCk7 CitnbC5iaW5kVGV4dHVyZShnbC5URVhUVVJFXzJELCB0ZXh0dXJlKTsKK2dsLnVzZVByb2dyYW0o Z2wucHJvZ3JhbSk7CitnbC51bmlmb3JtMWkodGV4dHVyZUxvYywgMCk7CisvLyBEcmF3IHRoZSB0 ZXh0dXJlIHRvIHRoZSBmcmFtZSBidWZmZXIKK2dsLmRyYXdBcnJheXMoZ2wuVFJJQU5HTEVTLCAw LCA2KTsKKworLy8gUmVhZCBiYWNrIHRoZSBmcmFtZSBidWZmZXIKK3ZhciBidWYgPSBnbC5yZWFk UGl4ZWxzKDAsIDAsIHRleHR1cmVXaWR0aCwgdGV4dHVyZUhlaWdodCwgZ2wuUkdCQSwgZ2wuVU5T SUdORURfQllURSk7CisKKy8vIFZlcmlmeSB0aGUgZnJhbWUgYnVmZmVyJ3MgY29udGVudHMKK3Zh ciBwYXNzZWQgPSB0cnVlOworZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXh0dXJlV2lkdGg7IGkrKykg eworICAgIHZhciB2YWwgPSBpOworICAgIGlmIChidWZbNCAqIGkgKyAwXSAhPSB2YWwgfHwKKyAg ICAgICAgYnVmWzQgKiBpICsgMV0gIT0gdmFsIHx8CisgICAgICAgIGJ1Zls0ICogaSArIDJdICE9 IHZhbCkgeworICAgICAgICB0ZXN0RmFpbGVkKCJwaXhlbCBhdCAoIiArIGkgKyAiLCAwKSB3YXMg KCIgKworICAgICAgICAgICAgICAgICAgIGJ1Zls0ICogaSArIDBdICsgIiwgIiArCisgICAgICAg ICAgICAgICAgICAgYnVmWzQgKiBpICsgMV0gKyAiLCAiICsKKyAgICAgICAgICAgICAgICAgICBi dWZbNCAqIGkgKyAyXSArICIpLCBzaG91bGQgYmUgKCIgKworICAgICAgICAgICAgICAgICAgIHZh bCArICIsICIgKyB2YWwgKyAiLCAiICsgdmFsICsgIikiKTsKKyAgICAgICAgcGFzc2VkID0gZmFs c2U7CisgICAgICAgIGJyZWFrOworICAgIH0KK30KKworaWYgKHBhc3NlZCkKKyAgICB0ZXN0UGFz c2VkKCIiKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=