33931 2010-01-20 18:07:13 -0800 pushstate() from within a popstate handler might lead to improper scroll/view state being incorrect later 2010-06-29 14:14:15 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All NEW P2 Normal --- 1 beidson webkit-unassigned fishd justin.lebar+bug oldest_to_newest 183003 0 beidson 2010-01-20 18:07:13 -0800 pushstate() from within a popstate handler might lead to improper scroll/view state being incorrect later See the test case in https://bugs.webkit.org/show_bug.cgi?id=33830 for reference. Since the popstate event - fired from within FrameLoader::loadInSameDocument() called from FrameLoader::navigateWithinDocument() - can effectively change the current history item, the later call to history()->restoreScrollPositionAndViewState() will be operating on the wrong "current history item" from the perspective of the load. There's a lot of complexity here in getting this precisely right, especially since popstate events might nest and we'd probably only want to restore the scroll/view state from the most recently popped item. 183527 1 fishd 2010-01-22 00:27:58 -0800 We should be very careful here since history()->restoreScrollPositionAndViewState() may lead to the scroll event being dispatched. Can the app do other things within the popstate event that could cause the scroll event to be confusing to the app? (This re-entrancy stuff gives me a headache!) 244475 2 justin.lebar+bug 2010-06-29 14:13:53 -0700 Forgot to include a link above: [2]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-definitions 244477 3 justin.lebar+bug 2010-06-29 14:14:15 -0700 Oops, wrong bug. Sorry!