33929 2010-01-20 17:24:14 -0800 [V8] Need to handle WebGLUnsignedByteArray as method argument for V8 binding 2010-01-22 21:44:03 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 crogers webkit-unassigned commit-queue dglazkov eric oldest_to_newest 182989 0 crogers 2010-01-20 17:24:14 -0800 This only applies to V8 (not JSC). Apparently, WebGLUnsignedByteArray was accidentally left out of the GL types which may appear as method arguments in IDL files. Nobody has noticed so far because this case has not been needed up to this point - but I'm working on a patch which will need it. 182990 1 47084 crogers 2010-01-20 17:29:05 -0800 Created attachment 47084 patch 183384 2 47084 eric 2010-01-21 16:48:29 -0800 Comment on attachment 47084 patch This results in a functional change to the V8 JavaScript bindings, no? If it does, it needs a test. If it doesn't, it's just a build fix and doesn't need review. :) 183385 3 47084 eric 2010-01-21 16:49:23 -0800 Comment on attachment 47084 patch I meant to mark it r-. By "test" I mean a layout test. Some javascript code which creates one of these WebGLUnsignedByteArray and tries to pass it somewhere where behavior has now changed. 183405 4 crogers 2010-01-21 17:13:55 -0800 Eric, AFAIK there are currently no IDL files which take WebGLUnsignedByteArray as an argument so there is nothing I can test. I have a future patch which will need this and currently the JSC generator already handles this case, but V8 does not. Put in other words, this fixes the V8 generator to be on par with JSC. But currently there are no APIs which can be tested. The omission of WebGLUnsignedByteArray (among the other WebGL types) appears to be an oversight. thanks for having a look 183414 5 47084 eric 2010-01-21 17:27:56 -0800 Comment on attachment 47084 patch Ok. If there is nothing that uses this yet, then there is no way to test it. ideally you should say that in the ChangeLog so that folks using annotate later have a better chance of understanding. :) 183415 6 47084 eric 2010-01-21 17:28:12 -0800 Comment on attachment 47084 patch Chris isn't a committer, so marking cq+ too. 183489 7 47084 commit-queue 2010-01-21 22:36:46 -0800 Comment on attachment 47084 patch Rejecting patch 47084 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Last 500 characters of output: e/LayoutTests Testing 12030 test cases. http/tests/history/redirect-302.pl -> timed out Sampling process 88106 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 88106 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 11241 tests run. 297.88s total testing time 11240 test cases (99%) succeeded 1 test case (<1%) timed out 6 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/203615 183746 8 47084 jorlow 2010-01-22 12:21:25 -0800 Comment on attachment 47084 patch Looks like flake. Try again. 183758 9 eric 2010-01-22 12:47:07 -0800 (In reply to comment #8) > (From update of attachment 47084 [details]) > Looks like flake. Try again. Yes. bug 30391. Trying again was the proper response. :) 183946 10 47084 commit-queue 2010-01-22 21:43:57 -0800 Comment on attachment 47084 patch Clearing flags on attachment: 47084 Committed r53760: <http://trac.webkit.org/changeset/53760> 183947 11 commit-queue 2010-01-22 21:44:03 -0800 All reviewed patches have been landed. Closing bug. 47084 2010-01-20 17:29:05 -0800 2010-01-22 21:43:56 -0800 patch ttt text/plain 1116 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMjAgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO ZWVkIHRvIGhhbmRsZSBXZWJHTFVuc2lnbmVkQnl0ZUFycmF5IGFzIG1ldGhvZCBhcmd1bWVudCBm b3IgVjggYmluZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzM5MjkKKworICAgICAgICBWOCBjb2RlIGdlbmVyYXRvciBkb2VzIG5vdCBoYXZlIGFz c29jaWF0ZWQgdGVzdHMKKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtOgorCiAyMDEwLTAxLTIwICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNTM1NzgpCisrKyBX ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkp CkBAIC0yMjA2LDYgKzIyMDYsNyBAQCBteSAldHlwZUNhbkZhaWxDb252ZXJzaW9uID0gKAogICAg ICJXZWJHTEFycmF5IiA9PiAwLAogICAgICJXZWJHTEJ1ZmZlciIgPT4gMCwKICAgICAiV2ViR0xC eXRlQXJyYXkiID0+IDAsCisgICAgIldlYkdMVW5zaWduZWRCeXRlQXJyYXkiID0+IDAsCiAgICAg IldlYkdMQ29udGV4dEF0dHJpYnV0ZXMiID0+IDAsCiAgICAgIldlYkdMRmxvYXRBcnJheSIgPT4g MCwKICAgICAiV2ViR0xGcmFtZWJ1ZmZlciIgPT4gMCwK