33917 2010-01-20 12:55:56 -0800 [Chromium] "ChromiumBridge" should be also accessible as "PlatformBridge" 2010-01-21 11:01:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 33608 33673 0 andreip webkit-unassigned android-webkit-unforking commit-queue oldest_to_newest 182889 0 andreip 2010-01-20 12:55:56 -0800 A better name for ChromiumBridge is PlatformBridge. This is because, on Chromium, it is the client that provides some of the functionality that is normally provided by the underlying operating system (or platform). This functionality is accessible via the ChromiumBridge class, so the word "Chromium" is used where "Platform" is actually meant. Android already uses PlatformBridge in a similar way to how Chromium uses ChromiumBridge. Therefore, an added benefit of renaming ChromiumBridge to PlatformBridge is that the two ports, Android and Chromium, will share code without the need for any #ifdefs. We therefore aim to rename ChromiumBridge to PlatformBridge. For now, we will add the PlatformBridge.h header and just typedef ChromiumBridge PlatformBridge. This is what this bug tracks. When the Android port is fully upstreamed, we will rename ChromiumBridge to PlatformBridge and merge it with Android's version. This will be tracked in a separate bug. Patch coming soon. 182896 1 47056 andreip 2010-01-20 13:15:55 -0800 Created attachment 47056 Add PlatformBridge.h header. 183249 2 47056 commit-queue 2010-01-21 11:01:36 -0800 Comment on attachment 47056 Add PlatformBridge.h header. Clearing flags on attachment: 47056 Committed r53633: <http://trac.webkit.org/changeset/53633> 183250 3 commit-queue 2010-01-21 11:01:41 -0800 All reviewed patches have been landed. Closing bug. 47056 2010-01-20 13:15:55 -0800 2010-01-21 11:01:36 -0800 Add PlatformBridge.h header. 33917.patch text/plain 3171 andreip SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMjAgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBQbGF0Zm9ybUJyaWRnZS5oIGhlYWRlciBhbmQgYSB0eXBlZGVmIHRvIGdpdmUgQ2hyb21p dW1CcmlkZ2UgYSBuZXcgbmFtZTogUGxhdGZvcm1CcmlkZ2UuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzkxNworCisgICAgICAgIE5vIG5ldyB0ZXN0 cyBuZWVkZWQsIHRoaXMgaXMganVzdCB0byBhbGxvdyBvdGhlciBtZXRob2RzIHRvIGNhbGwgQ2hy b21pdW1CcmlkZ2UKKyAgICAgICAgdXNpbmcgdGhlIG5ldyAnUGxhdGZvcm1CcmlkZ2UnIG5hbWUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUJyaWRnZS5oOiBBZGRlZC4K KwogMjAxMC0wMS0yMCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4K IAogICAgICAgICBCdWlsZCBmaXggZm9yICFFTkFCTEUoU1ZHKS4KSW5kZXg6IFdlYkNvcmUvcGxh dGZvcm0vY2hyb21pdW0vUGxhdGZvcm1CcmlkZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtQnJpZGdlLmgJKHJldmlzaW9uIDApCisrKyBXZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtQnJpZGdlLmgJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNDcgQEAKKy8qCisgKiBDb3B5cmlnaHQgKGMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1p dHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyAqIG1ldDoK KyAqCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4g dGhlIGFib3ZlIGNvcHlyaWdodAorICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICAgICogUmVkaXN0cmlidXRpb25zIGlu IGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQorICogY29weXJpZ2h0IG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgor ICogaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZQorICogZGlzdHJpYnV0aW9uLgorICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBH b29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworICogY29udHJpYnV0b3JzIG1heSBiZSB1 c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KKyAqIHRoaXMg c29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisgKgor ICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5E IENPTlRSSUJVVE9SUworICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyAqIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdB UlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorICogQSBQQVJUSUNV TEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklH SFQKKyAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElO RElSRUNULCBJTkNJREVOVEFMLAorICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5U SUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorICogTElNSVRFRCBUTywgUFJPQ1VSRU1F TlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCisgKiBEQVRB LCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFO RCBPTiBBTlkKKyAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNU UklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhF UldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZU V0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4K KyAqLworCisjaWZuZGVmIFBsYXRmb3JtQnJpZGdlX2gKKyNkZWZpbmUgUGxhdGZvcm1CcmlkZ2Vf aAorCisjaW5jbHVkZSAiQ2hyb21pdW1CcmlkZ2UuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgewor CisvLyBGSVhNRTogQSBiZXR0ZXIgbmFtZSBmb3IgQ2hyb21pdW1CcmlkZ2UgaXMgUGxhdGZvcm1C cmlkZ2UuIEFuZHJvaWQgYWxyZWFkeQorLy8gdXNlcyBQbGF0Zm9ybUJyaWRnZSBzbyB0aGUgY29k ZSB0aGF0IGlzIHNoYXJlZCBhbW9uZyB0aGUgQW5kcm9pZCBhbmQgQ2hyb21pdW0KKy8vIHBvcnRz IGlzIGdyYWR1YWxseSBtb3ZpbmcgdG93YXJkcyB1c2luZyBQbGF0Zm9ybUJyaWRnZS4gT25jZSB0 aGUgQW5kcm9pZAorLy8gdW5mb3JraW5nIGlzIGRvbmUsIHdlIHdpbGwgY2hhbmdlIHRoZSBuYW1l IG9mIENocm9taXVtQnJpZGdlIHRvIFBsYXRmb3JtQnJpZGdlCisvLyBhbmQgbWVyZ2UgdGhlIHR3 byBjbGFzc2VzIGludG8gb25lIHRoYXQgd2lsbCBiZSBzaGFyZWQgYnkgYm90aCBwb3J0cy4KK3R5 cGVkZWYgQ2hyb21pdW1CcmlkZ2UgUGxhdGZvcm1CcmlkZ2U7CisKK30gLy8gbmFtZXNwYWNlIFdl YkNvcmUKKworI2VuZGlmIC8vIFBsYXRmb3JtQnJpZGdlX2gK