33916 2010-01-20 12:33:00 -0800 openDatabase should throw exception if database access is disallowed 2010-04-12 19:59:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 ericu dumi abarth dglazkov dimich dumi eric fishd patrik.j.persson webkit.review.bot oldest_to_newest 182884 0 ericu 2010-01-20 12:33:00 -0800 From the spec [http://dev.w3.org/html5/webdatabase/ section 4.1.1]: "The user agent may raise a SECURITY_ERR exception instead of returning a Database object if the request violates a policy decision (e.g. if the user agent is configured to not allow the page to open databases)." We're just returning null, which isn't an option offered by the specification. The current behavior is enforced by LayoutTests/fast/frames/sandboxed-iframe-storage.html. 210348 1 52889 dumi 2010-04-08 13:19:11 -0700 Created attachment 52889 patch 210349 2 52889 dglazkov 2010-04-08 13:25:06 -0700 Comment on attachment 52889 patch ok. Can you reference a layout test that enforces it? 210588 3 patrik.j.persson 2010-04-09 00:02:33 -0700 (In reply to comment #3) > From the spec [http://dev.w3.org/html5/webdatabase/ section 4.1.1]: "The user > agent may raise a SECURITY_ERR exception instead of returning a Database object > if the request violates a policy decision (e.g. if the user agent is configured > to not allow the page to open databases)." We're just returning null, which > isn't an option offered by the specification. > > The current behavior is enforced by > LayoutTests/fast/frames/sandboxed-iframe-storage.html. FYI: that particular layout test was revised in bug 32369. However, that change was specific to sandboxed iframes. Other database policy decisions were not addressed by bug 32369. 211789 4 dumi 2010-04-12 17:26:18 -0700 Do we have a way to turn on/off DB support in tests? If not, then I'm not sure how to write a test for this patch, because DB support is enabled by default. 211796 5 dumi 2010-04-12 18:08:42 -0700 Landed as r57492. 211801 6 webkit.review.bot 2010-04-12 18:35:38 -0700 http://trac.webkit.org/changeset/57492 might have broken SnowLeopard Intel Release (Tests) 211818 7 dumi 2010-04-12 19:59:24 -0700 (In reply to comment #6) > http://trac.webkit.org/changeset/57492 might have broken SnowLeopard Intel > Release (Tests) Fixed storage/open-database-over-quota.html in r57493. 52889 2010-04-08 13:19:11 -0700 2010-04-08 13:25:06 -0700 patch patch text/plain 2092 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzI4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMDggIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaHJvd2luZyBhIFNFQ1VSSVRZX0VSUiB3aGVuIG9wZW5EYXRhYmFzZSgpIGNhbm5vdCBvcGVu IGEgZGF0YWJhc2UKKyAgICAgICAgZm9yIHdoYXRldmVyIHJlYXNvbiwgYXMgcmVxdWlyZWQgYnkg dGhlIHNwZWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMzkxNgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5kb3c6Om9wZW5EYXRhYmFzZSk6CisgICAgICAgICog YmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4RE9NV2luZG93OjpvcGVuRGF0YWJhc2VDYWxsYmFjayk6CisKIDIwMTAtMDQtMDggIEJl bmphbWluIE90dGUgIDxvdHRlQGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0 YXZvIE5vcm9uaGEuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9t LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9t LmNwcAkocmV2aXNpb24gNTcyODUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93 Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTc3LDYgKzk3Nyw5IEBAIEpTVmFsdWUgSlNE T01XaW5kb3c6Om9wZW5EYXRhYmFzZShFeGVjU3QKICAgICAgICAgY3JlYXRpb25DYWxsYmFjayA9 IEpTRGF0YWJhc2VDYWxsYmFjazo6Y3JlYXRlKGFzT2JqZWN0KGFyZ3MuYXQoNCkpLCBnbG9iYWxP YmplY3QoKSk7CiAKICAgICBKU1ZhbHVlIHJlc3VsdCA9IHRvSlMoZXhlYywgZ2xvYmFsT2JqZWN0 KCksIFdURjo6Z2V0UHRyKGltcGwoKS0+b3BlbkRhdGFiYXNlKG5hbWUsIHZlcnNpb24sIGRpc3Bs YXlOYW1lLCBlc3RpbWF0ZWRTaXplLCBjcmVhdGlvbkNhbGxiYWNrLnJlbGVhc2UoKSwgZWMpKSk7 CisgICAgaWYgKCFlYyAmJiByZXN1bHQuaXNOdWxsKCkpCisgICAgICAgIGVjID0gU0VDVVJJVFlf RVJSOworCiAgICAgc2V0RE9NRXhjZXB0aW9uKGV4ZWMsIGVjKTsKICAgICByZXR1cm4gcmVzdWx0 OwogfQpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93 Q3VzdG9tLmNwcAkocmV2aXNpb24gNTcyODUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOERPTVdpbmRvd0N1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczNSw2ICs3MzUsOSBA QCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XaW5kb3c6Om9wZW5ECiAgICAgICAgIGNyZWF0 aW9uQ2FsbGJhY2sgPSBWOERhdGFiYXNlQ2FsbGJhY2s6OmNyZWF0ZShhcmdzWzRdLCBpbXAtPmZy YW1lKCkpOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHJlc3VsdCA9IHRvVjgoaW1wLT5v cGVuRGF0YWJhc2UobmFtZSwgdmVyc2lvbiwgZGlzcGxheU5hbWUsIGVzdGltYXRlZFNpemUsIGNy ZWF0aW9uQ2FsbGJhY2sucmVsZWFzZSgpLCBlYykpOworICAgIGlmICghZWMgJiYgcmVzdWx0Lklz RW1wdHkoKSkKKyAgICAgICAgZWMgPSBTRUNVUklUWV9FUlI7CisKICAgICBWOFByb3h5OjpzZXRE T01FeGNlcHRpb24oZWMpOwogICAgIHJldHVybiByZXN1bHQ7CiB9Cg==