33908 2010-01-20 09:41:58 -0800 [Chromium] Skia "seatbelts" should be removed. 2010-01-20 20:54:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco commit-queue oldest_to_newest 182833 0 senorblanco 2010-01-20 09:41:58 -0800 [Chromium] Skia "seatbelts" should be removed. 182835 1 47042 senorblanco 2010-01-20 09:45:12 -0800 Created attachment 47042 Patch 182840 2 senorblanco 2010-01-20 09:49:31 -0800 ENSURE_VALUE_SAFETY_FOR_SKIA should be disabled, since we believe we've fixed the underlying Skia problems, and the seatbelts themselves also causing bugs (e.g., http://crbug.com/18630). 182844 3 47042 levin 2010-01-20 09:54:45 -0800 Comment on attachment 47042 Patch > Index: WebCore/ChangeLog > + Reviewed by NOBODY (OOPS!). > + > + Disable the "seatbelt" coordinate validation functions in the > + Skia graphics layer. We believe all the underlying bugs have > + been fixed, but just in case we're being overly optimistic, this > + leaves in the code for an easy revert. Please add a bug link here. > Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp > +// Diabling these checks (20/01/2010), since we think we've fixed all the Skia typo: Diabling 182847 4 47044 senorblanco 2010-01-20 10:00:37 -0800 Created attachment 47044 Patch 183066 5 47044 commit-queue 2010-01-20 20:54:54 -0800 Comment on attachment 47044 Patch Clearing flags on attachment: 47044 Committed r53600: <http://trac.webkit.org/changeset/53600> 183067 6 commit-queue 2010-01-20 20:54:59 -0800 All reviewed patches have been landed. Closing bug. 47042 2010-01-20 09:45:12 -0800 2010-01-20 10:00:32 -0800 Patch bug-33908-20100120124510.patch text/plain 1568 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMjAgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGlzYWJsZSB0aGUgInNlYXRiZWx0IiBjb29yZGluYXRlIHZhbGlkYXRpb24gZnVuY3Rp b25zIGluIHRoZQorICAgICAgICBTa2lhIGdyYXBoaWNzIGxheWVyLiAgV2UgYmVsaWV2ZSBhbGwg dGhlIHVuZGVybHlpbmcgYnVncyBoYXZlCisgICAgICAgIGJlZW4gZml4ZWQsIGJ1dCBqdXN0IGlu IGNhc2Ugd2UncmUgYmVpbmcgb3Zlcmx5IG9wdGltaXN0aWMsIHRoaXMKKyAgICAgICAgbGVhdmVz IGluIHRoZSBjb2RlIGZvciBhbiBlYXN5IHJldmVydC4KKworICAgICAgICBFeGVyY2lzZWQgYnkg bWFueSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dy YXBoaWNzQ29udGV4dFNraWEuY3BwOgorCiAyMDEwLTAxLTIwICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBVbnJldmlld2VkIGJ1aWxkZml4IGZv ciByNTM1NDcuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3ND b250ZXh0U2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA1MzU0OSkKKysrIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODYsNyArODYsMTAgQEAgaW5saW5lIGZsb2F0IHNxdWFyZShmbG9hdCBuKQogLy8g SWRlYWxseSwgYWxsIG9mIHRoZXNlIHdvdWxkIGJlIGZpeGVkIGluIHRoZSBncmFwaGljcyBsYXll ciBhbmQgd2Ugd291bGQgbm90CiAvLyBoYXZlIHRvIGRvIGFueSBjaGVja2luZy4gWW91IGNhbiB1 bmNvbW1lbnQgdGhlIEVOU1VSRV9WQUxVRV9TQUZFVFlfRk9SX1NLSUEKIC8vIGZsYWcgdG8gY2hl Y2sgdGhlIGdyYXBoaWNzIGxheWVyLgotI2RlZmluZSBFTlNVUkVfVkFMVUVfU0FGRVRZX0ZPUl9T S0lBCisKKy8vIERpYWJsaW5nIHRoZXNlIGNoZWNrcyAoMjAvMDEvMjAxMCksIHNpbmNlIHdlIHRo aW5rIHdlJ3ZlIGZpeGVkIGFsbCB0aGUgU2tpYQorLy8gYnVncy4gIExlYXZpbmcgdGhlIGNvZGUg aW4gZm9yIG5vdywgc28gd2UgY2FuIHJldmVydCBlYXNpbHkgaWYgbmVjZXNzYXJ5LgorLy8gI2Rl ZmluZSBFTlNVUkVfVkFMVUVfU0FGRVRZX0ZPUl9TS0lBCiAKIHN0YXRpYyBib29sIGlzQ29vcmRp bmF0ZVNraWFTYWZlKGZsb2F0IGNvb3JkKQogewo= 47044 2010-01-20 10:00:37 -0800 2010-01-20 20:54:54 -0800 Patch bug-33908-20100120130035.patch text/plain 1624 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzU0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMjAgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGlzYWJsZSB0aGUgInNlYXRiZWx0IiBjb29yZGluYXRlIHZhbGlkYXRpb24gZnVuY3Rp b25zIGluIHRoZQorICAgICAgICBTa2lhIGdyYXBoaWNzIGxheWVyLiAgV2UgYmVsaWV2ZSBhbGwg dGhlIHVuZGVybHlpbmcgYnVncyBoYXZlCisgICAgICAgIGJlZW4gZml4ZWQsIGJ1dCBqdXN0IGlu IGNhc2Ugd2UncmUgYmVpbmcgb3Zlcmx5IG9wdGltaXN0aWMsIHRoaXMKKyAgICAgICAgbGVhdmVz IGluIHRoZSBjb2RlIGZvciBhbiBlYXN5IHJldmVydC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5MDgKKyAgICAgICAgRXhlcmNpc2VkIGJ5IG1h bnkgbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFw aGljc0NvbnRleHRTa2lhLmNwcDoKKwogMjAxMC0wMS0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8 b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBidWlsZGZpeCBmb3Ig cjUzNTQ3LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29u dGV4dFNraWEuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkocmV2aXNpb24gNTM1NDkpCisrKyBXZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTg2LDcgKzg2LDEwIEBAIGlubGluZSBmbG9hdCBzcXVhcmUoZmxvYXQgbikKIC8vIElk ZWFsbHksIGFsbCBvZiB0aGVzZSB3b3VsZCBiZSBmaXhlZCBpbiB0aGUgZ3JhcGhpY3MgbGF5ZXIg YW5kIHdlIHdvdWxkIG5vdAogLy8gaGF2ZSB0byBkbyBhbnkgY2hlY2tpbmcuIFlvdSBjYW4gdW5j b21tZW50IHRoZSBFTlNVUkVfVkFMVUVfU0FGRVRZX0ZPUl9TS0lBCiAvLyBmbGFnIHRvIGNoZWNr IHRoZSBncmFwaGljcyBsYXllci4KLSNkZWZpbmUgRU5TVVJFX1ZBTFVFX1NBRkVUWV9GT1JfU0tJ QQorCisvLyBEaXNhYmxpbmcgdGhlc2UgY2hlY2tzICgyMC8wMS8yMDEwKSwgc2luY2Ugd2UgdGhp bmsgd2UndmUgZml4ZWQgYWxsIHRoZSBTa2lhCisvLyBidWdzLiAgTGVhdmluZyB0aGUgY29kZSBp biBmb3Igbm93LCBzbyB3ZSBjYW4gcmV2ZXJ0IGVhc2lseSBpZiBuZWNlc3NhcnkuCisvLyAjZGVm aW5lIEVOU1VSRV9WQUxVRV9TQUZFVFlfRk9SX1NLSUEKIAogc3RhdGljIGJvb2wgaXNDb29yZGlu YXRlU2tpYVNhZmUoZmxvYXQgY29vcmQpCiB7Cg==