33903 2010-01-20 07:29:28 -0800 FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems 2010-10-21 12:57:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux UNCONFIRMED P2 Normal --- 0 fabo webkit-unassigned bladehawke darin mjs oldest_to_newest 182790 0 47028 fabo 2010-01-20 07:29:28 -0800 Created attachment 47028 fix kfreebsd ftbfs While building Qt 4.6.1 on GNU/kFreeBSD, it fails to build from scratch: websockets/WebSocketHandshake.cpp: In member function ‘int WebCore::WebSocketHandshake::readServerHandshake(const char*, size_t)’: websockets/WebSocketHandshake.cpp:255: error: ‘strnstr’ was not declared in this scope it's caused by the missing strnstr() function on glibc systems. webkit trunk should be also affected as the source code found on Qt 4.6.1 is similar. Please, find attached an initial patch to fix the issue. 182815 1 47028 darin 2010-01-20 08:32:59 -0800 Comment on attachment 47028 fix kfreebsd ftbfs Platforms that happen to have glibc are not OS(LINUX) and just because that's handy at one particular call site does not mean this is the correct way to do it. The right way to do this is to change the check at the strnstr definition, perhaps as described in the FIXME in StringExtras.h. Maciej Stachowiak is working on rationalizing Platform.h and might have a suggestion on the correct way to handle this. 182816 2 darin 2010-01-20 08:33:08 -0800 Also, patches need a change log entry. 182820 3 fabo 2010-01-20 08:43:27 -0800 that's what I mean by "initial" patch :) I'm just waiting someone points me the way to go for a proper fix. 297584 4 71477 bladehawke 2010-10-21 12:54:59 -0700 Created attachment 71477 Patch to use HAVE_STRNSTRN 297586 5 bladehawke 2010-10-21 12:56:14 -0700 Proposed patch addresses the above and will help other affected platforms (like NetBSD) whose libc implementations lack strnstr. 297587 6 71477 darin 2010-10-21 12:57:14 -0700 Comment on attachment 71477 Patch to use HAVE_STRNSTRN This patch will break non-configure-based platforms that have strnstr, which is the majority of platforms we support. Platform.h needs to set HAVE_STRNSTR for those platforms. 47028 2010-01-20 07:29:28 -0800 2010-06-10 20:34:08 -0700 fix kfreebsd ftbfs ftbfs_kfreebsd.diff text/plain 298 fabo Rml4IEZUQkZTIG9uIEdOVS9rRnJlZUJTRCBjYXVzZWQgYnkgbWlzc2luZyBzdHJuc3RyKCkgb24g Z2xpYmMgc3lzdGVtcy4KCi0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBi L0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC0zMzUsNyArMzM1LDcgQEAKICNlbmRp ZgogCiAvKiBPUyhMSU5VWCkgLSBMaW51eCAqLwotI2lmZGVmIF9fbGludXhfXworI2lmIGRlZmlu ZWQoX19saW51eF9fKSB8fCBkZWZpbmVkKF9fR0xJQkNfXykKICNkZWZpbmUgV1RGX09TX0xJTlVY IDEKICNlbmRpZgogCg== 71477 2010-10-21 12:54:59 -0700 2010-10-21 12:57:14 -0700 Patch to use HAVE_STRNSTRN WebKitStrnstr.patch text/plain 2012 bladehawke ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0OTlmZjY1Li4wNTIwZmNm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMjEgIEFudG9uIEZhZXJuICA8YW50b25AYmxhZGVoYXdrZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzOTAzCisKKyAgICAgICAgVGVzdCBmb3Igc3RybnN0 cgorCisgICAgICAgICogY29uZmlndXJlLmFjOgorCiAyMDEwLTEwLTE5ICBSeXVhbiBDaG9pICA8 cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRpbmcgbWlz c2VkIGFkZGl0aW9uYWxBcmd1bWVudHMuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggM2FjNTkxNS4uZWFhNzlhNSAx MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTIxICBBbnRvbiBGYWVybiAgPGFu dG9uQGJsYWRlaGF3a2UuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzkw MworCisgICAgICAgIEFkZHJlc3MgRklYTUU6IGluIHd0Zi9TdHJpbmdFeHRyYXMuaCB0byB1c2Ug SEFWRV9TVFJOU1RSCisgICAgICAgIGluc3RlYWQgb2YgYWRkaW5nIGFkZGl0aW9uYWwgcGxhdGZv cm1zIHRvIHRoZSBhbHJlYWR5CisgICAgICAgIG92ZXJsb25nIGNvbmRpdGlvbmFsCisKKyAgICAg ICAgKiB3dGYvU3RyaW5nRXh0cmFzLmg6CisKIDIwMTAtMTAtMTkgIEt3YW5nIFl1bCBTZW8gIDxz a3l1bEBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIu CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmggYi9KYXZhU2Ny aXB0Q29yZS93dGYvU3RyaW5nRXh0cmFzLmgKaW5kZXggNDczYmIyMi4uNWM4NmVkOSAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1N0cmluZ0V4dHJhcy5oCisrKyBiL0phdmFTY3JpcHRD b3JlL3d0Zi9TdHJpbmdFeHRyYXMuaApAQCAtMTAwLDggKzEwMCw3IEBAIGlubGluZSBpbnQgc3Ry Y2FzZWNtcChjb25zdCBjaGFyKiBzMSwgY29uc3QgY2hhciogczIpCiAKICNlbmRpZgogCi0jaWYg Q09NUElMRVIoTVNWQykgfHwgQ09NUElMRVIoUlZDVCkgfHwgT1MoV0lORE9XUykgfHwgT1MoTElO VVgpIHx8IE9TKFNPTEFSSVMpCi0vLyBGSVhNRTogc2hvdWxkIGNoZWNrIEhBVkVfU1RSTlNUUgor I2lmbmRlZiBIQVZFX1NUUk5TVFIKIAogaW5saW5lIGNoYXIqIHN0cm5zdHIoY29uc3QgY2hhciog YnVmZmVyLCBjb25zdCBjaGFyKiB0YXJnZXQsIHNpemVfdCBidWZmZXJMZW5ndGgpCiB7CmRpZmYg LS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggZGZmYmU3Ny4uNmRkNWE2 NiAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtMTA2LDYg KzEwNiw5IEBAIEFDX0NIRUNLX0hFQURFUlMoW3B0aHJlYWQuaF0sCiAgICAgICAgICAgICAgICAg IEFDX01TR19FUlJPUihbcHRocmVhZCBzdXBwb3J0IGlzIHJlcXVpcmVkIHRvIGJ1aWxkIFdlYktp dF0pKQogZmkKIAorIyBzdHJuc3RyIGlzIG1pc3Npbmcgb24gYSBzaWduaWZpY2FudCBudW1iZXIg b2YgcGxhdGZvcm1zLCBzbyB0ZXN0IGZvciBpdAorQUNfQ0hFQ0tfRlVOQyhbc3RybnN0cl0pCisK ICMgY2hlY2sgZm9yIGxpYmpwZWcgdGhlIHdheSBHdGsgZG9lcyBpdC4KIEFDX0NIRUNLX0xJQihq cGVnLCBqcGVnX2Rlc3Ryb3lfZGVjb21wcmVzcywKICAgICAgICAgICAgICAgICAgICBqcGVnX29r PXllcywganBlZ19vaz1ubwo=