33902 2010-01-20 07:24:02 -0800 Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler 2010-01-26 20:20:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 lyon.chen webkit-unassigned commit-queue ggaren staikos yong.li.webkit oldest_to_newest 182789 0 lyon.chen 2010-01-20 07:24:02 -0800 In commit r52231, Opcode is changed from void* to const void* when COMPUTED_GOTO is used, this caused a compiling error #1211 for RVCT 4.0 compilers. Suggest to change to: --- a/JavaScriptCore/bytecode/Opcode.h +++ b/JavaScriptCore/bytecode/Opcode.h @@ -196,7 +196,11 @@ #undef VERIFY_OPCODE_ID #if HAVE(COMPUTED_GOTO) +#if COMPILER(RVCT) + typedef void* Opcode; +#else typedef const void* Opcode; +#endif #else typedef OpcodeID Opcode; #endif 182801 1 47035 lyon.chen 2010-01-20 08:03:26 -0800 Created attachment 47035 Patch for bug 33902 182806 2 47035 darin 2010-01-20 08:14:12 -0800 Comment on attachment 47035 Patch for bug 33902 Two problems here: 1) We don't accept patches without change log entries. 2) This is probably not something that should be ifdef'd based on compiler. If void* works for the other compilers, then the patch should just switch from const void* to void*. 182807 3 lyon.chen 2010-01-20 08:19:09 -0800 Darin: In commit r52231, ggaren@apple.com mentioned the change from void* to const void* is to avoid generating bloated codes in interpreter.cpp, so maybe it's better #ifdef this change? And maybe RVCT compiler can someday updated to support const void* for computed goto, instead of void*? Hope to hear from ggaren@apple.com on this matter. 182866 4 ggaren 2010-01-20 11:11:05 -0800 > In commit r52231, ggaren@apple.com mentioned the change from void* to const > void* is to avoid generating bloated codes in interpreter.cpp, so maybe it's > better #ifdef this change? I'm not sure if that specific part of the change is required. I guess you'd have to test to find out. 183221 5 47128 lyon.chen 2010-01-21 09:29:03 -0800 Created attachment 47128 New patch with changelog. 183231 6 ggaren 2010-01-21 09:57:42 -0800 Did you verify that this change doesn't change code generation for non-RVCT compilers? 183234 7 lyon.chen 2010-01-21 10:02:53 -0800 No, I didn't, Garen. I thought your comment means this part is not essential to your optimization, and based on Darin's comments, I simply removed the #ifdef for RVCT. Sorry I don't have the time to verify it for other platforms for now, should I add these #ifdef back? 183239 8 yong.li.webkit 2010-01-21 10:31:54 -0800 +George Staikos 183245 9 47131 lyon.chen 2010-01-21 10:54:06 -0800 Created attachment 47131 New patch with RVCT flag. Add a new patch with code change limited to RVCT compiler. 183246 10 47128 darin 2010-01-21 10:55:14 -0800 Comment on attachment 47128 New patch with changelog. I’ll let Geoff handle reviewing duties on this bug. I’m not sure I know what the issues are and I know he does. 183546 11 47131 mjs 2010-01-22 01:52:15 -0800 Comment on attachment 47131 New patch with RVCT flag. Seems fine to have this scoped to COMPILER(RCVT) 184606 12 47131 commit-queue 2010-01-26 08:54:31 -0800 Comment on attachment 47131 New patch with RVCT flag. Rejecting patch 47131 from commit-queue. lyon.chen@torchmobile.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 184917 13 47131 commit-queue 2010-01-26 20:20:44 -0800 Comment on attachment 47131 New patch with RVCT flag. Clearing flags on attachment: 47131 Committed r53891: <http://trac.webkit.org/changeset/53891> 184918 14 commit-queue 2010-01-26 20:20:50 -0800 All reviewed patches have been landed. Closing bug. 47035 2010-01-20 08:03:26 -0800 2010-01-21 10:54:06 -0800 Patch for bug 33902 PatchFor33902.patch text/plain 436 lyon.chen SW5kZXg6IEphdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgJKHJldmlzaW9uIDUzNTQ3KQ0KKysrIEph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oCSh3b3JraW5nIGNvcHkpDQpAQCAtMTk2LDcg KzE5NiwxMSBAQA0KICAgICAjdW5kZWYgVkVSSUZZX09QQ09ERV9JRAogCiAjaWYgSEFWRShDT01Q VVRFRF9HT1RPKQorI2lmIENPTVBJTEVSKFJWQ1QpCisgICAgdHlwZWRlZiB2b2lkKiBPcGNvZGU7 CisjZWxzZQogICAgIHR5cGVkZWYgY29uc3Qgdm9pZCogT3Bjb2RlOworI2VuZGlmCiAjZWxzZQog ICAgIHR5cGVkZWYgT3Bjb2RlSUQgT3Bjb2RlOwogI2VuZGlmCg== 47128 2010-01-21 09:29:03 -0800 2010-01-21 10:55:14 -0800 New patch with changelog. 33902.patch text/plain 877 lyon.chen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjYTNlMDgzLi45ZDAyODliIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTAtMDEtMjEgIEx5b24gQ2hlbiAgPGxpYWNoZW5AcmltLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcGNvZGUuaCB1c2UgY29uc3Qg dm9pZCogZm9yIE9wY29kZSBjYXVzZSBlcnJvciAjMTIxMSBmb3IgUlZDVCBjb21waWxlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5MDIKKworICAg ICAgICAqIGJ5dGVjb2RlL09wY29kZS5oOgorCiAyMDEwLTAxLTIwICBNYXJrIFJvd2UgIDxtcm93 ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmggYi9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUu aAppbmRleCBiMTExMTNiLi5lODhmMDUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9PcGNvZGUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaApAQCAt MTk2LDcgKzE5Niw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICN1bmRlZiBWRVJJRllfT1BDT0RF X0lECiAKICNpZiBIQVZFKENPTVBVVEVEX0dPVE8pCi0gICAgdHlwZWRlZiBjb25zdCB2b2lkKiBP cGNvZGU7CisgICAgdHlwZWRlZiB2b2lkKiBPcGNvZGU7CiAjZWxzZQogICAgIHR5cGVkZWYgT3Bj b2RlSUQgT3Bjb2RlOwogI2VuZGlmCg== 47131 2010-01-21 10:54:06 -0800 2010-01-26 20:20:44 -0800 New patch with RVCT flag. 33902rvct.patch text/plain 913 lyon.chen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjYTNlMDgzLi45ZDAyODliIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTAtMDEtMjEgIEx5b24gQ2hlbiAgPGxpYWNoZW5AcmltLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPcGNvZGUuaCB1c2UgY29uc3Qg dm9pZCogZm9yIE9wY29kZSBjYXVzZSBlcnJvciAjMTIxMSBmb3IgUlZDVCBjb21waWxlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM5MDIKKworICAg ICAgICAqIGJ5dGVjb2RlL09wY29kZS5oOgorCiAyMDEwLTAxLTIwICBNYXJrIFJvd2UgIDxtcm93 ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmggYi9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUu aAppbmRleCBiMTExMTNiLi5kOWIyMTUzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9PcGNvZGUuaAorKysgYi9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaApAQCAt MTk2LDcgKzE5NiwxMSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAjdW5kZWYgVkVSSUZZX09QQ09E RV9JRAogCiAjaWYgSEFWRShDT01QVVRFRF9HT1RPKQorI2lmIENPTVBJTEVSKFJWQ1QpCisgICAg dHlwZWRlZiB2b2lkKiBPcGNvZGU7CisjZWxzZQogICAgIHR5cGVkZWYgY29uc3Qgdm9pZCogT3Bj b2RlOworI2VuZGlmCiAjZWxzZQogICAgIHR5cGVkZWYgT3Bjb2RlSUQgT3Bjb2RlOwogI2VuZGlm Cg==