33900 2010-01-20 07:10:32 -0800 media/video-play-pause-exception.html is flaky (on GTK at least) 2010-01-20 09:31:38 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned darin oldest_to_newest 182782 0 pnormand 2010-01-20 07:10:32 -0800 In that test we try to play an empty <video> element. A timer is started after pause() has been called. I think it would be better to wait the pause event instead. 182783 1 47024 pnormand 2010-01-20 07:12:46 -0800 Created attachment 47024 Refactored the test to use the pause event instead of a timer. 182812 2 47024 darin 2010-01-20 08:29:44 -0800 Comment on attachment 47024 Refactored the test to use the pause event instead of a timer. > +<html> > +<body> This seems like a pointless change to me; including explicit HTML and body elements does not make our tests better. I assume it has no effect on the test. > + waitForEvent("pause", onpause); It seems to me we should call waitForEvent("pause") before calling video.play() and video.pause(). I would not have preserved the blank line at the end of the test created with consoleWrite. I would probably have used waitForEventTestAndEnd. Seems OK as is. r=me 182821 3 pnormand 2010-01-20 08:49:37 -0800 Oh I didn't know about waitForEventTestAndEnd. Perfect fit for this test indeed ;) 182830 4 pnormand 2010-01-20 09:31:38 -0800 Landed as r53550. Thanks for the review Darin! 47024 2010-01-20 07:12:46 -0800 2010-01-20 08:29:43 -0800 Refactored the test to use the pause event instead of a timer. Refactored-the-test-to-use-the-pause-event-instead.patch text/plain 2600 pnormand RnJvbSBmNWE1ZWU1YTEyMGRjNzhkODEzNTEwN2I5MDFkZWNiYjkxZWEwYTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIwIEphbiAyMDEwIDE2OjEyOjI1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g UmVmYWN0b3JlZCB0aGUgdGVzdCB0byB1c2UgdGhlIHBhdXNlIGV2ZW50IGluc3RlYWQgb2YgYSB0 aW1lci4KCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMTEgKysrKysrKysrKysKIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXktcGF1 c2UtZXhjZXB0aW9uLmh0bWwgfCAgIDExICsrKysrKy0tLS0tCiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZCAgICAgICAgICAgICAgICAgIHwgICAgMSAtCiAzIGZpbGVzIGNoYW5nZWQs IDE3IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGZhNjVjNzguLjZhMWQx NWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMS0yMCAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0d0a10gbWVkaWEvdmlkZW8tcGxheS1wYXVzZS1leGNlcHRpb24uaHRt bCBpcyBmbGFja3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMzOTAwCisKKyAgICAgICAgUmVmYWN0b3JlZCB0aGUgdGVzdCB0byB1c2UgdGhlIHBhdXNl IGV2ZW50IGluc3RlYWQgb2YgYSB0aW1lci4KKyAgICAgICAgKiBtZWRpYS92aWRlby1wbGF5LXBh dXNlLWV4Y2VwdGlvbi5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorCiAy MDEwLTAxLTIwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgW1F0XSBmYXN0L2ZyYW1lcy9zZXQtdW5sb2FkZWQtZnJhbWUtbG9jYXRpb24uaHRtbCB0aW1l ZCBvdXQgb24gUXQgTGludXggUmVsZWFzZSBCdWlsZCBCb3QKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL21lZGlhL3ZpZGVvLXBsYXktcGF1c2UtZXhjZXB0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1wbGF5LXBhdXNlLWV4Y2VwdGlvbi5odG1sCmluZGV4IGYyYzc3YWIuLjYzZGY0 OTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXktcGF1c2UtZXhjZXB0 aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheS1wYXVzZS1leGNlcHRp b24uaHRtbApAQCAtMSw0ICsxLDUgQEAKLQorPGh0bWw+Cis8Ym9keT4KIDx2aWRlbyBjb250cm9s cz48L3ZpZGVvPgogCiA8cD5WaWRlbyBoYXMgbm8gc3JjLiBUZXN0IHRoYXQgdGhlIHBsYXlpbmcg ZXZlbnQgaXMgbm90IGRpc3BhdGNoZWQuPC9wPgpAQCAtOSwxOCArMTAsMTggQEAKIAogICAgIHdh aXRGb3JFdmVudCgibG9hZHN0YXJ0Iik7CiAgICAgd2FpdEZvckV2ZW50KCJ0aW1ldXBkYXRlIik7 Ci0gICAgd2FpdEZvckV2ZW50KCJwYXVzZSIpOwogICAgIHdhaXRGb3JFdmVudCgid2FpdGluZyIp OwogCiAgICAgcnVuKCJ2aWRlby5wbGF5KCkiKTsKICAgICBydW4oInZpZGVvLnBhdXNlKCkiKTsK IAotICAgIGZ1bmN0aW9uIHNvbWVUaW1lTGF0ZXIoKQorICAgIGZ1bmN0aW9uIG9ucGF1c2UoKQog ICAgIHsKICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5uZXR3b3JrU3RhdGUiLCBIVE1MTWVk aWFFbGVtZW50Lk5FVFdPUktfRU1QVFkpOwogICAgICAgICBlbmRUZXN0KCk7CiAgICAgICAgIGNv bnNvbGVXcml0ZSgiIik7CiAgICAgIH0KLSAgICAKLSAgICBzZXRUaW1lb3V0KHNvbWVUaW1lTGF0 ZXIsIDQwMCkgCisgICAgd2FpdEZvckV2ZW50KCJwYXVzZSIsIG9ucGF1c2UpOwogPC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv U2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IDAwZjgyNWUu LjZjMDNhNmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC01NTY5LDcgKzU1NjksNiBA QCBmYXN0L2Nzcy9vcGFjaXR5LWZsb2F0Lmh0bWwKICMgTWVkaWEgdGVzdHMgdGhhdCBrZWVwIGZh aWxpbmcgb24gdGhlIGJvdAogbWVkaWEvdmlkZW8tY3VycmVudFRpbWUtc2V0Lmh0bWwKIG1lZGlh L3ZpZGVvLXBsYXktcGF1c2UtZXZlbnRzLmh0bWwKLW1lZGlhL3ZpZGVvLXBsYXktcGF1c2UtZXhj ZXB0aW9uLmh0bWwKIAogIyBOZXcgZXZlbnRzIGZhaWxpbmc7IHNlZSBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjg4MjMKIGZhc3QvZXZlbnRzL3BhZ2VzaG93LXBhZ2Vo aWRlLW9uLWJhY2stY2FjaGVkLmh0bWwKLS0gCjEuNi4zLjM=