33889 2010-01-20 02:44:29 -0800 autobuffer value not forwarded media element to MediaPlayer 2010-01-27 00:40:20 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 30004 1 pnormand webkit-unassigned oldest_to_newest 182688 0 pnormand 2010-01-20 02:44:29 -0800 In HTMLMediaElement parseMappedAttribute() forwards autobuffer only if m_player has been created. m_player.setAutobuffer() should also be called just after the m_player has been created too (in loadResource()). 182796 1 47032 pnormand 2010-01-20 07:42:40 -0800 Created attachment 47032 Forward autobuffer value to MediaPlayer instance. 182810 2 47032 darin 2010-01-20 08:22:12 -0800 Comment on attachment 47032 Forward autobuffer value to MediaPlayer instance. Code change looks great. We normally require test cases or an explanation of why a test case is lacking. Since nobody is doing anything with the autobuffer flag right now, at least as far as I can tell with grep, I guess that's not possible here. 182814 3 pnormand 2010-01-20 08:31:21 -0800 Well there is a test for autobuffer but it checks only the DOM attributes. After this patch I thought it would also be good for the MediaPlayer to call setAutobuffer() on its media engine after loading an url. Otherwise each media engine implementing setAutoBuffer() would need to manually call it. What do think? I am fine with sending an updated patch. BTW I need this for Bug 30004 ;) 184253 4 47341 pnormand 2010-01-25 05:11:33 -0800 Created attachment 47341 updated patch 184778 5 47341 eric 2010-01-26 15:04:18 -0800 Comment on attachment 47341 updated patch How do we test this? Looks sane, but all changes should have tests or explanation as to why testing is impossible. 184984 6 pnormand 2010-01-27 00:40:20 -0800 (In reply to comment #5) > (From update of attachment 47341 [details]) > How do we test this? Looks sane, but all changes should have tests or > explanation as to why testing is impossible. Well I am still new to this but I didn't see unittests for the MediaPlayer, maybe it would make sense to have some? The MediaPlayerPrivate implementations are not unittested either, afaics. Anyway I landed this patch as r53910. I will think about unittesting the MediaPlayer at least. 47032 2010-01-20 07:42:40 -0800 2010-01-25 05:11:33 -0800 Forward autobuffer value to MediaPlayer instance. Forward-autobuffer-value-to-MediaPlayer-instance.patch text/plain 1466 pnormand RnJvbSBjODYwODc2YWQ5ODQ2ZjkzZjQ4YWU0ZDFkNWFjMThkZWYxMjEyNDY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIwIEphbiAyMDEwIDEzOjAyOjI3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Rm9yd2FyZCBhdXRvYnVmZmVyIHZhbHVlIHRvIE1lZGlhUGxheWVyIGluc3RhbmNlLgoKLS0tCiBX ZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiBXZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgfCAgICAxICsKIDIgZmlsZXMgY2hhbmdlZCwg MTIgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQyYWI0MDQuLmI1MGJjYmMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTAtMDEtMjAgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGF1 dG9idWZmZXIgdmFsdWUgbm90IGZvcndhcmRlZCBtZWRpYSBlbGVtZW50IHRvIE1lZGlhUGxheWVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzg4OQor CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSk6IEZvcndhcmQgYXV0b2J1ZmZlcgorICAg ICAgICB2YWx1ZSB0byBNZWRpYVBsYXllciBpbnN0YW5jZS4KKwogMjAxMC0wMS0yMCAgU3RldmUg QmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAg Yi9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggMDFiMGZhZS4uYWUwMmU1 NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNTcxLDYgKzU3MSw3IEBAIHZvaWQg SFRNTE1lZGlhRWxlbWVudDo6bG9hZFJlc291cmNlKGNvbnN0IEtVUkwmIGluaXRpYWxVUkwsIENv bnRlbnRUeXBlJiBjb250ZW50CiAgICAgICAgIG1fcGxheWVyID0gTWVkaWFQbGF5ZXI6OmNyZWF0 ZSh0aGlzKTsKICNlbmRpZgogCisgICAgbV9wbGF5ZXItPnNldEF1dG9idWZmZXIoYXV0b2J1ZmZl cigpKTsKICAgICBtX3BsYXllci0+c2V0UHJlc2VydmVzUGl0Y2gobV93ZWJraXRQcmVzZXJ2ZXNQ aXRjaCk7CiAgICAgdXBkYXRlVm9sdW1lKCk7CiAKLS0gCjEuNi4zLjM= 47341 2010-01-25 05:11:33 -0800 2010-01-26 15:04:18 -0800 updated patch updated-patch.patch text/plain 2251 pnormand RnJvbSA4NDA0ZDVkYTgyMjQwOTNhNDliYjhhZDhhODUzNGZiNzI2MWE1YWJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIwIEphbiAyMDEwIDEzOjAyOjI3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g dXBkYXRlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcCAgICAgICAgIHwgICAgMSArCiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmNwcCB8ICAgIDMgKystCiAzIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNWY2N2ViLi4yNjlkYmE3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTAxLTI1 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhdXRvYnVmZmVyIHZhbHVlIG5vdCBm b3J3YXJkZWQgbWVkaWEgZWxlbWVudCB0byBNZWRpYVBsYXllcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4ODkKKworICAgICAgICAqIGh0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojps b2FkUmVzb3VyY2UpOiBGb3J3YXJkIGF1dG9idWZmZXIKKyAgICAgICAgdmFsdWUgdG8gTWVkaWFQ bGF5ZXIgaW5zdGFuY2UuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXI6OmxvYWQpOiBGb3J3YXJkIGF1dG9i dWZmZXIgYW5kCisgICAgICAgIHByZXNlcnZlc1BpdGNoIHZhbHVlcyB0byBuZXdseSBjcmVhdGVk IHBsYXRmb3JtIG1lZGlhIHBsYXllciBpbnN0YW5jZS4KKwogMjAxMC0wMS0yNCAgRXJpYyBDYXJs c29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw IGIvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGQxYmVjODAuLjVjZDAx NTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAorKysgYi9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTU4Niw2ICs1ODYsNyBAQCB2b2lk IEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zdCBLVVJMJiBpbml0aWFsVVJMLCBD b250ZW50VHlwZSYgY29udGVudAogICAgICAgICBtX3BsYXllciA9IE1lZGlhUGxheWVyOjpjcmVh dGUodGhpcyk7CiAjZW5kaWYKIAorICAgIG1fcGxheWVyLT5zZXRBdXRvYnVmZmVyKGF1dG9idWZm ZXIoKSk7CiAgICAgbV9wbGF5ZXItPnNldFByZXNlcnZlc1BpdGNoKG1fd2Via2l0UHJlc2VydmVz UGl0Y2gpOwogICAgIHVwZGF0ZVZvbHVtZSgpOwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv TWVkaWFQbGF5ZXIuY3BwCmluZGV4IGMyNmEyNmYuLjk5NGM3YjYgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCkBAIC0yNDUsNyArMjQ1LDggQEAgdm9pZCBNZWRp YVBsYXllcjo6bG9hZChjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgQ29udGVudFR5cGUmIGNvbnRl bnRUeXBlKQogI2lmIEVOQUJMRShQTFVHSU5fUFJPWFlfRk9SX1ZJREVPKQogICAgICAgICBtX3By aXZhdGUtPnNldE1lZGlhUGxheWVyUHJveHkobV9wbGF5ZXJQcm94eSk7CiAjZW5kaWYKLQorICAg ICAgICBtX3ByaXZhdGUtPnNldEF1dG9idWZmZXIoYXV0b2J1ZmZlcigpKTsKKyAgICAgICAgbV9w cml2YXRlLT5zZXRQcmVzZXJ2ZXNQaXRjaChwcmVzZXJ2ZXNQaXRjaCgpKTsKICAgICB9CiAKICAg ICBpZiAobV9wcml2YXRlKQotLSAKMS42LjMuMw==