33884 2010-01-19 23:16:04 -0800 [Chromium] spurious WebViewClient::didStopLoading if changing location.hash while a subframe is still loading 2010-03-06 07:14:09 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd commit-queue webkit.review.bot oldest_to_newest 182624 0 fishd 2010-01-19 23:16:04 -0800 [Chromium] spurious WebViewClient::didStopLoading if changing location.hash while a subframe is still loading The code in dispatchDidChangeLocationWithinPage needs to check more than just the isLoading state of the main frame. It needs to also check if any subframes are loading. 183347 1 47152 fishd 2010-01-21 15:28:49 -0800 Created attachment 47152 v1 patch There isn't a mechanism to verify WebViewClient::did{Start,Stop}Loading notifications using DRT. I plan to write a test for this in the Chromium repository, leveraging the TestShellTests framework. 183348 2 webkit.review.bot 2010-01-21 15:31:58 -0800 Attachment 47152 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:1681: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 If any of these errors are false positives, please file a bug against check-webkit-style. 183404 3 47161 fishd 2010-01-21 17:11:06 -0800 Created attachment 47161 v2 patch (fixes style issue) 183700 4 fishd 2010-01-22 10:50:24 -0800 Landed as http://trac.webkit.org/changeset/53705 184682 5 fishd 2010-01-26 12:50:31 -0800 This change was reverted (http://trac.webkit.org/changeset/53747) due to Chromium test failures. 184683 6 fishd 2010-01-26 12:51:46 -0800 It turns out that we sometimes get a didStartLoading before didStopLoading. This happens when loading error pages. It may also be possible for script to trigger this case, but I haven't studied this fully. At any rate, I think this means that I need a less aggressive solution. 187140 7 47161 eric 2010-02-02 14:13:08 -0800 Comment on attachment 47161 v2 patch (fixes style issue) Marking this patch r- since it was reverted. 196650 8 50118 fishd 2010-03-05 14:07:05 -0800 Created attachment 50118 v1 patch This is a less aggressive solution. Just check to see if any subframes are also loading. isLoadingInAPISense checks this frame as well as any of its subframes, which is exactly what we want. 196907 9 50118 commit-queue 2010-03-06 07:14:04 -0800 Comment on attachment 50118 v1 patch Clearing flags on attachment: 50118 Committed r55625: <http://trac.webkit.org/changeset/55625> 196908 10 commit-queue 2010-03-06 07:14:09 -0800 All reviewed patches have been landed. Closing bug. 47152 2010-01-21 15:28:49 -0800 2010-01-21 17:11:06 -0800 v1 patch loading_1.txt text/plain 6049 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1MzY1NikKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMS0yMSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gc3B1cmlvdXMgV2ViVmlld0NsaWVu dDo6ZGlkU3RvcExvYWRpbmcgaWYgY2hhbmdpbmcKKyAgICAgICAgbG9jYXRpb24uaGFzaCB3aGls ZSBhIHN1YmZyYW1lIGlzIHN0aWxsIGxvYWRpbmcKKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4ODQKKworICAgICAgICBUaGlzIGlzIGEgcmVmaW5l bWVudCBvZiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81MTU0OAorCisgICAgICAg ICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1l TG9hZGVyQ2xpZW50SW1wbDo6ZGlzcGF0Y2hEaWRDaGFuZ2VMb2NhdGlvbldpdGhpblBhZ2UpOgor ICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc1N0YXJ0 ZWROb3RpZmljYXRpb24pOgorICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6 OnBvc3RQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uKToKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6V2ViVmlld0ltcGwpOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6ZGlkU3RhcnRMb2FkaW5nKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OmRpZFN0b3BMb2FkaW5nKToKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuaDoKKwogMjAxMC0wMS0yMSAgRXJpYyBVaHJoYW5lICA8ZXJpY3VAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRyeSBUaXRvdi4KSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdl YktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNTM2 NTEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU0NiwxNiArNTQ2LDEwIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJ bXBsOjpkaXNwYXRjaERpZEMKICAgICAvLyBzb21lIGV2ZW50cyBmb3Igb3VyIGRlbGVnYXRlLgog ICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3ID0gbV93ZWJGcmFtZS0+dmlld0ltcGwoKTsKIAotICAg IC8vIEZsYWcgb2Ygd2hldGhlciBmcmFtZSBsb2FkZXIgaXMgY29tcGxldGVkLiBHZW5lcmF0ZSBk aWRTdGFydExvYWRpbmcgYW5kCi0gICAgLy8gZGlkU3RvcExvYWRpbmcgb25seSB3aGVuIGxvYWRl ciBpcyBjb21wbGV0ZWQgc28gdGhhdCB3ZSBkb24ndCBmaXJlCi0gICAgLy8gdGhlbSBmb3IgZnJh Z21lbnQgcmVkaXJlY3Rpb24gdGhhdCBoYXBwZW5zIGluIHdpbmRvdy5vbmxvYWQgaGFuZGxlci4K LSAgICAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODM4 Ci0gICAgYm9vbCBsb2FkZXJDb21wbGV0ZWQgPQotICAgICAgICAhbV93ZWJGcmFtZS0+ZnJhbWUo KS0+cGFnZSgpLT5tYWluRnJhbWUoKS0+bG9hZGVyKCktPmlzTG9hZGluZygpOwotCi0gICAgLy8g R2VuZXJhdGUgZGlkU3RhcnRMb2FkaW5nIGlmIGxvYWRlciBpcyBjb21wbGV0ZWQuCi0gICAgaWYg KHdlYlZpZXctPmNsaWVudCgpICYmIGxvYWRlckNvbXBsZXRlZCkKLSAgICAgICAgd2ViVmlldy0+ Y2xpZW50KCktPmRpZFN0YXJ0TG9hZGluZygpOworICAgIC8vIEl0IGlzIHBvc3NpYmxlIGZvciBh IGZyYWdtZW50IHJlZGlyZWN0aW9uIHRvIG9jY3VyIGFmdGVyIHRoZSBwYWdlIGhhcworICAgIC8v IGZ1bGx5IGxvYWRlZCwgc28gd2UgbWF5IG5lZWQgdG8gc3ludGhlc2l6ZSBkaWRTdGFydExvYWRp bmcgYW5kCisgICAgLy8gZGlkU3RvcExvYWRpbmcuICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxODM4CisgICAgd2ViVmlldy0+ZGlkU3RhcnRMb2FkaW5nKCk7 CiAKICAgICBXZWJEYXRhU291cmNlSW1wbCogZHMgPSBtX3dlYkZyYW1lLT5kYXRhU291cmNlSW1w bCgpOwogICAgIEFTU0VSVChkcyk7ICAvLyBTaG91bGQgbm90IGJlIG51bGwgd2hlbiBuYXZpZ2F0 aW5nIHRvIGEgcmVmZXJlbmNlIGZyYWdtZW50IQpAQCAtNjAwLDkgKzU5NCw3IEBAIHZvaWQgRnJh bWVMb2FkZXJDbGllbnRJbXBsOjpkaXNwYXRjaERpZEMKICAgICBpZiAobV93ZWJGcmFtZS0+Y2xp ZW50KCkpCiAgICAgICAgIG1fd2ViRnJhbWUtPmNsaWVudCgpLT5kaWRDaGFuZ2VMb2NhdGlvbldp dGhpblBhZ2UobV93ZWJGcmFtZSwgaXNOZXdOYXZpZ2F0aW9uKTsKIAotICAgIC8vIEdlbmVyYXRl IGRpZFN0b3BMb2FkaW5nIGlmIGxvYWRlciBpcyBjb21wbGV0ZWQuCi0gICAgaWYgKHdlYlZpZXct PmNsaWVudCgpICYmIGxvYWRlckNvbXBsZXRlZCkKLSAgICAgICAgd2ViVmlldy0+Y2xpZW50KCkt PmRpZFN0b3BMb2FkaW5nKCk7CisgICAgd2ViVmlldy0+ZGlkU3RvcExvYWRpbmcoKTsKIH0KIAog dm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkUHVzaFN0YXRlV2l0aGluUGFn ZSgpCkBAIC05NzQsOSArOTY2LDkgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnNldE1h aW5Eb2N1bQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6cG9zdFByb2dyZXNzU3RhcnRl ZE5vdGlmaWNhdGlvbigpCiB7Ci0gICAgV2ViVmlld0ltcGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1l LT52aWV3SW1wbCgpOwotICAgIGlmICh3ZWJ2aWV3ICYmIHdlYnZpZXctPmNsaWVudCgpKQotICAg ICAgICB3ZWJ2aWV3LT5jbGllbnQoKS0+ZGlkU3RhcnRMb2FkaW5nKCk7CisgICAgV2ViVmlld0lt cGwqIHdlYlZpZXcgPSBtX3dlYkZyYW1lLT52aWV3SW1wbCgpOworICAgIGlmICh3ZWJWaWV3KQor ICAgICAgICB3ZWJWaWV3LT5kaWRTdGFydExvYWRpbmcoKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRl ckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc0VzdGltYXRlQ2hhbmdlZE5vdGlmaWNhdGlvbigpCkBA IC05ODcsOSArOTc5LDkgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVz cwogdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc0ZpbmlzaGVkTm90aWZp Y2F0aW9uKCkKIHsKICAgICAvLyBGSVhNRTogd2h5IG1pZ2h0IHRoZSB3ZWJ2aWV3IGJlIG51bGw/ ICBodHRwOi8vYi8xMjM0NDYxCi0gICAgV2ViVmlld0ltcGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1l LT52aWV3SW1wbCgpOwotICAgIGlmICh3ZWJ2aWV3ICYmIHdlYnZpZXctPmNsaWVudCgpKQotICAg ICAgICB3ZWJ2aWV3LT5jbGllbnQoKS0+ZGlkU3RvcExvYWRpbmcoKTsKKyAgICBXZWJWaWV3SW1w bCogd2ViVmlldyA9IG1fd2ViRnJhbWUtPnZpZXdJbXBsKCk7CisgICAgaWYgKHdlYlZpZXcpCisg ICAgICAgIHdlYlZpZXctPmRpZFN0b3BMb2FkaW5nKCk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJD bGllbnRJbXBsOjpzZXRNYWluRnJhbWVEb2N1bWVudFJlYWR5KGJvb2wgcmVhZHkpCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA1MzY1MSkKKysrIFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDAsNiAr MjAwLDcgQEAgV2ViVmlld0ltcGw6OldlYlZpZXdJbXBsKFdlYlZpZXdDbGllbnQqIAogI2lmbmRl ZiBOREVCVUcKICAgICAsIG1fbmV3TmF2aWdhdGlvbkxvYWRlcigwKQogI2VuZGlmCisgICAgLCBt X2lzTG9hZGluZygwKQogICAgICwgbV96b29tTGV2ZWwoMCkKICAgICAsIG1fY29udGV4dE1lbnVB bGxvd2VkKGZhbHNlKQogICAgICwgbV9kb2luZ0RyYWdBbmREcm9wKGZhbHNlKQpAQCAtMTY2Nyw2 ICsxNjY4LDIyIEBAIHZvaWQgV2ViVmlld0ltcGw6OmRpZENvbW1pdExvYWQoYm9vbCogaXMKICAg ICBtX29ic2VydmVkTmV3TmF2aWdhdGlvbiA9IGZhbHNlOwogfQogCit2b2lkIFdlYlZpZXdJbXBs OjpkaWRTdGFydExvYWRpbmcoKQoreworICAgIGlmICgrK21faXNMb2FkaW5nID09IDEpIHsKKyAg ICAgICAgaWYgKG1fY2xpZW50KQorICAgICAgICAgICAgbV9jbGllbnQtPmRpZFN0YXJ0TG9hZGlu ZygpOworICAgIH0KK30KKwordm9pZCBXZWJWaWV3SW1wbDo6ZGlkU3RvcExvYWRpbmcoKQorewor ICAgIGlmICgtLW1faXNMb2FkaW5nID09IDApIHsKKyAgICAgICAgaWYgKG1fY2xpZW50KQorICAg ICAgICAgICAgbV9jbGllbnQtPmRpZFN0b3BMb2FkaW5nKCk7CisgICAgfQorfQorCiBib29sIFdl YlZpZXdJbXBsOjpuYXZpZ2F0aW9uUG9saWN5RnJvbU1vdXNlRXZlbnQodW5zaWduZWQgc2hvcnQg YnV0dG9uLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJvb2wgY3RybCwgYm9vbCBzaGlmdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBib29sIGFsdCwgYm9vbCBtZXRhLApJbmRleDogV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiA1MzY1MSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDYgKzIyMywxMyBAQCBwdWJsaWM6 CiAgICAgLy8gbG9hZC4KICAgICB2b2lkIGRpZENvbW1pdExvYWQoYm9vbCogaXNOZXdOYXZpZ2F0 aW9uKTsKIAorICAgIC8vIE5vdGlmaWVzIHRoZSBXZWJWaWV3IHRoYXQgbG9hZGluZyBzdGFydGVk IG9yIHN0b3BwZWQuICBJdCBpcyBva2F5IHRvCisgICAgLy8gY2FsbCBkaWRTdGFydExvYWRpbmcg bXVsdGlwbGUgdGltZXMgYmVmb3JlIGNhbGxpbmcgZGlkU3RvcExvYWRpbmcuCisgICAgLy8gSG93 ZXZlciwgZGlkU3RvcExvYWRpbmcgbXVzdCBiZSBjYWxsZWQganVzdCBhcyBtYW55IHRpbWVzIGFz CisgICAgLy8gZGlkU3RhcnRMb2FkaW5nIGluIG9yZGVyIGZvciB0aGUgbG9hZGluZyBzdGF0ZSB0 byByZXR1cm4gdG8gZmFsc2UuCisgICAgdm9pZCBkaWRTdGFydExvYWRpbmcoKTsKKyAgICB2b2lk IGRpZFN0b3BMb2FkaW5nKCk7CisKICAgICBib29sIGNvbnRleHRNZW51QWxsb3dlZCgpIGNvbnN0 CiAgICAgewogICAgICAgICByZXR1cm4gbV9jb250ZXh0TWVudUFsbG93ZWQ7CkBAIC0zMjMsNiAr MzMwLDkgQEAgcHJpdmF0ZToKICAgICBjb25zdCBXZWJDb3JlOjpEb2N1bWVudExvYWRlciogbV9u ZXdOYXZpZ2F0aW9uTG9hZGVyOwogI2VuZGlmCiAKKyAgICAvLyBUaGlzIGNvdW50ZXIgaXMgbm9u LXplcm8gaWYgd2UgYXJlIGxvYWRpbmcuCisgICAgaW50IG1faXNMb2FkaW5nOworCiAgICAgLy8g QW4gb2JqZWN0IHRoYXQgY2FuIGJlIHVzZWQgdG8gbWFuaXB1bGF0ZSBtX3BhZ2UtPnNldHRpbmdz KCkgd2l0aG91dCBsaW5raW5nCiAgICAgLy8gYWdhaW5zdCBXZWJDb3JlLiAgVGhpcyBpcyBsYXpp bHkgYWxsb2NhdGVkIHRoZSBmaXJzdCB0aW1lIEdldFdlYlNldHRpbmdzKCkKICAgICAvLyBpcyBj YWxsZWQuCg== 47161 2010-01-21 17:11:06 -0800 2010-03-05 14:07:05 -0800 v2 patch (fixes style issue) loading_2.txt text/plain 6041 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1MzY1NikKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMS0yMSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gc3B1cmlvdXMgV2ViVmlld0NsaWVu dDo6ZGlkU3RvcExvYWRpbmcgaWYgY2hhbmdpbmcKKyAgICAgICAgbG9jYXRpb24uaGFzaCB3aGls ZSBhIHN1YmZyYW1lIGlzIHN0aWxsIGxvYWRpbmcKKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4ODQKKworICAgICAgICBUaGlzIGlzIGEgcmVmaW5l bWVudCBvZiBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81MTU0OAorCisgICAgICAg ICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1l TG9hZGVyQ2xpZW50SW1wbDo6ZGlzcGF0Y2hEaWRDaGFuZ2VMb2NhdGlvbldpdGhpblBhZ2UpOgor ICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc1N0YXJ0 ZWROb3RpZmljYXRpb24pOgorICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6 OnBvc3RQcm9ncmVzc0ZpbmlzaGVkTm90aWZpY2F0aW9uKToKKyAgICAgICAgKiBzcmMvV2ViVmll d0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6V2ViVmlld0ltcGwpOgor ICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6ZGlkU3RhcnRMb2FkaW5nKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OmRpZFN0b3BMb2FkaW5nKToKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuaDoKKwogMjAxMC0wMS0yMSAgRXJpYyBVaHJoYW5lICA8ZXJpY3VAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERtaXRyeSBUaXRvdi4KSW5kZXg6IFdlYktpdC9j aHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdl YktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNTM2 NTEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU0NiwxNiArNTQ2LDEwIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJ bXBsOjpkaXNwYXRjaERpZEMKICAgICAvLyBzb21lIGV2ZW50cyBmb3Igb3VyIGRlbGVnYXRlLgog ICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3ID0gbV93ZWJGcmFtZS0+dmlld0ltcGwoKTsKIAotICAg IC8vIEZsYWcgb2Ygd2hldGhlciBmcmFtZSBsb2FkZXIgaXMgY29tcGxldGVkLiBHZW5lcmF0ZSBk aWRTdGFydExvYWRpbmcgYW5kCi0gICAgLy8gZGlkU3RvcExvYWRpbmcgb25seSB3aGVuIGxvYWRl ciBpcyBjb21wbGV0ZWQgc28gdGhhdCB3ZSBkb24ndCBmaXJlCi0gICAgLy8gdGhlbSBmb3IgZnJh Z21lbnQgcmVkaXJlY3Rpb24gdGhhdCBoYXBwZW5zIGluIHdpbmRvdy5vbmxvYWQgaGFuZGxlci4K LSAgICAvLyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODM4 Ci0gICAgYm9vbCBsb2FkZXJDb21wbGV0ZWQgPQotICAgICAgICAhbV93ZWJGcmFtZS0+ZnJhbWUo KS0+cGFnZSgpLT5tYWluRnJhbWUoKS0+bG9hZGVyKCktPmlzTG9hZGluZygpOwotCi0gICAgLy8g R2VuZXJhdGUgZGlkU3RhcnRMb2FkaW5nIGlmIGxvYWRlciBpcyBjb21wbGV0ZWQuCi0gICAgaWYg KHdlYlZpZXctPmNsaWVudCgpICYmIGxvYWRlckNvbXBsZXRlZCkKLSAgICAgICAgd2ViVmlldy0+ Y2xpZW50KCktPmRpZFN0YXJ0TG9hZGluZygpOworICAgIC8vIEl0IGlzIHBvc3NpYmxlIGZvciBh IGZyYWdtZW50IHJlZGlyZWN0aW9uIHRvIG9jY3VyIGFmdGVyIHRoZSBwYWdlIGhhcworICAgIC8v IGZ1bGx5IGxvYWRlZCwgc28gd2UgbWF5IG5lZWQgdG8gc3ludGhlc2l6ZSBkaWRTdGFydExvYWRp bmcgYW5kCisgICAgLy8gZGlkU3RvcExvYWRpbmcuICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxODM4CisgICAgd2ViVmlldy0+ZGlkU3RhcnRMb2FkaW5nKCk7 CiAKICAgICBXZWJEYXRhU291cmNlSW1wbCogZHMgPSBtX3dlYkZyYW1lLT5kYXRhU291cmNlSW1w bCgpOwogICAgIEFTU0VSVChkcyk7ICAvLyBTaG91bGQgbm90IGJlIG51bGwgd2hlbiBuYXZpZ2F0 aW5nIHRvIGEgcmVmZXJlbmNlIGZyYWdtZW50IQpAQCAtNjAwLDkgKzU5NCw3IEBAIHZvaWQgRnJh bWVMb2FkZXJDbGllbnRJbXBsOjpkaXNwYXRjaERpZEMKICAgICBpZiAobV93ZWJGcmFtZS0+Y2xp ZW50KCkpCiAgICAgICAgIG1fd2ViRnJhbWUtPmNsaWVudCgpLT5kaWRDaGFuZ2VMb2NhdGlvbldp dGhpblBhZ2UobV93ZWJGcmFtZSwgaXNOZXdOYXZpZ2F0aW9uKTsKIAotICAgIC8vIEdlbmVyYXRl IGRpZFN0b3BMb2FkaW5nIGlmIGxvYWRlciBpcyBjb21wbGV0ZWQuCi0gICAgaWYgKHdlYlZpZXct PmNsaWVudCgpICYmIGxvYWRlckNvbXBsZXRlZCkKLSAgICAgICAgd2ViVmlldy0+Y2xpZW50KCkt PmRpZFN0b3BMb2FkaW5nKCk7CisgICAgd2ViVmlldy0+ZGlkU3RvcExvYWRpbmcoKTsKIH0KIAog dm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkUHVzaFN0YXRlV2l0aGluUGFn ZSgpCkBAIC05NzQsOSArOTY2LDkgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnNldE1h aW5Eb2N1bQogCiB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6cG9zdFByb2dyZXNzU3RhcnRl ZE5vdGlmaWNhdGlvbigpCiB7Ci0gICAgV2ViVmlld0ltcGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1l LT52aWV3SW1wbCgpOwotICAgIGlmICh3ZWJ2aWV3ICYmIHdlYnZpZXctPmNsaWVudCgpKQotICAg ICAgICB3ZWJ2aWV3LT5jbGllbnQoKS0+ZGlkU3RhcnRMb2FkaW5nKCk7CisgICAgV2ViVmlld0lt cGwqIHdlYlZpZXcgPSBtX3dlYkZyYW1lLT52aWV3SW1wbCgpOworICAgIGlmICh3ZWJWaWV3KQor ICAgICAgICB3ZWJWaWV3LT5kaWRTdGFydExvYWRpbmcoKTsKIH0KIAogdm9pZCBGcmFtZUxvYWRl ckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc0VzdGltYXRlQ2hhbmdlZE5vdGlmaWNhdGlvbigpCkBA IC05ODcsOSArOTc5LDkgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVz cwogdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnBvc3RQcm9ncmVzc0ZpbmlzaGVkTm90aWZp Y2F0aW9uKCkKIHsKICAgICAvLyBGSVhNRTogd2h5IG1pZ2h0IHRoZSB3ZWJ2aWV3IGJlIG51bGw/ ICBodHRwOi8vYi8xMjM0NDYxCi0gICAgV2ViVmlld0ltcGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1l LT52aWV3SW1wbCgpOwotICAgIGlmICh3ZWJ2aWV3ICYmIHdlYnZpZXctPmNsaWVudCgpKQotICAg ICAgICB3ZWJ2aWV3LT5jbGllbnQoKS0+ZGlkU3RvcExvYWRpbmcoKTsKKyAgICBXZWJWaWV3SW1w bCogd2ViVmlldyA9IG1fd2ViRnJhbWUtPnZpZXdJbXBsKCk7CisgICAgaWYgKHdlYlZpZXcpCisg ICAgICAgIHdlYlZpZXctPmRpZFN0b3BMb2FkaW5nKCk7CiB9CiAKIHZvaWQgRnJhbWVMb2FkZXJD bGllbnRJbXBsOjpzZXRNYWluRnJhbWVEb2N1bWVudFJlYWR5KGJvb2wgcmVhZHkpCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcA0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA1MzY1MSkKKysrIFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDAsNiAr MjAwLDcgQEAgV2ViVmlld0ltcGw6OldlYlZpZXdJbXBsKFdlYlZpZXdDbGllbnQqIAogI2lmbmRl ZiBOREVCVUcKICAgICAsIG1fbmV3TmF2aWdhdGlvbkxvYWRlcigwKQogI2VuZGlmCisgICAgLCBt X2lzTG9hZGluZygwKQogICAgICwgbV96b29tTGV2ZWwoMCkKICAgICAsIG1fY29udGV4dE1lbnVB bGxvd2VkKGZhbHNlKQogICAgICwgbV9kb2luZ0RyYWdBbmREcm9wKGZhbHNlKQpAQCAtMTY2Nyw2 ICsxNjY4LDIyIEBAIHZvaWQgV2ViVmlld0ltcGw6OmRpZENvbW1pdExvYWQoYm9vbCogaXMKICAg ICBtX29ic2VydmVkTmV3TmF2aWdhdGlvbiA9IGZhbHNlOwogfQogCit2b2lkIFdlYlZpZXdJbXBs OjpkaWRTdGFydExvYWRpbmcoKQoreworICAgIGlmICghbV9pc0xvYWRpbmcrKykgeworICAgICAg ICBpZiAobV9jbGllbnQpCisgICAgICAgICAgICBtX2NsaWVudC0+ZGlkU3RhcnRMb2FkaW5nKCk7 CisgICAgfQorfQorCit2b2lkIFdlYlZpZXdJbXBsOjpkaWRTdG9wTG9hZGluZygpCit7CisgICAg aWYgKCEtLW1faXNMb2FkaW5nKSB7CisgICAgICAgIGlmIChtX2NsaWVudCkKKyAgICAgICAgICAg IG1fY2xpZW50LT5kaWRTdG9wTG9hZGluZygpOworICAgIH0KK30KKwogYm9vbCBXZWJWaWV3SW1w bDo6bmF2aWdhdGlvblBvbGljeUZyb21Nb3VzZUV2ZW50KHVuc2lnbmVkIHNob3J0IGJ1dHRvbiwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGN0 cmwsIGJvb2wgc2hpZnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYm9vbCBhbHQsIGJvb2wgbWV0YSwKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuaAkocmV2aXNpb24gNTM2NTEpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTIyMyw2ICsyMjMsMTMgQEAgcHVibGljOgogICAgIC8v IGxvYWQuCiAgICAgdm9pZCBkaWRDb21taXRMb2FkKGJvb2wqIGlzTmV3TmF2aWdhdGlvbik7CiAK KyAgICAvLyBOb3RpZmllcyB0aGUgV2ViVmlldyB0aGF0IGxvYWRpbmcgc3RhcnRlZCBvciBzdG9w cGVkLiAgSXQgaXMgb2theSB0bworICAgIC8vIGNhbGwgZGlkU3RhcnRMb2FkaW5nIG11bHRpcGxl IHRpbWVzIGJlZm9yZSBjYWxsaW5nIGRpZFN0b3BMb2FkaW5nLgorICAgIC8vIEhvd2V2ZXIsIGRp ZFN0b3BMb2FkaW5nIG11c3QgYmUgY2FsbGVkIGp1c3QgYXMgbWFueSB0aW1lcyBhcworICAgIC8v IGRpZFN0YXJ0TG9hZGluZyBpbiBvcmRlciBmb3IgdGhlIGxvYWRpbmcgc3RhdGUgdG8gcmV0dXJu IHRvIGZhbHNlLgorICAgIHZvaWQgZGlkU3RhcnRMb2FkaW5nKCk7CisgICAgdm9pZCBkaWRTdG9w TG9hZGluZygpOworCiAgICAgYm9vbCBjb250ZXh0TWVudUFsbG93ZWQoKSBjb25zdAogICAgIHsK ICAgICAgICAgcmV0dXJuIG1fY29udGV4dE1lbnVBbGxvd2VkOwpAQCAtMzIzLDYgKzMzMCw5IEBA IHByaXZhdGU6CiAgICAgY29uc3QgV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXIqIG1fbmV3TmF2aWdh dGlvbkxvYWRlcjsKICNlbmRpZgogCisgICAgLy8gVGhpcyBjb3VudGVyIGlzIG5vbi16ZXJvIGlm IHdlIGFyZSBsb2FkaW5nLgorICAgIGludCBtX2lzTG9hZGluZzsKKwogICAgIC8vIEFuIG9iamVj dCB0aGF0IGNhbiBiZSB1c2VkIHRvIG1hbmlwdWxhdGUgbV9wYWdlLT5zZXR0aW5ncygpIHdpdGhv dXQgbGlua2luZwogICAgIC8vIGFnYWluc3QgV2ViQ29yZS4gIFRoaXMgaXMgbGF6aWx5IGFsbG9j YXRlZCB0aGUgZmlyc3QgdGltZSBHZXRXZWJTZXR0aW5ncygpCiAgICAgLy8gaXMgY2FsbGVkLgo= 50118 2010-03-05 14:07:05 -0800 2010-03-06 07:14:04 -0800 v1 patch load_1.txt text/plain 1518 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NTU5MikKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0wNSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gc3B1cmlvdXMgV2ViVmlld0NsaWVu dDo6ZGlkU3RvcExvYWRpbmcgaWYgY2hhbmdpbmcKKyAgICAgICAgbG9jYXRpb24uaGFzaCB3aGls ZSBhIHN1YmZyYW1lIGlzIHN0aWxsIGxvYWRpbmcKKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4ODQKKworICAgICAgICAqIHNyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6 OmRpc3BhdGNoRGlkQ2hhbmdlTG9jYXRpb25XaXRoaW5QYWdlKToKKyAgICAgICAgQ2FsbCBpc0xv YWRpbmdJbkFQSVNlbnNlLCB3aGljaCBjaGVja3Mgc3ViZnJhbWVzLgorCiAyMDEwLTAzLTA1ICBJ bHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFt ZUxvYWRlckNsaWVudEltcGwuY3BwCShyZXZpc2lvbiA1NTU5MikKKysrIFdlYktpdC9jaHJvbWl1 bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTc5LDcg KzU3OSw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpkaXNwYXRjaERpZEMKICAgICAv LyB0aGVtIGZvciBmcmFnbWVudCByZWRpcmVjdGlvbiB0aGF0IGhhcHBlbnMgaW4gd2luZG93Lm9u bG9hZCBoYW5kbGVyLgogICAgIC8vIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzE4MzgKICAgICBib29sIGxvYWRlckNvbXBsZXRlZCA9Ci0gICAgICAgICFtX3dl YkZyYW1lLT5mcmFtZSgpLT5wYWdlKCktPm1haW5GcmFtZSgpLT5sb2FkZXIoKS0+aXNMb2FkaW5n KCk7CisgICAgICAgICF3ZWJWaWV3LT5wYWdlKCktPm1haW5GcmFtZSgpLT5sb2FkZXIoKS0+YWN0 aXZlRG9jdW1lbnRMb2FkZXIoKS0+aXNMb2FkaW5nSW5BUElTZW5zZSgpOwogCiAgICAgLy8gR2Vu ZXJhdGUgZGlkU3RhcnRMb2FkaW5nIGlmIGxvYWRlciBpcyBjb21wbGV0ZWQuCiAgICAgaWYgKHdl YlZpZXctPmNsaWVudCgpICYmIGxvYWRlckNvbXBsZXRlZCkK