33881 2010-01-19 22:48:54 -0800 [Chromium] computePageRectsForFrame seems to be unnecessary 2010-01-20 00:26:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned hayato yuzo oldest_to_newest 182618 0 hamaji 2010-01-19 22:48:54 -0800 It seems the pagination is done in PrintContext::computePageRects in WebCore/page/PrintContext is responsible for pagination on Chromium (note that this function is used in WebKit/chromium/src/WebFrameImpl.cpp via ChromePrintContext, which is a subclass of PrintContext). So, WebCore::computePageRectsForFrame in WebCore/page/FrameChromium.cpp, which is almost as same as PrintContext::computePageRects, would be unnecessary. 182623 1 46981 hamaji 2010-01-19 23:14:13 -0800 Created attachment 46981 Patch v1 182651 2 46981 hamaji 2010-01-20 00:26:38 -0800 Comment on attachment 46981 Patch v1 Clearing flags on attachment: 46981 Committed r53527: <http://trac.webkit.org/changeset/53527> 182652 3 hamaji 2010-01-20 00:26:51 -0800 All reviewed patches have been landed. Closing bug. 46981 2010-01-19 23:14:13 -0800 2010-01-20 00:26:38 -0800 Patch v1 bug-33881-20100120161412.patch text/plain 6517 hamaji ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Njk0NzFiYy4uOWMyNDE3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMS0xOSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gY29tcHV0ZVBhZ2VSZWN0c0ZvckZyYW1l IHNlZW1zIHRvIGJlIHVubmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMzg4MQorCisgICAgICAgICogV2ViQ29yZS5neXBpOiBSZW1vdmVk IEZyYW1lQ2hyb21pdW0uaAorICAgICAgICAqIHBhZ2UvY2hyb21pdW0vRnJhbWVDaHJvbWl1bS5j cHA6IFJlbW92ZWQgY29tcHV0ZVBhZ2VSZWN0c0ZvckZyYW1lLgorICAgICAgICAqIHBhZ2UvY2hy b21pdW0vRnJhbWVDaHJvbWl1bS5oOiBSZW1vdmVkLgorCiAyMDEwLTAxLTE4ICBTdGV2ZSBCbG9j ayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9XZWJDb3JlL1dlYkNvcmUu Z3lwaQppbmRleCBhYTVmNTliLi4yNjI1OThjIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUu Z3lwaQorKysgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwaQpAQCAtMTczNyw3ICsxNzM3LDYgQEAKICAg ICAgICAgICAgICdwYWdlL2Nocm9taXVtL0RyYWdDb250cm9sbGVyQ2hyb21pdW0uY3BwJywKICAg ICAgICAgICAgICdwYWdlL2Nocm9taXVtL0V2ZW50SGFuZGxlckNocm9taXVtLmNwcCcsCiAgICAg ICAgICAgICAncGFnZS9jaHJvbWl1bS9GcmFtZUNocm9taXVtLmNwcCcsCi0gICAgICAgICAgICAn cGFnZS9jaHJvbWl1bS9GcmFtZUNocm9taXVtLmgnLAogICAgICAgICAgICAgJ3BhZ2UvZ3RrL0Ry YWdDb250cm9sbGVyR3RrLmNwcCcsCiAgICAgICAgICAgICAncGFnZS9ndGsvRXZlbnRIYW5kbGVy R3RrLmNwcCcsCiAgICAgICAgICAgICAncGFnZS9ndGsvRnJhbWVHdGsuY3BwJywKZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGFnZS9jaHJvbWl1bS9GcmFtZUNocm9taXVtLmNwcCBiL1dlYkNvcmUvcGFn ZS9jaHJvbWl1bS9GcmFtZUNocm9taXVtLmNwcAppbmRleCBkNzlhZTY4Li41NDhlMGZhIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRnJhbWVDaHJvbWl1bS5jcHAKKysrIGIvV2Vi Q29yZS9wYWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uY3BwCkBAIC0yNSw3ICsyNSw2IEBACiAg Ki8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIkZyYW1lQ2hyb21pdW0uaCIKIAog I2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRmxvYXRSZWN0LmgiCkBAIC0zNiw1NyAr MzUsNiBAQCB1c2luZyBzdGQ6Om1pbjsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIGNv bXB1dGVQYWdlUmVjdHNGb3JGcmFtZShGcmFtZSogZnJhbWUsIGNvbnN0IEludFJlY3QmIHByaW50 UmVjdCwgZmxvYXQgaGVhZGVySGVpZ2h0LCBmbG9hdCBmb290ZXJIZWlnaHQsIGZsb2F0IHVzZXJT Y2FsZUZhY3RvciwgVmVjdG9yPEludFJlY3Q+JiBwYWdlcywgaW50JiBvdXRQYWdlSGVpZ2h0KQot ewotICAgIEFTU0VSVChmcmFtZSk7Ci0KLSAgICBwYWdlcy5jbGVhcigpOwotICAgIG91dFBhZ2VI ZWlnaHQgPSAwOwotCi0gICAgaWYgKCFmcmFtZS0+ZG9jdW1lbnQoKSB8fCAhZnJhbWUtPnZpZXco KSB8fCAhZnJhbWUtPmRvY3VtZW50KCktPnJlbmRlcmVyKCkpCi0gICAgICAgIHJldHVybjsKLSAK LSAgICBSZW5kZXJWaWV3KiByb290ID0gdG9SZW5kZXJWaWV3KGZyYW1lLT5kb2N1bWVudCgpLT5y ZW5kZXJlcigpKTsKLQotICAgIGlmICghcm9vdCkgewotICAgICAgICBMT0dfRVJST1IoImRvY3Vt ZW50IHRvIGJlIHByaW50ZWQgaGFzIG5vIHJlbmRlcmVyIik7Ci0gICAgICAgIHJldHVybjsKLSAg ICB9Ci0KLSAgICBpZiAodXNlclNjYWxlRmFjdG9yIDw9IDApIHsKLSAgICAgICAgTE9HX0VSUk9S KCJ1c2VyU2NhbGVGYWN0b3IgaGFzIGJhZCB2YWx1ZSAlLjJmIiwgdXNlclNjYWxlRmFjdG9yKTsK LSAgICAgICAgcmV0dXJuOwotICAgIH0KLSAgICAKLSAgICBmbG9hdCByYXRpbyA9IHN0YXRpY19j YXN0PGZsb2F0PihwcmludFJlY3QuaGVpZ2h0KCkpIC8gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHByaW50 UmVjdC53aWR0aCgpKTsKLSAKLSAgICBmbG9hdCBwYWdlV2lkdGggID0gc3RhdGljX2Nhc3Q8Zmxv YXQ+KHJvb3QtPnJpZ2h0TGF5b3V0T3ZlcmZsb3coKSk7Ci0gICAgZmxvYXQgcGFnZUhlaWdodCA9 IHBhZ2VXaWR0aCAqIHJhdGlvOwotICAgIG91dFBhZ2VIZWlnaHQgPSBzdGF0aWNfY2FzdDxpbnQ+ KHBhZ2VIZWlnaHQpOyAgIC8vIHRoaXMgaXMgdGhlIGhlaWdodCBvZiB0aGUgcGFnZSBhZGp1c3Rl ZCBieSBtYXJnaW5zCi0gICAgcGFnZUhlaWdodCAtPSAoaGVhZGVySGVpZ2h0ICsgZm9vdGVySGVp Z2h0KTsKLQotICAgIGlmIChwYWdlSGVpZ2h0IDw9IDApIHsKLSAgICAgICAgTE9HX0VSUk9SKCJw YWdlSGVpZ2h0IGhhcyBiYWQgdmFsdWUgJS4yZiIsIHBhZ2VIZWlnaHQpOwotICAgICAgICByZXR1 cm47Ci0gICAgfQotCi0gICAgZmxvYXQgY3VyclBhZ2VIZWlnaHQgPSBwYWdlSGVpZ2h0IC8gdXNl clNjYWxlRmFjdG9yOwotICAgIGZsb2F0IGRvY0hlaWdodCAgICAgID0gcm9vdC0+bGF5ZXIoKS0+ aGVpZ2h0KCk7Ci0gICAgZmxvYXQgY3VyclBhZ2VXaWR0aCAgPSBwYWdlV2lkdGggLyB1c2VyU2Nh bGVGYWN0b3I7Ci0KLSAgICAKLSAgICAvLyBhbHdheXMgcmV0dXJuIGF0IGxlYXN0IG9uZSBwYWdl LCBzaW5jZSBlbXB0eSBmaWxlcyBzaG91bGQgcHJpbnQgYSBibGFuayBwYWdlCi0gICAgZmxvYXQg cHJpbnRlZFBhZ2VzSGVpZ2h0ID0gMC4wZjsKLSAgICBkbyB7Ci0gICAgICAgIGZsb2F0IHByb3Bv c2VkQm90dG9tID0gbWluKGRvY0hlaWdodCwgcHJpbnRlZFBhZ2VzSGVpZ2h0ICsgcGFnZUhlaWdo dCk7Ci0gICAgICAgIGZyYW1lLT52aWV3KCktPmFkanVzdFBhZ2VIZWlnaHQoJnByb3Bvc2VkQm90 dG9tLCBwcmludGVkUGFnZXNIZWlnaHQsIHByb3Bvc2VkQm90dG9tLCBwcmludGVkUGFnZXNIZWln aHQpOwotICAgICAgICBjdXJyUGFnZUhlaWdodCA9IG1heCgxLjBmLCBwcm9wb3NlZEJvdHRvbSAt IHByaW50ZWRQYWdlc0hlaWdodCk7Ci0gICAgICAgCi0gICAgICAgIHBhZ2VzLmFwcGVuZChJbnRS ZWN0KDAsIHByaW50ZWRQYWdlc0hlaWdodCwgY3VyclBhZ2VXaWR0aCwgY3VyclBhZ2VIZWlnaHQp KTsKLSAgICAgICAgcHJpbnRlZFBhZ2VzSGVpZ2h0ICs9IGN1cnJQYWdlSGVpZ2h0OwotICAgIH0g d2hpbGUgKHByaW50ZWRQYWdlc0hlaWdodCA8IGRvY0hlaWdodCk7Ci19Ci0KIERyYWdJbWFnZVJl ZiBGcmFtZTo6ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKCkKIHsgICAgCiAgICAgaWYgKHNlbGVjdGlv bigpLT5pc1JhbmdlKCkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvY2hyb21pdW0vRnJhbWVD aHJvbWl1bS5oIGIvV2ViQ29yZS9wYWdlL2Nocm9taXVtL0ZyYW1lQ2hyb21pdW0uaApkZWxldGVk IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZmFhNzhlNy4uMDAwMDAwMAotLS0gYS9XZWJDb3JlL3Bh Z2UvY2hyb21pdW0vRnJhbWVDaHJvbWl1bS5oCisrKyAvZGV2L251bGwKQEAgLTEsMzkgKzAsMCBA QAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNiwgMjAwNyBBcHBsZSBJbmMuICBBbGwgcmlnaHRz IHJlc2VydmVkLgotICogQ29weXJpZ2h0IChDKSAyMDA4IEdvb2dsZSBJbmMuCi0gKgotICogUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMKLSAqIGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMg b2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90 aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVy LgotICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRo ZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24g YW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0g KgotICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5DLiBg YEFTIElTJycgQU5EIEFOWQotICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xV RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKLSAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBN RVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgotICogUFVSUE9TRSBB UkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMuIE9S Ci0gKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5D SURFTlRBTCwgU1BFQ0lBTCwKLSAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VT IChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSAqIFBST0NVUkVNRU5UIE9GIFNVQlNU SVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgotICogUFJPRklU UzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRI RU9SWQotICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklM SVRZLCBPUiBUT1JUCi0gKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklT SU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKLSAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuIAotICovCi0KLSNp Zm5kZWYgRnJhbWVDaHJvbWl1bV9oCi0jZGVmaW5lIEZyYW1lQ2hyb21pdW1faAotCi0jaW5jbHVk ZSAiRnJhbWUuaCIKLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi0gICAgLy8gcHJpbnRSZWN0IGlz IG9ubHkgdXNlZCBmb3IgdGhlIHdpZHRoL2hlaWdodCByYXRpby4gVGhlaXIgYWJzb2x1dGUgdmFs dWVzIGFyZW4ndCB1c2VkLgotICAgIHZvaWQgY29tcHV0ZVBhZ2VSZWN0c0ZvckZyYW1lKEZyYW1l KiwgY29uc3QgSW50UmVjdCYgcHJpbnRSZWN0LCBmbG9hdCBoZWFkZXJIZWlnaHQsIGZsb2F0IGZv b3RlckhlaWdodCwgZmxvYXQgdXNlclNjYWxlRmFjdG9yLCBWZWN0b3I8SW50UmVjdD4mIHBhZ2Vz LCBpbnQmIHBhZ2VIZWlnaHQpOwotCi19Ci0KLSNlbmRpZgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjZiOWVi Ny4uYmIxMTQ5MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEtMTkgIFNo aW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIGNvbXB1dGVQYWdlUmVj dHNGb3JGcmFtZSBzZWVtcyB0byBiZSB1bm5lY2Vzc2FyeQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4ODEKKworICAgICAgICAqIHNyYy9XZWJGcmFt ZUltcGwuY3BwOiBTdG9wIGluY2x1ZGluZyBGcmFtZUNocm9taXVtLmgKKwogMjAxMC0wMS0xOCAg Sm9uYXRoYW4gRGl4b24gIDxqb3RoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IDI5M2Q3 ZWUuLjI4YzI3Y2MgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBs LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTg0LDcg Kzg0LDYgQEAKICNpbmNsdWRlICJFZGl0b3IuaCIKICNpbmNsdWRlICJFdmVudEhhbmRsZXIuaCIK ICNpbmNsdWRlICJGb3JtU3RhdGUuaCIKLSNpbmNsdWRlICJGcmFtZUNocm9taXVtLmgiCiAjaW5j bHVkZSAiRnJhbWVMb2FkZXIuaCIKICNpbmNsdWRlICJGcmFtZUxvYWRSZXF1ZXN0LmgiCiAjaW5j bHVkZSAiRnJhbWVUcmVlLmgiCg==