33878 2010-01-19 20:08:56 -0800 Add ThreadSpecific for for ENABLE(SINGLE_THREADED) 2010-01-21 23:36:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned ap commit-queue eric oldest_to_newest 182592 0 skyul 2010-01-19 20:08:56 -0800 When ENABLE(SINGLE_THREADED) is true, ThreadSpecific can be replaced with a simple getter/setter. Due to the change in https://bugs.webkit.org/show_bug.cgi?id=33236, an implementation of ThreadSpecific must be available to build WebKit. This causes a build failure for platforms without a proper ThreadSpecific implementation. 182596 1 46971 skyul 2010-01-19 20:16:23 -0800 Created attachment 46971 Implement ThreadSpecific with a simple getter/setter for ENABLE(SINGLE_THREADED) 183386 2 eric 2010-01-21 16:51:26 -0800 I think Alexey is your best reviewer here. 183398 3 ap 2010-01-21 17:00:57 -0800 The implementation looks fine, but I don't understand what ENABLE(SINGLE_THREADED) means. Is it about thread use in WebCore? If so, why do JSC-only changes made in bug 33236 make this patch necessary? 183459 4 skyul 2010-01-21 20:31:20 -0800 ENABLE(SINGLE_THREADED) is used mainly by Qt port and it means both JavaScriptCore and WebCore are single-threaded. As ThreadSpecific can be used by both JavaScriptCore and WebCore, checking only ENABLE(JSC_MULTIPLE_THREADS) is not correct here. Before 33236 is landed, ThreadSpecific was not used at all when some multi-threaded WebCore features such as database and workers are disabled. However, as the following code is added in 33236, an implementation of ThreadSpecific is required even for single-threaded WebKit build. #if ENABLE(JSC_MULTIPLE_THREADS) pthread_once_t createIdentifierTableSpecificOnce = PTHREAD_ONCE_INIT; static void createIdentifierTableSpecificCallback() { ASSERT(!g_identifierTableSpecific); g_identifierTableSpecific = new ThreadSpecific<ThreadIdentifierTableData>(); } void createIdentifierTableSpecific() { pthread_once(&createIdentifierTableSpecificOnce, createIdentifierTableSpecificCallback); ASSERT(g_identifierTableSpecific); } #else void createIdentifierTableSpecific() { ASSERT(!g_identifierTableSpecific); g_identifierTableSpecific = new ThreadSpecific<ThreadIdentifierTableData>(); } #endif 183467 5 46971 ap 2010-01-21 21:01:22 -0800 Comment on attachment 46971 Implement ThreadSpecific with a simple getter/setter for ENABLE(SINGLE_THREADED) ok, r=me 183516 6 46971 commit-queue 2010-01-21 23:36:35 -0800 Comment on attachment 46971 Implement ThreadSpecific with a simple getter/setter for ENABLE(SINGLE_THREADED) Clearing flags on attachment: 46971 Committed r53682: <http://trac.webkit.org/changeset/53682> 183517 7 commit-queue 2010-01-21 23:36:42 -0800 All reviewed patches have been landed. Closing bug. 46971 2010-01-19 20:16:23 -0800 2010-01-21 23:36:35 -0800 Implement ThreadSpecific with a simple getter/setter for ENABLE(SINGLE_THREADED) ThreadSpecific.patch text/plain 2478 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUzNTE5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDEtMTkgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgVGhyZWFkU3BlY2lmaWMgZm9yIEVOQUJMRShTSU5H TEVfVEhSRUFERUQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMzg3OAorCisgICAgICAgIEltcGxlbWVudCBUaHJlYWRTcGVjaWZpYyB3aXRoIGEgc2lt cGxlIGdldHRlci9zZXR0ZXIKKyAgICAgICAgd2hlbiBFTkFCTEUoU0lOR0xFX1RIUkVBREVEKSBp cyB0cnVlLgorCisgICAgICAgIER1ZSB0byB0aGUgY2hhbmdlIGluIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzIzNiwKKyAgICAgICAgYW4gaW1wbGVtZW50YXRpb24g b2YgVGhyZWFkU3BlY2lmaWMgbXVzdCBiZSBhdmFpbGFibGUgdG8gYnVpbGQgV2ViS2l0LgorICAg ICAgICBUaGlzIGNhdXNlcyBhIGJ1aWxkIGZhaWx1cmUgZm9yIHBsYXRmb3JtcyB3aXRob3V0IGEg cHJvcGVyCisgICAgICAgIFRocmVhZFNwZWNpZmljIGltcGxlbWVudGF0aW9uLgorCisgICAgICAg ICogd3RmL1RocmVhZFNwZWNpZmljLmg6CisgICAgICAgIChXVEY6Ojo6VGhyZWFkU3BlY2lmaWMp OgorICAgICAgICAoV1RGOjo6On5UaHJlYWRTcGVjaWZpYyk6CisgICAgICAgIChXVEY6Ojo6Z2V0 KToKKyAgICAgICAgKFdURjo6OjpzZXQpOgorICAgICAgICAoV1RGOjo6OmRlc3Ryb3kpOgorCiAy MDEwLTAxLTE5ICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBUaW0gSGF0Y2hlci4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9U aHJlYWRTcGVjaWZpYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRT cGVjaWZpYy5oCShyZXZpc2lvbiA1MzUxMSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRT cGVjaWZpYy5oCSh3b3JraW5nIGNvcHkpCkBAIC05MSw2ICs5MSw5IEBAIHByaXZhdGU6CiAgICAg fTsKICNlbmRpZgogCisjaWYgRU5BQkxFKFNJTkdMRV9USFJFQURFRCkKKyAgICBUKiBtX3ZhbHVl OworI2Vsc2UKICNpZiBVU0UoUFRIUkVBRFMpCiAgICAgcHRocmVhZF9rZXlfdCBtX2tleTsKICNl bGlmIFBMQVRGT1JNKFFUKQpAQCAtOTgsOCArMTAxLDM0IEBAIHByaXZhdGU6CiAjZWxpZiBPUyhX SU5ET1dTKQogICAgIGludCBtX2luZGV4OwogI2VuZGlmCisjZW5kaWYKIH07CiAKKyNpZiBFTkFC TEUoU0lOR0xFX1RIUkVBREVEKQordGVtcGxhdGU8dHlwZW5hbWUgVD4KK2lubGluZSBUaHJlYWRT cGVjaWZpYzxUPjo6VGhyZWFkU3BlY2lmaWMoKQorICAgIDogbV92YWx1ZSgwKQoreworfQorCit0 ZW1wbGF0ZTx0eXBlbmFtZSBUPgoraW5saW5lIFRocmVhZFNwZWNpZmljPFQ+Ojp+VGhyZWFkU3Bl Y2lmaWMoKQoreworfQorCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgoraW5saW5lIFQqIFRocmVhZFNw ZWNpZmljPFQ+OjpnZXQoKQoreworICAgIHJldHVybiBtX3ZhbHVlOworfQorCit0ZW1wbGF0ZTx0 eXBlbmFtZSBUPgoraW5saW5lIHZvaWQgVGhyZWFkU3BlY2lmaWM8VD46OnNldChUKiBwdHIpCit7 CisgICAgQVNTRVJUKCFnZXQoKSk7CisgICAgbV92YWx1ZSA9IHB0cjsKK30KKyNlbHNlCiAjaWYg VVNFKFBUSFJFQURTKQogdGVtcGxhdGU8dHlwZW5hbWUgVD4KIGlubGluZSBUaHJlYWRTcGVjaWZp YzxUPjo6VGhyZWFkU3BlY2lmaWMoKQpAQCAtMjA3LDEwICsyMzYsMTIgQEAgaW5saW5lIHZvaWQg VGhyZWFkU3BlY2lmaWM8VD46OnNldChUKiBwdAogI2Vsc2UKICNlcnJvciBUaHJlYWRTcGVjaWZp YyBpcyBub3QgaW1wbGVtZW50ZWQgZm9yIHRoaXMgcGxhdGZvcm0uCiAjZW5kaWYKKyNlbmRpZgog CiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogaW5saW5lIHZvaWQgVGhyZWFkU3BlY2lmaWM8VD46OmRl c3Ryb3kodm9pZCogcHRyKQogeworI2lmICFFTkFCTEUoU0lOR0xFX1RIUkVBREVEKQogICAgIERh dGEqIGRhdGEgPSBzdGF0aWNfY2FzdDxEYXRhKj4ocHRyKTsKIAogI2lmIFVTRShQVEhSRUFEUykK QEAgLTIzOSw2ICsyNzAsNyBAQCBpbmxpbmUgdm9pZCBUaHJlYWRTcGVjaWZpYzxUPjo6ZGVzdHJv eSh2CiAjaWYgIVBMQVRGT1JNKFFUKQogICAgIGRlbGV0ZSBkYXRhOwogI2VuZGlmCisjZW5kaWYK IH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4K