<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33865</bug_id>
          
          <creation_ts>2010-01-19 13:53:25 -0800</creation_ts>
          <short_desc>svg/custom/stroke-width-click.svg fixes</short_desc>
          <delta_ts>2010-01-22 22:35:34 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Garret Kelly">gdk</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>gdk</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>182435</commentid>
    <comment_count>0</comment_count>
      <attachid>46950</attachid>
    <who name="Garret Kelly">gdk</who>
    <bug_when>2010-01-19 13:53:25 -0800</bug_when>
    <thetext>Created attachment 46950
Initial patch

Two issues:
- The way that stroke-width-click is written causes double-click events within the Chromium test_shell and triggers an ASSERT that is unrelated to the test.
- The output formatting does not allow for variances between platforms.

I&apos;ve attached a patch that resolves this issue by reordering the click events so as to not trigger the double-click logic, and which changes the output formatting to not have rigid expectations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182452</commentid>
    <comment_count>1</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-19 14:16:38 -0800</bug_when>
    <thetext>You would need to include updating resutls if you were changing the test.

By &quot;not judging&quot; the results, its no longer clear from the test if it passed or failed.  I think that&apos;s bad.  If we have intentional platform-specific results those should be split out into another test instead of losing the value of having SUCCESS/FAIL for most of the test which is not platform-specific.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183278</commentid>
    <comment_count>2</comment_count>
      <attachid>47137</attachid>
    <who name="Garret Kelly">gdk</who>
    <bug_when>2010-01-21 12:23:31 -0800</bug_when>
    <thetext>Created attachment 47137
Updated patch

I&apos;ve investigated this bug a bit more, and it appears that the test has been disabled and flagged as a regression since Leopard. However, the output for Leopard (which agrees with Chromium and GTK (with the minor exception of another bug in the output, or else I&apos;d re-enable it there too)) appears to be completely valid.

This patch updates the test to not trigger the double-click logic in the Chromium test_shell, disables the test under mac-tiger, enables the test under mac-leopard (it can probably be re-enabled on mac-snowleopard but I don&apos;t currently have access to that platform), fixes the expectation within the test about the the presence of the shape at (300, 150) and updates the expected file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183302</commentid>
    <comment_count>3</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2010-01-21 13:47:38 -0800</bug_when>
    <thetext>Removed [chromium] since this is a generic change (even though the change may be done for chromium).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183558</commentid>
    <comment_count>4</comment_count>
      <attachid>47137</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2010-01-22 02:07:00 -0800</bug_when>
    <thetext>Comment on attachment 47137
Updated patch

Looks good but I suggest enabling it on SnowLeopard too even if you have to do it blind. The odds that it will fail are pretty small. r- to consider that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183625</commentid>
    <comment_count>5</comment_count>
      <attachid>47198</attachid>
    <who name="Garret Kelly">gdk</who>
    <bug_when>2010-01-22 06:28:18 -0800</bug_when>
    <thetext>Created attachment 47198
Updated patch (activate the test in platform-snowleopard)

Thanks for the input Maciej! Here&apos;s an updated patch that removes the test from mac-snowleopard/Skipped but is otherwise identical to the previous one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183719</commentid>
    <comment_count>6</comment_count>
      <attachid>47198</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-22 11:32:39 -0800</bug_when>
    <thetext>Comment on attachment 47198
Updated patch (activate the test in platform-snowleopard)

Rejecting patch 47198 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/run-webkit-tests&apos;, &apos;--no-launch-safari&apos;, &apos;--exit-after-n-failures=1&apos;, &apos;--quiet&apos;]&quot; exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 12031 test cases.
svg/custom/stroke-width-click.svg -&gt; failed

Exiting early after 1 failures. 9696 tests run.
208.00s total testing time

9695 test cases (99%) succeeded
1 test case (&lt;1%) had incorrect layout
6 test cases (&lt;1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/204917</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183767</commentid>
    <comment_count>7</comment_count>
      <attachid>47221</attachid>
    <who name="Garret Kelly">gdk</who>
    <bug_when>2010-01-22 13:19:20 -0800</bug_when>
    <thetext>Created attachment 47221
Updated patch (re-adds missing newline)

This patch is identical to the last, except it has the missing newline that I accidentally stripped out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183956</commentid>
    <comment_count>8</comment_count>
      <attachid>47221</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-22 22:35:27 -0800</bug_when>
    <thetext>Comment on attachment 47221
Updated patch (re-adds missing newline)

Clearing flags on attachment: 47221

Committed r53762: &lt;http://trac.webkit.org/changeset/53762&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>183957</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-01-22 22:35:34 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46950</attachid>
            <date>2010-01-19 13:53:25 -0800</date>
            <delta_ts>2010-01-19 14:16:01 -0800</delta_ts>
            <desc>Initial patch</desc>
            <filename>stroke-width-click-fixes.patch</filename>
            <type>text/plain</type>
            <size>4171</size>
            <attacher name="Garret Kelly">gdk</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBjNWY2YjJhLi40OTk2YTcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt
MTkgIEdhcnJldCBLZWxseSAgPGdka0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIGV2ZW50IHNlcXVlbmNlIGluIHN2
Zy9jdXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZyBzbyBhcyB0bworICAgICAgICBub3QgZmly
ZSB0aGUgZG91YmxlLWNsaWNrIGhhbmRsZXIgaW4gdGhlIENocm9taXVtIHRlc3Rfc2hlbGwuIFRo
aXMKKyAgICAgICAgcGF0Y2ggYWxzbyByZW1vdmVzIHRoZSBwbGF0Zm9ybSBkZXBlbmVuY2UgaW4g
dGhpcyB0ZXN0IGJ5IGNoYW5naW5nIHRoZQorICAgICAgICBvdXRwdXQgZm9ybWF0IHRvIG1lcmVs
eSByZXBvcnQgcmVzdWx0cywgbm90IGp1ZGdlIHRoZW0uCisKKyAgICAgICAgKiBzdmcvY3VzdG9t
L3N0cm9rZS13aWR0aC1jbGljay5zdmc6CisKIDIwMTAtMDEtMTkgIEJyYWR5IEVpZHNvbiAgPGJl
aWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFr
b3YuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGlj
ay5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay5zdmcKaW5k
ZXggMTgzNTU4ZC4uNjI0ZTcxYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9z
dHJva2Utd2lkdGgtY2xpY2suc3ZnCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tl
LXdpZHRoLWNsaWNrLnN2ZwpAQCAtMTMsMjMgKzEzLDE5IEBACiAgICAgCiAgICAgdmFyIGxhc3RF
dmVudCA9IG51bGw7CiAgICAgCi0gICAgZnVuY3Rpb24gdGVzdENsaWNrKHgsIHksIGV4cGVjdGVk
KSB7CisgICAgZnVuY3Rpb24gdGVzdENsaWNrKHgsIHkpIHsKICAgICAgIGV2ZW50U2VuZGVyLm1v
dXNlTW92ZVRvKHgsIHkpOwogICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CiAgICAgICBl
dmVudFNlbmRlci5tb3VzZVVwKCk7Ci0gICAgICBpZiAoZXhwZWN0ZWQgJiYgbGFzdEV2ZW50ICYm
IGxhc3RFdmVudC5jbGllbnRYID09IHggJiYgbGFzdEV2ZW50LmNsaWVudFkgPT0geSkgewotICAg
ICAgICBsb2coIlNVQ0NFU1M6IGNsaWNrIHJlY2VpdmVkIGF0OiAiICsgeCArICIsICIgKyB5KTsK
LSAgICAgIH0gZWxzZSBpZiAoIWV4cGVjdGVkICYmICFsYXN0RXZlbnQpIHsKLSAgICAgICAgbG9n
KCJTVUNDRVNTOiBjbGljayBhdCAiICsgeCArICIsICIgKyB5ICsgIiB3YXMgY29ycmVjdGx5IGln
bm9yZWQiKTsKLSAgICAgIH0gZWxzZSBpZiAoZXhwZWN0ZWQgJiYgbGFzdEV2ZW50KSB7Ci0gICAg
ICAgIGxvZygiRkFJTFVSRTogY2xpY2sgcmVjZWl2ZWQgYXQ6ICIgKyBsYXN0RXZlbnQuY2xpZW50
WCArICIsICIgKyBsYXN0RXZlbnQuY2xpZW50WSArICIgYnV0IGl0IHdhcyBleHBlY3RlZCBhdDog
IiArIHggKyAiLCAiICsgeSk7Ci0gICAgICB9IGVsc2UgaWYgKCFleHBlY3RlZCAmJiBsYXN0RXZl
bnQpIHsKLSAgICAgICAgbG9nKCJGQUlMVVJFOiBVTkVYUEVDVEVEIGNsaWNrIHJlY2VpdmVkIGF0
OiAiICsgbGFzdEV2ZW50LmNsaWVudFggKyAiLCAiICsgbGFzdEV2ZW50LmNsaWVudFkpOwotICAg
ICAgfSBlbHNlIGlmIChleHBlY3RlZCAmJiAhbGFzdEV2ZW50KSB7Ci0gICAgICAgIGxvZygiRkFJ
TFVSRTogTk8gY2xpY2sgcmVjZWl2ZWQgYXQ6ICIgKyB4ICsgIiwgIiArIHkpOwotICAgICAgfSBl
bHNlIHsKLSAgICAgICAgbG9nKCJMT0dJQyBFUk9SUiIpOworCisgICAgICBpZiAoIWxhc3RFdmVu
dCkgeworICAgICAgICBsb2coIklHTk9SRUQgY2xpY2sgYXQgKCIgKyB4ICsgIiwgIiArIHkgKyAi
KSIpOworICAgICAgfSBlbHNlIGlmIChsYXN0RXZlbnQgJiYgbGFzdEV2ZW50LmNsaWVudFggPT0g
eCAmJiBsYXN0RXZlbnQuY2xpZW50WSA9PSB5KSB7CisgICAgICAgIGxvZygiUkVDRUlWRUQgY2xp
Y2sgYXQgKCIgKyB4ICsgIiwgIiArIHkgKyAiKSIpOworICAgICAgfSBlbHNlIGlmIChsYXN0RXZl
bnQgJiYgKGxhc3RFdmVudC5jbGllbnRYICE9IHggfHwgbGFzdEV2ZW50LmNsaWVuWSAhPSB5KSkg
eworICAgICAgICBsb2coIkZBSUxVUkUgY2xpY2sgcmVjZWl2ZWQgYXQgKCIgKyBsYXN0RXZlbnQu
Y2xpZW50WCArICIsICIgKyBsYXN0RXZlbnQuY2xpZW50WSArICIpIGJ1dCB3YXMgZXhwZWN0ZWQg
YXQgKCIgKyB4ICsgIiwgIiArIHkgKyAiKSIpOwogICAgICAgfQorCiAgICAgICBsYXN0RXZlbnQg
PSBudWxsOwogICAgIH0KICAgICAKQEAgLTQyLDcgKzM4LDcgQEAKICAgICAgICAgZG9jdW1lbnQu
Z2V0RWxlbWVudEJ5SWQoJ21vdXNlb3Zlci10ZXh0JykudGV4dENvbnRlbnQgPSB0eXBlICsgIiBh
dCAiICsgZXZ0LmNsaWVudFggKyAiLCAiICsgZXZ0LmNsaWVudFk7CiAgICAgfQogICBdXT4KLSAg
PC9zY3JpcHQ+ICAKKyAgPC9zY3JpcHQ+CiAgIDxmb3JlaWduT2JqZWN0IHk9IjIwMCIgd2lkdGg9
IjYwMCIgaGVpZ2h0PSI0MDAiPgogICA8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5
OS94aHRtbCI+CiAgICAgPGJvZHk+CkBAIC01NiwyMiArNTIsMjQgQEAKICAgPHBhdGggZD0iTSAz
MCAxMDAgTCAzMDEgMTAwIiBzdHJva2Utd2lkdGg9IjEwMCIgc3Ryb2tlPSJ5ZWxsb3ciIG9uY2xp
Y2s9ImdvdENsaWNrKGV2dCkiIG9ubW91c2VvdmVyPSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNl
b3ZlcicpIiBvbm1vdXNlb3V0PSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNlb3V0JykiIG9ubW91
c2Vtb3ZlPSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNlbW92ZScpIiAvPgogICA8dGV4dCBpZD0i
bW91c2VvdmVyLXRleHQiIHg9IjMwIiB5PSIxOTAiPjwvdGV4dD4KICAgCisgIDwhLS0gVGhlc2Ug
bW91c2UgZXZlbnRzIGFyZSBkaXN0YW5jZWQgZnJvbSBlYWNoIG90aGVyIG9uIHB1cG9zZSwgdG8g
cHJldmVudCB0aGUgY2xpY2tzIGZyb20gcmVnaXN0ZXJpbmcgYXMgZG91YmxlLWNsaWNrcyAtLT4K
ICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICA8IVtDREFUQVsKICAgICBpZiAo
d2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICB0ZXN0Q2xpY2soMTAsIDEwLCBmYWxzZSk7Ci0g
ICAgICB0ZXN0Q2xpY2soMzAsIDEwMCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMjksIDEwMCwg
ZmFsc2UpOwotICAgICAgdGVzdENsaWNrKDMwLCA1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2so
MzAsIDQ5LCBmYWxzZSk7Ci0gICAgICB0ZXN0Q2xpY2soMzAsIDE1MCwgdHJ1ZSk7Ci0gICAgICB0
ZXN0Q2xpY2soMzAsIDE1MSwgZmFsc2UpOwotICAgICAgdGVzdENsaWNrKDMwMCwgMTAwLCB0cnVl
KTsKLSAgICAgIHRlc3RDbGljaygzMDEsIDEwMCwgZmFsc2UpOwotICAgICAgdGVzdENsaWNrKDMw
MCwgNTAsIHRydWUpOwotICAgICAgdGVzdENsaWNrKDMwMCwgNDksIGZhbHNlKTsKLSAgICAgIHRl
c3RDbGljaygzMDAsIDE1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMzAwLCAxNTEsIGZhbHNl
KTsKKyAgICAgIHRlc3RDbGljaygzMCwgMTAwKTsKKyAgICAgIHRlc3RDbGljaygzMCwgNTApOwor
ICAgICAgdGVzdENsaWNrKDMwLCAxNTApOworICAgICAgdGVzdENsaWNrKDMwMCwgMTAwKTsKKyAg
ICAgIHRlc3RDbGljaygzMDAsIDUwKTsKKyAgICAgIHRlc3RDbGljaygzMDAsIDE1MCk7CisKKyAg
ICAgIHRlc3RDbGljaygxMCwgMTApOworICAgICAgdGVzdENsaWNrKDI5LCAxMDApOworICAgICAg
dGVzdENsaWNrKDMwLCA0OSk7CisgICAgICB0ZXN0Q2xpY2soMzAsIDE1MSk7CisgICAgICB0ZXN0
Q2xpY2soMzAxLCAxMDApOworICAgICAgdGVzdENsaWNrKDMwMCwgNDkpOworICAgICAgdGVzdENs
aWNrKDMwMCwgMTUxKTsKICAgICB9IGVsc2UgewogICAgICAgbG9nKCJFUlJPUjogd2luZG93LmV2
ZW50U2VuZGVyIG5vdCBmb3VuZCEgIFRoaXMgdGVzdCBtdXN0IGJlIHJ1biB1c2luZyBEdW1wUmVu
ZGVyVHJlZS4gIE1vdXNpbmcgb3ZlciB0aGUgeWVsbG93IGFyZWEgd2lsbCBsb2cgaG93ZXZlci4i
KTsKICAgICB9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47137</attachid>
            <date>2010-01-21 12:23:31 -0800</date>
            <delta_ts>2010-01-22 06:28:18 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>stroke-width-click.patch</filename>
            <type>text/plain</type>
            <size>4965</size>
            <attacher name="Garret Kelly">gdk</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCA2ODg3ODMyLi4zNDc4MDBjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEt
MjEgIEdhcnJldCBLZWxseSAgPGdka0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4aW5nIHN2Zy9jdXN0b20vc3Ryb2tlLXdp
ZHRoLWNsaWNrLnN2ZyB0byBub3QgY2F1c2UgdGhlIGRvdWJsZS1jbGljaworICAgICAgICBoYW5k
bGVyIHRvIGZpcmUgb24gY2VydGFpbiBwbGF0Zm9ybXMgKGNocm9taXVtLCBmb3Igb25lKS4gQ2hy
b21pdW0sCisgICAgICAgIExlb3BhcmQsIGFuZCBHVEsgYWxsIGFncmVlIG9uIHRoZSBjYWxjdWxh
dGVkIGV4dGVudHMgb2YgdGhlIHNoYXBlLCBzbyBJJ20KKyAgICAgICAgZGlzYWJsaW5nIHRoaXMg
dGVzdCBvbiBtYWMtdGlnZXIgYW5kIHJlLWVuYWJsaW5nIGl0IG9uIG1hYy1sZW9wYXJkIGFuZAor
ICAgICAgICB1cGRhdGluZyB0aGUgZXhwZWN0ZWQgZmlsZSB0byByZWZsZWN0IHRoZSBjdXJyZW50
IHN0YXRlIG9mIHRoZSB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzM4NjUKKworICAgICAgICAqIHBsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBw
ZWQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQ6CisgICAgICAgICogc3Zn
L2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN2Zy9j
dXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZzoKKwogMjAxMC0wMS0xOSAgU2ltb24gRnJhc2Vy
ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVy
bnN0ZWluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tp
cHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQKaW5kZXggNTNl
NjMwOC4uMGUzYTM3ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3Bh
cmQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVk
CkBAIC01LDkgKzUsNiBAQCBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZyYW1lLWxvYWRpbmctdmlhLWRv
Y3VtZW50LXdyaXRlLmh0bWwKICMgPHJkYXI6Ly9wcm9ibGVtLzU2ODY1NTI+IHN2Zy9jc3MvZ2x5
cGgtb3JpZW50YXRpb24tcm91bmRpbmctdGVzdC54aHRtbCBzb21ldGltZXMgZmFpbHMKIHN2Zy9j
c3MvZ2x5cGgtb3JpZW50YXRpb24tcm91bmRpbmctdGVzdC54aHRtbAogCi0jIDxyZGFyOi8vcHJv
YmxlbS81NTM5ODIyPiBSRUdSRVNTSU9OIChMZW9wYXJkKTogc3ZnL2N1c3RvbS9zdHJva2Utd2lk
dGgtY2xpY2suc3ZnIHRlc3QgZmFpbGluZwotc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2su
c3ZnCi0KICMgVGVzdHMgb2YgdGFibGUgYWNjZXNzaWJpbGl0eSBmdW5jdGlvbmFsaXR5IG5vdCBz
dXBwb3J0ZWQgb24gTGVvcGFyZAogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdGFibGUtbXVs
dGktYm9kaWVzLmh0bWwKICMgTGlzdHMgYXJlIG5vdCBzdXBwb3J0ZWQgb24gTGVvcGFyZC4KZGlm
ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkIGIvTGF5b3V0
VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQKaW5kZXggZGMwOWVmYi4uMzI5NDUzNiAx
MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQKKysrIGIv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQKQEAgLTk4LDMgKzk4LDcgQEAg
aHR0cC90ZXN0cy9tZWRpYS92aWRlby1lcnJvci1hYm9ydC5odG1sCiAjIEZhaWxzIGludGVybWl0
dGVudGx5IG9uIFRpZ2VyIEJ1aWxkIEJvdC4KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTMxNDEyCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2xvZ291dC5odG1s
CisKKyMgVGhpcyB3YXMgZmxhZ2dlZCBhcyBhIHJlZ3Jlc3Npb24gaW4gTGVvcGFyZCBhbmQgU25v
dyBMZW9wYXJkLCBidXQgdGhlCisjIGJlaGF2aW91ciBpcyBjb25zaXN0ZW50IHdpdGggb3RoZXIg
cGxhdGZvcm1zLiA8cmRhcjovL3Byb2JsZW0vNTUzOTgyMj4KK3N2Zy9jdXN0b20vc3Ryb2tlLXdp
ZHRoLWNsaWNrLnN2ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdHJva2Ut
d2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdHJva2Ut
d2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0CmluZGV4IDUxMWQ2MmYuLjMyMzFjMGYgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLWV4cGVjdGVkLnR4
dAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay1leHBlY3Rl
ZC50eHQKQEAgLTEsMTQgKzEsMTMgQEAKLVNVQ0NFU1M6IGNsaWNrIGF0IDEwLCAxMCB3YXMgY29y
cmVjdGx5IGlnbm9yZWQKIFNVQ0NFU1M6IGNsaWNrIHJlY2VpdmVkIGF0OiAzMCwgMTAwCi1TVUND
RVNTOiBjbGljayBhdCAyOSwgMTAwIHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xp
Y2sgcmVjZWl2ZWQgYXQ6IDMwLCA1MAotU1VDQ0VTUzogY2xpY2sgYXQgMzAsIDQ5IHdhcyBjb3Jy
ZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xpY2sgcmVjZWl2ZWQgYXQ6IDMwLCAxNTAKLVNVQ0NF
U1M6IGNsaWNrIGF0IDMwLCAxNTEgd2FzIGNvcnJlY3RseSBpZ25vcmVkCiBTVUNDRVNTOiBjbGlj
ayByZWNlaXZlZCBhdDogMzAwLCAxMDAKLVNVQ0NFU1M6IGNsaWNrIGF0IDMwMSwgMTAwIHdhcyBj
b3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xpY2sgcmVjZWl2ZWQgYXQ6IDMwMCwgNTAKLVNV
Q0NFU1M6IGNsaWNrIGF0IDMwMCwgNDkgd2FzIGNvcnJlY3RseSBpZ25vcmVkCitTVUNDRVNTOiBj
bGljayByZWNlaXZlZCBhdDogMzAxLCAxMDAKIFNVQ0NFU1M6IGNsaWNrIHJlY2VpdmVkIGF0OiAz
MDAsIDE1MAorU1VDQ0VTUzogY2xpY2sgYXQgMTAsIDEwIHdhcyBjb3JyZWN0bHkgaWdub3JlZAor
U1VDQ0VTUzogY2xpY2sgYXQgMjksIDEwMCB3YXMgY29ycmVjdGx5IGlnbm9yZWQKK1NVQ0NFU1M6
IGNsaWNrIGF0IDMwLCA0OSB3YXMgY29ycmVjdGx5IGlnbm9yZWQKK1NVQ0NFU1M6IGNsaWNrIGF0
IDMwLCAxNTEgd2FzIGNvcnJlY3RseSBpZ25vcmVkCitTVUNDRVNTOiBjbGljayBhdCAzMDAsIDQ5
IHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xpY2sgYXQgMzAwLCAxNTEgd2FzIGNv
cnJlY3RseSBpZ25vcmVkCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ry
b2tlLXdpZHRoLWNsaWNrLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tlLXdpZHRo
LWNsaWNrLnN2ZwppbmRleCAxODM1NThkLi4zODQ4OTE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay5zdmcKKysrIGIvTGF5b3V0VGVzdHMvc3Zn
L2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCkBAIC01NiwyMSArNTYsMjMgQEAKICAgPHBh
dGggZD0iTSAzMCAxMDAgTCAzMDEgMTAwIiBzdHJva2Utd2lkdGg9IjEwMCIgc3Ryb2tlPSJ5ZWxs
b3ciIG9uY2xpY2s9ImdvdENsaWNrKGV2dCkiIG9ubW91c2VvdmVyPSJnb3RNb3VzZUV2ZW50KGV2
dCwgJ21vdXNlb3ZlcicpIiBvbm1vdXNlb3V0PSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNlb3V0
JykiIG9ubW91c2Vtb3ZlPSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNlbW92ZScpIiAvPgogICA8
dGV4dCBpZD0ibW91c2VvdmVyLXRleHQiIHg9IjMwIiB5PSIxOTAiPjwvdGV4dD4KICAgCisgIDwh
LS0gVGhlIGZvbGxvd2luZyBtb3VzZSBldmVudHMgYXJlIHNwYWNlZCBleHBsaWNpdHkgdG8gcHJl
dmVudCB0cmlnZ2VyaW5nIGRvdWJsZS1jbGljayBsb2dpYyAtLT4KICAgPHNjcmlwdCB0eXBlPSJ0
ZXh0L2phdmFzY3JpcHQiPgogICA8IVtDREFUQVsKICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVy
KSB7Ci0gICAgICB0ZXN0Q2xpY2soMTAsIDEwLCBmYWxzZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAs
IDEwMCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMjksIDEwMCwgZmFsc2UpOwogICAgICAgdGVz
dENsaWNrKDMwLCA1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMzAsIDQ5LCBmYWxzZSk7CiAg
ICAgICB0ZXN0Q2xpY2soMzAsIDE1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMzAsIDE1MSwg
ZmFsc2UpOwogICAgICAgdGVzdENsaWNrKDMwMCwgMTAwLCB0cnVlKTsKLSAgICAgIHRlc3RDbGlj
aygzMDEsIDEwMCwgZmFsc2UpOwogICAgICAgdGVzdENsaWNrKDMwMCwgNTAsIHRydWUpOwotICAg
ICAgdGVzdENsaWNrKDMwMCwgNDksIGZhbHNlKTsKKyAgICAgIHRlc3RDbGljaygzMDEsIDEwMCwg
dHJ1ZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAwLCAxNTAsIHRydWUpOworCisgICAgICB0ZXN0Q2xp
Y2soMTAsIDEwLCBmYWxzZSk7CisgICAgICB0ZXN0Q2xpY2soMjksIDEwMCwgZmFsc2UpOworICAg
ICAgdGVzdENsaWNrKDMwLCA0OSwgZmFsc2UpOworICAgICAgdGVzdENsaWNrKDMwLCAxNTEsIGZh
bHNlKTsKKyAgICAgIHRlc3RDbGljaygzMDAsIDQ5LCBmYWxzZSk7CiAgICAgICB0ZXN0Q2xpY2so
MzAwLCAxNTEsIGZhbHNlKTsKICAgICB9IGVsc2UgewogICAgICAgbG9nKCJFUlJPUjogd2luZG93
LmV2ZW50U2VuZGVyIG5vdCBmb3VuZCEgIFRoaXMgdGVzdCBtdXN0IGJlIHJ1biB1c2luZyBEdW1w
UmVuZGVyVHJlZS4gIE1vdXNpbmcgb3ZlciB0aGUgeWVsbG93IGFyZWEgd2lsbCBsb2cgaG93ZXZl
ci4iKTsK
</data>
<flag name="review"
          id="29533"
          type_id="1"
          status="-"
          setter="mjs"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47198</attachid>
            <date>2010-01-22 06:28:18 -0800</date>
            <delta_ts>2010-01-22 13:19:20 -0800</delta_ts>
            <desc>Updated patch (activate the test in platform-snowleopard)</desc>
            <filename>updated-swc-patch.patch</filename>
            <type>text/plain</type>
            <size>5624</size>
            <attacher name="Garret Kelly">gdk</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCBjYjg3ODUxLi4yNWY0ZWYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDEt
MjIgIEdhcnJldCBLZWxseSAgPGdka0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4aW5nIHN2Zy9jdXN0b20vc3Ryb2tlLXdp
ZHRoLWNsaWNrLnN2ZyB0byBub3QgY2F1c2UgdGhlIGRvdWJsZS1jbGljaworICAgICAgICBoYW5k
bGVyIHRvIGZpcmUgb24gY2VydGFpbiBwbGF0Zm9ybXMgKGNocm9taXVtLCBmb3Igb25lKS4gQ2hy
b21pdW0sCisgICAgICAgIExlb3BhcmQsIGFuZCBHVEsgYWxsIGFncmVlIG9uIHRoZSBjYWxjdWxh
dGVkIGV4dGVudHMgb2YgdGhlIHNoYXBlLCBzbyBJJ20KKyAgICAgICAgZGlzYWJsaW5nIHRoaXMg
dGVzdCBvbiBtYWMtdGlnZXIgYW5kIHJlLWVuYWJsaW5nIGl0IG9uIG1hYy1sZW9wYXJkIGFuZAor
ICAgICAgICB1cGRhdGluZyB0aGUgZXhwZWN0ZWQgZmlsZSB0byByZWZsZWN0IHRoZSBjdXJyZW50
IHN0YXRlIG9mIHRoZSB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzM4NjUKKworICAgICAgICAqIHBsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBw
ZWQ6CisgICAgICAgICogcGxheWZvcm0vbWFjLXNub3dsZWFvcGFyZC9Ta2lwcGVkOgorICAgICAg
ICAqIHBsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkOgorICAgICAgICAqIHN2Zy9jdXN0b20vc3Ry
b2tlLXdpZHRoLWNsaWNrLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBzdmcvY3VzdG9tL3N0cm9r
ZS13aWR0aC1jbGljay5zdmc6CisKIDIwMTAtMDEtMjIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9z
c3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFNraXAgdGVzdCBpbnRyb2R1Y2VkIGluIHI1
MzY4NCBiZWNhdXNlIG9mIG1pc3NpbmcgZXZlbnRTZW5kZXIudGV4dFpvb21JbigpCmRpZmYgLS1n
aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkIGIvTGF5b3V0VGVz
dHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZAppbmRleCBkMWE1Y2Y1Li5mNDU0NWRiIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCisrKyBi
L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBwZWQKQEAgLTUsOSArNSw2IEBA
IGh0dHAvdGVzdHMvc2VjdXJpdHkvZnJhbWUtbG9hZGluZy12aWEtZG9jdW1lbnQtd3JpdGUuaHRt
bAogIyA8cmRhcjovL3Byb2JsZW0vNTY4NjU1Mj4gc3ZnL2Nzcy9nbHlwaC1vcmllbnRhdGlvbi1y
b3VuZGluZy10ZXN0LnhodG1sIHNvbWV0aW1lcyBmYWlscwogc3ZnL2Nzcy9nbHlwaC1vcmllbnRh
dGlvbi1yb3VuZGluZy10ZXN0LnhodG1sCiAKLSMgPHJkYXI6Ly9wcm9ibGVtLzU1Mzk4MjI+IFJF
R1JFU1NJT04gKExlb3BhcmQpOiBzdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay5zdmcgdGVz
dCBmYWlsaW5nCi1zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay5zdmcKLQogIyBUZXN0cyBv
ZiB0YWJsZSBhY2Nlc3NpYmlsaXR5IGZ1bmN0aW9uYWxpdHkgbm90IHN1cHBvcnRlZCBvbiBMZW9w
YXJkCiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS90YWJsZS1tdWx0aS1ib2RpZXMuaHRtbAog
IyBMaXN0cyBhcmUgbm90IHN1cHBvcnRlZCBvbiBMZW9wYXJkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0
Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZAppbmRleCAzYTQzMjhlLi5hMjAwNTMwIDEwMDY0
NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZAorKysg
Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZApAQCAtMjEsNyAr
MjEsNiBAQCBzdmcvYmF0aWsvcGFpbnRzL3BhdHRlcm5SZWdpb25BLnN2Zwogc3ZnL2N1c3RvbS9w
YXRoLWJhZC1kYXRhLnN2Zwogc3ZnL2N1c3RvbS9wYXR0ZXJuLWRlZXAtcmVmZXJlbmNpbmcuc3Zn
CiBzdmcvY3VzdG9tL3ByZXNlcnZlLWFzcGVjdC1yYXRpby1zeW50YXguc3ZnCi1zdmcvY3VzdG9t
L3N0cm9rZS13aWR0aC1jbGljay5zdmcKIHN2Zy9jdXN0b20vdmlld2JveC1zeW50YXguc3ZnCiBz
dmcvaGl4aWUvcGVyZi8wMDcueG1sCiBzdmcvdHJhbnNmb3Jtcy90ZXh0LXdpdGgtcGF0dGVybi1p
bnNpZGUtdHJhbnNmb3JtZWQtaHRtbC54aHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh
dGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIv
U2tpcHBlZAppbmRleCBkYzA5ZWZiLi4zMjk0NTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w
bGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt
dGlnZXIvU2tpcHBlZApAQCAtOTgsMyArOTgsNyBAQCBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWVy
cm9yLWFib3J0Lmh0bWwKICMgRmFpbHMgaW50ZXJtaXR0ZW50bHkgb24gVGlnZXIgQnVpbGQgQm90
LgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE0MTIKIGh0dHAv
dGVzdHMveG1saHR0cHJlcXVlc3QvbG9nb3V0Lmh0bWwKKworIyBUaGlzIHdhcyBmbGFnZ2VkIGFz
IGEgcmVncmVzc2lvbiBpbiBMZW9wYXJkIGFuZCBTbm93IExlb3BhcmQsIGJ1dCB0aGUKKyMgYmVo
YXZpb3VyIGlzIGNvbnNpc3RlbnQgd2l0aCBvdGhlciBwbGF0Zm9ybXMuIDxyZGFyOi8vcHJvYmxl
bS81NTM5ODIyPgorc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCmRpZmYgLS1naXQg
YS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay1leHBlY3RlZC50eHQg
Yi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay1leHBlY3RlZC50eHQK
aW5kZXggNTExZDYyZi4uMzIzMWMwZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3Rv
bS9zdHJva2Utd2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N2Zy9j
dXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLWV4cGVjdGVkLnR4dApAQCAtMSwxNCArMSwxMyBAQAot
U1VDQ0VTUzogY2xpY2sgYXQgMTAsIDEwIHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzog
Y2xpY2sgcmVjZWl2ZWQgYXQ6IDMwLCAxMDAKLVNVQ0NFU1M6IGNsaWNrIGF0IDI5LCAxMDAgd2Fz
IGNvcnJlY3RseSBpZ25vcmVkCiBTVUNDRVNTOiBjbGljayByZWNlaXZlZCBhdDogMzAsIDUwCi1T
VUNDRVNTOiBjbGljayBhdCAzMCwgNDkgd2FzIGNvcnJlY3RseSBpZ25vcmVkCiBTVUNDRVNTOiBj
bGljayByZWNlaXZlZCBhdDogMzAsIDE1MAotU1VDQ0VTUzogY2xpY2sgYXQgMzAsIDE1MSB3YXMg
Y29ycmVjdGx5IGlnbm9yZWQKIFNVQ0NFU1M6IGNsaWNrIHJlY2VpdmVkIGF0OiAzMDAsIDEwMAot
U1VDQ0VTUzogY2xpY2sgYXQgMzAxLCAxMDAgd2FzIGNvcnJlY3RseSBpZ25vcmVkCiBTVUNDRVNT
OiBjbGljayByZWNlaXZlZCBhdDogMzAwLCA1MAotU1VDQ0VTUzogY2xpY2sgYXQgMzAwLCA0OSB3
YXMgY29ycmVjdGx5IGlnbm9yZWQKK1NVQ0NFU1M6IGNsaWNrIHJlY2VpdmVkIGF0OiAzMDEsIDEw
MAogU1VDQ0VTUzogY2xpY2sgcmVjZWl2ZWQgYXQ6IDMwMCwgMTUwCitTVUNDRVNTOiBjbGljayBh
dCAxMCwgMTAgd2FzIGNvcnJlY3RseSBpZ25vcmVkCitTVUNDRVNTOiBjbGljayBhdCAyOSwgMTAw
IHdhcyBjb3JyZWN0bHkgaWdub3JlZAorU1VDQ0VTUzogY2xpY2sgYXQgMzAsIDQ5IHdhcyBjb3Jy
ZWN0bHkgaWdub3JlZAorU1VDQ0VTUzogY2xpY2sgYXQgMzAsIDE1MSB3YXMgY29ycmVjdGx5IGln
bm9yZWQKK1NVQ0NFU1M6IGNsaWNrIGF0IDMwMCwgNDkgd2FzIGNvcnJlY3RseSBpZ25vcmVkCiBT
VUNDRVNTOiBjbGljayBhdCAzMDAsIDE1MSB3YXMgY29ycmVjdGx5IGlnbm9yZWQKLQpkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnIGIvTGF5
b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCmluZGV4IDE4MzU1OGQu
LjM4NDg5MTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tlLXdpZHRo
LWNsaWNrLnN2ZworKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGlj
ay5zdmcKQEAgLTU2LDIxICs1NiwyMyBAQAogICA8cGF0aCBkPSJNIDMwIDEwMCBMIDMwMSAxMDAi
IHN0cm9rZS13aWR0aD0iMTAwIiBzdHJva2U9InllbGxvdyIgb25jbGljaz0iZ290Q2xpY2soZXZ0
KSIgb25tb3VzZW92ZXI9ImdvdE1vdXNlRXZlbnQoZXZ0LCAnbW91c2VvdmVyJykiIG9ubW91c2Vv
dXQ9ImdvdE1vdXNlRXZlbnQoZXZ0LCAnbW91c2VvdXQnKSIgb25tb3VzZW1vdmU9ImdvdE1vdXNl
RXZlbnQoZXZ0LCAnbW91c2Vtb3ZlJykiIC8+CiAgIDx0ZXh0IGlkPSJtb3VzZW92ZXItdGV4dCIg
eD0iMzAiIHk9IjE5MCI+PC90ZXh0PgogICAKKyAgPCEtLSBUaGUgZm9sbG93aW5nIG1vdXNlIGV2
ZW50cyBhcmUgc3BhY2VkIGV4cGxpY2l0eSB0byBwcmV2ZW50IHRyaWdnZXJpbmcgZG91YmxlLWNs
aWNrIGxvZ2ljIC0tPgogICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiAgIDwhW0NE
QVRBWwogICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKLSAgICAgIHRlc3RDbGljaygxMCwg
MTAsIGZhbHNlKTsKICAgICAgIHRlc3RDbGljaygzMCwgMTAwLCB0cnVlKTsKLSAgICAgIHRlc3RD
bGljaygyOSwgMTAwLCBmYWxzZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAsIDUwLCB0cnVlKTsKLSAg
ICAgIHRlc3RDbGljaygzMCwgNDksIGZhbHNlKTsKICAgICAgIHRlc3RDbGljaygzMCwgMTUwLCB0
cnVlKTsKLSAgICAgIHRlc3RDbGljaygzMCwgMTUxLCBmYWxzZSk7CiAgICAgICB0ZXN0Q2xpY2so
MzAwLCAxMDAsIHRydWUpOwotICAgICAgdGVzdENsaWNrKDMwMSwgMTAwLCBmYWxzZSk7CiAgICAg
ICB0ZXN0Q2xpY2soMzAwLCA1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMzAwLCA0OSwgZmFs
c2UpOworICAgICAgdGVzdENsaWNrKDMwMSwgMTAwLCB0cnVlKTsKICAgICAgIHRlc3RDbGljaygz
MDAsIDE1MCwgdHJ1ZSk7CisKKyAgICAgIHRlc3RDbGljaygxMCwgMTAsIGZhbHNlKTsKKyAgICAg
IHRlc3RDbGljaygyOSwgMTAwLCBmYWxzZSk7CisgICAgICB0ZXN0Q2xpY2soMzAsIDQ5LCBmYWxz
ZSk7CisgICAgICB0ZXN0Q2xpY2soMzAsIDE1MSwgZmFsc2UpOworICAgICAgdGVzdENsaWNrKDMw
MCwgNDksIGZhbHNlKTsKICAgICAgIHRlc3RDbGljaygzMDAsIDE1MSwgZmFsc2UpOwogICAgIH0g
ZWxzZSB7CiAgICAgICBsb2coIkVSUk9SOiB3aW5kb3cuZXZlbnRTZW5kZXIgbm90IGZvdW5kISAg
VGhpcyB0ZXN0IG11c3QgYmUgcnVuIHVzaW5nIER1bXBSZW5kZXJUcmVlLiAgTW91c2luZyBvdmVy
IHRoZSB5ZWxsb3cgYXJlYSB3aWxsIGxvZyBob3dldmVyLiIpOwo=
</data>
<flag name="review"
          id="29600"
          type_id="1"
          status="+"
          setter="darin"
    />
    <flag name="commit-queue"
          id="29614"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>47221</attachid>
            <date>2010-01-22 13:19:20 -0800</date>
            <delta_ts>2010-01-22 22:35:27 -0800</delta_ts>
            <desc>Updated patch (re-adds missing newline)</desc>
            <filename>updated-swc-patch.patch</filename>
            <type>text/plain</type>
            <size>5556</size>
            <attacher name="Garret Kelly">gdk</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv
ZwppbmRleCAxOWVmMzY5Li44NDAyMzRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEt
MjIgIEdhcnJldCBLZWxseSAgPGdka0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4aW5nIHN2Zy9jdXN0b20vc3Ryb2tlLXdp
ZHRoLWNsaWNrLnN2ZyB0byBub3QgY2F1c2UgdGhlIGRvdWJsZS1jbGljaworICAgICAgICBoYW5k
bGVyIHRvIGZpcmUgb24gY2VydGFpbiBwbGF0Zm9ybXMgKGNocm9taXVtLCBmb3Igb25lKS4gQ2hy
b21pdW0sCisgICAgICAgIExlb3BhcmQsIGFuZCBHVEsgYWxsIGFncmVlIG9uIHRoZSBjYWxjdWxh
dGVkIGV4dGVudHMgb2YgdGhlIHNoYXBlLCBzbyBJJ20KKyAgICAgICAgZGlzYWJsaW5nIHRoaXMg
dGVzdCBvbiBtYWMtdGlnZXIgYW5kIHJlLWVuYWJsaW5nIGl0IG9uIG1hYy1sZW9wYXJkIGFuZAor
ICAgICAgICB1cGRhdGluZyB0aGUgZXhwZWN0ZWQgZmlsZSB0byByZWZsZWN0IHRoZSBjdXJyZW50
IHN0YXRlIG9mIHRoZSB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MzM4NjUKKworICAgICAgICAqIHBsYXRmb3JtL21hYy1sZW9wYXJkL1NraXBw
ZWQ6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQ6CisgICAgICAgICogc3Zn
L2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN2Zy9j
dXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZzoKKwogMjAxMC0wMS0yMiAgQWRhbSBSb2JlbiAg
PGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hlY2sgaW4gZXhwZWN0ZWQgZmFpbHVyZSBy
ZXN1bHRzIGZvciB0ZXh0LXpvb20ueGh0bWwgb24gV2luZG93cwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt
L21hYy1sZW9wYXJkL1NraXBwZWQKaW5kZXggZDFhNWNmNS4uZjQ1NDVkYiAxMDA2NDQKLS0tIGEv
TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0
cy9wbGF0Zm9ybS9tYWMtbGVvcGFyZC9Ta2lwcGVkCkBAIC01LDkgKzUsNiBAQCBodHRwL3Rlc3Rz
L3NlY3VyaXR5L2ZyYW1lLWxvYWRpbmctdmlhLWRvY3VtZW50LXdyaXRlLmh0bWwKICMgPHJkYXI6
Ly9wcm9ibGVtLzU2ODY1NTI+IHN2Zy9jc3MvZ2x5cGgtb3JpZW50YXRpb24tcm91bmRpbmctdGVz
dC54aHRtbCBzb21ldGltZXMgZmFpbHMKIHN2Zy9jc3MvZ2x5cGgtb3JpZW50YXRpb24tcm91bmRp
bmctdGVzdC54aHRtbAogCi0jIDxyZGFyOi8vcHJvYmxlbS81NTM5ODIyPiBSRUdSRVNTSU9OIChM
ZW9wYXJkKTogc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnIHRlc3QgZmFpbGluZwot
c3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCi0KICMgVGVzdHMgb2YgdGFibGUgYWNj
ZXNzaWJpbGl0eSBmdW5jdGlvbmFsaXR5IG5vdCBzdXBwb3J0ZWQgb24gTGVvcGFyZAogcGxhdGZv
cm0vbWFjL2FjY2Vzc2liaWxpdHkvdGFibGUtbXVsdGktYm9kaWVzLmh0bWwKICMgTGlzdHMgYXJl
IG5vdCBzdXBwb3J0ZWQgb24gTGVvcGFyZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm
b3JtL21hYy1zbm93bGVvcGFyZC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNu
b3dsZW9wYXJkL1NraXBwZWQKaW5kZXggM2E0MzI4ZS4uYTIwMDUzMCAxMDA2NDQKLS0tIGEvTGF5
b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz
dHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkL1NraXBwZWQKQEAgLTIxLDcgKzIxLDYgQEAgc3Zn
L2JhdGlrL3BhaW50cy9wYXR0ZXJuUmVnaW9uQS5zdmcKIHN2Zy9jdXN0b20vcGF0aC1iYWQtZGF0
YS5zdmcKIHN2Zy9jdXN0b20vcGF0dGVybi1kZWVwLXJlZmVyZW5jaW5nLnN2Zwogc3ZnL2N1c3Rv
bS9wcmVzZXJ2ZS1hc3BlY3QtcmF0aW8tc3ludGF4LnN2Zwotc3ZnL2N1c3RvbS9zdHJva2Utd2lk
dGgtY2xpY2suc3ZnCiBzdmcvY3VzdG9tL3ZpZXdib3gtc3ludGF4LnN2Zwogc3ZnL2hpeGllL3Bl
cmYvMDA3LnhtbAogc3ZnL3RyYW5zZm9ybXMvdGV4dC13aXRoLXBhdHRlcm4taW5zaWRlLXRyYW5z
Zm9ybWVkLWh0bWwueGh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy10
aWdlci9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQKaW5k
ZXggZGMwOWVmYi4uMzI5NDUzNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj
LXRpZ2VyL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBw
ZWQKQEAgLTk4LDMgKzk4LDcgQEAgaHR0cC90ZXN0cy9tZWRpYS92aWRlby1lcnJvci1hYm9ydC5o
dG1sCiAjIEZhaWxzIGludGVybWl0dGVudGx5IG9uIFRpZ2VyIEJ1aWxkIEJvdC4KICMgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNDEyCiBodHRwL3Rlc3RzL3htbGh0
dHByZXF1ZXN0L2xvZ291dC5odG1sCisKKyMgVGhpcyB3YXMgZmxhZ2dlZCBhcyBhIHJlZ3Jlc3Np
b24gaW4gTGVvcGFyZCBhbmQgU25vdyBMZW9wYXJkLCBidXQgdGhlCisjIGJlaGF2aW91ciBpcyBj
b25zaXN0ZW50IHdpdGggb3RoZXIgcGxhdGZvcm1zLiA8cmRhcjovL3Byb2JsZW0vNTUzOTgyMj4K
K3N2Zy9jdXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz
dHMvc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2stZXhwZWN0ZWQudHh0CmluZGV4IDUxMWQ2
MmYuLjY4ZjY1ZTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tlLXdp
ZHRoLWNsaWNrLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9r
ZS13aWR0aC1jbGljay1leHBlY3RlZC50eHQKQEAgLTEsMTQgKzEsMTQgQEAKLVNVQ0NFU1M6IGNs
aWNrIGF0IDEwLCAxMCB3YXMgY29ycmVjdGx5IGlnbm9yZWQKIFNVQ0NFU1M6IGNsaWNrIHJlY2Vp
dmVkIGF0OiAzMCwgMTAwCi1TVUNDRVNTOiBjbGljayBhdCAyOSwgMTAwIHdhcyBjb3JyZWN0bHkg
aWdub3JlZAogU1VDQ0VTUzogY2xpY2sgcmVjZWl2ZWQgYXQ6IDMwLCA1MAotU1VDQ0VTUzogY2xp
Y2sgYXQgMzAsIDQ5IHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xpY2sgcmVjZWl2
ZWQgYXQ6IDMwLCAxNTAKLVNVQ0NFU1M6IGNsaWNrIGF0IDMwLCAxNTEgd2FzIGNvcnJlY3RseSBp
Z25vcmVkCiBTVUNDRVNTOiBjbGljayByZWNlaXZlZCBhdDogMzAwLCAxMDAKLVNVQ0NFU1M6IGNs
aWNrIGF0IDMwMSwgMTAwIHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xpY2sgcmVj
ZWl2ZWQgYXQ6IDMwMCwgNTAKLVNVQ0NFU1M6IGNsaWNrIGF0IDMwMCwgNDkgd2FzIGNvcnJlY3Rs
eSBpZ25vcmVkCitTVUNDRVNTOiBjbGljayByZWNlaXZlZCBhdDogMzAxLCAxMDAKIFNVQ0NFU1M6
IGNsaWNrIHJlY2VpdmVkIGF0OiAzMDAsIDE1MAorU1VDQ0VTUzogY2xpY2sgYXQgMTAsIDEwIHdh
cyBjb3JyZWN0bHkgaWdub3JlZAorU1VDQ0VTUzogY2xpY2sgYXQgMjksIDEwMCB3YXMgY29ycmVj
dGx5IGlnbm9yZWQKK1NVQ0NFU1M6IGNsaWNrIGF0IDMwLCA0OSB3YXMgY29ycmVjdGx5IGlnbm9y
ZWQKK1NVQ0NFU1M6IGNsaWNrIGF0IDMwLCAxNTEgd2FzIGNvcnJlY3RseSBpZ25vcmVkCitTVUND
RVNTOiBjbGljayBhdCAzMDAsIDQ5IHdhcyBjb3JyZWN0bHkgaWdub3JlZAogU1VDQ0VTUzogY2xp
Y2sgYXQgMzAwLCAxNTEgd2FzIGNvcnJlY3RseSBpZ25vcmVkCiAKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL3N2Zy9jdXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZyBiL0xheW91dFRlc3RzL3N2
Zy9jdXN0b20vc3Ryb2tlLXdpZHRoLWNsaWNrLnN2ZwppbmRleCAxODM1NThkLi4zODQ4OTE1IDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3N0cm9rZS13aWR0aC1jbGljay5zdmcK
KysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9zdHJva2Utd2lkdGgtY2xpY2suc3ZnCkBAIC01
NiwyMSArNTYsMjMgQEAKICAgPHBhdGggZD0iTSAzMCAxMDAgTCAzMDEgMTAwIiBzdHJva2Utd2lk
dGg9IjEwMCIgc3Ryb2tlPSJ5ZWxsb3ciIG9uY2xpY2s9ImdvdENsaWNrKGV2dCkiIG9ubW91c2Vv
dmVyPSJnb3RNb3VzZUV2ZW50KGV2dCwgJ21vdXNlb3ZlcicpIiBvbm1vdXNlb3V0PSJnb3RNb3Vz
ZUV2ZW50KGV2dCwgJ21vdXNlb3V0JykiIG9ubW91c2Vtb3ZlPSJnb3RNb3VzZUV2ZW50KGV2dCwg
J21vdXNlbW92ZScpIiAvPgogICA8dGV4dCBpZD0ibW91c2VvdmVyLXRleHQiIHg9IjMwIiB5PSIx
OTAiPjwvdGV4dD4KICAgCisgIDwhLS0gVGhlIGZvbGxvd2luZyBtb3VzZSBldmVudHMgYXJlIHNw
YWNlZCBleHBsaWNpdHkgdG8gcHJldmVudCB0cmlnZ2VyaW5nIGRvdWJsZS1jbGljayBsb2dpYyAt
LT4KICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICA8IVtDREFUQVsKICAgICBp
ZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICB0ZXN0Q2xpY2soMTAsIDEwLCBmYWxzZSk7
CiAgICAgICB0ZXN0Q2xpY2soMzAsIDEwMCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xpY2soMjksIDEw
MCwgZmFsc2UpOwogICAgICAgdGVzdENsaWNrKDMwLCA1MCwgdHJ1ZSk7Ci0gICAgICB0ZXN0Q2xp
Y2soMzAsIDQ5LCBmYWxzZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAsIDE1MCwgdHJ1ZSk7Ci0gICAg
ICB0ZXN0Q2xpY2soMzAsIDE1MSwgZmFsc2UpOwogICAgICAgdGVzdENsaWNrKDMwMCwgMTAwLCB0
cnVlKTsKLSAgICAgIHRlc3RDbGljaygzMDEsIDEwMCwgZmFsc2UpOwogICAgICAgdGVzdENsaWNr
KDMwMCwgNTAsIHRydWUpOwotICAgICAgdGVzdENsaWNrKDMwMCwgNDksIGZhbHNlKTsKKyAgICAg
IHRlc3RDbGljaygzMDEsIDEwMCwgdHJ1ZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAwLCAxNTAsIHRy
dWUpOworCisgICAgICB0ZXN0Q2xpY2soMTAsIDEwLCBmYWxzZSk7CisgICAgICB0ZXN0Q2xpY2so
MjksIDEwMCwgZmFsc2UpOworICAgICAgdGVzdENsaWNrKDMwLCA0OSwgZmFsc2UpOworICAgICAg
dGVzdENsaWNrKDMwLCAxNTEsIGZhbHNlKTsKKyAgICAgIHRlc3RDbGljaygzMDAsIDQ5LCBmYWxz
ZSk7CiAgICAgICB0ZXN0Q2xpY2soMzAwLCAxNTEsIGZhbHNlKTsKICAgICB9IGVsc2UgewogICAg
ICAgbG9nKCJFUlJPUjogd2luZG93LmV2ZW50U2VuZGVyIG5vdCBmb3VuZCEgIFRoaXMgdGVzdCBt
dXN0IGJlIHJ1biB1c2luZyBEdW1wUmVuZGVyVHJlZS4gIE1vdXNpbmcgb3ZlciB0aGUgeWVsbG93
IGFyZWEgd2lsbCBsb2cgaG93ZXZlci4iKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>