33864 2010-01-19 13:51:02 -0800 REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset() 2010-01-19 14:18:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 enrica webkit-unassigned oldest_to_newest 182433 0 enrica 2010-01-19 13:51:02 -0800 REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset() 182440 1 46951 enrica 2010-01-19 13:56:52 -0800 Created attachment 46951 Patch 182447 2 46951 simon.fraser 2010-01-19 14:10:13 -0800 Comment on attachment 46951 Patch > Index: WebCore/ChangeLog > =================================================================== > + REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset() > + https://bugs.webkit.org/show_bug.cgi?id=33864 > + <rdar://problem/7552959> > + > + Regression has been introduced by changeset 53085. > + The original fix had to be limited to editable content. Could you reword this to explain it without reference to the original change? > Index: LayoutTests/editing/selection/selection-applet.html > =================================================================== > --- LayoutTests/editing/selection/selection-applet.html (revision 0) > +++ LayoutTests/editing/selection/selection-applet.html (revision 0) > @@ -0,0 +1,10 @@ > +<body> > +<script language="JavaScript" type="text/javascript"> > +if (window.layoutTestController) > + layoutTestController.dumpAsText(); > + > +document.write('<applet id="test" width="400" height="400" name="test applet" code="test.class" codebase="." mayscript>'); > +document.write('You need Java(tm) to view this presentation. <a href="http://www.java.com">Download Java</a></applet> '); > +window.getSelection().setPosition(document.getElementById("test"), 0); > +</script> > +</body> Does the testcase really require Java, or would a simpler test with divs suffice? Also, is it required to document.write the test content? r=me, but it would be nice to make the testcase more generic if possible. 182455 3 enrica 2010-01-19 14:18:09 -0800 Committed revision 53494 46951 2010-01-19 13:56:52 -0800 2010-01-19 14:10:13 -0800 Patch bug-33864-20100119135651.patch text/plain 3431 enrica SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzQ4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMTkgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS RUdSRVNTSU9OOiBJbmZpbml0ZSByZWN1cnNpb24gaW4gUG9zaXRpb246OmdldElubGluZUJveEFu ZE9mZnNldCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMzg2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzU1Mjk1OT4KKyAgICAgICAgCisgICAg ICAgIFJlZ3Jlc3Npb24gaGFzIGJlZW4gaW50cm9kdWNlZCBieSBjaGFuZ2VzZXQgNTMwODUuCisg ICAgICAgIFRoZSBvcmlnaW5hbCBmaXggaGFkIHRvIGJlIGxpbWl0ZWQgdG8gZWRpdGFibGUgY29u dGVudC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Rpb24tYXBwbGV0 Lmh0bWwKKworICAgICAgICAqIGRvbS9Qb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQ b3NpdGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KToKKwogMjAxMC0wMS0xOSAgSmFpbWUgWWFw ICA8amFpbWV5YXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxk bWFuLgpJbmRleDogV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvZG9tL1Bvc2l0aW9uLmNwcAkocmV2aXNpb24gNTM0ODcpCisrKyBXZWJDb3JlL2RvbS9Qb3Np dGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMTMsMTEgKzEwMTMsMTIgQEAgdm9pZCBQb3Np dGlvbjo6Z2V0SW5saW5lQm94QW5kT2Zmc2V0KEVBZgogICAgICAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgICAgIH0KICAgICAgICAgfQorICAgICAgICBpbmxpbmVCb3ggPSAwOwogICAgICAg ICBpZiAocmVuZGVyZXItPmlzQm94KCkpIHsKICAgICAgICAgICAgIGlubGluZUJveCA9IHRvUmVu ZGVyQm94KHJlbmRlcmVyKS0+aW5saW5lQm94V3JhcHBlcigpOwogICAgICAgICAgICAgaWYgKCFp bmxpbmVCb3ggfHwgKGNhcmV0T2Zmc2V0ID4gaW5saW5lQm94LT5jYXJldE1pbk9mZnNldCgpICYm IGNhcmV0T2Zmc2V0IDwgaW5saW5lQm94LT5jYXJldE1heE9mZnNldCgpKSkKICAgICAgICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgIH0gZWxzZSB7CisgICAgICAgIH0gZWxzZSBpZiAobm9kZSgp LT5pc0NvbnRlbnRFZGl0YWJsZSgpKSB7CiAgICAgICAgICAgICBQb3NpdGlvbiBwb3MgPSBwb3Np dGlvbkluUGFyZW50QmVmb3JlTm9kZShub2RlKCkpLnVwc3RyZWFtKCk7CiAgICAgICAgICAgICBw b3MuZ2V0SW5saW5lQm94QW5kT2Zmc2V0KERPV05TVFJFQU0sIHByaW1hcnlEaXJlY3Rpb24sIGlu bGluZUJveCwgY2FyZXRPZmZzZXQpOwogICAgICAgICAgICAgcmV0dXJuOwpJbmRleDogTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2 aXNpb24gNTM0ODgpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNCBAQAorMjAxMC0wMS0xOSAgRW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJF R1JFU1NJT046IEluZmluaXRlIHJlY3Vyc2lvbiBpbiBQb3NpdGlvbjo6Z2V0SW5saW5lQm94QW5k T2Zmc2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMzODY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTUyOTU5PgorCisgICAgICAgICogZWRp dGluZy9zZWxlY3Rpb24vc2VsZWN0aW9uLWFwcGxldC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg ICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdGlvbi1hcHBsZXQuaHRtbDogQWRkZWQuCisK IDIwMTAtMDEtMTkgIEphaW1lIFlhcCAgPGphaW1leWFwQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2Vs ZWN0aW9uL3NlbGVjdGlvbi1hcHBsZXQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdGlvbi1hcHBsZXQtZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0aW9uLWFw cGxldC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1lvdSBuZWVkIEph dmEodG0pIHRvIHZpZXcgdGhpcyBwcmVzZW50YXRpb24uIERvd25sb2FkIEphdmEKSW5kZXg6IExh eW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL3NlbGVjdGlvbi1hcHBsZXQuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Rpb24tYXBwbGV0Lmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Rp b24tYXBwbGV0Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKKzxib2R5PgorPHNj cmlwdCBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2lmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBBc1RleHQoKTsKKworZG9jdW1lbnQud3JpdGUoJzxhcHBsZXQgaWQ9InRlc3QiIHdpZHRoPSI0 MDAiIGhlaWdodD0iNDAwIiBuYW1lPSJ0ZXN0IGFwcGxldCIgY29kZT0idGVzdC5jbGFzcyIgY29k ZWJhc2U9Ii4iIG1heXNjcmlwdD4nKTsKK2RvY3VtZW50LndyaXRlKCdZb3UgbmVlZCBKYXZhKHRt KSB0byB2aWV3IHRoaXMgcHJlc2VudGF0aW9uLiA8YSBocmVmPSJodHRwOi8vd3d3LmphdmEuY29t Ij5Eb3dubG9hZCBKYXZhPC9hPjwvYXBwbGV0PiAnKTsKK3dpbmRvdy5nZXRTZWxlY3Rpb24oKS5z ZXRQb3NpdGlvbihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpLCAwKTsKKzwvc2NyaXB0 PgorPC9ib2R5Pgo=