33863 2010-01-19 13:42:19 -0800 Occasional crash when interacting with page with reflected WebGL 2010-01-19 16:45:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 182427 0 simon.fraser 2010-01-19 13:42:19 -0800 There's an issue where compositing layers for a reflection can be torn down, without clearing the original layer's replicaLayer pointer. 182432 1 46949 simon.fraser 2010-01-19 13:50:09 -0800 Created attachment 46949 Patch 182469 2 46949 mitz 2010-01-19 14:39:20 -0800 Comment on attachment 46949 Patch > if (layer->backing()) { > + // If we're removing backing on a reflection, clear the source GraphicsLayer's pointer to > + // its replica GraphicsLayer. In practise this should never happen So can we add an assertion? > + if (layer->isReflection()) { > + RenderLayer* sourceLayer = toRenderBoxModelObject(layer->renderer()->parent())->layer(); > + if (RenderLayerBacking* backing = sourceLayer->backing()) > + backing->graphicsLayer()->setReplicatedByLayer(0); And also assert right before here that the graphicsLayer currently thinks that it’s replicated by our layer? r=me 182507 3 simon.fraser 2010-01-19 16:37:59 -0800 http://trac.webkit.org/changeset/53507 182519 4 simon.fraser 2010-01-19 16:45:37 -0800 http://trac.webkit.org/changeset/53507 46949 2010-01-19 13:50:09 -0800 2010-01-19 14:39:39 -0800 Patch bug-33863-20100119135008.patch text/plain 6035 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjkwZGIyOS4uOTY0MDlhZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzNSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIE9jY2FzaW9uYWwgY3Jhc2ggd2hlbiBpbnRlcmVyYWN0 aW5nIHdpdGggcGFnZSB3aXRoIHJlZmxlY3RlZCBXZWJHTAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4NjMKKyAgICAgICAgCisgICAgICAgIElmIHVw ZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKCkgd2FzIGNhbGxlZCB3aXRoIGFuIHVwZGF0ZVJvb3QgdGhh dCB3YXMgYSByZWZsZWN0aW9uIGxheWVyLAorICAgICAgICB0aGVuIHdlIHdvdWxkIGRldGVybWlu ZSB0aGF0IHRoZSBsYXllciBkb2VzIG5vdCByZXF1aXJlIGNvbXBvc2l0aW5nLCBhbmQgdGVhciBk b3duIGl0cworICAgICAgICBiYWNraW5nICh3aXRob3V0IGNsZWFyaW5nIHJlcGxpY2FMYXllcigp IG9uIHRoZSBzb3VyY2UgbGF5ZXIncyBHcmFwaGljc0xheWVyKS4KKyAgICAgICAgCisgICAgICAg IEZpeCBieSBjaGFuZ2luZyByZXF1aXJlc0NvbXBvc2l0aW5nTGF5ZXIoKSBvbiBhIHJlZmxlY3Rp b24gbGF5ZXIgdG8gYWx3YXlzIGdpdmUgdGhlCisgICAgICAgIHNhbWUgYW5zd2VyIGZvciBhIHJl ZmxlY3Rpb24gYW5kIGl0cyBvcmlnaW5hbC4KKyAgICAgICAgCisgICAgICAgIEFsc28gYWRkIHZh cmlvdXMgYmVsdC1hbmQtYnJhbmNlcyBjb2RlIGFuZCBudWxsIGNoZWNrcyB0byBlbnN1cmUgdGhh dCBpZiB3ZSBldmVyIGVuZCB1cAorICAgICAgICB3aXRoIGEgbm9uLWNvbXBvc2l0ZWQgcmVmbGVj dGlvbiBsYXllciwgd2Ugd29uJ3QgY3Jhc2guCisgICAgICAgIAorICAgICAgICBObyBuZXcgdGVz dHMsIGJlY2F1c2UgdGhlIGNyYXNoIGRlcGVuZHMgb24gdGltaW5nIGlzc3VlcyB0aGF0IGFyZSBo YXJkIHRvIHJlcHJvZHVjZSBpbiBhIHRlc3QuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9z aXRvcjo6dXBkYXRlQmFja2luZyk6IENsZWFyIHRoZSBzb3VyY2UgbGF5ZXIncyByZXBsaWNhIGxh eWVyCisgICAgICAgIHBvaW50ZXIgaWYgdGVhcmluZyBkb3duIGJhY2tpbmcgc3RvcmUgb2YgYSBy ZWZsZWN0aW9uLgorICAgICAgICAKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9z aXRvcjo6cmVidWlsZENvbXBvc2l0aW5nTGF5ZXJUcmVlKTogTnVsbC1jaGVjayByZWZsZWN0aW9u LT5iYWNraW5nKCkuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVw ZGF0ZUxheWVyVHJlZUdlb21ldHJ5KTogTnVsbC1jaGVjayByZWZsZWN0aW9uLT5iYWNraW5nKCku CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OnVwZGF0ZUNvbXBvc2l0 aW5nRGVzY2VuZGFudEdlb21ldHJ5KTogcmVmbGVjdGlvbi0+YmFja2luZygpLgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nTGF5ZXIp OiBJZiBiZWluZyBjYWxsZWQgZm9yIGEgcmVmbGVjdGlvbiBsYXllciwKKyAgICAgICAgdXNlIHRo ZSBzb3VyY2UgbGF5ZXIgdG8gYW5zd2VyIHRoZSBxdWVzdGlvbi4gICAgICAgIAorCisyMDEwLTAx LTE5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFNvbWUgY29tcG9zaXRlZCByZWZs ZWN0aW9ucyBpbmNvcnJlY3RseSBwb3NpdGlvbmVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzg1NgogICAgICAgICAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDlhN2YzZTUuLjVkZjEyNjQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMzgsOCArMzgs OSBAQAogI2luY2x1ZGUgIkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJIVE1MQ2FudmFzRWxl bWVudC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKLSNpbmNsdWRlICJSZW5kZXJMYXllckJhY2tpbmcu aCIKICNpbmNsdWRlICJSZW5kZXJFbWJlZGRlZE9iamVjdC5oIgorI2luY2x1ZGUgIlJlbmRlckxh eWVyQmFja2luZy5oIgorI2luY2x1ZGUgIlJlbmRlclJlcGxpY2EuaCIKICNpbmNsdWRlICJSZW5k ZXJWaWRlby5oIgogI2luY2x1ZGUgIlJlbmRlclZpZXcuaCIKICNpbmNsdWRlICJTZXR0aW5ncy5o IgpAQCAtMjM3LDYgKzIzOCwxNSBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRl QmFja2luZyhSZW5kZXJMYXllciogbGF5ZXIsIENvbXBvc2l0aW5nQ2hhbmdlUgogICAgICAgICB9 CiAgICAgfSBlbHNlIHsKICAgICAgICAgaWYgKGxheWVyLT5iYWNraW5nKCkpIHsKKyAgICAgICAg ICAgIC8vIElmIHdlJ3JlIHJlbW92aW5nIGJhY2tpbmcgb24gYSByZWZsZWN0aW9uLCBjbGVhciB0 aGUgc291cmNlIEdyYXBoaWNzTGF5ZXIncyBwb2ludGVyIHRvCisgICAgICAgICAgICAvLyBpdHMg cmVwbGljYSBHcmFwaGljc0xheWVyLiBJbiBwcmFjdGlzZSB0aGlzIHNob3VsZCBuZXZlciBoYXBw ZW4gYmVjYXVzZSByZWZsZWN0ZWUgYW5kIHJlZmxlY3Rpb24gCisgICAgICAgICAgICAvLyBhcmUg Ym90aCBlaXRoZXIgY29tcG9zaXRlZCwgb3Igbm90IGNvbXBvc2l0ZWQuCisgICAgICAgICAgICBp ZiAobGF5ZXItPmlzUmVmbGVjdGlvbigpKSB7CisgICAgICAgICAgICAgICAgUmVuZGVyTGF5ZXIq IHNvdXJjZUxheWVyID0gdG9SZW5kZXJCb3hNb2RlbE9iamVjdChsYXllci0+cmVuZGVyZXIoKS0+ cGFyZW50KCkpLT5sYXllcigpOworICAgICAgICAgICAgICAgIGlmIChSZW5kZXJMYXllckJhY2tp bmcqIGJhY2tpbmcgPSBzb3VyY2VMYXllci0+YmFja2luZygpKQorICAgICAgICAgICAgICAgICAg ICBiYWNraW5nLT5ncmFwaGljc0xheWVyKCktPnNldFJlcGxpY2F0ZWRCeUxheWVyKDApOworICAg ICAgICAgICAgfQorICAgICAgICAgICAgCiAgICAgICAgICAgICBsYXllci0+Y2xlYXJCYWNraW5n KCk7CiAgICAgICAgICAgICBsYXllckNoYW5nZWQgPSB0cnVlOwogCkBAIC02MjQsOCArNjM0LDEw IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZWJ1aWxkQ29tcG9zaXRpbmdMYXllclRy ZWUoUmVuZGVyTGF5ZXIqIGxheWVyLCBjb25zCiAgICAgICAgIC8vIHdlIGNhbiBjb21wdXRlIGFu ZCBjYWNoZSB0aGUgY29tcG9zaXRlZCBib3VuZHMgZm9yIHRoaXMgbGF5ZXIuCiAgICAgICAgIGxh eWVyQmFja2luZy0+dXBkYXRlQ29tcG9zaXRlZEJvdW5kcygpOwogCi0gICAgICAgIGlmIChsYXll ci0+cmVmbGVjdGlvbkxheWVyKCkpCi0gICAgICAgICAgICBsYXllci0+cmVmbGVjdGlvbkxheWVy KCktPmJhY2tpbmcoKS0+dXBkYXRlQ29tcG9zaXRlZEJvdW5kcygpOworICAgICAgICBpZiAoUmVu ZGVyTGF5ZXIqIHJlZmxlY3Rpb24gPSBsYXllci0+cmVmbGVjdGlvbkxheWVyKCkpIHsKKyAgICAg ICAgICAgIGlmIChyZWZsZWN0aW9uLT5iYWNraW5nKCkpCisgICAgICAgICAgICAgICAgcmVmbGVj dGlvbi0+YmFja2luZygpLT51cGRhdGVDb21wb3NpdGVkQm91bmRzKCk7CisgICAgICAgIH0KIAog ICAgICAgICBsYXllckJhY2tpbmctPnVwZGF0ZUdyYXBoaWNzTGF5ZXJDb25maWd1cmF0aW9uKCk7 CiAgICAgICAgIGxheWVyQmFja2luZy0+dXBkYXRlR3JhcGhpY3NMYXllckdlb21ldHJ5KCk7CkBA IC03MDAsOCArNzEyLDEwIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVMYXll clRyZWVHZW9tZXRyeShSZW5kZXJMYXllciogbGF5ZXIpCiAgICAgICAgIC8vIHdlIGNhbiBjb21w dXRlIGFuZCBjYWNoZSB0aGUgY29tcG9zaXRlZCBib3VuZHMgZm9yIHRoaXMgbGF5ZXIuCiAgICAg ICAgIGxheWVyQmFja2luZy0+dXBkYXRlQ29tcG9zaXRlZEJvdW5kcygpOwogCi0gICAgICAgIGlm IChsYXllci0+cmVmbGVjdGlvbkxheWVyKCkpCi0gICAgICAgICAgICBsYXllci0+cmVmbGVjdGlv bkxheWVyKCktPmJhY2tpbmcoKS0+dXBkYXRlQ29tcG9zaXRlZEJvdW5kcygpOworICAgICAgICBp ZiAoUmVuZGVyTGF5ZXIqIHJlZmxlY3Rpb24gPSBsYXllci0+cmVmbGVjdGlvbkxheWVyKCkpIHsK KyAgICAgICAgICAgIGlmIChyZWZsZWN0aW9uLT5iYWNraW5nKCkpCisgICAgICAgICAgICAgICAg cmVmbGVjdGlvbi0+YmFja2luZygpLT51cGRhdGVDb21wb3NpdGVkQm91bmRzKCk7CisgICAgICAg IH0KIAogICAgICAgICBsYXllckJhY2tpbmctPnVwZGF0ZUdyYXBoaWNzTGF5ZXJDb25maWd1cmF0 aW9uKCk7CiAgICAgICAgIGxheWVyQmFja2luZy0+dXBkYXRlR3JhcGhpY3NMYXllckdlb21ldHJ5 KCk7CkBAIC03NDMsOCArNzU3LDEwIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRh dGVDb21wb3NpdGluZ0Rlc2NlbmRhbnRHZW9tZXRyeShSZW5kZXJMYXllciogY29tCiAgICAgICAg IGlmIChSZW5kZXJMYXllckJhY2tpbmcqIGxheWVyQmFja2luZyA9IGxheWVyLT5iYWNraW5nKCkp IHsKICAgICAgICAgICAgIGxheWVyQmFja2luZy0+dXBkYXRlQ29tcG9zaXRlZEJvdW5kcygpOwog Ci0gICAgICAgICAgICBpZiAobGF5ZXItPnJlZmxlY3Rpb25MYXllcigpKQotICAgICAgICAgICAg ICAgIGxheWVyLT5yZWZsZWN0aW9uTGF5ZXIoKS0+YmFja2luZygpLT51cGRhdGVDb21wb3NpdGVk Qm91bmRzKCk7CisgICAgICAgICAgICBpZiAoUmVuZGVyTGF5ZXIqIHJlZmxlY3Rpb24gPSBsYXll ci0+cmVmbGVjdGlvbkxheWVyKCkpIHsKKyAgICAgICAgICAgICAgICBpZiAocmVmbGVjdGlvbi0+ YmFja2luZygpKQorICAgICAgICAgICAgICAgICAgICByZWZsZWN0aW9uLT5iYWNraW5nKCktPnVw ZGF0ZUNvbXBvc2l0ZWRCb3VuZHMoKTsKKyAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgbGF5 ZXJCYWNraW5nLT51cGRhdGVHcmFwaGljc0xheWVyR2VvbWV0cnkoKTsKICAgICAgICAgICAgIGlm ICh1cGRhdGVEZXB0aCA9PSBSZW5kZXJMYXllckJhY2tpbmc6OkNvbXBvc2l0aW5nQ2hpbGRyZW4p CkBAIC05MDUsNiArOTIxLDExIEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpuZWVkc1Rv QmVDb21wb3NpdGVkKGNvbnN0IFJlbmRlckxheWVyKiBsYXllcikgY29uc3QKIGJvb2wgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nTGF5ZXIoY29uc3QgUmVuZGVyTGF5 ZXIqIGxheWVyKSBjb25zdAogewogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBsYXllci0+ cmVuZGVyZXIoKTsKKyAgICAvLyBUaGUgY29tcG9zaXRpbmcgc3RhdGUgb2YgYSByZWZsZWN0aW9u IHNob3VsZCBtYXRjaCB0aGF0IG9mIGl0cyByZWZsZWN0ZWQgbGF5ZXIuCisgICAgaWYgKGxheWVy LT5pc1JlZmxlY3Rpb24oKSkgeworICAgICAgICByZW5kZXJlciA9IHJlbmRlcmVyLT5wYXJlbnQo KTsgLy8gVGhlIFJlbmRlclJlcGxpY2EncyBwYXJlbnQgaXMgdGhlIG9iamVjdCBiZWluZyByZWZs ZWN0ZWQuCisgICAgICAgIGxheWVyID0gdG9SZW5kZXJCb3hNb2RlbE9iamVjdChyZW5kZXJlcikt PmxheWVyKCk7CisgICAgfQogICAgIC8vIFRoZSByb290IGxheWVyIGFsd2F5cyBoYXMgYSBjb21w b3NpdGluZyBsYXllciwgYnV0IGl0IG1heSBub3QgaGF2ZSBiYWNraW5nLgogICAgIHJldHVybiAo aW5Db21wb3NpdGluZ01vZGUoKSAmJiBsYXllci0+aXNSb290TGF5ZXIoKSkgfHwKICAgICAgICAg ICAgICByZXF1aXJlc0NvbXBvc2l0aW5nRm9yVHJhbnNmb3JtKHJlbmRlcmVyKSB8fAo=