33855 2010-01-19 12:19:47 -0800 error events don't fire if no <source> elements passed to media engine 2010-01-19 13:16:09 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson aroben oldest_to_newest 182368 0 eric.carlson 2010-01-19 12:19:47 -0800 No error event is fired if a none of a media element's <source> elements has a valid src, media, or type attribute, but the spec says: "[If] the media element has neither a src attribute nor a source element child: set the networkState to NETWORK_EMPTY, and abort these steps; the synchronous section ends." To reproduce: 1. Download the attached test case to LayoutTests/media 2. run-webkit-tests media/video-source-error-no-candidate.html 182369 1 46934 eric.carlson 2010-01-19 12:20:19 -0800 Created attachment 46934 Test case 182399 2 46939 eric.carlson 2010-01-19 13:04:08 -0800 Created attachment 46939 Proposed patch 182408 3 eric.carlson 2010-01-19 13:15:50 -0800 <rdar://problem/7557393> 182409 4 eric.carlson 2010-01-19 13:16:09 -0800 http://trac.webkit.org/changeset/53486 46934 2010-01-19 12:20:19 -0800 2010-01-19 12:20:19 -0800 Test case video-source-error-no-candidate.html text/html 1761 eric.carlson PGh0bWwgbGFuZz0iZW4iPgogICAgPGhlYWQ+CiAgICAgICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29u dGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPgogICAgICAgIDx0 aXRsZT4mbHQ7dmlkZW8mZ3Q7IGFuZCAmbHQ7c291cmNlJmd0OyBlcnJvciB0ZXN0PC90aXRsZT4K ICAgICAgICA8c2NyaXB0IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgoKICAgICAgICA8c2Ny aXB0PgoKICAgICAgICAgICAgdmFyIHNvdXJjZXMgPSBbXTsKICAgICAgICAgICAgdmFyIGVycm9y Q291bnQgPSAwOwoKICAgICAgICAgICAgZnVuY3Rpb24gZXJyb3JFdmVudChldnQpCiAgICAgICAg ICAgIHsKICAgICAgICAgICAgICAgIHZhciBuZHg7CiAgICAgICAgICAgICAgICBmb3IgKG5keCA9 IDA7IG5keCA8IHNvdXJjZXMubGVuZ3RoOyBuZHgrKykgewogICAgICAgICAgICAgICAgICAgIGlm IChzb3VyY2VzW25keF0gPT0gZXZ0LnRhcmdldCkKICAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgICAgICAgICB9CgogICAgICAgICAgICAgICAgaWYgKHNvdXJjZXNbbmR4XSA9 PSBldnQudGFyZ2V0KQogICAgICAgICAgICAgICAgICAgIGxvZ1Jlc3VsdCh0cnVlLCAiRVZFTlQo ZXJyb3IpIGZyb20gJmx0O3NvdXJjZSBpZD0nPGVtPiIgKyBldnQudGFyZ2V0LmlkICsgIjwvZW0+ JyBzcmM9JzxlbT4iICsgcmVsYXRpdmVVUkwoZXZ0LnRhcmdldC5zcmMpICsgIjwvZW0+JyZndDsi KTsKICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICBsb2dSZXN1bHQoZmFs c2UsICJFVkVOVChlcnJvcikgZnJvbSAiICsgZXZ0LnRhcmdldCk7CgogICAgICAgICAgICAgICAg dGVzdEV4cGVjdGVkKCJ2aWRlby5lcnJvciIsIG51bGwpOwogICAgICAgICAgICAgICAgY29uc29s ZVdyaXRlKCIiKTsKICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgaWYgKCsrZXJyb3JD b3VudCA9PSAzKQogICAgICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoZW5kVGVzdCwgMTAwMCk7 CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKICAgICAgICAgICAg ewogICAgICAgICAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiZXJyb3IiLCBlcnJv ckV2ZW50LCB0cnVlKTsKCiAgICAgICAgICAgICAgICBzb3VyY2VzID0gZG9jdW1lbnQuZ2V0RWxl bWVudHNCeVRhZ05hbWUoJ3NvdXJjZScpOwoKICAgICAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1l bnQoKTsKICAgICAgICAgICAgICAgIHdhaXRGb3JFdmVudCgibG9hZHN0YXJ0Iik7CiAgICAgICAg ICAgIH0KICAgICAgICA8L3NjcmlwdD4KICAgIDwvaGVhZD4KCiAgICA8Ym9keSBvbmxvYWQ9InN0 YXJ0KCkiPgoKICAgICAgICA8dmlkZW8gY29udHJvbHM+CiAgICAgICAgICAgIDxzb3VyY2UgaWQ9 bWlzc2luZy1zcmMgdHlwZT0idmlkZW8vYmxhaGJsYWgiPgogICAgICAgICAgICA8c291cmNlIGlk PWJvZ3VzLXR5cGUgc3JjPWNvbnRlbnQvdGVzdC5tcDQgdHlwZT0idmlkZW8vYmxhaGJsYWgiPgog ICAgICAgICAgICA8c291cmNlIGlkPXVuc3VwcG9ydGVkLW1lZGlhLXF1ZXJ5IHNyYz1jb250ZW50 L3Rlc3QubXA0IG1lZGlhPXByaW50PgogICAgICAgIDwvdmlkZW8+CiAgICAgICAgCiAgICAgICAg PHA+VGVzdCB0aGF0ICdlcnJvcicgZXZlbnRzIGFyZSBmaXJlZCB3aGVuIG5vIHVybHMgYXJlIHBh c3NlZCB0byB0aGUgbWVkaWEgZW5naW5lLjwvcD4KCiAgICA8L2JvZHk+CjwvaHRtbD4K 46939 2010-01-19 13:04:08 -0800 2010-01-19 13:05:04 -0800 Proposed patch patch_1.txt text/plain 5706 eric.carlson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzQ4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTkgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgZXJyb3IgZXZlbnRzIGRvbid0IGZpcmUgaWYgbm8gPHNvdXJjZT4gZWxlbWVudHMgcGFzc2Vk IHRvIG1lZGlhIGVuZ2luZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzM4NTUKKworICAgICAgICBUZXN0OiBtZWRpYS92aWRlby1zb3VyY2UtZXJyb3It bm8tY2FuZGlkYXRlLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpzZWxlY3RNZWRpYVJlc291cmNl KTogT25seSBiYWlsIGVhcmx5IGlmCisgICAgICAgIHRoZXJlIGlzIG5vICdzcmMnIGF0dHJpYnV0 ZSBhbmQgbm8gPHNvdXJjZT4gY2hpbGQgZWxlbWVudHMgYXQgYWxsLgorCiAyMDEwLTAxLTE5ICBT dGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAJ KHJldmlzaW9uIDUzNDc4KQorKysgV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC00ODMsMTUgKzQ4MywyNCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OnNlbGVjdE1lZGlhUmVzb3VyCiAKICAgICAvLyAyIC0gQXN5bmNocm9ub3VzbHkgYXdhaXQgYSBz dGFibGUgc3RhdGUuCiAKLSAgICAvLyAzIC0gSWYgdGhlIG1lZGlhIGVsZW1lbnQgaGFzIG5laXRo ZXIgYSBzcmMgYXR0cmlidXRlIG5vciBhbnkgc291cmNlIGVsZW1lbnQgY2hpbGRyZW4sIHJ1biB0 aGVzZSBzdWJzdGVwcworICAgIC8vIDMgLSAuLi4gdGhlIG1lZGlhIGVsZW1lbnQgaGFzIG5laXRo ZXIgYSBzcmMgYXR0cmlidXRlIC4uLgogICAgIFN0cmluZyBtZWRpYVNyYyA9IGdldEF0dHJpYnV0 ZShzcmNBdHRyKTsKLSAgICBpZiAoIW1lZGlhU3JjICYmICFoYXZlUG90ZW50aWFsU291cmNlQ2hp bGQoKSkgewotICAgICAgICBtX2xvYWRTdGF0ZSA9IFdhaXRpbmdGb3JTb3VyY2U7CisgICAgaWYg KCFtZWRpYVNyYykgeworICAgICAgICAvLyAuLi4gbm9yIGEgc291cmNlIGVsZW1lbnQgY2hpbGQ6 IC4uLgorICAgICAgICBOb2RlKiBub2RlOworICAgICAgICBmb3IgKG5vZGUgPSBmaXJzdENoaWxk KCk7IG5vZGU7IG5vZGUgPSBub2RlLT5uZXh0U2libGluZygpKSB7CisgICAgICAgICAgICBpZiAo bm9kZS0+aGFzVGFnTmFtZShzb3VyY2VUYWcpKQorICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICB9CiAKLSAgICAgICAgLy8gMSAtIFNldCB0aGUgbmV0d29ya1N0YXRlIHRvIE5FVFdPUktf RU1QVFkgYW5kIGFib3J0IHRoZXNlIHN0ZXBzCi0gICAgICAgIG1fbmV0d29ya1N0YXRlID0gTkVU V09SS19FTVBUWTsKLSAgICAgICAgQVNTRVJUKCFtX2RlbGF5aW5nVGhlTG9hZEV2ZW50KTsKLSAg ICAgICAgcmV0dXJuOworICAgICAgICBpZiAoIW5vZGUpIHsKKyAgICAgICAgICAgIG1fbG9hZFN0 YXRlID0gV2FpdGluZ0ZvclNvdXJjZTsKKworICAgICAgICAgICAgLy8gLi4uIHNldCB0aGUgbmV0 d29ya1N0YXRlIHRvIE5FVFdPUktfRU1QVFksIGFuZCBhYm9ydCB0aGVzZSBzdGVwcworICAgICAg ICAgICAgbV9uZXR3b3JrU3RhdGUgPSBORVRXT1JLX0VNUFRZOworICAgICAgICAgICAgQVNTRVJU KCFtX2RlbGF5aW5nVGhlTG9hZEV2ZW50KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg fQogICAgIH0KIAogICAgIC8vIDQKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDUzNDgzKQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEt MTkgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZXJyb3IgZXZlbnRzIGRvbid0IGZp cmUgaWYgbm8gPHNvdXJjZT4gZWxlbWVudHMgcGFzc2VkIHRvIG1lZGlhIGVuZ2luZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM4NTUKKworICAgICAg ICAqIG1lZGlhL3ZpZGVvLXNvdXJjZS1lcnJvci1uby1jYW5kaWRhdGUtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBtZWRpYS92aWRlby1zb3VyY2UtZXJyb3Itbm8tY2FuZGlkYXRlLmh0 bWw6IEFkZGVkLgorCiAyMDEwLTAxLTE5ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtZXJyb3Itbm8tY2FuZGlkYXRlLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtZXJyb3Itbm8tY2Fu ZGlkYXRlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL3Zp ZGVvLXNvdXJjZS1lcnJvci1uby1jYW5kaWRhdGUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDE1IEBACitUZXN0IHRoYXQgJ2Vycm9yJyBldmVudHMgYXJlIGZpcmVkIHdoZW4g bm8gdXJscyBhcmUgcGFzc2VkIHRvIHRoZSBtZWRpYSBlbmdpbmUuCisKK0VWRU5UKGxvYWRzdGFy dCkKKworRVZFTlQoZXJyb3IpIGZyb20gPHNvdXJjZSBpZD0nbWlzc2luZy1zcmMnIHNyYz0nJz4g T0sKK0VYUEVDVEVEICh2aWRlby5lcnJvciA9PSAnbnVsbCcpIE9LCisKK0VWRU5UKGVycm9yKSBm cm9tIDxzb3VyY2UgaWQ9J2JvZ3VzLXR5cGUnIHNyYz0nY29udGVudC90ZXN0Lm1wNCc+IE9LCitF WFBFQ1RFRCAodmlkZW8uZXJyb3IgPT0gJ251bGwnKSBPSworCitFVkVOVChlcnJvcikgZnJvbSA8 c291cmNlIGlkPSd1bnN1cHBvcnRlZC1tZWRpYS1xdWVyeScgc3JjPSdjb250ZW50L3Rlc3QubXA0 Jz4gT0sKK0VYUEVDVEVEICh2aWRlby5lcnJvciA9PSAnbnVsbCcpIE9LCisKK0VORCBPRiBURVNU CisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNvdXJjZS1lcnJvci1uby1jYW5kaWRh dGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zb3VyY2UtZXJy b3Itbm8tY2FuZGlkYXRlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92 aWRlby1zb3VyY2UtZXJyb3Itbm8tY2FuZGlkYXRlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNTggQEAKKzxodG1sIGxhbmc9ImVuIj4KKyAgICA8aGVhZD4KKyAgICAgICAgPG1ldGEgaHR0 cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgi PgorICAgICAgICA8dGl0bGU+Jmx0O3ZpZGVvJmd0OyBhbmQgJmx0O3NvdXJjZSZndDsgZXJyb3Ig dGVzdDwvdGl0bGU+CisgICAgICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+ CisKKyAgICAgICAgPHNjcmlwdD4KKworICAgICAgICAgICAgdmFyIHNvdXJjZXMgPSBbXTsKKyAg ICAgICAgICAgIHZhciBlcnJvckNvdW50ID0gMDsKKworICAgICAgICAgICAgZnVuY3Rpb24gZXJy b3JFdmVudChldnQpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRl KCIiKTsKKworICAgICAgICAgICAgICAgIHZhciBuZHg7CisgICAgICAgICAgICAgICAgZm9yIChu ZHggPSAwOyBuZHggPCBzb3VyY2VzLmxlbmd0aDsgbmR4KyspIHsKKyAgICAgICAgICAgICAgICAg ICAgaWYgKHNvdXJjZXNbbmR4XSA9PSBldnQudGFyZ2V0KQorICAgICAgICAgICAgICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgaWYgKHNvdXJj ZXNbbmR4XSA9PSBldnQudGFyZ2V0KQorICAgICAgICAgICAgICAgICAgICBsb2dSZXN1bHQodHJ1 ZSwgIkVWRU5UKGVycm9yKSBmcm9tICZsdDtzb3VyY2UgaWQ9JzxlbT4iICsgZXZ0LnRhcmdldC5p ZCArICI8L2VtPicgc3JjPSc8ZW0+IiArIHJlbGF0aXZlVVJMKGV2dC50YXJnZXQuc3JjKSArICI8 L2VtPicmZ3Q7Iik7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBs b2dSZXN1bHQoZmFsc2UsICJFVkVOVChlcnJvcikgZnJvbSAiICsgZXZ0LnRhcmdldCk7CisKKyAg ICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmVycm9yIiwgbnVsbCk7CisgICAgICAg ICAgICAgICAgCisgICAgICAgICAgICAgICAgaWYgKCsrZXJyb3JDb3VudCA9PSAzKSB7CisgICAg ICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAgICAgICAgICAgIHNl dFRpbWVvdXQoZW5kVGVzdCwgMTAwMCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg fQorCisgICAgICAgICAgICBmdW5jdGlvbiBzdGFydCgpCisgICAgICAgICAgICB7CisgICAgICAg ICAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiZXJyb3IiLCBlcnJvckV2ZW50LCB0 cnVlKTsKKworICAgICAgICAgICAgICAgIHNvdXJjZXMgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5 VGFnTmFtZSgnc291cmNlJyk7CisKKyAgICAgICAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50KCk7 CisgICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCJsb2Fkc3RhcnQiKTsKKyAgICAgICAgICAg IH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgorCisgICAgPGJvZHkgb25sb2FkPSJz dGFydCgpIj4KKworICAgICAgICA8dmlkZW8gY29udHJvbHM+CisgICAgICAgICAgICA8c291cmNl IGlkPW1pc3Npbmctc3JjIHR5cGU9InZpZGVvL2JsYWhibGFoIj4KKyAgICAgICAgICAgIDxzb3Vy Y2UgaWQ9Ym9ndXMtdHlwZSBzcmM9Y29udGVudC90ZXN0Lm1wNCB0eXBlPSJ2aWRlby9ibGFoYmxh aCI+CisgICAgICAgICAgICA8c291cmNlIGlkPXVuc3VwcG9ydGVkLW1lZGlhLXF1ZXJ5IHNyYz1j b250ZW50L3Rlc3QubXA0IG1lZGlhPXByaW50PgorICAgICAgICA8L3ZpZGVvPgorICAgICAgICAK KyAgICAgICAgPHA+VGVzdCB0aGF0ICdlcnJvcicgZXZlbnRzIGFyZSBmaXJlZCB3aGVuIG5vIHVy bHMgYXJlIHBhc3NlZCB0byB0aGUgbWVkaWEgZW5naW5lLjwvcD4KKworICAgIDwvYm9keT4KKzwv aHRtbD4K