33816 2010-01-18 16:52:32 -0800 Crashes in Geolocation code due to refcounting, observer balance issues 2010-01-22 14:07:41 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken oldest_to_newest 182040 0 sfalken 2010-01-18 16:52:32 -0800 Geolocation is crashing for me during development. Issues are caused by a reference to a disposed this ptr in GeoNotifier, and an add/remove observer balance issue in GeolocationController. 182043 1 46864 sfalken 2010-01-18 16:55:48 -0800 Created attachment 46864 Patch 183800 2 sfalken 2010-01-22 14:07:41 -0800 This is fixed. 46864 2010-01-18 16:55:48 -0800 2010-01-18 17:03:45 -0800 Patch patch.diff text/plain 2967 sfalken SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzQzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDEtMTggIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzODE2PiAgICAgICAg CisgICAgICAgIENyYXNoZXMgaW4gR2VvbG9jYXRpb24gY29kZSBkdWUgdG8gcmVmY291bnRpbmcs IG9ic2VydmVyIGJhbGFuY2UgaXNzdWVzLgorICAgICAgICAKKyAgICAgICAgSG9sZCBhIHJlZiB0 byB0aGUgR2VvTm90aWZpZXIgd2hpbGUgZGlzcGF0Y2hpbmcgYSBjYWxsYmFjay4gVGhlIGNvZGUg d2FzCisgICAgICAgIGNvcHlpbmcgYSBkYXRhIG1lbWJlciB0byBhdm9pZCBhY2Nlc3NpbmcgYSBm cmVlZCB0aGlzIHB0ciwgYnV0IHdhcyBzdGlsbAorICAgICAgICB1c2luZyB0aGUgdGhpcyBwdHIu CisgICAgICAgIAorICAgICAgICBHZW9sb2NhdGlvbjo6cmVtb3ZlT2JzZXJ2ZXIgY2FsbHMgYXJl IG5vdCBhbHdheXMgYmFsYW5jZWQgd2l0aCBhZGRPYnNlcnZlci4KKyAgICAgICAgSW5zdGVhZCBv ZiBhc3NlcnRpbmcgYW5kIGNvbnRpbnVpbmcsIGRvbid0IHRyeSB0byByZW1vdmUgbm9uLWV4aXN0 YW50CisgICAgICAgIG9ic2VydmVycy4KKworICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb246Okdlb05vdGlmaWVyOjp0aW1lckZpcmVk KTogUHJvdGVjdCBub3RpZmllci4KKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uQ29udHJvbGxl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbkNvbnRyb2xsZXI6OnJlbW92ZU9i c2VydmVyKTogQ2hhbmdlIEFTU0VSVCBpbnRvIGFuIGlmIHdpdGggZWFybHkgcmV0dXJuLgorCiAy MDEwLTAxLTE4ICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9u LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lv biA1MzQxOSkKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEwNywxNSArMTA3LDE1IEBAIHZvaWQgR2VvbG9jYXRpb246Okdlb05vdGlmaWVyOjp0aW1l ckZpcmUKIHsKICAgICBtX3RpbWVyLnN0b3AoKTsKIAotICAgIC8vIENhY2hlIG91ciBwb2ludGVy IHRvIHRoZSBHZW9sb2NhdGlvbiBvYmplY3QsIGFzIHRoaXMgR2VvTm90aWZpZXIgb2JqZWN0Cisg ICAgLy8gUHJvdGVjdCB0aGlzIEdlb05vdGlmaWVyIG9iamVjdCwgc2luY2UgaXQKICAgICAvLyBj b3VsZCBiZSBkZWxldGVkIGJ5IGEgY2FsbCB0byBjbGVhcldhdGNoIGluIGEgY2FsbGJhY2suCi0g ICAgR2VvbG9jYXRpb24qIGdlb2xvY2F0aW9uID0gbV9nZW9sb2NhdGlvbjsKKyAgICBSZWZQdHI8 R2VvTm90aWZpZXI+IHByb3RlY3QodGhpcyk7CiAKICAgICBpZiAobV9mYXRhbEVycm9yKSB7CiAg ICAgICAgIGlmIChtX2Vycm9yQ2FsbGJhY2spCiAgICAgICAgICAgICBtX2Vycm9yQ2FsbGJhY2st PmhhbmRsZUV2ZW50KG1fZmF0YWxFcnJvci5nZXQoKSk7CiAgICAgICAgIC8vIFRoaXMgd2lsbCBj YXVzZSB0aGlzIG5vdGlmaWVyIHRvIGJlIGRlbGV0ZWQuCi0gICAgICAgIGdlb2xvY2F0aW9uLT5m YXRhbEVycm9yT2NjdXJyZWQodGhpcyk7CisgICAgICAgIG1fZ2VvbG9jYXRpb24tPmZhdGFsRXJy b3JPY2N1cnJlZCh0aGlzKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMTIzLDcgKzEy Myw3IEBAIHZvaWQgR2VvbG9jYXRpb246Okdlb05vdGlmaWVyOjp0aW1lckZpcmUKICAgICAgICAg UmVmUHRyPFBvc2l0aW9uRXJyb3I+IGVycm9yID0gUG9zaXRpb25FcnJvcjo6Y3JlYXRlKFBvc2l0 aW9uRXJyb3I6OlRJTUVPVVQsICJUaW1lb3V0IGV4cGlyZWQiKTsKICAgICAgICAgbV9lcnJvckNh bGxiYWNrLT5oYW5kbGVFdmVudChlcnJvci5nZXQoKSk7CiAgICAgfQotICAgIGdlb2xvY2F0aW9u LT5yZXF1ZXN0VGltZWRPdXQodGhpcyk7CisgICAgbV9nZW9sb2NhdGlvbi0+cmVxdWVzdFRpbWVk T3V0KHRoaXMpOwogfQogCiB2b2lkIEdlb2xvY2F0aW9uOjpXYXRjaGVyczo6c2V0KGludCBpZCwg UGFzc1JlZlB0cjxHZW9Ob3RpZmllcj4gcHJwTm90aWZpZXIpCkluZGV4OiBXZWJDb3JlL3BhZ2Uv R2VvbG9jYXRpb25Db250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2Vv bG9jYXRpb25Db250cm9sbGVyLmNwcAkocmV2aXNpb24gNTM0MTkpCisrKyBXZWJDb3JlL3BhZ2Uv R2VvbG9jYXRpb25Db250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsOCBA QCB2b2lkIEdlb2xvY2F0aW9uQ29udHJvbGxlcjo6YWRkT2JzZXJ2ZXIoCiAKIHZvaWQgR2VvbG9j YXRpb25Db250cm9sbGVyOjpyZW1vdmVPYnNlcnZlcihHZW9sb2NhdGlvbiogb2JzZXJ2ZXIpCiB7 Ci0gICAgQVNTRVJUKG1fb2JzZXJ2ZXJzLmNvbnRhaW5zKG9ic2VydmVyKSk7CisgICAgaWYgKCFt X29ic2VydmVycy5jb250YWlucyhvYnNlcnZlcikpCisgICAgICAgIHJldHVybjsKIAogICAgIG1f b2JzZXJ2ZXJzLnJlbW92ZShvYnNlcnZlcik7CiAgICAgaWYgKG1fb2JzZXJ2ZXJzLmlzRW1wdHko KSkK