33813 2010-01-18 14:26:27 -0800 Crash when using DOMApplicationCache from a destroyed frame 2010-01-18 14:52:16 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 33811 1 ap ap oldest_to_newest 181997 0 ap 2010-01-18 14:26:27 -0800 DOMApplicationCache::scriptExecutionContext() isn't prepared have its frame destroyed. <rdar://problem/7545104> 182001 1 46852 ap 2010-01-18 14:39:27 -0800 Created attachment 46852 proposed fix 182005 2 46852 ggaren 2010-01-18 14:45:35 -0800 Comment on attachment 46852 proposed fix r=me I think you need a follow-up patch to fix callers of scriptExecutionContext() so they all check for null, though. 182009 3 ap 2010-01-18 14:52:16 -0800 Committed <http://trac.webkit.org/changeset/53433>. 46852 2010-01-18 14:39:27 -0800 2010-01-18 14:45:35 -0800 proposed fix appcache.txt text/plain 4324 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzQzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzODEzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83NTQ1MTA0PiBDcmFzaCB3aGVuIHVzaW5nIERPTUFwcGxpY2F0aW9uQ2Fj aGUgZnJvbSBhIGRlc3Ryb3llZCBmcmFtZQorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvYXBw Y2FjaGUvZGVzdHJveWVkLWZyYW1lLmh0bWwKKworICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9E T01BcHBsaWNhdGlvbkNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTUFwcGxpY2F0aW9u Q2FjaGU6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOiBSZXR1cm4gbnVsbCB3aGVuIHRoZXJlIGlz IG5vIGZyYW1lLgorCiAyMDEwLTAxLTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2xvYWRl ci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNhY2hlLmNwcAkocmV2aXNpb24gNTM0Mjkp CisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9ET01BcHBsaWNhdGlvbkNhY2hlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODcsOCArODcsOSBAQCB2b2lkIERPTUFwcGxpY2F0aW9uQ2FjaGU6OnN3 YXBDYWNoZShFeGNlCiAKIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIERPTUFwcGxpY2F0aW9uQ2Fj aGU6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdAogewotICAgIEFTU0VSVChtX2ZyYW1l KTsKLSAgICByZXR1cm4gbV9mcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICBpZiAobV9mcmFtZSkKKyAg ICAgICAgcmV0dXJuIG1fZnJhbWUtPmRvY3VtZW50KCk7CisgICAgcmV0dXJuIDA7CiB9CiAKIGNv bnN0IEF0b21pY1N0cmluZyYgRE9NQXBwbGljYXRpb25DYWNoZTo6dG9FdmVudFR5cGUoQXBwbGlj YXRpb25DYWNoZUhvc3Q6OkV2ZW50SUQgaWQpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MzQzMikKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisy MDEwLTAxLTE4ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzgxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzU0 NTEwND4gQ3Jhc2ggd2hlbiB1c2luZyBET01BcHBsaWNhdGlvbkNhY2hlIGZyb20gYSBkZXN0cm95 ZWQgZnJhbWUKKworICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvZGVzdHJveWVkLWZyYW1l LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9hcHBjYWNoZS9kZXN0 cm95ZWQtZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTAtMDEtMTggIERhbiBCZXJuc3RlaW4gIDxt aXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6 IExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvZGVzdHJveWVkLWZyYW1lLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL2Rlc3Ry b3llZC1mcmFtZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2FwcGNhY2hlL2Rlc3Ryb3llZC1mcmFtZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsNSBAQAorVGVzdCBmb3IgYnVnIDMzODEzOiBDcmFzaCB3aGVuIHVzaW5nIERP TUFwcGxpY2F0aW9uQ2FjaGUgZnJvbSBhIGRlc3Ryb3llZCBmcmFtZS4KKworUEFTUyBpZiBkaWRu J3QgY3Jhc2guCisKKwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9kZXN0 cm95ZWQtZnJhbWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Fw cGNhY2hlL2Rlc3Ryb3llZC1mcmFtZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9hcHBjYWNoZS9kZXN0cm95ZWQtZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSw1MiBAQAorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorPHA+VGVzdCBmb3IgPGEgaHJl Zj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzODEzIj5idWcgMzM4 MTM8L2E+OiBDcmFzaCB3aGVuIHVzaW5nIERPTUFwcGxpY2F0aW9uQ2FjaGUgZnJvbSBhIGRlc3Ry b3llZCBmcmFtZS48L3A+Cis8cD5QQVNTIGlmIGRpZG4ndCBjcmFzaC48L3A+Cis8aWZyYW1lIHNy Yz0iYWJvdXQ6YmxhbmsiPjwvaWZyYW1lPgorCis8c2NyaXB0PgorCitmdW5jdGlvbiBnYygpCit7 CisgICAgaWYgKHdpbmRvdy5HQ0NvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBHQ0NvbnRyb2xs ZXIuY29sbGVjdCgpOworCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSB7IC8v ID4gZm9yY2UgZ2FyYmFnZSBjb2xsZWN0aW9uIChGRiByZXF1aXJlcyBhYm91dCA5SyBhbGxvY2F0 aW9ucyBiZWZvcmUgYSBjb2xsZWN0KQorICAgICAgICB2YXIgcyA9IG5ldyBTdHJpbmcoIiIpOwor ICAgIH0KK30KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7Cit9CisKK3ZhciBpZnJDYWNoZTsKKworZnVuY3Rpb24gdGVzdCgpCit7 CisgICAgaWZyQ2FjaGUgPSBmcmFtZXNbMF0uYXBwbGljYXRpb25DYWNoZTsKKyAgICBkb2N1bWVu dC5ib2R5LnJlbW92ZUNoaWxkKGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJpZnJhbWUi KVswXSk7CisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZ2MoKTsKKyAgICAg ICAgaWZyQ2FjaGUub25jaGVja2luZyA9IGZ1bmN0aW9uKCkgeyB9CisgICAgICAgIGlmckNhY2hl Lm9uZXJyb3IgPSBmdW5jdGlvbigpIHsgfQorICAgICAgICBpZnJDYWNoZS5vbm5vdXBkYXRlID0g ZnVuY3Rpb24oKSB7IH0KKyAgICAgICAgaWZyQ2FjaGUub25kb3dubG9hZGluZyA9IGZ1bmN0aW9u KCkgeyB9CisgICAgICAgIGlmckNhY2hlLm9ucHJvZ3Jlc3MgPSBmdW5jdGlvbigpIHsgfQorICAg ICAgICBpZnJDYWNoZS5vbnVwZGF0ZXJlYWR5ID0gZnVuY3Rpb24oKSB7IH0KKyAgICAgICAgaWZy Q2FjaGUub25jYWNoZWQgPSBmdW5jdGlvbigpIHsgfQorICAgICAgICBpZnJDYWNoZS5vbm9ic29s ZXRlID0gZnVuY3Rpb24oKSB7IH0KKyAgICAgICAgaWZyQ2FjaGUuYWRkRXZlbnRMaXN0ZW5lcigi ZXJyb3IiLCBmdW5jdGlvbigpIHsgfSwgdHJ1ZSk7CisKKyAgICAgICAgdmFyIGV2dCA9IGRvY3Vt ZW50LmNyZWF0ZUV2ZW50KCJFdmVudCIpOworICAgICAgICBldnQuaW5pdEV2ZW50KCJlcnJvciIs IHRydWUsIHRydWUpOworICAgICAgICBpZnJDYWNoZS5kaXNwYXRjaEV2ZW50KGV2dCk7CisKKyAg ICAgICAgdHJ5IHsgaWZyQ2FjaGUudXBkYXRlKCk7IH0gY2F0Y2ggKGV4KSB7IH0KKyAgICAgICAg dHJ5IHsgaWZyQ2FjaGUuc3dhcENhY2hlKCk7IH0gY2F0Y2ggKGV4KSB7IH0KKworICAgICAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgIH0sIDApOworfQorPC9zY3JpcHQ+Cg==