33795 2010-01-18 05:51:12 -0800 [v8] [Android] V8 bindings for touch events are missing. 2010-02-18 02:22:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 32485 1 benm benm android-webkit-unforking hausmann oldest_to_newest 181844 0 benm 2010-01-18 05:51:12 -0800 There are currently no V8 bindings upstream for touch events. Patch to follow shortly. 190999 1 48895 benm 2010-02-17 05:07:13 -0800 Created attachment 48895 Patch. 191085 2 48895 japhet 2010-02-17 10:46:23 -0800 Comment on attachment 48895 Patch. Looks good. Ignorant question: Does this patch require changes to the Android build files? 191093 3 benm 2010-02-17 10:57:31 -0800 (In reply to comment #2) > (From update of attachment 48895 [details]) > Looks good. > > Ignorant question: Does this patch require changes to the Android build files? Ah, I thought these were already in the upstream version of our makefile. Turns out they are not. I can amend the Android makefiles and land this patch without another review, or would you like me to send another patch? Thanks, Ben 191497 4 48895 benm 2010-02-18 02:22:01 -0800 Comment on attachment 48895 Patch. Landed as r54950, closing bug. 48895 2010-02-17 05:07:13 -0800 2010-02-18 02:22:01 -0800 Patch. 33795.txt text/plain 5436 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDg4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDItMTcgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2OF0g W0FuZHJvaWRdIFY4IGJpbmRpbmdzIGZvciB0b3VjaCBldmVudHMgYXJlIG1pc3NpbmcuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzc5NQorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGp1c3QgZW5hYmxlcyB0b3VjaCBldmVudHMgaW4gVjgu IEV4aXN0aW5nIHRvdWNoIHRlc3RzIHN1ZmZpY2UuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6 IEFkZCBUb3VjaCBpZGwgZmlsZXMuCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG06IEFkZCBUb3VjaExpc3QgdG8gdHlwZUNhbkZhaWxDb252ZXJzaW9uIG1hcC4K KyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01PYmplY3RzSW5jbHVkZS5oOiBBZGQgdG91Y2ggaGVh ZGVycy4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcDog QWRkIHRvdWNoIGdlbmVyYXRlZCBiaW5kaW5ncy4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOElu ZGV4Lmg6IEFkZCB0b3VjaCBET00gb2JqZWN0IHR5cGVzLgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L2N1c3RvbS9WOEV2ZW50Q3VzdG9tLmNwcDogQWRkIGNvbnZlcnNpb24gb2YgZXZlbnQgdG8gdG91 Y2ggZXZlbnQuCisKIDIwMTAtMDItMTcgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KSW5kZXg6IFdlYkNvcmUv V2ViQ29yZS5neXBpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5neXBpCShyZXZpc2lv biA1NDgyMSkKKysrIFdlYkNvcmUvV2ViQ29yZS5neXBpCSh3b3JraW5nIGNvcHkpCkBAIC03Myw2 ICs3Myw5IEBACiAgICAgICAgICAgICAnZG9tL1JhbmdlRXhjZXB0aW9uLmlkbCcsCiAgICAgICAg ICAgICAnZG9tL1RleHQuaWRsJywKICAgICAgICAgICAgICdkb20vVGV4dEV2ZW50LmlkbCcsCisg ICAgICAgICAgICAnZG9tL1RvdWNoLmlkbCcsCisgICAgICAgICAgICAnZG9tL1RvdWNoRXZlbnQu aWRsJywKKyAgICAgICAgICAgICdkb20vVG91Y2hMaXN0LmlkbCcsCiAgICAgICAgICAgICAnZG9t L1RyZWVXYWxrZXIuaWRsJywKICAgICAgICAgICAgICdkb20vVUlFdmVudC5pZGwnLAogICAgICAg ICAgICAgJ2RvbS9XZWJLaXRBbmltYXRpb25FdmVudC5pZGwnLApJbmRleDogV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCShyZXZpc2lvbiA1NDgyMSkKKysrIFdl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHdvcmtpbmcgY29weSkK QEAgLTI0NjAsNiArMjQ2MCw3IEBAIG15ICV0eXBlQ2FuRmFpbENvbnZlcnNpb24gPSAoCiAgICAg IlNWR1ByZXNlcnZlQXNwZWN0UmF0aW8iID0+IDEsCiAgICAgIlNWR1JlY3QiID0+IDEsCiAgICAg IlNWR1RyYW5zZm9ybSIgPT4gMSwKKyAgICAiVG91Y2hMaXN0IiA9PiAwLAogICAgICJWb2lkQ2Fs bGJhY2siID0+IDEsCiAgICAgIldlYktpdENTU01hdHJpeCIgPT4gMCwKICAgICAiV2ViS2l0UG9p bnQiID0+IDAsCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTU9iamVjdHNJbmNsdWRlLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9ET01PYmplY3RzSW5jbHVkZS5oCShy ZXZpc2lvbiA1NDgyMSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvRE9NT2JqZWN0c0luY2x1ZGUu aAkod29ya2luZyBjb3B5KQpAQCAtMjgyLDYgKzI4MiwxMiBAQAogI2luY2x1ZGUgIkluc3BlY3Rv ckZyb250ZW5kSG9zdC5oIgogI2VuZGlmIC8vIElOU1BFQ1RPUgogCisjaWYgRU5BQkxFKFRPVUNI X0VWRU5UUykKKyNpbmNsdWRlICJUb3VjaC5oIgorI2luY2x1ZGUgIlRvdWNoRXZlbnQuaCIKKyNp bmNsdWRlICJUb3VjaExpc3QuaCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAg ICAvLyBBIGhlbHBlciBjbGFzcyBmb3IgdW5kZXRlY3RhYmxlIGRvY3VtZW50LmFsbApJbmRleDog V2ViQ29yZS9iaW5kaW5ncy92OC9EZXJpdmVkU291cmNlc0FsbEluT25lLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L0Rlcml2ZWRTb3VyY2VzQWxsSW5PbmUuY3BwCShyZXZp c2lvbiA1NDgyMSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvRGVyaXZlZFNvdXJjZXNBbGxJbk9u ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxOSw2ICsyMTksOSBAQAogI2luY2x1ZGUgImJpbmRp bmdzL1Y4VGV4dEV2ZW50LmNwcCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFRleHRNZXRyaWNzLmNw cCIKICNpbmNsdWRlICJiaW5kaW5ncy9WOFRpbWVSYW5nZXMuY3BwIgorI2luY2x1ZGUgImJpbmRp bmdzL1Y4VG91Y2guY3BwIgorI2luY2x1ZGUgImJpbmRpbmdzL1Y4VG91Y2hFdmVudC5jcHAiCisj aW5jbHVkZSAiYmluZGluZ3MvVjhUb3VjaExpc3QuY3BwIgogI2luY2x1ZGUgImJpbmRpbmdzL1Y4 VHJlZVdhbGtlci5jcHAiCiAjaW5jbHVkZSAiYmluZGluZ3MvVjhVSUV2ZW50LmNwcCIKICNpbmNs dWRlICJiaW5kaW5ncy9WOFZhbGlkaXR5U3RhdGUuY3BwIgpJbmRleDogV2ViQ29yZS9iaW5kaW5n cy92OC9WOEluZGV4LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOEluZGV4 LmgJKHJldmlzaW9uIDU0ODIxKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOEluZGV4LmgJKHdv cmtpbmcgY29weSkKQEAgLTUyNiw2ICs1MjYsMTUgQEAgc3RhdGljIGNvbnN0IGludCB2OERlZmF1 bHRXcmFwcGVySW50ZXJuYQogICAgIFYoR0VPUE9TSVRJT04sIEdlb3Bvc2l0aW9uKSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIFYoUE9TSVRJT05FUlJPUiwg UG9zaXRpb25FcnJvcikKIAorI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCisjZGVmaW5lIERPTV9P QkpFQ1RfVE9VQ0hfRVZFTlRfVFlQRVMoVikgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBcCisgICAgVihUT1VDSCwgVG91Y2gpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcCisgICAgVihUT1VDSEVWRU5ULCBUb3VjaEV2ZW50KSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgVihUT1VDSExJU1Qs IFRvdWNoTGlzdCkKKyNlbHNlCisjZGVmaW5lIERPTV9PQkpFQ1RfVE9VQ0hfRVZFTlRfVFlQRVMo VikKKyNlbmRpZgorCiAjZGVmaW5lIERPTV9PQkpFQ1RfVFlQRVMoVikgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgRE9NX09CSkVDVF9UWVBFU18xKFYp ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgRE9N X09CSkVDVF9UWVBFU18yKFYpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBcCkBAIC01MzcsNyArNTQ2LDggQEAgc3RhdGljIGNvbnN0IGludCB2OERlZmF1bHRX cmFwcGVySW50ZXJuYQogICAgIERPTV9PQkpFQ1RfWFBBVEhfVFlQRVMoVikgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIERPTV9PQkpFQ1RfWFNMVF9UWVBF UyhWKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIERP TV9PQkpFQ1RfSU5TUEVDVE9SX1RZUEVTKFYpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAotICAgIERPTV9PQkpFQ1RfR0VPTE9DQVRJT05fVFlQRVMoVikKKyAgICBET01f T0JKRUNUX0dFT0xPQ0FUSU9OX1RZUEVTKFYpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFwKKyAgICBET01fT0JKRUNUX1RPVUNIX0VWRU5UX1RZUEVTKFYpCiAKICNpZiBFTkFC TEUoU1ZHKQogLy8gU1ZHX09CSkVDVF9UWVBFUyBhcmUgc3ZnIG5vbi1ub2RlLCBub24tcG9kIHR5 cGVzLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudEN1c3RvbS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVudEN1c3RvbS5j cHAJKHJldmlzaW9uIDU0ODIxKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhFdmVu dEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxLDYgKzUxLDcgQEAKICNpbmNsdWRlICJW OFNWR1pvb21FdmVudC5oIgogI2luY2x1ZGUgIlY4U3RvcmFnZUV2ZW50LmgiCiAjaW5jbHVkZSAi VjhUZXh0RXZlbnQuaCIKKyNpbmNsdWRlICJWOFRvdWNoRXZlbnQuaCIKICNpbmNsdWRlICJWOFVJ RXZlbnQuaCIKICNpbmNsdWRlICJWOFdlYktpdEFuaW1hdGlvbkV2ZW50LmgiCiAjaW5jbHVkZSAi VjhXZWJLaXRUcmFuc2l0aW9uRXZlbnQuaCIKQEAgLTEwNCw2ICsxMDUsMTAgQEAgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IHRvVjgoRXZlbnQqIGltcGwpCiAjZW5kaWYKICAgICAgICAgaWYgKGltcGwt PmlzQ29tcG9zaXRpb25FdmVudCgpKQogICAgICAgICAgICAgcmV0dXJuIHRvVjgoc3RhdGljX2Nh c3Q8Q29tcG9zaXRpb25FdmVudCo+KGltcGwpKTsKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQor ICAgICAgICBpZiAoaW1wbC0+aXNUb3VjaEV2ZW50KCkpCisgICAgICAgICAgICByZXR1cm4gdG9W OChzdGF0aWNfY2FzdDxUb3VjaEV2ZW50Kj4oaW1wbCkpOworI2VuZGlmCiAgICAgICAgIHJldHVy biB0b1Y4KHN0YXRpY19jYXN0PFVJRXZlbnQqPihpbXBsKSk7CiAgICAgfQogICAgIGlmIChpbXBs LT5pc011dGF0aW9uRXZlbnQoKSkK