33790 2010-01-18 02:31:32 -0800 Web Inspector: Improve ResourcesPanel performance with lots of resources 2010-01-19 11:08:46 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 apavlov webkit-unassigned bweinstein commit-queue eric gustavo joepeck keishi pfeldman pmuellr rik timothy xan.lopez oldest_to_newest 181803 0 apavlov 2010-01-18 02:31:32 -0800 There are several bottlenecks in the ResourcesPanel, which dramatically impact performance when working with 1000s of resources. 181836 1 46813 apavlov 2010-01-18 05:31:22 -0800 Created attachment 46813 patch 181851 2 46813 commit-queue 2010-01-18 06:20:57 -0800 Comment on attachment 46813 patch Clearing flags on attachment: 46813 Committed r53405: <http://trac.webkit.org/changeset/53405> 181852 3 commit-queue 2010-01-18 06:21:05 -0800 All reviewed patches have been landed. Closing bug. 181884 4 46813 timothy 2010-01-18 08:38:39 -0800 Comment on attachment 46813 patch Nice patch! > + var aVal = a.endTime; > + var bVal = b.endTime; Const would have been good here too. 181938 5 eric 2010-01-18 11:32:44 -0800 Gtk bot seems to have had kittens after this landed: http://build.webkit.org/results/GTK%20Linux%20Release/r53405%20(7765)/results.html Not sure it's related to this change though. 181941 6 eric 2010-01-18 11:35:51 -0800 Xan might know what's up with the gtk bot. 181944 7 xan.lopez 2010-01-18 11:42:06 -0800 (In reply to comment #6) > Xan might know what's up with the gtk bot. Actually Gustavo handles the Release bot, I'm the Debug bots guy :) Looks like random (and possibly unrelated) gstreamer/media woes though, IIRC it has happened before. CCing Gustavo. 182330 8 gustavo 2010-01-19 11:08:46 -0800 (In reply to comment #7) > (In reply to comment #6) > > Xan might know what's up with the gtk bot. > > Actually Gustavo handles the Release bot, I'm the Debug bots guy :) > > Looks like random (and possibly unrelated) gstreamer/media woes though, IIRC it > has happened before. CCing Gustavo. This is actually caused by pulseaudio misbehaving. I'll try to figure it out. 46813 2010-01-18 05:31:22 -0800 2010-01-18 08:38:39 -0800 patch fixrespanelperf.patch text/plain 6994 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWVkMzczMS4uZTIwZGIzNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMS0xOCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgUmVzb3VyY2VzIHBhbmVsIHBlcmZvcm1hbmNl IGZvciBsb3RzIG9mIHJlc291cmNlcworCisgICAgICAgIERPTSBwcm9wZXJ0aWVzIGFyZSBleHRy YWN0ZWQgaW50byBjb25zdCdzLCBjb21wYXJpc29ucyBhcmUgZmFzdGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3OTAKKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvQWJzdHJhY3RUaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkFic3RyYWN0VGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX3VwZGF0ZURpdmlkZXJz TGFiZWxCYXJQb3NpdGlvbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5Db21wYXJlQnlTdGFydFRpbWUp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlLkNvbXBhcmVCeVJlc3BvbnNlUmVjZWl2 ZWRUaW1lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5Db21wYXJlQnlFbmRUaW1l KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5Db21wYXJlQnlEdXJhdGlvbik6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2UuQ29tcGFyZUJ5TGF0ZW5jeSk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuUmVzb3VyY2UuQ29tcGFyZUJ5U2l6ZSk6CisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5S ZXNvdXJjZUdyYXBoLnByb3RvdHlwZS5yZWZyZXNoTGFiZWxQb3NpdGlvbnMpOgorCiAyMDEwLTAx LTE4ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkIFN5bWJpYW4gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0VGltZWxpbmVQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9BYnN0cmFjdFRpbWVsaW5lUGFuZWwuanMKaW5kZXggYzUxODBmNi4uMDVh ZjljMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Fic3RyYWN0VGlt ZWxpbmVQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWJzdHJhY3RU aW1lbGluZVBhbmVsLmpzCkBAIC0yMTUsOCArMjE1LDkgQEAgV2ViSW5zcGVjdG9yLkFic3RyYWN0 VGltZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICBfdXBkYXRlRGl2aWRlcnNMYWJlbEJh clBvc2l0aW9uOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB2YXIgc2Nyb2xsVG9wID0gdGhp cy5jb250YWluZXJFbGVtZW50LnNjcm9sbFRvcDsKLSAgICAgICAgdmFyIGRpdmlkZXJzVG9wID0g KHNjcm9sbFRvcCA8IHRoaXMuc3VtbWFyeUJhci5lbGVtZW50Lm9mZnNldEhlaWdodCA/IHRoaXMu c3VtbWFyeUJhci5lbGVtZW50Lm9mZnNldEhlaWdodCA6IHNjcm9sbFRvcCk7CisgICAgICAgIGNv bnN0IHNjcm9sbFRvcCA9IHRoaXMuY29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3A7CisgICAgICAg IGNvbnN0IG9mZnNldEhlaWdodCA9IHRoaXMuc3VtbWFyeUJhci5lbGVtZW50Lm9mZnNldEhlaWdo dDsKKyAgICAgICAgY29uc3QgZGl2aWRlcnNUb3AgPSAoc2Nyb2xsVG9wIDwgb2Zmc2V0SGVpZ2h0 ID8gb2Zmc2V0SGVpZ2h0IDogc2Nyb2xsVG9wKTsKICAgICAgICAgdGhpcy5fdGltZWxpbmVHcmlk LnNldFNjcm9sbEFuZERpdmlkZXJUb3Aoc2Nyb2xsVG9wLCBkaXZpZGVyc1RvcCk7CiAgICAgfSwK IApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzCmluZGV4IGQyOTJlMTkuLjk4 NjAzMDAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5q cworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2UuanMKQEAgLTU3MCw2 NCArNTcwLDQwIEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUuX19wcm90b19fID0g V2ViSW5zcGVjdG9yLk9iamVjdC5wcm90b3R5cGU7CiAKIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5D b21wYXJlQnlTdGFydFRpbWUgPSBmdW5jdGlvbihhLCBiKQogewotICAgIGlmIChhLnN0YXJ0VGlt ZSA8IGIuc3RhcnRUaW1lKQotICAgICAgICByZXR1cm4gLTE7Ci0gICAgaWYgKGEuc3RhcnRUaW1l ID4gYi5zdGFydFRpbWUpCi0gICAgICAgIHJldHVybiAxOwotICAgIHJldHVybiAwOworICAgIHJl dHVybiBhLnN0YXJ0VGltZSAtIGIuc3RhcnRUaW1lOwogfQogCiBXZWJJbnNwZWN0b3IuUmVzb3Vy Y2UuQ29tcGFyZUJ5UmVzcG9uc2VSZWNlaXZlZFRpbWUgPSBmdW5jdGlvbihhLCBiKQogewotICAg IGlmIChhLnJlc3BvbnNlUmVjZWl2ZWRUaW1lID09PSAtMSAmJiBiLnJlc3BvbnNlUmVjZWl2ZWRU aW1lICE9PSAtMSkKLSAgICAgICAgcmV0dXJuIDE7Ci0gICAgaWYgKGEucmVzcG9uc2VSZWNlaXZl ZFRpbWUgIT09IC0xICYmIGIucmVzcG9uc2VSZWNlaXZlZFRpbWUgPT09IC0xKQotICAgICAgICBy ZXR1cm4gLTE7Ci0gICAgaWYgKGEucmVzcG9uc2VSZWNlaXZlZFRpbWUgPCBiLnJlc3BvbnNlUmVj ZWl2ZWRUaW1lKQotICAgICAgICByZXR1cm4gLTE7Ci0gICAgaWYgKGEucmVzcG9uc2VSZWNlaXZl ZFRpbWUgPiBiLnJlc3BvbnNlUmVjZWl2ZWRUaW1lKQotICAgICAgICByZXR1cm4gMTsKLSAgICBy ZXR1cm4gMDsKKyAgICB2YXIgYVZhbCA9IGEucmVzcG9uc2VSZWNlaXZlZFRpbWU7CisgICAgdmFy IGJWYWwgPSBiLnJlc3BvbnNlUmVjZWl2ZWRUaW1lOworICAgIGlmIChhVmFsID09PSAtMSBeIGJW YWwgPT09IC0xKQorICAgICAgICByZXR1cm4gYlZhbCAtIGFWYWw7CisgICAgcmV0dXJuIGFWYWwg LSBiVmFsOwogfQogCiBXZWJJbnNwZWN0b3IuUmVzb3VyY2UuQ29tcGFyZUJ5RW5kVGltZSA9IGZ1 bmN0aW9uKGEsIGIpCiB7Ci0gICAgaWYgKGEuZW5kVGltZSA9PT0gLTEgJiYgYi5lbmRUaW1lICE9 PSAtMSkKLSAgICAgICAgcmV0dXJuIDE7Ci0gICAgaWYgKGEuZW5kVGltZSAhPT0gLTEgJiYgYi5l bmRUaW1lID09PSAtMSkKLSAgICAgICAgcmV0dXJuIC0xOwotICAgIGlmIChhLmVuZFRpbWUgPCBi LmVuZFRpbWUpCi0gICAgICAgIHJldHVybiAtMTsKLSAgICBpZiAoYS5lbmRUaW1lID4gYi5lbmRU aW1lKQotICAgICAgICByZXR1cm4gMTsKLSAgICByZXR1cm4gMDsKKyAgICB2YXIgYVZhbCA9IGEu ZW5kVGltZTsKKyAgICB2YXIgYlZhbCA9IGIuZW5kVGltZTsKKyAgICBpZiAoYVZhbCA9PT0gLTEg XiBiVmFsID09PSAtMSkKKyAgICAgICAgcmV0dXJuIGJWYWwgLSBhVmFsOworICAgIHJldHVybiBh VmFsIC0gYlZhbDsKIH0KIAogV2ViSW5zcGVjdG9yLlJlc291cmNlLkNvbXBhcmVCeUR1cmF0aW9u ID0gZnVuY3Rpb24oYSwgYikKIHsKLSAgICBpZiAoYS5kdXJhdGlvbiA8IGIuZHVyYXRpb24pCi0g ICAgICAgIHJldHVybiAtMTsKLSAgICBpZiAoYS5kdXJhdGlvbiA+IGIuZHVyYXRpb24pCi0gICAg ICAgIHJldHVybiAxOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBhLmR1cmF0aW9uIC0gYi5k dXJhdGlvbjsKIH0KIAogV2ViSW5zcGVjdG9yLlJlc291cmNlLkNvbXBhcmVCeUxhdGVuY3kgPSBm dW5jdGlvbihhLCBiKQogewotICAgIGlmIChhLmxhdGVuY3kgPCBiLmxhdGVuY3kpCi0gICAgICAg IHJldHVybiAtMTsKLSAgICBpZiAoYS5sYXRlbmN5ID4gYi5sYXRlbmN5KQotICAgICAgICByZXR1 cm4gMTsKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gYS5sYXRlbmN5IC0gYi5sYXRlbmN5Owog fQogCiBXZWJJbnNwZWN0b3IuUmVzb3VyY2UuQ29tcGFyZUJ5U2l6ZSA9IGZ1bmN0aW9uKGEsIGIp CiB7Ci0gICAgaWYgKGEuY29udGVudExlbmd0aCA8IGIuY29udGVudExlbmd0aCkKLSAgICAgICAg cmV0dXJuIC0xOwotICAgIGlmIChhLmNvbnRlbnRMZW5ndGggPiBiLmNvbnRlbnRMZW5ndGgpCi0g ICAgICAgIHJldHVybiAxOwotICAgIHJldHVybiAwOworICAgIHJldHVybiBhLmNvbnRlbnRMZW5n dGggLSBiLmNvbnRlbnRMZW5ndGg7CiB9CiAKIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5TdGF0dXNU ZXh0Rm9yQ29kZSA9IGZ1bmN0aW9uKGNvZGUpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggMTNiYzFmMi4uMDM0NzI5NCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtMTE4NywxNCArMTE4 NywxOSBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VHcmFwaC5wcm90b3R5cGUgPSB7CiAgICAgICAg IHRoaXMuX2xhYmVsUmlnaHRFbGVtZW50LnJlbW92ZVN0eWxlQ2xhc3MoImhpZGRlbiIpOwogCiAg ICAgICAgIGNvbnN0IGxhYmVsUGFkZGluZyA9IDEwOwotICAgICAgICBjb25zdCByaWdodEJhcldp ZHRoID0gKHRoaXMuX2JhclJpZ2h0RWxlbWVudC5vZmZzZXRXaWR0aCAtIGxhYmVsUGFkZGluZyk7 Ci0gICAgICAgIGNvbnN0IGxlZnRCYXJXaWR0aCA9ICgodGhpcy5fYmFyTGVmdEVsZW1lbnQub2Zm c2V0V2lkdGggLSB0aGlzLl9iYXJSaWdodEVsZW1lbnQub2Zmc2V0V2lkdGgpIC0gbGFiZWxQYWRk aW5nKTsKKyAgICAgICAgY29uc3QgYmFyUmlnaHRFbGVtZW50T2Zmc2V0V2lkdGggPSB0aGlzLl9i YXJSaWdodEVsZW1lbnQub2Zmc2V0V2lkdGg7CisgICAgICAgIGNvbnN0IGJhckxlZnRFbGVtZW50 T2Zmc2V0V2lkdGggPSB0aGlzLl9iYXJMZWZ0RWxlbWVudC5vZmZzZXRXaWR0aDsKKyAgICAgICAg Y29uc3QgcmlnaHRCYXJXaWR0aCA9IChiYXJSaWdodEVsZW1lbnRPZmZzZXRXaWR0aCAtIGxhYmVs UGFkZGluZyk7CisgICAgICAgIGNvbnN0IGxlZnRCYXJXaWR0aCA9ICgoYmFyTGVmdEVsZW1lbnRP ZmZzZXRXaWR0aCAtIGJhclJpZ2h0RWxlbWVudE9mZnNldFdpZHRoKSAtIGxhYmVsUGFkZGluZyk7 CisgICAgICAgIGNvbnN0IGxhYmVsTGVmdEVsZW1lbnRPZmZzZXRXaWR0aCA9IHRoaXMuX2xhYmVs TGVmdEVsZW1lbnQub2Zmc2V0V2lkdGg7CisgICAgICAgIGNvbnN0IGxhYmVsUmlnaHRFbGVtZW50 T2Zmc2V0V2lkdGggPSB0aGlzLl9sYWJlbFJpZ2h0RWxlbWVudC5vZmZzZXRXaWR0aDsKIAotICAg ICAgICB2YXIgbGFiZWxCZWZvcmUgPSAodGhpcy5fbGFiZWxMZWZ0RWxlbWVudC5vZmZzZXRXaWR0 aCA+IGxlZnRCYXJXaWR0aCk7Ci0gICAgICAgIHZhciBsYWJlbEFmdGVyID0gKHRoaXMuX2xhYmVs UmlnaHRFbGVtZW50Lm9mZnNldFdpZHRoID4gcmlnaHRCYXJXaWR0aCk7CisgICAgICAgIGNvbnN0 IGxhYmVsQmVmb3JlID0gKGxhYmVsTGVmdEVsZW1lbnRPZmZzZXRXaWR0aCA+IGxlZnRCYXJXaWR0 aCk7CisgICAgICAgIGNvbnN0IGxhYmVsQWZ0ZXIgPSAobGFiZWxSaWdodEVsZW1lbnRPZmZzZXRX aWR0aCA+IHJpZ2h0QmFyV2lkdGgpOworICAgICAgICBjb25zdCBncmFwaEVsZW1lbnRPZmZzZXRX aWR0aCA9IHRoaXMuX2dyYXBoRWxlbWVudC5vZmZzZXRXaWR0aDsKIAogICAgICAgICBpZiAobGFi ZWxCZWZvcmUpIHsKLSAgICAgICAgICAgIGlmICgodGhpcy5fZ3JhcGhFbGVtZW50Lm9mZnNldFdp ZHRoICogKHRoaXMuX3BlcmNlbnRhZ2VzLnN0YXJ0IC8gMTAwKSkgPCAodGhpcy5fbGFiZWxMZWZ0 RWxlbWVudC5vZmZzZXRXaWR0aCArIDEwKSkKKyAgICAgICAgICAgIGlmICgoZ3JhcGhFbGVtZW50 T2Zmc2V0V2lkdGggKiAodGhpcy5fcGVyY2VudGFnZXMuc3RhcnQgLyAxMDApKSA8IChsYWJlbExl ZnRFbGVtZW50T2Zmc2V0V2lkdGggKyAxMCkpCiAgICAgICAgICAgICAgICAgdGhpcy5fbGFiZWxM ZWZ0RWxlbWVudC5hZGRTdHlsZUNsYXNzKCJoaWRkZW4iKTsKICAgICAgICAgICAgIHRoaXMuX2xh YmVsTGVmdEVsZW1lbnQuc3R5bGUuc2V0UHJvcGVydHkoInJpZ2h0IiwgKDEwMCAtIHRoaXMuX3Bl cmNlbnRhZ2VzLnN0YXJ0KSArICIlIik7CiAgICAgICAgICAgICB0aGlzLl9sYWJlbExlZnRFbGVt ZW50LmFkZFN0eWxlQ2xhc3MoImJlZm9yZSIpOwpAQCAtMTIwNCw3ICsxMjA5LDcgQEAgV2ViSW5z cGVjdG9yLlJlc291cmNlR3JhcGgucHJvdG90eXBlID0gewogICAgICAgICB9CiAKICAgICAgICAg aWYgKGxhYmVsQWZ0ZXIpIHsKLSAgICAgICAgICAgIGlmICgodGhpcy5fZ3JhcGhFbGVtZW50Lm9m ZnNldFdpZHRoICogKCgxMDAgLSB0aGlzLl9wZXJjZW50YWdlcy5lbmQpIC8gMTAwKSkgPCAodGhp cy5fbGFiZWxSaWdodEVsZW1lbnQub2Zmc2V0V2lkdGggKyAxMCkpCisgICAgICAgICAgICBpZiAo KGdyYXBoRWxlbWVudE9mZnNldFdpZHRoICogKCgxMDAgLSB0aGlzLl9wZXJjZW50YWdlcy5lbmQp IC8gMTAwKSkgPCAobGFiZWxSaWdodEVsZW1lbnRPZmZzZXRXaWR0aCArIDEwKSkKICAgICAgICAg ICAgICAgICB0aGlzLl9sYWJlbFJpZ2h0RWxlbWVudC5hZGRTdHlsZUNsYXNzKCJoaWRkZW4iKTsK ICAgICAgICAgICAgIHRoaXMuX2xhYmVsUmlnaHRFbGVtZW50LnN0eWxlLnNldFByb3BlcnR5KCJs ZWZ0IiwgdGhpcy5fcGVyY2VudGFnZXMuZW5kICsgIiUiKTsKICAgICAgICAgICAgIHRoaXMuX2xh YmVsUmlnaHRFbGVtZW50LmFkZFN0eWxlQ2xhc3MoImFmdGVyIik7Cg==