33786 2010-01-18 00:35:31 -0800 [Qt] Fix qmake warning with qmake in Qt for Symbian 2010-01-19 14:14:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hausmann webkit-unassigned commit-queue kenneth laszlo.gombos oldest_to_newest 181762 0 hausmann 2010-01-18 00:35:31 -0800 [Qt] Fix qmake warning with qmake in Qt for Symbian 181763 1 46795 hausmann 2010-01-18 00:36:49 -0800 Created attachment 46795 Patch 181764 2 hausmann 2010-01-18 00:37:31 -0800 (In reply to comment #1) > Created an attachment (id=46795) [details] > Patch Note that this patch will break the build on Symbian with Qt versions earlier than Qt 4.6.0. 181766 3 46795 hausmann 2010-01-18 00:38:38 -0800 Comment on attachment 46795 Patch Laszlo, are you okay with this change? 181767 4 kenneth 2010-01-18 00:43:39 -0800 Sorry, awaiting Laszlo's input. 181768 5 kenneth 2010-01-18 00:45:56 -0800 What about doing this for Qt 4.6 only? If that is possible. 181775 6 hausmann 2010-01-18 01:17:19 -0800 (In reply to comment #5) > What about doing this for Qt 4.6 only? If that is possible. I just want to check if it would cause problems with their environment and if yes then we simply wait. It's just a warning fix and a small good cleanup after all. 182124 7 46795 laszlo.gombos 2010-01-18 20:43:27 -0800 Comment on attachment 46795 Patch Looks good to me as well, but have not had a chance to try it - for that we need more time. I'm OK with landing it now (but only for trunk). I think for the Symbian port Qt version 4.6 is probably a minimal dependency anyway. 182450 8 46795 commit-queue 2010-01-19 14:14:37 -0800 Comment on attachment 46795 Patch Clearing flags on attachment: 46795 Committed r53493: <http://trac.webkit.org/changeset/53493> 182451 9 commit-queue 2010-01-19 14:14:43 -0800 All reviewed patches have been landed. Closing bug. 46795 2010-01-18 00:36:49 -0800 2010-01-19 14:14:37 -0800 Patch bug-33786-20100118093646.patch text/plain 1122 hausmann ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWEzZTg1My4uMmRmNzQ1MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wMS0xOCAgS3Jpc3RpYW4gQW1s aWUgPGtyaXN0aWFuLmFtbGllQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCBxbWFrZSB3YXJuaW5nIHdpdGggcW1ha2Ug aW4gUXQgZm9yIFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzNzg2CisKKyAgICAgICAgKiBXZWJDb3JlLnBybzogVXNlIFFNQUtFX0xGTEFH UyBpbnN0ZWFkIG9mIE1NUF9SVUxFUy4KKwogMjAxMC0wMS0xNyAgU3JpbmlkaGkgU2hyZWVkaGFy YSAgPHNyaW5pZGhpLnNocmVlZGhhcmFAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLnBybyBiL1dlYkNv cmUvV2ViQ29yZS5wcm8KaW5kZXggZDk3ZjY5YS4uNzE5ZDlkOSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9XZWJDb3JlLnBybworKysgYi9XZWJDb3JlL1dlYkNvcmUucHJvCkBAIC0yNiw3ICsyNiw3IEBA IHN5bWJpYW46IHsKICAgICBNTVBfUlVMRVMgKz0gIlVTRVJJTkNMVURFIHBsYXRmb3JtL3RleHQi CiAgICAgIyBSTyB0ZXh0IChjb2RlKSBzZWN0aW9uIGluIHF0d2Via2l0LmRsbCBleGNlZWRzIGFs bG9jYXRlZCBzcGFjZSBmb3IgZ2NjZSB1ZGViIHRhcmdldC4KICAgICAjIE1vdmUgUlctc2VjdGlv biBiYXNlIGFkZHJlc3MgdG8gc3RhcnQgZnJvbSAweEUwMDAwMCBpbnN0ZWFkIG9mIHRoZSB0b29s Y2hhaW4gZGVmYXVsdCAweDQwMDAwMC4KLSAgICBNTVBfUlVMRVMgKz0gIkxJTktFUk9QVElPTiAg YXJtY2MgLS1ydy1iYXNlIDB4RTAwMDAwIgorICAgIFFNQUtFX0xGTEFHUy5BUk1DQyArPSAtLXJ3 LWJhc2UgMHhFMDAwMDAKICAgICBNTVBfUlVMRVMgKz0gQUxXQVlTX0JVSUxEX0FTX0FSTQogICAg IFFNQUtFX0NYWEZMQUdTLkFSTUNDICs9IC1PVGltZSAtTzMKIH0K