33778 2010-01-17 18:35:01 -0800 [Chromium] Remove an old runFileChooser() method. 2010-01-17 20:53:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tkent webkit-unassigned commit-queue fishd oldest_to_newest 181685 0 tkent 2010-01-17 18:35:01 -0800 [Chromium] Remove an old runFileChooser() method. 181686 1 46775 tkent 2010-01-17 18:36:45 -0800 Created attachment 46775 Patch 181688 2 tkent 2010-01-17 18:38:22 -0800 This is a follow-up of Bug#32473 and http://codereview.chromium.org/497001 . 181714 3 46775 hamaji 2010-01-17 20:14:37 -0800 Comment on attachment 46775 Patch Looks good. 181719 4 46775 commit-queue 2010-01-17 20:53:34 -0800 Comment on attachment 46775 Patch Clearing flags on attachment: 46775 Committed r53389: <http://trac.webkit.org/changeset/53389> 181720 5 commit-queue 2010-01-17 20:53:40 -0800 All reviewed patches have been landed. Closing bug. 46775 2010-01-17 18:36:45 -0800 2010-01-17 20:53:33 -0800 Patch bug-33778-20100118113642.patch text/plain 2396 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDdkNzc5NDEuLmJlZTY0ZGIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDEwLTAxLTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1d IFJlbW92ZSBhbiBvbGQgcnVuRmlsZUNob29zZXIoKSBtZXRob2QuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzc3OAorICAgICAgICAKKyAgICAgICAg Q2hyb21pdW0gY29kZSBzd2l0Y2hlZCB0byBuZXcgcnVuRmlsZUNob29zZXIoKSBpbnRyb2R1Y2Vk IGJ5CisgICAgICAgIHI1MzI2OS4gVGhlIG9sZCBvbmUgaXMgbm90IG5lZWRlZCBhbnltb3JlLgor CisgICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAgICAgICAgKiBzcmMvQ2hyb21l Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OnJ1bk9w ZW5QYW5lbCk6CisKIDIwMTAtMDEtMTUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgog CiAgICAgICAgIE5vIHJldmlldywgcm9sbGluZyBvdXQgcjUzMzQ0LgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYlZpZXdDbGllbnQuaAppbmRleCAxNmEyZmNhLi45OGRiNGIyIDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtMTYxLDExICsxNjEsNiBAQCBwdWJsaWM6CiAK ICAgICAvLyBEaWFsb2dzIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotICAgIC8vIERlcHJlY2F0ZWQuIFVzZSBhbm90aGVyIHJ1 bkZpbGVDaG9vc2VyKCkgYmVsb3cgaW5zdGVhZC4KLSAgICB2aXJ0dWFsIGJvb2wgcnVuRmlsZUNo b29zZXIoCi0gICAgICAgIGJvb2wgbXVsdGlTZWxlY3QsIGNvbnN0IFdlYlN0cmluZyYgdGl0bGUs Ci0gICAgICAgIGNvbnN0IFdlYlN0cmluZyYgaW5pdGlhbFZhbHVlLCBXZWJGaWxlQ2hvb3NlckNv bXBsZXRpb24qKSB7IHJldHVybiBmYWxzZTsgfQotCiAgICAgLy8gVGhpcyBtZXRob2QgcmV0dXJu cyBpbW1lZGlhdGVseSBhZnRlciBzaG93aW5nIHRoZSBkaWFsb2cuIFdoZW4gdGhlCiAgICAgLy8g ZGlhbG9nIGlzIGNsb3NlZCwgaXQgc2hvdWxkIGNhbGwgdGhlIFdlYkZpbGVDaG9vc2VyQ29tcGxl dGlvbiB0bwogICAgIC8vIHBhc3MgdGhlIHJlc3VsdHMgb2YgdGhlIGRpYWxvZy4gUmV0dXJucyBm YWxzZSBpZgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggNzU1 Mjk5Ny4uOTA3OTA5NCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGll bnRJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3Bw CkBAIC01NzIsMTQgKzU3Miw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50SW1wbDo6cnVuT3BlblBhbmVs KEZyYW1lKiBmcmFtZSwgUGFzc1JlZlB0cjxGaWxlQ2hvb3Nlcj4gZmlsZUNoCiAgICAgaWYgKGNs aWVudC0+cnVuRmlsZUNob29zZXIocGFyYW1zLCBjaG9vc2VyQ29tcGxldGlvbikpCiAgICAgICAg IHJldHVybjsKIAotICAgIC8vIENob29zaW5nIHdpdGggbmV3IGZ1bmN0aW9uIGZhaWxlZCwgc28g ZmFsbGJhY2sgdG8gb2xkIGZ1bmN0aW9uLgotICAgIGlmIChjbGllbnQtPnJ1bkZpbGVDaG9vc2Vy KHBhcmFtcy5tdWx0aVNlbGVjdCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYXJh bXMudGl0bGUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFyYW1zLmluaXRpYWxW YWx1ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaG9vc2VyQ29tcGxldGlvbikp Ci0gICAgICAgIHJldHVybjsKLQotICAgIC8vIENob29zaW5nIHdpdGggdGhlIG9sZCBmdW5jdGlv biBmYWlsZWQsIHNvIGRvIGNhbGxiYWNrIHdpdGggYW4gZW1wdHkgbGlzdC4KKyAgICAvLyBDaG9v c2luZyBmYWlsZWQsIHNvIGRvIGNhbGxiYWNrIHdpdGggYW4gZW1wdHkgbGlzdC4KICAgICBjaG9v c2VyQ29tcGxldGlvbi0+ZGlkQ2hvb3NlRmlsZShXZWJWZWN0b3I8V2ViU3RyaW5nPigpKTsKIH0K IAo=