33765 2010-01-16 14:10:50 -0800 Web Inspector: Use String.trim() instead of a regex 2010-01-16 15:31:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 181556 0 timothy 2010-01-16 14:10:50 -0800 Use String.trim() instead of a regex in the Web Inspector 181558 1 46749 timothy 2010-01-16 14:12:02 -0800 Created attachment 46749 Proposed Change 181568 2 timothy 2010-01-16 15:31:42 -0800 Landed in r53366 46749 2010-01-16 14:12:02 -0800 2010-01-16 15:20:17 -0800 Proposed Change bug-33765-20100116141201.patch text/plain 6079 timothy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGJmNThmNy4uNWU5NWY2MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wMS0xNiAgVGltb3RoeSBIYXRj aGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFN0cmluZy50cmltKCkgaW5z dGVhZCBvZiBhIHJlZ2V4IGluIHRoZSBXZWIgSW5zcGVjdG9yLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzc2NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVt ZW50c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90 eXBlLnBlcmZvcm1TZWFyY2gpOiBVc2UgLnRyaW0oKS4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0aW9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y Lk9iamVjdFByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlLmFwcGx5RXhwcmVzc2lvbik6IERp dHRvLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZVZpZXcuanM6CisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuX2V2YWxTZWxlY3Rpb25JbkNhbGxGcmFtZSk6 IERpdHRvLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3Rv dHlwZSk6IERpdHRvLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpz OgorICAgICAgICAoU3RyaW5nLnByb3RvdHlwZS50cmltTGVhZGluZ1doaXRlc3BhY2UpOiBSZW1v dmVkLgorICAgICAgICAoU3RyaW5nLnByb3RvdHlwZS50cmltVHJhaWxpbmdXaGl0ZXNwYWNlKTog UmVtb3ZlZC4KKyAgICAgICAgKFN0cmluZy5wcm90b3R5cGUudHJpbVdoaXRlc3BhY2UpOiBSZW1v dmVkLgorCiAyMDEwLTAxLTE1ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcwppbmRleCA5M2RkNzAwLi4xZTY0ZGYwIDEwMDY0NAot LS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcworKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcwpAQCAtMjY1LDcgKzI2 NSw3IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAg Ly8gQ2FsbCBzZWFyY2hDYW5jZWxlZCBzaW5jZSBpdCB3aWxsIHJlc2V0IGV2ZXJ5dGhpbmcgd2Ug bmVlZCBiZWZvcmUgZG9pbmcgYSBuZXcgc2VhcmNoLgogICAgICAgICB0aGlzLnNlYXJjaENhbmNl bGVkKCk7CiAKLSAgICAgICAgY29uc3Qgd2hpdGVzcGFjZVRyaW1tZWRRdWVyeSA9IHF1ZXJ5LnRy aW1XaGl0ZXNwYWNlKCk7CisgICAgICAgIGNvbnN0IHdoaXRlc3BhY2VUcmltbWVkUXVlcnkgPSBx dWVyeS50cmltKCk7CiAgICAgICAgIGlmICghd2hpdGVzcGFjZVRyaW1tZWRRdWVyeS5sZW5ndGgp CiAgICAgICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5qcwppbmRleCBmY2ZkNGNmLi4wZjlkY2Vj IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGll c1NlY3Rpb24uanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3Bl cnRpZXNTZWN0aW9uLmpzCkBAIC0yMzMsNyArMjMzLDcgQEAgV2ViSW5zcGVjdG9yLk9iamVjdFBy b3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgYXBwbHlFeHByZXNzaW9uOiBm dW5jdGlvbihleHByZXNzaW9uLCB1cGRhdGVJbnRlcmZhY2UpCiAgICAgewotICAgICAgICBleHBy ZXNzaW9uID0gZXhwcmVzc2lvbi50cmltV2hpdGVzcGFjZSgpOworICAgICAgICBleHByZXNzaW9u ID0gZXhwcmVzc2lvbi50cmltKCk7CiAgICAgICAgIHZhciBleHByZXNzaW9uTGVuZ3RoID0gZXhw cmVzc2lvbi5sZW5ndGg7CiAgICAgICAgIHZhciBzZWxmID0gdGhpczsKICAgICAgICAgdmFyIGNh bGxiYWNrID0gZnVuY3Rpb24oc3VjY2VzcykgewpAQCAtMjUxLDcgKzI1MSw3IEBAIFdlYkluc3Bl Y3Rvci5PYmplY3RQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg ICAgICBzZWxmLnVwZGF0ZVNpYmxpbmdzKCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH07Ci0g ICAgICAgIEluamVjdGVkU2NyaXB0QWNjZXNzLnNldFByb3BlcnR5VmFsdWUodGhpcy5wcm9wZXJ0 eS5wYXJlbnRPYmplY3RQcm94eSwgdGhpcy5wcm9wZXJ0eS5uYW1lLCBleHByZXNzaW9uLnRyaW1X aGl0ZXNwYWNlKCksIGNhbGxiYWNrKTsKKyAgICAgICAgSW5qZWN0ZWRTY3JpcHRBY2Nlc3Muc2V0 UHJvcGVydHlWYWx1ZSh0aGlzLnByb3BlcnR5LnBhcmVudE9iamVjdFByb3h5LCB0aGlzLnByb3Bl cnR5Lm5hbWUsIGV4cHJlc3Npb24udHJpbSgpLCBjYWxsYmFjayk7CiAgICAgfQogfQogCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZVZpZXcuanMgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZVZpZXcuanMKaW5kZXggYzE2NGU5NC4uM2Ex Y2UzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVWaWV3 LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlVmlldy5qcwpAQCAt MjMzLDcgKzIzMyw3IEBAIFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUgPSB7 CiAgICAgICAgIC8vIENhbGwgc2VhcmNoQ2FuY2VsZWQgc2luY2UgaXQgd2lsbCByZXNldCBldmVy eXRoaW5nIHdlIG5lZWQgYmVmb3JlIGRvaW5nIGEgbmV3IHNlYXJjaC4KICAgICAgICAgdGhpcy5z ZWFyY2hDYW5jZWxlZCgpOwogCi0gICAgICAgIHF1ZXJ5ID0gcXVlcnkudHJpbVdoaXRlc3BhY2Uo KTsKKyAgICAgICAgcXVlcnkgPSBxdWVyeS50cmltKCk7CiAKICAgICAgICAgaWYgKCFxdWVyeS5s ZW5ndGgpCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvU291cmNlRnJhbWUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv U291cmNlRnJhbWUuanMKaW5kZXggNzdiMjVjNC4uYTBjMDlhZCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwpAQCAtNDQ0LDcgKzQ0NCw3IEBAIFdlYkluc3Bl Y3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghc2VsZWN0aW9uLnJh bmdlQ291bnQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdmFyIGV4cHJlc3Npb24g PSBzZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKS50b1N0cmluZygpLnRyaW1XaGl0ZXNwYWNlKCk7Cisg ICAgICAgIHZhciBleHByZXNzaW9uID0gc2VsZWN0aW9uLmdldFJhbmdlQXQoMCkudG9TdHJpbmco KS50cmltKCk7CiAgICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy5ldmFsdWF0ZUlu U2VsZWN0ZWRDYWxsRnJhbWUoZXhwcmVzc2lvbiwgZmFsc2UsICJjb25zb2xlIiwgZnVuY3Rpb24o cmVzdWx0LCBleGNlcHRpb24pIHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5zaG93Q29uc29s ZSgpOwogICAgICAgICAgICAgdmFyIGNvbW1hbmRNZXNzYWdlID0gbmV3IFdlYkluc3BlY3Rvci5D b25zb2xlQ29tbWFuZChleHByZXNzaW9uKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwppbmRleCBhNmYyM2I1Li4xYjVmZmJjIDEwMDY0NAot LS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKKysr IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC0x MzEwLDcgKzEzMTAsNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnBy b3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZhciBzZWN0aW9uID0gdGhpcy50cmVlT3V0bGlu ZS5zZWN0aW9uOwogICAgICAgICB2YXIgZWxlbWVudHNQYW5lbCA9IFdlYkluc3BlY3Rvci5wYW5l bHMuZWxlbWVudHM7Ci0gICAgICAgIHZhciBzdHlsZVRleHRMZW5ndGggPSBzdHlsZVRleHQudHJp bVdoaXRlc3BhY2UoKS5sZW5ndGg7CisgICAgICAgIHZhciBzdHlsZVRleHRMZW5ndGggPSBzdHls ZVRleHQudHJpbSgpLmxlbmd0aDsKICAgICAgICAgaWYgKCFzdHlsZVRleHRMZW5ndGggJiYgdXBk YXRlSW50ZXJmYWNlKSB7CiAgICAgICAgICAgICBpZiAodGhpcy5fbmV3UHJvcGVydHkpIHsKICAg ICAgICAgICAgICAgICAvLyBUaGUgdXNlciBkZWxldGVkIGV2ZXJ5dGhpbmcsIHNvIHJlbW92ZSB0 aGUgdHJlZSBlbGVtZW50IGFuZCB1cGRhdGUuCkBAIC0xMzYxLDcgKzEzNjEsNyBAQCBXZWJJbnNw ZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg ICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzLnRyZWVPdXRsaW5lLnVwZGF0ZSgpOwog ICAgICAgICB9CiAKLSAgICAgICAgSW5qZWN0ZWRTY3JpcHRBY2Nlc3MuYXBwbHlTdHlsZVRleHQo dGhpcy5zdHlsZS5pZCwgc3R5bGVUZXh0LnRyaW1XaGl0ZXNwYWNlKCksIHRoaXMubmFtZSwgY2Fs bGJhY2spOworICAgICAgICBJbmplY3RlZFNjcmlwdEFjY2Vzcy5hcHBseVN0eWxlVGV4dCh0aGlz LnN0eWxlLmlkLCBzdHlsZVRleHQudHJpbSgpLCB0aGlzLm5hbWUsIGNhbGxiYWNrKTsKICAgICB9 CiB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCmluZGV4IDQ3NTE0 NTkuLmQ1NDAwNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGls aXRpZXMuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwpA QCAtMzMzLDIxICszMzMsNiBAQCBTdHJpbmcucHJvdG90eXBlLmNvbGxhcHNlV2hpdGVzcGFjZSA9 IGZ1bmN0aW9uKCkKICAgICByZXR1cm4gdGhpcy5yZXBsYWNlKC9bXHNceEEwXSsvZywgIiAiKTsK IH0KIAotU3RyaW5nLnByb3RvdHlwZS50cmltTGVhZGluZ1doaXRlc3BhY2UgPSBmdW5jdGlvbigp Ci17Ci0gICAgcmV0dXJuIHRoaXMucmVwbGFjZSgvXltcc1x4QTBdKy9nLCAiIik7Ci19Ci0KLVN0 cmluZy5wcm90b3R5cGUudHJpbVRyYWlsaW5nV2hpdGVzcGFjZSA9IGZ1bmN0aW9uKCkKLXsKLSAg ICByZXR1cm4gdGhpcy5yZXBsYWNlKC9bXHNceEEwXSskL2csICIiKTsKLX0KLQotU3RyaW5nLnBy b3RvdHlwZS50cmltV2hpdGVzcGFjZSA9IGZ1bmN0aW9uKCkKLXsKLSAgICByZXR1cm4gdGhpcy5y ZXBsYWNlKC9eW1xzXHhBMF0rfFtcc1x4QTBdKyQvZywgIiIpOwotfQotCiBTdHJpbmcucHJvdG90 eXBlLnRyaW1VUkwgPSBmdW5jdGlvbihiYXNlVVJMRG9tYWluKQogewogICAgIHZhciByZXN1bHQg PSB0aGlzLnJlcGxhY2UoL15odHRwcz86XC9cLy9pLCAiIik7Cg==