33746 2010-01-15 15:06:12 -0800 [GTK] More crashes related to the clipboard management 2010-01-21 00:30:07 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 32900 Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 181413 0 gustavo 2010-01-15 15:06:12 -0800 OK, looks like my last patch was not enough. I still got some crashes, and end up figuring we cannot trust in Page being alive or null, at all, so my alternative approach to the crash is to do explicit ref counting to guard the webView in between the clipboard call and its callbacks being called. 181414 1 46713 gustavo 2010-01-15 15:10:29 -0800 Created attachment 46713 Use WebView object instead of page for clipboard callbacks, allowing us to avoid its destruction inbetween 181571 2 gustavo 2010-01-16 16:25:08 -0800 *** This bug has been marked as a duplicate of bug 32900 *** 183108 3 46713 mjs 2010-01-21 00:30:07 -0800 Comment on attachment 46713 Use WebView object instead of page for clipboard callbacks, allowing us to avoid its destruction inbetween Unflagging since this appears to be already fixed in the original of which this is a duplicate. 46713 2010-01-15 15:10:29 -0800 2010-01-21 00:30:06 -0800 Use WebView object instead of page for clipboard callbacks, allowing us to avoid its destruction inbetween 0001-Fix-crash-by-passing-WebView-object-to-the-clipboard.patch text/plain 4826 gustavo RnJvbSBhOWFmYzY2ZTFiMmFkODAwN2I2M2MxZTA2Mjk5NzI4NzZhNTc4ZjQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgMTUgSmFuIDIwMTAgMjE6MDg6MjkgLTAyMDAKU3ViamVjdDogW1BBVENIXSBG aXggY3Jhc2ggYnkgcGFzc2luZyBXZWJWaWV3IG9iamVjdCB0byB0aGUgY2xpcGJvYXJkIGZ1bmN0 aW9ucyBpbnN0ZWFkIG9mIFBhZ2UKCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKwogV2ViS2l0L2d0ay9XZWJD b3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwICAgICB8ICAgIDIgKy0KIFdlYktpdC9ndGsv V2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhlbHBlckd0ay5jcHAgfCAgIDMxICsrKysrKysrKysr KysrKy0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hh bmdlTG9nCmluZGV4IDAzN2YyOGQuLjY2NTA0YzAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hh bmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAt MDEtMTUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTW9yZSBjcmFzaGVz IHJlbGF0ZWQgdG8gdGhlIGNsaXBib2FyZCBtYW5hZ2VtZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzc0NgorCisgICAgICAgIFBhc3MgdGhlIFdl YktpdFdlYlZpZXcgb2JqZWN0ICh3aGljaCBpcyBhIEdPYmplY3QsIHRodXMKKyAgICAgICAgcmVm LWNvdW50ZWQpIHRvIHRoZSBjbGlwYm9hcmQgZnVuY3Rpb25zIGluc3RlYWQgb2YgcGFzc2luZyB0 aGUKKyAgICAgICAgUGFnZSAtIHRoaXMgYWxsb3dzIHVzIHRvIGV4cGxpY2l0ZWx5IHByb3RlY3Qg dGhlIG9iamVjdCBpbmJldHdlZW4KKyAgICAgICAgdGhlIGNsaXBib2FyZCBjYWxsIGFuZCBpdHMg Y2FsbGJhY2tzLCB3aGljaCBmaXhlcyB0aGUgY3Jhc2guCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnQ6 OnJlc3BvbmRUb0NoYW5nZWRTZWxlY3Rpb24pOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1Bh c3RlYm9hcmRIZWxwZXJHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpnZXRDbGlwYm9hcmRDb250 ZW50c0NhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6Y2xlYXJDbGlwYm9hcmRDb250ZW50c0Nh bGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6UGFzdGVib2FyZEhlbHBlckd0azo6d3JpdGVDbGlw Ym9hcmRDb250ZW50cyk6CisKIDIwMTAtMDEtMTQgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGdu c0Bnbm9tZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAgYi9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEd0ay5jcHAKaW5kZXggMjY2NzIzYi4u MDJkMWE1MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50R3Rr LmNwcApAQCAtMjA2LDcgKzIwNiw3IEBAIHZvaWQgRWRpdG9yQ2xpZW50OjpyZXNwb25kVG9DaGFu Z2VkU2VsZWN0aW9uKCkKICAgICBpZiAodGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT5pc1Jhbmdl KCkpIHsKICAgICAgICAgZGF0YU9iamVjdC0+Y2xlYXIoKTsKICAgICAgICAgZGF0YU9iamVjdC0+ c2V0UmFuZ2UodGFyZ2V0RnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpKTsK LSAgICAgICAgcGFzdGVib2FyZEhlbHBlckluc3RhbmNlKCktPndyaXRlQ2xpcGJvYXJkQ29udGVu dHMoY2xpcGJvYXJkLCBjb3JlUGFnZSk7CisgICAgICAgIHBhc3RlYm9hcmRIZWxwZXJJbnN0YW5j ZSgpLT53cml0ZUNsaXBib2FyZENvbnRlbnRzKGNsaXBib2FyZCwgbV93ZWJWaWV3KTsKICAgICB9 CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJv YXJkSGVscGVyR3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGFzdGVib2FyZEhl bHBlckd0ay5jcHAKaW5kZXggMzdmM2IxOC4uMGZmY2FkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay9XZWJDb3JlU3VwcG9ydC9QYXN0ZWJvYXJkSGVscGVyR3RrLmNwcAorKysgYi9XZWJLaXQvZ3Rr L1dlYkNvcmVTdXBwb3J0L1Bhc3RlYm9hcmRIZWxwZXJHdGsuY3BwCkBAIC0xMTEsNiArMTExLDkg QEAgc3RhdGljIHZvaWQgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxsYmFjayhHdGtDbGlwYm9hcmQq IGNsaXBib2FyZCwgR3RrU2VsZWN0aW9uRGEKICAgICBEYXRhT2JqZWN0R3RrKiBkYXRhT2JqZWN0 ID0gRGF0YU9iamVjdEd0azo6Zm9yQ2xpcGJvYXJkKGNsaXBib2FyZCk7CiAgICAgQVNTRVJUKGRh dGFPYmplY3QpOwogICAgIGZpbGxTZWxlY3Rpb25EYXRhKHNlbGVjdGlvbkRhdGEsIGluZm8sIGRh dGFPYmplY3QpOworCisgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IHN0YXRpY19jYXN0PFdl YktpdFdlYlZpZXcqPihkYXRhKTsKKyAgICBnX29iamVjdF91bnJlZih3ZWJWaWV3KTsKIH0KIAog c3RhdGljIHZvaWQgY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrKEd0a0NsaXBib2FyZCog Y2xpcGJvYXJkLCBncG9pbnRlciBkYXRhKQpAQCAtMTI0LDE4ICsxMjcsMjEgQEAgc3RhdGljIHZv aWQgY2xlYXJDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNrKEd0a0NsaXBib2FyZCogY2xpcGJvYXJk LCBncG9pbnRlciBkYXQKICAgICBBU1NFUlQoZGF0YU9iamVjdCk7CiAKICAgICBkYXRhT2JqZWN0 LT5jbGVhcigpOwotICAgIGlmIChkYXRhKSB7Ci0gICAgICAgIFdlYkNvcmU6OlBhZ2UqIGNvcmVQ YWdlID0gcmVpbnRlcnByZXRfY2FzdDxXZWJDb3JlOjpQYWdlKj4oZGF0YSk7CisgICAgV2ViS2l0 V2ViVmlldyogd2ViVmlldyA9IHJlaW50ZXJwcmV0X2Nhc3Q8V2ViS2l0V2ViVmlldyo+KGRhdGEp OworICAgIFdlYkNvcmU6OlBhZ2UqIGNvcmVQYWdlID0gY29yZSh3ZWJWaWV3KTsKIAotICAgICAg ICBpZiAoIWNvcmVQYWdlLT5mb2N1c0NvbnRyb2xsZXIoKSkKLSAgICAgICAgICAgIHJldHVybjsK KyAgICBpZiAoIWNvcmVQYWdlIHx8ICFjb3JlUGFnZS0+Zm9jdXNDb250cm9sbGVyKCkpIHsKKyAg ICAgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAK LSAgICAgICAgRnJhbWUqIGZyYW1lID0gY29yZVBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5mb2N1 c2VkT3JNYWluRnJhbWUoKTsKKyAgICBGcmFtZSogZnJhbWUgPSBjb3JlUGFnZS0+Zm9jdXNDb250 cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOwogCi0gICAgICAgIC8vIENvbGxhcHNlIHRo ZSBzZWxlY3Rpb24gd2l0aG91dCBjbGVhcmluZyBpdAotICAgICAgICBBU1NFUlQoZnJhbWUpOwot ICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldEJhc2UoZnJhbWUtPnNlbGVjdGlvbigpLT5l eHRlbnQoKSwgZnJhbWUtPnNlbGVjdGlvbigpLT5hZmZpbml0eSgpKTsKLSAgICB9CisgICAgLy8g Q29sbGFwc2UgdGhlIHNlbGVjdGlvbiB3aXRob3V0IGNsZWFyaW5nIGl0CisgICAgQVNTRVJUKGZy YW1lKTsKKyAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldEJhc2UoZnJhbWUtPnNlbGVjdGlvbigp LT5leHRlbnQoKSwgZnJhbWUtPnNlbGVjdGlvbigpLT5hZmZpbml0eSgpKTsKKworICAgIGdfb2Jq ZWN0X3VucmVmKHdlYlZpZXcpOwogfQogCiB2b2lkIFBhc3RlYm9hcmRIZWxwZXJHdGs6OndyaXRl Q2xpcGJvYXJkQ29udGVudHMoR3RrQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIGdwb2ludGVyIGRhdGEp CkBAIC0xNDgsNiArMTU0LDEzIEBAIHZvaWQgUGFzdGVib2FyZEhlbHBlckd0azo6d3JpdGVDbGlw Ym9hcmRDb250ZW50cyhHdGtDbGlwYm9hcmQqIGNsaXBib2FyZCwgZ3BvaW50CiAKICAgICBpZiAo bnVtYmVyT2ZUYXJnZXRzID4gMCAmJiB0YWJsZSkgewogICAgICAgICBzZXR0aW5nQ2xpcGJvYXJk ID0gdHJ1ZTsKKworICAgICAgICAvLyBQcm90ZWN0IHRoZSB3ZWIgdmlldyBmcm9tIGJlaW5nIGRl c3Ryb3llZCBiZWZvcmUgb25lIG9mIHRoZSBjbGlwYm9hcmQgY2FsbGJhY2tzCisgICAgICAgIC8v IGlzIGNhbGxlZC4gQmFsYW5jZWQgaW4gYm90aCBnZXRDbGlwYm9hcmRDb250ZW50c0NhbGxiYWNr IGFuZAorICAgICAgICAvLyBjbGVhckNsaXBib2FyZENvbnRlbnRzQ2FsbGJhY2suCisgICAgICAg IFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBzdGF0aWNfY2FzdDxXZWJLaXRXZWJWaWV3Kj4oZGF0 YSk7CisgICAgICAgIGdfb2JqZWN0X3JlZih3ZWJWaWV3KTsKKwogICAgICAgICBndGtfY2xpcGJv YXJkX3NldF93aXRoX2RhdGEoY2xpcGJvYXJkLCB0YWJsZSwgbnVtYmVyT2ZUYXJnZXRzLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2V0Q2xpcGJvYXJkQ29udGVudHNDYWxs YmFjaywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsZWFyQ2xpcGJvYXJk Q29udGVudHNDYWxsYmFjaywgZGF0YSk7Ci0tIAoxLjYuNS43Cgo=