33739 2010-01-15 14:09:50 -0800 Fullscreen video HUD stays on top when switching to another window (e.g. via Alt-Tab) 2010-03-12 15:17:31 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned bdakin cmarrin oldest_to_newest 181382 0 aroben 2010-01-15 14:09:50 -0800 To reproduce: 1. Go to a page with <video controls> 2. Click the fullscreen button in the video's controls 3. Switch to another window via Alt-Tab (e.g., the Safari window that contained the <video>) The fullscreen video's HUD stays on screen, on top of whatever window you've just switched to. 181389 1 aroben 2010-01-15 14:15:18 -0800 <rdar://problem/7547574> 198821 2 50556 bdakin 2010-03-11 16:04:35 -0800 Created attachment 50556 Patch 199197 3 50556 aroben 2010-03-12 13:44:35 -0800 Comment on attachment 50556 Patch > void FullscreenVideoController::draw() > { > + HWND foregroundWindow = GetForegroundWindow(); > + if (foregroundWindow == m_videoWindow) > + createHUDWindow(); > + else if (foregroundWindow != m_hudWindow) > + destroyHUDWindow(); > + After this, I think you should assert that m_hudWindow is non-null. And maybe you should bail if it is null, in release builds. r=me 199208 4 50631 bdakin 2010-03-12 14:09:19 -0800 Created attachment 50631 New patch Adam and I discussed a better way to do this on IRC! 199210 5 50631 aroben 2010-03-12 14:10:53 -0800 Comment on attachment 50631 New patch r=me! 199236 6 bdakin 2010-03-12 15:17:31 -0800 Fixed with r55942. 50556 2010-03-11 16:04:35 -0800 2010-03-12 14:09:19 -0800 Patch forReview.txt text/plain 3620 bdakin SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTg1OSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTAtMDMtMTEgIEJldGggRGFraW4gIDxiZGFraW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNzM5 IEZ1bGxzY3JlZW4gCisgICAgICAgIHZpZGVvIEhVRCBzdGF5cyBvbiB0b3Agd2hlbiBzd2l0Y2hp bmcgdG8gYW5vdGhlciB3aW5kb3cgKGUuZy4gdmlhIAorICAgICAgICBBbHQtVGFiKQorICAgICAg ICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTQ3NTc0Pgor CisgICAgICAgIFRoZSBIVUQgaXMgYWx3YXlzIG9uIHRvcCBiZWNhdXNlIGl0IGhhcyB0aGUgV1Nf RVhfVE9QTU9TVCBzdHlsZSwgCisgICAgICAgIHdoaWNoIG1ha2VzIGl0IHN0YXkgb24gdG9wIG9m IGFsbCBvdGhlciB3aW5kb3dzIGV2ZW4gd2hlbiBpdCBpcyAKKyAgICAgICAgZGVhY3RpdmF0ZWQu IFVuZm9ydHVuYXRlbHksIEkgY291bGRuJ3QgZmlndXJlIG91dCBhbm90aGVyIAorICAgICAgICBj b21iaW5hdGlvbiBvZiB3aW5kb3cgc3R5bGVzIHRvIG1ha2UgdGhlIEhVRCBzdGF5IG9uIHRvcCBv bmx5IGFuZCAKKyAgICAgICAgYWx3YXlzIHdoZW4gdGhlIHZpZGVvIGlzIHRoZSBhY3RpdmUgd2lu ZG93LiBTbyBpbnN0ZWFkLCBJIGNoZWNrIHRoZSAKKyAgICAgICAgZm9yZWdyb3VuZCB3aW5kb3cg aW4gRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcjo6ZHJhdygpLiBJZiB0aGUgCisgICAgICAgIGZv cmVncm91bmQgd2luZG93IGlzIG5laXRoZXIgbV9odWRXaW5kb3cgbm9yIG1fdmlkZW9XaW5kb3cs IHRoZW4gSSAKKyAgICAgICAgZGVzdHJveSB0aGUgSFVELiBJZiBtX3ZpZGVvV2luZG93IGlzIHRo ZSBmb3JlZ3JvdW5kIHdpbmRvdywgdGhlbiBJIAorICAgICAgICByZS1jcmVhdGUgdGhlIEhVRC4K KworICAgICAgICAqIEZ1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoRnVs bHNjcmVlblZpZGVvQ29udHJvbGxlcjo6ZXhpdEZ1bGxzY3JlZW4pOgorICAgICAgICAoRnVsbHNj cmVlblZpZGVvQ29udHJvbGxlcjo6Y3JlYXRlSFVEV2luZG93KToKKyAgICAgICAgKEZ1bGxzY3Jl ZW5WaWRlb0NvbnRyb2xsZXI6OmRlc3Ryb3lIVURXaW5kb3cpOgorICAgICAgICAoRnVsbHNjcmVl blZpZGVvQ29udHJvbGxlcjo6ZHJhdyk6CisgICAgICAgICogRnVsbHNjcmVlblZpZGVvQ29udHJv bGxlci5oOgorCiAyMDEwLTAzLTEwICBFcmljIFVocmhhbmUgIDxlcmljdUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJLaXQvd2luL0Z1 bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vRnVs bHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDU1ODQ5KQorKysgV2ViS2l0L3dp bi9GdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjMxLDgg KzIzMSw3IEBAIHZvaWQgRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcjo6ZXhpdEZ1bGwKIAogICAg IG1fdmlkZW9XaW5kb3cgPSAwOwogICAgIFNldFdpbmRvd0xvbmdQdHIobV9odWRXaW5kb3csIDAs IDApOwotICAgIERlc3Ryb3lXaW5kb3cobV9odWRXaW5kb3cpOwotICAgIG1faHVkV2luZG93ID0g MDsKKyAgICBkZXN0cm95SFVEV2luZG93KCk7CiB9CiAKIGJvb2wgRnVsbHNjcmVlblZpZGVvQ29u dHJvbGxlcjo6Y2FuUGxheSgpIGNvbnN0CkBAIC0zNDYsNiArMzQ1LDkgQEAgdm9pZCBGdWxsc2Ny ZWVuVmlkZW9Db250cm9sbGVyOjpyZWdpc3RlcgogCiB2b2lkIEZ1bGxzY3JlZW5WaWRlb0NvbnRy b2xsZXI6OmNyZWF0ZUhVRFdpbmRvdygpCiB7CisgICAgaWYgKG1faHVkV2luZG93KQorICAgICAg ICByZXR1cm47CisKICAgICBtX2h1ZFBvc2l0aW9uLnNldFgoKG1fZnVsbHNjcmVlblNpemUud2lk dGgoKSAtIHdpbmRvd1dpZHRoKSAvIDIpOwogICAgIG1faHVkUG9zaXRpb24uc2V0WShtX2Z1bGxz Y3JlZW5TaXplLmhlaWdodCgpICogaW5pdGlhbEhVRFBvc2l0aW9uWSAtIHdpbmRvd0hlaWdodCAv IDIpOwogCkBAIC0zNzcsNiArMzc5LDE1IEBAIHZvaWQgRnVsbHNjcmVlblZpZGVvQ29udHJvbGxl cjo6Y3JlYXRlSFUKICAgICBkcmF3KCk7CiB9CiAKK3ZvaWQgRnVsbHNjcmVlblZpZGVvQ29udHJv bGxlcjo6ZGVzdHJveUhVRFdpbmRvdygpCit7CisgICAgaWYgKCFtX2h1ZFdpbmRvdykKKyAgICAg ICAgcmV0dXJuOworCisgICAgRGVzdHJveVdpbmRvdyhtX2h1ZFdpbmRvdyk7CisgICAgbV9odWRX aW5kb3cgPSAwOworfQorCiBzdGF0aWMgU3RyaW5nIHRpbWVUb1N0cmluZyhmbG9hdCB0aW1lKQog ewogICAgIGlmICghaXNmaW5pdGUodGltZSkpCkBAIC0zOTcsNiArNDA4LDEyIEBAIHN0YXRpYyBT dHJpbmcgdGltZVRvU3RyaW5nKGZsb2F0IHRpbWUpCiAKIHZvaWQgRnVsbHNjcmVlblZpZGVvQ29u dHJvbGxlcjo6ZHJhdygpCiB7CisgICAgSFdORCBmb3JlZ3JvdW5kV2luZG93ID0gR2V0Rm9yZWdy b3VuZFdpbmRvdygpOworICAgIGlmIChmb3JlZ3JvdW5kV2luZG93ID09IG1fdmlkZW9XaW5kb3cp CisgICAgICAgIGNyZWF0ZUhVRFdpbmRvdygpOworICAgIGVsc2UgaWYgKGZvcmVncm91bmRXaW5k b3cgIT0gbV9odWRXaW5kb3cpCisgICAgICAgIGRlc3Ryb3lIVURXaW5kb3coKTsKKwogICAgIEhE QyB3aW5kb3dEQyA9IEdldERDKG1faHVkV2luZG93KTsKICAgICBIREMgYml0bWFwREMgPSBDcmVh dGVDb21wYXRpYmxlREMod2luZG93REMpOwogICAgIDo6UmVsZWFzZURDKG1faHVkV2luZG93LCB3 aW5kb3dEQyk7CkluZGV4OiBXZWJLaXQvd2luL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvd2luL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuaAkocmV2 aXNpb24gNTU4NDkpCisrKyBXZWJLaXQvd2luL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuaAko d29ya2luZyBjb3B5KQpAQCAtMTM2LDYgKzEzNiw3IEBAIHByaXZhdGU6CiAgICAgc3RhdGljIHZv aWQgcmVnaXN0ZXJIVURXaW5kb3dDbGFzcygpOwogICAgIHN0YXRpYyBMUkVTVUxUIENBTExCQUNL IGh1ZFduZFByb2MoSFdORCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0sIExQQVJBTSk7CiAgICAgdm9p ZCBjcmVhdGVIVURXaW5kb3coKTsKKyAgICB2b2lkIGRlc3Ryb3lIVURXaW5kb3coKTsKICAgICB2 b2lkIHRpbWVyRmlyZWQoV2ViQ29yZTo6VGltZXI8RnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcj4q KTsKIAogICAgIHZvaWQgdG9nZ2xlUGxheSgpOwo= 50631 2010-03-12 14:09:19 -0800 2010-03-12 14:10:53 -0800 New patch forReview2.txt text/plain 2337 bdakin SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTkzNSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDMtMTIgIEJldGggRGFraW4gIDxiZGFraW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNzM5 IEZ1bGxzY3JlZW4gCisgICAgICAgIHZpZGVvIEhVRCBzdGF5cyBvbiB0b3Agd2hlbiBzd2l0Y2hp bmcgdG8gYW5vdGhlciB3aW5kb3cgKGUuZy4gdmlhIAorICAgICAgICBBbHQtVGFiKQorICAgICAg ICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTQ3NTc0Pgor CisgICAgICAgIFRoZSBIVUQgd2FzIGFsd2F5cyBvbiB0b3AgYmVjYXVzZSBpdCBoYWQgdGhlIFdT X0VYX1RPUE1PU1Qgc3R5bGUuIAorICAgICAgICBTbyBJIHJlbW92ZWQgdGhlIHN0eWxlIGFuZCBt YWRlIG1fdmlkZW9XaW5kb3cgdGhlIG93bmVyIG9mIAorICAgICAgICBtX2h1ZFdpbmRvdy4gVGhp cyBrZWVwcyBtX2h1ZFdpbmRvdyBvbiB0b3Agb25seSB3aGVuIG1fdmlkZW9XaW5kb3cgCisgICAg ICAgIGlzIHRoZSBmb2N1c2VkIHdpbmRvdy4KKworICAgICAgICAqIEZ1bGxzY3JlZW5WaWRlb0Nv bnRyb2xsZXIuY3BwOgorICAgICAgICAoRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcjo6ZXhpdEZ1 bGxzY3JlZW4pOiBBU1NFUlQgdGhhdCBtb3ZpZSgpLT5leGl0RnVsbHNjcmVlbigpIGFsc28gZGVz dHJveWVkIHRoZSBodWQuCisgICAgICAgIChGdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyOjpjcmVh dGVIVURXaW5kb3cpOgorCiAyMDEwLTAzLTExICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEtpbGwgV2ViRG9jdW1lbnQ6OmFwcGxpY2F0aW9uSUQoKSAocGFydCAx KS4KSW5kZXg6IFdlYktpdC93aW4vRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L3dpbi9GdWxsc2NyZWVuVmlkZW9Db250cm9sbGVyLmNwcAkocmV2aXNp b24gNTU5MjgpCisrKyBXZWJLaXQvd2luL0Z1bGxzY3JlZW5WaWRlb0NvbnRyb2xsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMjYsMTIgKzIyNiwxMiBAQCB2b2lkIEZ1bGxzY3JlZW5WaWRlb0Nv bnRyb2xsZXI6OmVudGVyRnVsCiAKIHZvaWQgRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcjo6ZXhp dEZ1bGxzY3JlZW4oKQogeworICAgIFNldFdpbmRvd0xvbmdQdHIobV9odWRXaW5kb3csIDAsIDAp OwogICAgIGlmIChtb3ZpZSgpKQogICAgICAgICBtb3ZpZSgpLT5leGl0RnVsbHNjcmVlbigpOwog CisgICAgQVNTRVJUKCFJc1dpbmRvdyhtX2h1ZFdpbmRvdykpOwogICAgIG1fdmlkZW9XaW5kb3cg PSAwOwotICAgIFNldFdpbmRvd0xvbmdQdHIobV9odWRXaW5kb3csIDAsIDApOwotICAgIERlc3Ry b3lXaW5kb3cobV9odWRXaW5kb3cpOwogICAgIG1faHVkV2luZG93ID0gMDsKIH0KIApAQCAtMzY4 LDkgKzM2OCw5IEBAIHZvaWQgRnVsbHNjcmVlblZpZGVvQ29udHJvbGxlcjo6Y3JlYXRlSFUKIAog ICAgIHJlZ2lzdGVySFVEV2luZG93Q2xhc3MoKTsKIAotICAgIG1faHVkV2luZG93ID0gQ3JlYXRl V2luZG93RXgoV1NfRVhfTEFZRVJFRCB8IFdTX0VYX1RSQU5TUEFSRU5UIHwgV1NfRVhfVE9QTU9T VCB8IFdTX0VYX1RPT0xXSU5ET1csIAorICAgIG1faHVkV2luZG93ID0gQ3JlYXRlV2luZG93RXgo V1NfRVhfTEFZRVJFRCB8IFdTX0VYX1RSQU5TUEFSRU5UIHwgV1NfRVhfVE9PTFdJTkRPVywgCiAg ICAgICAgIGZ1bGxzY3JlZW5WaWRlZW9IVURXaW5kb3dDbGFzc05hbWUsIDAsIFdTX1BPUFVQIHwg V1NfVklTSUJMRSwKLSAgICAgICAgbV9odWRQb3NpdGlvbi54KCksIG1faHVkUG9zaXRpb24ueSgp LCAwLCAwLCAwLCAwLCBnSW5zdGFuY2UsIDApOworICAgICAgICBtX2h1ZFBvc2l0aW9uLngoKSwg bV9odWRQb3NpdGlvbi55KCksIDAsIDAsIG1fdmlkZW9XaW5kb3csIDAsIGdJbnN0YW5jZSwgMCk7 CiAgICAgQVNTRVJUKDo6SXNXaW5kb3cobV9odWRXaW5kb3cpKTsKICAgICBTZXRXaW5kb3dMb25n UHRyKG1faHVkV2luZG93LCAwLCByZWludGVycHJldF9jYXN0PExPTkdfUFRSPih0aGlzKSk7CiAK