33728 2010-01-15 11:48:47 -0800 svg/custom/marker-changes.svg is flaky 2010-01-15 12:20:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned oldest_to_newest 181293 0 ojan 2010-01-15 11:48:47 -0800 svg/custom/marker-changes.svg is flaky 181294 1 46694 ojan 2010-01-15 11:49:47 -0800 Created attachment 46694 Patch 181296 2 46694 eric 2010-01-15 11:55:12 -0800 Comment on attachment 46694 Patch But your'e not removing the setTimeout? You're just moving it... no? I'm confused why this test needs one at all. 181298 3 46695 ojan 2010-01-15 12:03:37 -0800 Created attachment 46695 Patch 181301 4 ojan 2010-01-15 12:04:32 -0800 (In reply to comment #2) > (From update of attachment 46694 [details]) > But your'e not removing the setTimeout? You're just moving it... no? I'm > confused why this test needs one at all. Duh. I was just focused on the race. Removed the setTimeout for real this time and no longer needing to waitUntilDone. 181303 5 46695 eric 2010-01-15 12:06:30 -0800 Comment on attachment 46695 Patch Assuming it still passes, LGTM. 181309 6 ojan 2010-01-15 12:20:23 -0800 Committed r53337: <http://trac.webkit.org/changeset/53337> 46694 2010-01-15 11:49:47 -0800 2010-01-15 12:03:33 -0800 Patch bug-33728-20100115114945.patch text/plain 2058 ojan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzOWYwMTRlLi43Nzk2ZWQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTAtMDEt MTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2 ZyBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzM3MjgKKworICAgICAgICByZW1vdmluZyBncmF0dWl0b3VzIHNldFRpbWVvdXQuCisKKyAg ICAgICAgKiBzdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2ZzoKKworMjAxMC0wMS0xNSAgT2ph biBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCiAKICAgICAgICAgdHJhbnNpdGlvbnMvc2hvcnRoYW5kLWJvcmRlci10cmFuc2l0aW9u cy5odG1sIGlzIHN0aWxsIGZsYWt5IG9uIHNsb3dlciBib3RzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0 b20vbWFya2VyLWNoYW5nZXMuc3ZnCmluZGV4IDcxYzU1YzQuLmM0MDI2ZTYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N2Zy9jdXN0b20vbWFya2VyLWNoYW5nZXMuc3ZnCisrKyBiL0xheW91dFRl c3RzL3N2Zy9jdXN0b20vbWFya2VyLWNoYW5nZXMuc3ZnCkBAIC0xMSwxMyArMTEsMjIgQEAKICAg ICA8L21hcmtlcj4KIDwvZGVmcz4KIAorCis8ZyBvbmNsaWNrPSJtb3VzZUhhbmRsZXIoKSI+Cisg ICAgPHBhdGggZmlsbD0ibm9uZSIgc3Ryb2tlPSJibGFjayIgc3Ryb2tlLXdpZHRoPSI4IiBtYXJr ZXItc3RhcnQ9InVybCgjbWFya2VyU3RhcnQpIiBtYXJrZXItbWlkPSJ1cmwoI21hcmtlck1pZGRs ZSkiIG1hcmtlci1lbmQ9InVybCgjbWFya2VyRW5kKSIgZD0iTSAxMzAgMTM1IEwgMTgwIDEzNSBM IDE4MCAxODUiLz4KKzwvZz4KKwogPHNjcmlwdD4KIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogCi13aW5k b3cuc2V0VGltZW91dCgiY2xpY2tOb3coKSIsIDApOworZnVuY3Rpb24gbW91c2VIYW5kbGVyKGV2 dCkKK3sKKyAgICB2YXIgbWFya2VyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1hcmtlclN0 YXJ0Iik7CisgICAgbWFya2VyLnNldEF0dHJpYnV0ZSgibWFya2VyV2lkdGgiLCAiMiIpOworfQog Ci1mdW5jdGlvbiBjbGlja05vdygpIHsKK3dpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewog ICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VN b3ZlVG8oMTUwLCAxMzUpOwogICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKQEAgLTI3 LDE2ICszNiw3IEBAIGZ1bmN0aW9uIGNsaWNrTm93KCkgewogICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOwogICAgIH0KLX0KLQotZnVuY3Rpb24gbW91c2VIYW5kbGVyKGV2dCkKLXsKLSAgICB2YXIg bWFya2VyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1hcmtlclN0YXJ0Iik7Ci0gICAgbWFy a2VyLnNldEF0dHJpYnV0ZSgibWFya2VyV2lkdGgiLCAiMiIpOwotfQorfSwgMCk7CiA8L3Njcmlw dD4KIAotPGcgb25jbGljaz0ibW91c2VIYW5kbGVyKCkiPgotICAgIDxwYXRoIGZpbGw9Im5vbmUi IHN0cm9rZT0iYmxhY2siIHN0cm9rZS13aWR0aD0iOCIgbWFya2VyLXN0YXJ0PSJ1cmwoI21hcmtl clN0YXJ0KSIgbWFya2VyLW1pZD0idXJsKCNtYXJrZXJNaWRkbGUpIiBtYXJrZXItZW5kPSJ1cmwo I21hcmtlckVuZCkiIGQ9Ik0gMTMwIDEzNSBMIDE4MCAxMzUgTCAxODAgMTg1Ii8+Ci08L2c+CiA8 L3N2Zz4K 46695 2010-01-15 12:03:37 -0800 2010-01-15 12:06:29 -0800 Patch bug-33728-20100115120336.patch text/plain 2016 ojan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzOWYwMTRlLi43Nzk2ZWQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTAtMDEt MTUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2 ZyBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzM3MjgKKworICAgICAgICByZW1vdmluZyBncmF0dWl0b3VzIHNldFRpbWVvdXQuCisKKyAg ICAgICAgKiBzdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2ZzoKKworMjAxMC0wMS0xNSAgT2ph biBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCiAKICAgICAgICAgdHJhbnNpdGlvbnMvc2hvcnRoYW5kLWJvcmRlci10cmFuc2l0aW9u cy5odG1sIGlzIHN0aWxsIGZsYWt5IG9uIHNsb3dlciBib3RzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL21hcmtlci1jaGFuZ2VzLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0 b20vbWFya2VyLWNoYW5nZXMuc3ZnCmluZGV4IDcxYzU1YzQuLjcyYzc4Y2IgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N2Zy9jdXN0b20vbWFya2VyLWNoYW5nZXMuc3ZnCisrKyBiL0xheW91dFRl c3RzL3N2Zy9jdXN0b20vbWFya2VyLWNoYW5nZXMuc3ZnCkBAIC0xMSwzMiArMTEsMjMgQEAKICAg ICA8L21hcmtlcj4KIDwvZGVmcz4KIAotPHNjcmlwdD4KLWlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCi0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwotCi13 aW5kb3cuc2V0VGltZW91dCgiY2xpY2tOb3coKSIsIDApOwogCi1mdW5jdGlvbiBjbGlja05vdygp IHsKLSAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7Ci0gICAgICAgIGV2ZW50U2VuZGVyLm1v dXNlTW92ZVRvKDE1MCwgMTM1KTsKLSAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7Ci0g ICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKLSAgICB9Ci0KLSAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7Ci0gICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlm eURvbmUoKTsKLSAgICB9Ci19Cis8ZyBvbmNsaWNrPSJtb3VzZUhhbmRsZXIoKSI+CisgICAgPHBh dGggZmlsbD0ibm9uZSIgc3Ryb2tlPSJibGFjayIgc3Ryb2tlLXdpZHRoPSI4IiBtYXJrZXItc3Rh cnQ9InVybCgjbWFya2VyU3RhcnQpIiBtYXJrZXItbWlkPSJ1cmwoI21hcmtlck1pZGRsZSkiIG1h cmtlci1lbmQ9InVybCgjbWFya2VyRW5kKSIgZD0iTSAxMzAgMTM1IEwgMTgwIDEzNSBMIDE4MCAx ODUiLz4KKzwvZz4KIAorPHNjcmlwdD4KIGZ1bmN0aW9uIG1vdXNlSGFuZGxlcihldnQpCiB7CiAg ICAgdmFyIG1hcmtlciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJtYXJrZXJTdGFydCIpOwog ICAgIG1hcmtlci5zZXRBdHRyaWJ1dGUoIm1hcmtlcldpZHRoIiwgIjIiKTsKIH0KKworaWYgKHdp bmRvdy5ldmVudFNlbmRlcikgeworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDE1MCwgMTM1 KTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVw KCk7Cit9CiA8L3NjcmlwdD4KIAotPGcgb25jbGljaz0ibW91c2VIYW5kbGVyKCkiPgotICAgIDxw YXRoIGZpbGw9Im5vbmUiIHN0cm9rZT0iYmxhY2siIHN0cm9rZS13aWR0aD0iOCIgbWFya2VyLXN0 YXJ0PSJ1cmwoI21hcmtlclN0YXJ0KSIgbWFya2VyLW1pZD0idXJsKCNtYXJrZXJNaWRkbGUpIiBt YXJrZXItZW5kPSJ1cmwoI21hcmtlckVuZCkiIGQ9Ik0gMTMwIDEzNSBMIDE4MCAxMzUgTCAxODAg MTg1Ii8+Ci08L2c+CiA8L3N2Zz4K