33724 2010-01-15 10:54:02 -0800 check-webkit-style: Misses variables that contain underscores. 2010-02-17 18:13:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates webkit-unassigned abarth eric hamaji oldest_to_newest 181276 0 dbates 2010-01-15 10:54:02 -0800 Notice, the file WebCore/rendering/style/SVGRenderStyle.h <http://trac.webkit.org/browser/trunk/WebCore/rendering/style/SVGRenderStyle.h?rev=53300> contains various structs who field names contain an underscore. Run check-webkit-style on file WebCore/rendering/style/SVGRenderStyle.h. It catches NonInheritedFlags::_niflags and outputs the following error: WebCore/rendering/style/SVGRenderStyle.h:167: _niflags is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] But misses all the fields in InheritedFlags and the fields within the struct of the union in NonInheritedFlags. For example: <http://trac.webkit.org/browser/trunk/WebCore/rendering/style/SVGRenderStyle.h?rev=53300#L139> And <http://trac.webkit.org/browser/trunk/WebCore/rendering/style/SVGRenderStyle.h?rev=53300#L162> 190656 1 48801 hamaji 2010-02-16 03:23:15 -0800 Created attachment 48801 Patch v1 190657 2 hamaji 2010-02-16 03:36:13 -0800 There were two bugs: - "unsigned _length" wasn't complained. - a bitfield wasn't complained. This patch fixes both. I've ran check-webkit-style for 2180 C++ files in WebKit repository. This change increases the number of error reports by 14. There were no false-positives. 191253 3 48801 eric 2010-02-17 15:25:31 -0800 Comment on attachment 48801 Patch v1 wooo hoo! 191338 4 48801 hamaji 2010-02-17 18:13:16 -0800 Comment on attachment 48801 Patch v1 Clearing flags on attachment: 48801 Committed r54918: <http://trac.webkit.org/changeset/54918> 191339 5 hamaji 2010-02-17 18:13:24 -0800 All reviewed patches have been landed. Closing bug. 48801 2010-02-16 03:23:15 -0800 2010-02-17 18:13:16 -0800 Patch v1 bug-33724-20100216032313.patch text/plain 4255 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MzE2N2JjLi5jZjA2OWViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDIt MTYgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6 IE1pc3NlcyB2YXJpYWJsZXMgdGhhdCBjb250YWluIHVuZGVyc2NvcmVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3MjQKKworICAgICAgICAtIENo ZWNrIGlkZW50aWZpZXJzIHdob3NlIHR5cGVzIGFyZSB1bnNpZ25lZC4KKyAgICAgICAgLSBDaGVj ayBiaXRmaWVsZHMgcHJvcGVybHkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L3Byb2Nlc3NvcnMvY3BwLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJv Y2Vzc29ycy9jcHBfdW5pdHRlc3QucHk6CisKIDIwMTAtMDItMTUgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNz b3JzL2NwcC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29y cy9jcHAucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCBiOTRhOTFiLi5m ODNhZTZhCi0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29y cy9jcHAucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNz b3JzL2NwcC5weQpAQCAtMjQyNSw3ICsyNDI1LDkgQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJfbmFt ZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFtZSwgbGluZV9udW1iZXIsIGxpbmUsIGVycm9yKToKICAg ICAjIENvbnZlcnQgImxvbmcgbG9uZyIsICJsb25nIGRvdWJsZSIsIGFuZCAibG9uZyBsb25nIGlu dCIgdG8KICAgICAjIHNpbXBsZSB0eXBlcywgYnV0IGRvbid0IHJlbW92ZSBzaW1wbGUgImxvbmci LgogICAgIGxpbmUgPSBzdWIocidsb25nIChsb25nICk/KD89bG9uZ3xkb3VibGV8aW50KScsICcn LCBsaW5lKQotICAgIGxpbmUgPSBzdWIocidcYih1bnNpZ25lZHxzaWduZWR8aW5saW5lfHVzaW5n fHN0YXRpY3xjb25zdHx2b2xhdGlsZXxhdXRvfHJlZ2lzdGVyfGV4dGVybnx0eXBlZGVmfHJlc3Ry aWN0fHN0cnVjdHxjbGFzc3x2aXJ0dWFsKSg/PVxXKScsICcnLCBsaW5lKQorICAgICMgQ29udmVy dCB1bnNpZ25lZC9zaWduZWQgdHlwZXMgdG8gc2ltcGxlIHR5cGVzLCB0b28uCisgICAgbGluZSA9 IHN1YihyJyh1bnNpZ25lZHxzaWduZWQpICg/PWNoYXJ8c2hvcnR8aW50fGxvbmcpJywgJycsIGxp bmUpCisgICAgbGluZSA9IHN1YihyJ1xiKGlubGluZXx1c2luZ3xzdGF0aWN8Y29uc3R8dm9sYXRp bGV8YXV0b3xyZWdpc3RlcnxleHRlcm58dHlwZWRlZnxyZXN0cmljdHxzdHJ1Y3R8Y2xhc3N8dmly dHVhbCkoPz1cVyknLCAnJywgbGluZSkKIAogICAgICMgUmVtb3ZlIGFsbCB0ZW1wbGF0ZSBwYXJh bWV0ZXJzIGJ5IHJlbW92aW5nIG1hdGNoaW5nIDwgYW5kID4uCiAgICAgIyBMb29wIHVudGlsIG5v IHRlbXBsYXRlcyBhcmUgcmVtb3ZlZCB0byByZW1vdmUgbmVzdGVkIHRlbXBsYXRlcy4KQEAgLTI0 NTMsOCArMjQ1NSw5IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24o ZmlsZW5hbWUsIGxpbmVfbnVtYmVyLCBsaW5lLCBlcnJvcik6CiAgICAgIyBEZXRlY3QgdmFyaWFi bGUgYW5kIGZ1bmN0aW9ucy4KICAgICB0eXBlX3JlZ2V4cCA9IHInXHcoW1x3XXxccypbKiZdXHMq fDo6KSsnCiAgICAgaWRlbnRpZmllcl9yZWdleHAgPSByJyg/UDxpZGVudGlmaWVyPltcdzpdKykn CisgICAgbWF5YmVfYml0ZmllbGRfcmVnZXhwID0gcicoOlxzKlxkK1xzKik/JwogICAgIGNoYXJh Y3Rlcl9hZnRlcl9pZGVudGlmaWVyX3JlZ2V4cCA9IHInKD9QPGNoYXJhY3Rlcl9hZnRlcl9pZGVu dGlmaWVyPltbOygpPSxdKSg/IT0pJwotICAgIGRlY2xhcmF0aW9uX3dpdGhvdXRfdHlwZV9yZWdl eHAgPSByJ1xzKicgKyBpZGVudGlmaWVyX3JlZ2V4cCArIHInXHMqJyArIGNoYXJhY3Rlcl9hZnRl cl9pZGVudGlmaWVyX3JlZ2V4cAorICAgIGRlY2xhcmF0aW9uX3dpdGhvdXRfdHlwZV9yZWdleHAg PSByJ1xzKicgKyBpZGVudGlmaWVyX3JlZ2V4cCArIHInXHMqJyArIG1heWJlX2JpdGZpZWxkX3Jl Z2V4cCArIGNoYXJhY3Rlcl9hZnRlcl9pZGVudGlmaWVyX3JlZ2V4cAogICAgIGRlY2xhcmF0aW9u X3dpdGhfdHlwZV9yZWdleHAgPSByJ1xzKicgKyB0eXBlX3JlZ2V4cCArIHInXHMnICsgZGVjbGFy YXRpb25fd2l0aG91dF90eXBlX3JlZ2V4cAogICAgIGlzX2Z1bmN0aW9uX2FyZ3VtZW50cyA9IEZh bHNlCiAgICAgbnVtYmVyX29mX2lkZW50aWZpZXJzID0gMApAQCAtMjk4Niw0ICsyOTg5LDMgQEAg Y2xhc3MgQ3BwUHJvY2Vzc29yKG9iamVjdCk6CiBkZWYgcHJvY2Vzc19maWxlX2RhdGEoZmlsZW5h bWUsIGZpbGVfZXh0ZW5zaW9uLCBsaW5lcywgZXJyb3IsIHZlcmJvc2l0eSk6CiAgICAgcHJvY2Vz c29yID0gQ3BwUHJvY2Vzc29yKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IsIHZlcmJv c2l0eSkKICAgICBwcm9jZXNzb3IucHJvY2VzcyhsaW5lcykKLQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9wcm9jZXNzb3JzL2NwcF91bml0dGVzdC5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9jcHBfdW5pdHRl c3QucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1NQppbmRleCAyYmViM2UxLi5jNzg2 YjhlCi0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvcHJvY2Vzc29ycy9j cHBfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9w cm9jZXNzb3JzL2NwcF91bml0dGVzdC5weQpAQCAtMzUxNiw2ICszNTE2LDEyIEBAIGNsYXNzIFdl YktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAg ICAnX2xlbmd0aCcgKyBuYW1lX2Vycm9yX21lc3NhZ2UpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xp bnQoJ3Nob3J0IGxlbmd0aF87JywKICAgICAgICAgICAgICAgICAgICAgICAgICAnbGVuZ3RoXycg KyBuYW1lX2Vycm9yX21lc3NhZ2UpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3Vuc2lnbmVk IF9sZW5ndGg7JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAnX2xlbmd0aCcgKyBuYW1lX2Vy cm9yX21lc3NhZ2UpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3Vuc2lnbmVkIGludCBfbGVu Z3RoOycsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ19sZW5ndGgnICsgbmFtZV9lcnJvcl9t ZXNzYWdlKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd1bnNpZ25lZCBsb25nIGxvbmcgX2xl bmd0aDsnLAorICAgICAgICAgICAgICAgICAgICAgICAgICdfbGVuZ3RoJyArIG5hbWVfZXJyb3Jf bWVzc2FnZSkKIAogICAgICAgICAjIFBvaW50ZXJzLCByZWZlcmVuY2VzLCBmdW5jdGlvbnMsIHRl bXBsYXRlcywgYW5kIGFkamVjdGl2ZXMuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2NoYXIq IHVuZGVyX3Njb3JlOycsCkBAIC0zNjEyLDYgKzM2MTgsMTAgQEAgY2xhc3MgV2ViS2l0U3R5bGVU ZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAjIGNvbnN0X2l0ZXJhdG9yIGlzIGFsbG93 ZWQgYXMgd2VsbC4KICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndHlwZWRlZiBWZWN0b3JUeXBl Ojpjb25zdF9pdGVyYXRvciBjb25zdF9pdGVyYXRvcjsnLCAnJykKIAorICAgICAgICAjIEJpdGZp ZWxkcy4KKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndW5zaWduZWQgX2ZpbGxSdWxlIDogMTsn LAorICAgICAgICAgICAgICAgICAgICAgICAgICdfZmlsbFJ1bGUnICsgbmFtZV9lcnJvcl9tZXNz YWdlKQorCiAKICAgICBkZWYgdGVzdF9jb21tZW50cyhzZWxmKToKICAgICAgICAgIyBBIGNvbW1l bnQgYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxpbmUgaXMgb2suCg==