33715 2010-01-15 05:39:30 -0800 [Qt] Add setSpatialNavigationEnabled method to DRT 2010-03-05 08:35:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 18662 33714 1 tonikitoo tonikitoo eric hausmann jchaffraix kenneth webkit.review.bot oldest_to_newest 181214 0 tonikitoo 2010-01-15 05:39:30 -0800 DRT needs a way to toggle "Spatial Navigation" on and off. This bug is about implementing it to Qt's DRT. SNav itself is being implemented in bug 18662. 181215 1 46675 tonikitoo 2010-01-15 05:42:39 -0800 Created attachment 46675 (landed in r55580) patch 0.1 181216 2 webkit.review.bot 2010-01-15 05:47:49 -0800 Attachment 46675 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/174029 181218 3 tonikitoo 2010-01-15 05:51:33 -0800 (In reply to comment #2) > Attachment 46675 [details] did not build on qt: > Build output: http://webkit-commit-queue.appspot.com/results/174029 I will ignore the build error for now, because this patch depends on patch in but 33714, that on its turn depends on a patch in bug 18662. dep chain is deep and bot build error here is expected :) 181496 4 46675 hausmann 2010-01-16 00:59:40 -0800 Comment on attachment 46675 (landed in r55580) patch 0.1 r=me 187143 5 eric 2010-02-02 14:17:44 -0800 Ping? This was r+'d two weeks ago. 187215 6 tonikitoo 2010-02-02 17:22:30 -0800 (In reply to comment #5) > Ping? This was r+'d two weeks ago. as if https://bugs.webkit.org/show_bug.cgi?id=33714#c11 , this patch can not land before bug 18662 ... which i believe is in a good shape (or close to it) 188983 7 46675 tonikitoo 2010-02-09 06:45:36 -0800 Comment on attachment 46675 (landed in r55580) patch 0.1 Clearing r+/cq- since this patch depends on another bug to be landed first. 196449 8 tonikitoo 2010-03-05 08:35:51 -0800 landed in r55580 46675 2010-01-15 05:42:39 -0800 2010-03-05 08:37:07 -0800 (landed in r55580) patch 0.1 0001--Qt-Add-setSpatialNavigationEnabled-method-DRT.patch text/plain 4613 tonikitoo RnJvbSA3ZTkyODk5MDEyZjRmMDRmZGQ3NmZkNDU5YzAzNmI1YTk3ZWEyNWZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAxNCBKYW4gMjAxMCAxMjozMzoxNSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR dF0gQWRkIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCBtZXRob2QgRFJUCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3MTUKClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQGdtYWlsLmNvbT4KCkFk ZGVkIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCBzdXBwb3J0IHRvIFF0IERSVC4KCiogRHVt cFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHA6CihXZWJDb3JlOjpXZWJQYWdlOjpX ZWJQYWdlKToKKFdlYkNvcmU6OldlYlBhZ2U6OnJlc2V0U2V0dGluZ3MpOgoqIER1bXBSZW5kZXJU cmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwOgooTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCk6CiogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0 VGVzdENvbnRyb2xsZXJRdC5oOgotLS0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAgfCAgICAyICsrCiAuLi4vRHVtcFJl bmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAgICB8ICAgIDUgKysrKysKIC4u Li9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmggICAgIHwgICAgMSAr CiA0IGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGNlODEyMzkuLjA4MmY2Y2IgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZwor KysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMS0xNCAg QW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQWRkIHNldFNwYXRpYWxOYXZpZ2F0 aW9uRW5hYmxlZCBtZXRob2QgRFJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMzcxNQorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJQYWdlOjpXZWJQYWdlKToKKyAg ICAgICAgKFdlYkNvcmU6OldlYlBhZ2U6OnJlc2V0U2V0dGluZ3MpOgorICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoTGF5b3V0 VGVzdENvbnRyb2xsZXI6OnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCk6CisgICAgICAgICog RHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oOgorCiAyMDEwLTAxLTE0 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB ZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVt cFJlbmRlclRyZWVRdC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVu ZGVyVHJlZVF0LmNwcAppbmRleCA1MjkzOWU0Li41NzU5YjUyIDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcAorKysgYi9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcApAQCAtMTMyLDYgKzEz Miw3IEBAIFdlYlBhZ2U6OldlYlBhZ2UoUU9iamVjdCogcGFyZW50LCBEdW1wUmVuZGVyVHJlZSog ZHJ0KQogICAgIGdsb2JhbFNldHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpMb2Nh bENvbnRlbnRDYW5BY2Nlc3NSZW1vdGVVcmxzLCB0cnVlKTsKICAgICBnbG9iYWxTZXR0aW5ncy0+ c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdEVuYWJsZWQsIHRydWUpOwogICAg IGdsb2JhbFNldHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpQcml2YXRlQnJvd3Np bmdFbmFibGVkLCBmYWxzZSk7CisgICAgZ2xvYmFsU2V0dGluZ3MtPnNldEF0dHJpYnV0ZShRV2Vi U2V0dGluZ3M6OlNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCwgZmFsc2UpOwogICAgIGdsb2JhbFNl dHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpPZmZsaW5lV2ViQXBwbGljYXRpb25D YWNoZUVuYWJsZWQsIGZhbHNlKTsKIAogICAgIGNvbm5lY3QodGhpcywgU0lHTkFMKGdlb21ldHJ5 Q2hhbmdlUmVxdWVzdGVkKGNvbnN0IFFSZWN0ICYpKSwKQEAgLTE2Myw2ICsxNjQsNyBAQCB2b2lk IFdlYlBhZ2U6OnJlc2V0U2V0dGluZ3MoKQogICAgIHNldHRpbmdzKCktPnJlc2V0QXR0cmlidXRl KFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzKTsKICAgICBzZXR0aW5ncygp LT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OkphdmFzY3JpcHRFbmFibGVkKTsKICAgICBz ZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OlByaXZhdGVCcm93c2luZ0Vu YWJsZWQpOworICAgIHNldHRpbmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6U3Bh dGlhbE5hdmlnYXRpb25FbmFibGVkKTsKICAgICBzZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShR V2ViU2V0dGluZ3M6OkxpbmtzSW5jbHVkZWRJbkZvY3VzQ2hhaW4pOwogICAgIHNldHRpbmdzKCkt PnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVF bmFibGVkKTsKICAgICBzZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6Okxv Y2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVybHMpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAgYi9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAppbmRleCBjMmUw OTdiLi45MWFkNmE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9M YXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcApAQCAtMjc3LDYgKzI3NywxMSBAQCB2b2lk IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wgZW5h YmxlKQogICAgIG1fZHJ0LT53ZWJQYWdlKCktPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2Vi U2V0dGluZ3M6OlByaXZhdGVCcm93c2luZ0VuYWJsZWQsIGVuYWJsZSk7CiB9CiAKK3ZvaWQgTGF5 b3V0VGVzdENvbnRyb2xsZXI6OnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChib29sIGVuYWJs ZSkKK3sKKyAgICBtX2RydC0+d2ViUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdl YlNldHRpbmdzOjpTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQsIGVuYWJsZSk7Cit9CisKIHZvaWQg TGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFBvcHVwQmxvY2tpbmdFbmFibGVkKGJvb2wgZW5hYmxl KQogewogICAgIG1fZHJ0LT53ZWJQYWdlKCktPnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2Vi U2V0dGluZ3M6OkphdmFzY3JpcHRDYW5PcGVuV2luZG93cywgIWVuYWJsZSk7CmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0Lmgg Yi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgK aW5kZXggY2ZmODQ3NC4uNTJhNWQxZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBS ZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaApAQCAtMTEwLDYgKzExMCw3IEBA IHB1YmxpYyBzbG90czoKICAgICB2b2lkIHNldEphdmFTY3JpcHRQcm9maWxpbmdFbmFibGVkKGJv b2wgZW5hYmxlKTsKICAgICB2b2lkIHNldEZpeGVkQ29udGVudHNTaXplKGludCB3aWR0aCwgaW50 IGhlaWdodCk7CiAgICAgdm9pZCBzZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKGJvb2wgZW5hYmxl KTsKKyAgICB2b2lkIHNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZChib29sIGVuYWJsZWQpOwog ICAgIHZvaWQgc2V0UG9wdXBCbG9ja2luZ0VuYWJsZWQoYm9vbCBlbmFibGUpOwogICAgIHZvaWQg c2V0UE9TSVhMb2NhbGUoY29uc3QgUVN0cmluZyYgbG9jYWxlKTsKICAgICB2b2lkIHJlc2V0TG9h ZEZpbmlzaGVkKCkgeyBtX2xvYWRGaW5pc2hlZCA9IGZhbHNlOyB9Ci0tIAoxLjYuMC40Cgo=