<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33714</bug_id>
          
          <creation_ts>2010-01-15 05:29:05 -0800</creation_ts>
          <short_desc>[Qt] QWebSettings attribute for toggle Spatial Navigation on/off</short_desc>
          <delta_ts>2010-03-05 08:35:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>18662</dependson>
          <blocked>31552</blocked>
    
    <blocked>33715</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Antonio Gomes">tonikitoo</reporter>
          <assigned_to name="Antonio Gomes">tonikitoo</assigned_to>
          <cc>eric</cc>
    
    <cc>hausmann</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>kenneth</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>181209</commentid>
    <comment_count>0</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-15 05:29:05 -0800</bug_when>
    <thetext>This bug is about adding to QWebSettings support to toggle &quot;Spatial Navigation&quot; (SNav) on and off.

SNav itself is being implemented in bug 18662.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181211</commentid>
    <comment_count>1</comment_count>
      <attachid>46674</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-15 05:33:08 -0800</bug_when>
    <thetext>Created attachment 46674
patch 0.1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181212</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-15 05:35:30 -0800</bug_when>
    <thetext>Attachment 46674 did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/190174</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181213</commentid>
    <comment_count>3</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-15 05:38:26 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Attachment 46674 [details] did not build on qt:
&gt; Build output: http://webkit-commit-queue.appspot.com/results/190174

I will ignore the build error for now, because this patch depends on patch in bug 18662.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181315</commentid>
    <comment_count>4</comment_count>
      <attachid>46698</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-15 12:28:40 -0800</bug_when>
    <thetext>Created attachment 46698
patch 0.2

better docs</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181318</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-01-15 12:31:49 -0800</bug_when>
    <thetext>Attachment 46698 did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/190451</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181494</commentid>
    <comment_count>6</comment_count>
      <attachid>46698</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-01-16 00:50:11 -0800</bug_when>
    <thetext>Comment on attachment 46698
patch 0.2

Antonio, I think your patch looks fine, but I would prefer a slightly more elaborate explanation in the docs on what the _effect_ of enabling this feature is, i.e. that it affects the keyboard navigation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181536</commentid>
    <comment_count>7</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-16 11:36:06 -0800</bug_when>
    <thetext>thx for reviewing, simon. I will improve the patch.

(In reply to comment #6)
&gt; (From update of attachment 46698 [details])
&gt; Antonio, I think your patch looks fine, but I would prefer a slightly more
&gt; elaborate explanation in the docs on what the _effect_ of enabling this feature
&gt; is, i.e. that it affects the keyboard navigation.

@simon: something else that came to mind: as is, the patch will enable/disable SNav per-page, i.e. if two windows are opened at the same time, one can be with SNav ON while it is OFF in other. Is that what we want or we want it to be set a globally  ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182103</commentid>
    <comment_count>8</comment_count>
      <attachid>46879</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-01-18 19:35:10 -0800</bug_when>
    <thetext>Created attachment 46879
(committed in r55579) patch 0.3

Added a more detailed explanation about effects on enabling/disabling SNav.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>182175</commentid>
    <comment_count>9</comment_count>
      <attachid>46879</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2010-01-19 01:24:00 -0800</bug_when>
    <thetext>Comment on attachment 46879
(committed in r55579) patch 0.3

Looks good to me. Thanks Antonio for the improved docs :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187144</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-02-02 14:18:07 -0800</bug_when>
    <thetext>Ping?  This was r+&apos;d two weeks ago.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187213</commentid>
    <comment_count>11</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-02-02 17:20:59 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; Ping?  This was r+&apos;d two weeks ago.

eric, this patch can land before its blocker (bug 18662), which pends review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>187216</commentid>
    <comment_count>12</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-02-02 17:23:55 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; Ping?  This was r+&apos;d two weeks ago.
&gt; 
&gt; eric, this patch can land before its blocker (bug 18662), which pends review.

s/can/can not/gc

sorry for spamming it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>188985</commentid>
    <comment_count>13</comment_count>
      <attachid>46879</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-02-09 06:46:13 -0800</bug_when>
    <thetext>Comment on attachment 46879
(committed in r55579) patch 0.3

Clearing r+/cq- since this patch depends on another bug to be landed first.

so it does not appear on pending-commit page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196446</commentid>
    <comment_count>14</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-05 08:32:15 -0800</bug_when>
    <thetext>landed in r55579

thx for reviewing you simon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>196447</commentid>
    <comment_count>15</comment_count>
      <attachid>46879</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-05 08:33:43 -0800</bug_when>
    <thetext>Comment on attachment 46879
(committed in r55579) patch 0.3

clearing flags</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46674</attachid>
            <date>2010-01-15 05:33:08 -0800</date>
            <delta_ts>2010-01-15 12:28:40 -0800</delta_ts>
            <desc>patch 0.1</desc>
            <filename>0001--Qt-QWebSettings-attribute-for-toggle-SNav-Spatial.patch</filename>
            <type>text/plain</type>
            <size>2678</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSBkZWUyZWIzN2ZhNGFiZTQ5N2FjMmQxNDUyMjgzNmMyYWRhNWY1NWQxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVGh1LCAxNCBKYW4gMjAxMCAxMjozNjozNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gUVdlYlNldHRpbmdzIGF0dHJpYnV0ZSBmb3IgdG9nZ2xlIFNOYXYgKFNwYXRpYWwgTmF2aWdh
aW9uKSBvbi9vZmYKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzcx
NCAoUXQgQVBJIHBhcnQpCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClBhdGNoIGJ5IEFu
dG9uaW8gR29tZXMgPHRvbmlraXRvb0BnbWFpbC5jb20+CgpBZGRlZCAnU3BhdGlhbE5hdmlnYXRp
b25FbmFibGVkJyBhdHRyaWJ1dGUgdG8gUVdlYlNldHRpbmdzLgoKKiBBcGkvcXdlYnNldHRpbmdz
LmNwcDoKKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKiBBcGkvcXdlYnNldHRpbmdzLmg6
Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwIHwgICAgNCArKysrCiBXZWJLaXQv
cXQvQXBpL3F3ZWJzZXR0aW5ncy5oICAgfCAgICAzICsrLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAg
ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE5IGluc2Vy
dGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2Vi
c2V0dGluZ3MuY3BwIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCmluZGV4IGQ3ZDM3
NWIuLmI5YjdjNWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAor
KysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKQEAgLTE2OSw2ICsxNjksMTAgQEAg
dm9pZCBRV2ViU2V0dGluZ3NQcml2YXRlOjphcHBseSgpCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OlBy
aXZhdGVCcm93c2luZ0VuYWJsZWQpKTsKICAgICAgICAgc2V0dGluZ3MtPnNldFByaXZhdGVCcm93
c2luZ0VuYWJsZWQodmFsdWUpOwogCisgICAgICAgIHZhbHVlID0gYXR0cmlidXRlcy52YWx1ZShR
V2ViU2V0dGluZ3M6OlNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCwKKyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5n
czo6U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKSk7CisgICAgICAgIHNldHRpbmdzLT5zZXRTcGF0
aWFsTmF2aWdhdGlvbkVuYWJsZWQodmFsdWUpOworCiAgICAgICAgIHZhbHVlID0gYXR0cmlidXRl
cy52YWx1ZShRV2ViU2V0dGluZ3M6OkphdmFzY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQsCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1
ZShRV2ViU2V0dGluZ3M6OkphdmFzY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQpKTsKICAgICAgICAg
c2V0dGluZ3MtPnNldERPTVBhc3RlQWxsb3dlZCh2YWx1ZSk7CmRpZmYgLS1naXQgYS9XZWJLaXQv
cXQvQXBpL3F3ZWJzZXR0aW5ncy5oIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRl
eCAzMmFmNDQ4Li44OWZlMDk4IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5n
cy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgKQEAgLTY4LDcgKzY4LDggQEAg
cHVibGljOgogI2VuZGlmCiAgICAgICAgIExvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVybHMs
CiAgICAgICAgIERuc1ByZWZldGNoRW5hYmxlZCwKLSAgICAgICAgWFNTQXVkaXRvckVuYWJsZWQK
KyAgICAgICAgWFNTQXVkaXRvckVuYWJsZWQsCisgICAgICAgIFNwYXRpYWxOYXZpZ2F0aW9uRW5h
YmxlZAogICAgIH07CiAgICAgZW51bSBXZWJHcmFwaGljIHsKICAgICAgICAgTWlzc2luZ0ltYWdl
R3JhcGhpYywKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh
bmdlTG9nCmluZGV4IDYyZjJiNjQuLjNjYzA3M2QgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu
Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAx
LTE0ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3MgYXR0
cmlidXRlIGZvciB0b2dnbGUgU05hdiAoU3BhdGlhbCBOYXZpZ2Fpb24pIG9uL29mZgorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3MTQgKFF0IEFQSSBw
YXJ0KQorCisgICAgICAgIEFkZGVkICdTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQnIGF0dHJpYnV0
ZSB0byBRV2ViU2V0dGluZ3MuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAg
ICAgICAgKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKiBBcGkvcXdlYnNl
dHRpbmdzLmg6CisKIDIwMTAtMDEtMTQgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBw
bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCi0tIAoxLjYuMC40Cgo=
</data>
<flag name="commit-queue"
          id="28975"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46698</attachid>
            <date>2010-01-15 12:28:40 -0800</date>
            <delta_ts>2010-01-18 19:35:10 -0800</delta_ts>
            <desc>patch 0.2</desc>
            <filename>0001--Qt-QWebSettings-attribute-for-toggle-SNav-Spatial.patch</filename>
            <type>text/plain</type>
            <size>3920</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSA5YWYxYzA1YzRiNzI0ZmRmZDc5ZDVmM2U2NGFiMTgxYTFiNTVmYzQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVGh1LCAxNCBKYW4gMjAxMCAxMjozNjozNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gUVdlYlNldHRpbmdzIGF0dHJpYnV0ZSBmb3IgdG9nZ2xlIFNOYXYgKFNwYXRpYWwgTmF2aWdh
aW9uKSBvbi9vZmYKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzcx
NCAoUXQgQVBJIHBhcnQpCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClBhdGNoIGJ5IEFu
dG9uaW8gR29tZXMgPHRvbmlraXRvb0BnbWFpbC5jb20+CgpBZGRlZCAnU3BhdGlhbE5hdmlnYXRp
b25FbmFibGVkJyBhdHRyaWJ1dGUgdG8gUVdlYlNldHRpbmdzLgoKKiBBcGkvcXdlYnNldHRpbmdz
LmNwcDoKKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKiBBcGkvcXdlYnNldHRpbmdzLmg6
Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwIHwgICAgOCArKysrKysrKwogV2Vi
S2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaCAgIHwgICAgMyArKy0KIFdlYktpdC9xdC9DaGFuZ2VM
b2cgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAyMyBp
bnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkv
cXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCBk
N2QzNzViLi4zNzIwZTA1IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5j
cHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwCkBAIC0xNjksNiArMTY5LDEw
IEBAIHZvaWQgUVdlYlNldHRpbmdzUHJpdmF0ZTo6YXBwbHkoKQogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBnbG9iYWwtPmF0dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdz
OjpQcml2YXRlQnJvd3NpbmdFbmFibGVkKSk7CiAgICAgICAgIHNldHRpbmdzLT5zZXRQcml2YXRl
QnJvd3NpbmdFbmFibGVkKHZhbHVlKTsKIAorICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZXMudmFs
dWUoUVdlYlNldHRpbmdzOjpTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQsCisgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIGdsb2JhbC0+YXR0cmlidXRlcy52YWx1ZShRV2ViU2V0
dGluZ3M6OlNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCkpOworICAgICAgICBzZXR0aW5ncy0+c2V0
U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKHZhbHVlKTsKKwogICAgICAgICB2YWx1ZSA9IGF0dHJp
YnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkLAog
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9iYWwtPmF0dHJpYnV0ZXMu
dmFsdWUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkKSk7CiAgICAg
ICAgIHNldHRpbmdzLT5zZXRET01QYXN0ZUFsbG93ZWQodmFsdWUpOwpAQCAtMzQzLDYgKzM0Nyw5
IEBAIFFXZWJTZXR0aW5ncyogUVdlYlNldHRpbmdzOjpnbG9iYWxTZXR0aW5ncygpCiAgICAgICAg
IEN1cnJlbnRseSB0aGlzIGVuYWJsZXMgdGhlICJJbnNwZWN0IiBlbGVtZW50IGluIHRoZSBjb250
ZXh0IG1lbnUgYXMKICAgICAgICAgd2VsbCBhcyB0aGUgdXNlIG9mIFFXZWJJbnNwZWN0b3Igd2hp
Y2ggY29udHJvbHMgdGhlIFdlYktpdCBXZWJJbnNwZWN0b3IKICAgICAgICAgZm9yIHdlYiBzaXRl
IGRlYnVnZ2luZy4KKyAgICBcdmFsdWUgU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkIEVuYWJsZSBv
ciBkaXNhYmxlcyB0aGUgU3BhdGlhbCBOYXZpZ2F0aW9uIGZlYXR1cmUsIHdoaWNoCisgICAgICAg
IGNvbnNpc3RzIGluIHRoZSBhYmlsaXR5IHRvIG5hdmlnYXRlIGJldHdlZW4gZm9jdXNhYmxlIGVs
ZW1lbnRzLCBzdWNoIGFzIGh5cGVybGlua3MgYW5kCisgICAgICAgIGZvcm0gY29udHJvbHMsIGFj
Y29yZGluZyB0byB0aGUgc3BhdGlhbCBsb2NhdGlvbi4KICAgICBcdmFsdWUgTGlua3NJbmNsdWRl
ZEluRm9jdXNDaGFpbiBTcGVjaWZpZXMgd2hldGhlciBoeXBlcmxpbmtzIHNob3VsZCBiZQogICAg
ICAgICBpbmNsdWRlZCBpbiB0aGUga2V5Ym9hcmQgZm9jdXMgY2hhaW4uCiAgICAgXHZhbHVlIFpv
b21UZXh0T25seSBTcGVjaWZpZXMgd2hldGhlciB0aGUgem9vbSBmYWN0b3Igb24gYSBmcmFtZSBh
cHBsaWVzIHRvCkBAIC0zODIsNiArMzg5LDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3Mo
KQogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6QXV0b0xvYWRJbWFnZXMs
IHRydWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6RG5zUHJlZmV0
Y2hFbmFibGVkLCBmYWxzZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdz
OjpKYXZhc2NyaXB0RW5hYmxlZCwgdHJ1ZSk7CisgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdl
YlNldHRpbmdzOjpTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRy
aWJ1dGVzLmluc2VydChRV2ViU2V0dGluZ3M6OkxpbmtzSW5jbHVkZWRJbkZvY3VzQ2hhaW4sIHRy
dWUpOwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6Wm9vbVRleHRPbmx5
LCBmYWxzZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpQcmludEVs
ZW1lbnRCYWNrZ3JvdW5kcywgdHJ1ZSk7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJz
ZXR0aW5ncy5oIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRleCAzMmFmNDQ4Li44
OWZlMDk4IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCisrKyBiL1dl
YktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmgKQEAgLTY4LDcgKzY4LDggQEAgcHVibGljOgogI2Vu
ZGlmCiAgICAgICAgIExvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVybHMsCiAgICAgICAgIERu
c1ByZWZldGNoRW5hYmxlZCwKLSAgICAgICAgWFNTQXVkaXRvckVuYWJsZWQKKyAgICAgICAgWFNT
QXVkaXRvckVuYWJsZWQsCisgICAgICAgIFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZAogICAgIH07
CiAgICAgZW51bSBXZWJHcmFwaGljIHsKICAgICAgICAgTWlzc2luZ0ltYWdlR3JhcGhpYywKZGlm
ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4
IDYyZjJiNjQuLjNjYzA3M2QgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIv
V2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAxLTE0ICBBbnRvbmlv
IEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3MgYXR0cmlidXRlIGZvciB0
b2dnbGUgU05hdiAoU3BhdGlhbCBOYXZpZ2Fpb24pIG9uL29mZgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3MTQgKFF0IEFQSSBwYXJ0KQorCisgICAg
ICAgIEFkZGVkICdTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQnIGF0dHJpYnV0ZSB0byBRV2ViU2V0
dGluZ3MuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKFFXZWJT
ZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6CisK
IDIwMTAtMDEtMTQgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCi0tIAoxLjYuMC40Cgo=
</data>
<flag name="review"
          id="29001"
          type_id="1"
          status="-"
          setter="hausmann"
    />
    <flag name="commit-queue"
          id="29002"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>46879</attachid>
            <date>2010-01-18 19:35:10 -0800</date>
            <delta_ts>2010-03-05 08:33:43 -0800</delta_ts>
            <desc>(committed in r55579) patch 0.3</desc>
            <filename>0003--Qt-QWebSettings-attribute-for-toggle-SNav-Spatial.patch</filename>
            <type>text/plain</type>
            <size>4199</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSA1ZWNjMmEzMDdlYmI1OTM1NzBmN2Q5YTU2NzczOGQ0M2E1M2RhOTFmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVGh1LCAxNCBKYW4gMjAxMCAxMjozNjozNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtR
dF0gUVdlYlNldHRpbmdzIGF0dHJpYnV0ZSBmb3IgdG9nZ2xlIFNOYXYgKFNwYXRpYWwgTmF2aWdh
aW9uKSBvbi9vZmYKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzcx
NCAoUXQgQVBJIHBhcnQpCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50
b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5jb20+CgpBZGRlZCAnU3BhdGlhbE5hdmlnYXRp
b25FbmFibGVkJyBhdHRyaWJ1dGUgdG8gUVdlYlNldHRpbmdzLgoKKiBBcGkvcXdlYnNldHRpbmdz
LmNwcDoKKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKiBBcGkvcXdlYnNldHRpbmdzLmg6
Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3BwIHwgICAxMiArKysrKysrKysrKysK
IFdlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmggICB8ICAgIDMgKystCiBXZWJLaXQvcXQvQ2hh
bmdlTG9nICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwg
MjcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv
QXBpL3F3ZWJzZXR0aW5ncy5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKaW5k
ZXggZDdkMzc1Yi4uZmU1MmZiOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGlu
Z3MuY3BwCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcApAQCAtMTY5LDYgKzE2
OSwxMCBAQCB2b2lkIFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KCkKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0
aW5nczo6UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCkpOwogICAgICAgICBzZXR0aW5ncy0+c2V0UHJp
dmF0ZUJyb3dzaW5nRW5hYmxlZCh2YWx1ZSk7CiAKKyAgICAgICAgdmFsdWUgPSBhdHRyaWJ1dGVz
LnZhbHVlKFFXZWJTZXR0aW5nczo6U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkLAorICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9iYWwtPmF0dHJpYnV0ZXMudmFsdWUoUVdl
YlNldHRpbmdzOjpTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQpKTsKKyAgICAgICAgc2V0dGluZ3Mt
PnNldFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZCh2YWx1ZSk7CisKICAgICAgICAgdmFsdWUgPSBh
dHRyaWJ1dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbkFjY2Vzc0NsaXBib2Fy
ZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2xvYmFsLT5hdHRyaWJ1
dGVzLnZhbHVlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbkFjY2Vzc0NsaXBib2FyZCkpOwog
ICAgICAgICBzZXR0aW5ncy0+c2V0RE9NUGFzdGVBbGxvd2VkKHZhbHVlKTsKQEAgLTM0Myw2ICsz
NDcsMTMgQEAgUVdlYlNldHRpbmdzKiBRV2ViU2V0dGluZ3M6Omdsb2JhbFNldHRpbmdzKCkKICAg
ICAgICAgQ3VycmVudGx5IHRoaXMgZW5hYmxlcyB0aGUgIkluc3BlY3QiIGVsZW1lbnQgaW4gdGhl
IGNvbnRleHQgbWVudSBhcwogICAgICAgICB3ZWxsIGFzIHRoZSB1c2Ugb2YgUVdlYkluc3BlY3Rv
ciB3aGljaCBjb250cm9scyB0aGUgV2ViS2l0IFdlYkluc3BlY3RvcgogICAgICAgICBmb3Igd2Vi
IHNpdGUgZGVidWdnaW5nLgorICAgIFx2YWx1ZSBTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQgRW5h
YmxlcyBvciBkaXNhYmxlcyB0aGUgU3BhdGlhbCBOYXZpZ2F0aW9uCisgICAgICAgIGZlYXR1cmUs
IHdoaWNoIGNvbnNpc3RzIGluIHRoZSBhYmlsaXR5IHRvIG5hdmlnYXRlIGJldHdlZW4gZm9jdXNh
YmxlCisgICAgICAgIGVsZW1lbnRzIGluIGEgV2ViIHBhZ2UsIHN1Y2ggYXMgaHlwZXJsaW5rcyBh
bmQgZm9ybSBjb250cm9scywgYnkgdXNpbmcKKyAgICAgICAgTGVmdCwgUmlnaHQsIFVwIGFuZCBE
b3duIGFycm93IGtleXMuIEZvciBleGFtcGxlLCBpZiBhbiB1c2VyIHByZXNzZXMgdGhlCisgICAg
ICAgIFJpZ2h0IGtleSwgaGV1cmlzdGljcyBkZXRlcm1pbmUgd2hldGhlciB0aGVyZSBpcyBhbiBl
bGVtZW50IGhlIG1pZ2h0IGJlCisgICAgICAgIHRyeWluZyB0byByZWFjaCB0b3dhcmRzIHRoZSBy
aWdodCwgYW5kIGlmIHRoZXJlIGFyZSBtdWx0aXBsZSBlbGVtZW50cywKKyAgICAgICAgd2hpY2gg
ZWxlbWVudCBoZSBwcm9iYWJseSB3YW50cy4KICAgICBcdmFsdWUgTGlua3NJbmNsdWRlZEluRm9j
dXNDaGFpbiBTcGVjaWZpZXMgd2hldGhlciBoeXBlcmxpbmtzIHNob3VsZCBiZQogICAgICAgICBp
bmNsdWRlZCBpbiB0aGUga2V5Ym9hcmQgZm9jdXMgY2hhaW4uCiAgICAgXHZhbHVlIFpvb21UZXh0
T25seSBTcGVjaWZpZXMgd2hldGhlciB0aGUgem9vbSBmYWN0b3Igb24gYSBmcmFtZSBhcHBsaWVz
IHRvCkBAIC0zODIsNiArMzkzLDcgQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3MoKQogICAg
IGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6QXV0b0xvYWRJbWFnZXMsIHRydWUp
OwogICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6RG5zUHJlZmV0Y2hFbmFi
bGVkLCBmYWxzZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpKYXZh
c2NyaXB0RW5hYmxlZCwgdHJ1ZSk7CisgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRp
bmdzOjpTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQsIGZhbHNlKTsKICAgICBkLT5hdHRyaWJ1dGVz
Lmluc2VydChRV2ViU2V0dGluZ3M6OkxpbmtzSW5jbHVkZWRJbkZvY3VzQ2hhaW4sIHRydWUpOwog
ICAgIGQtPmF0dHJpYnV0ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6Wm9vbVRleHRPbmx5LCBmYWxz
ZSk7CiAgICAgZC0+YXR0cmlidXRlcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpQcmludEVsZW1lbnRC
YWNrZ3JvdW5kcywgdHJ1ZSk7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5n
cy5oIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuaAppbmRleCAzMmFmNDQ4Li44OWZlMDk4
IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5oCisrKyBiL1dlYktpdC9x
dC9BcGkvcXdlYnNldHRpbmdzLmgKQEAgLTY4LDcgKzY4LDggQEAgcHVibGljOgogI2VuZGlmCiAg
ICAgICAgIExvY2FsQ29udGVudENhbkFjY2Vzc1JlbW90ZVVybHMsCiAgICAgICAgIERuc1ByZWZl
dGNoRW5hYmxlZCwKLSAgICAgICAgWFNTQXVkaXRvckVuYWJsZWQKKyAgICAgICAgWFNTQXVkaXRv
ckVuYWJsZWQsCisgICAgICAgIFNwYXRpYWxOYXZpZ2F0aW9uRW5hYmxlZAogICAgIH07CiAgICAg
ZW51bSBXZWJHcmFwaGljIHsKICAgICAgICAgTWlzc2luZ0ltYWdlR3JhcGhpYywKZGlmZiAtLWdp
dCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDYyZjJi
NjQuLjNjYzA3M2QgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0
L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAxLTE0ICBBbnRvbmlvIEdvbWVz
ICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgW1F0XSBRV2ViU2V0dGluZ3MgYXR0cmlidXRlIGZvciB0b2dnbGUg
U05hdiAoU3BhdGlhbCBOYXZpZ2Fpb24pIG9uL29mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM3MTQgKFF0IEFQSSBwYXJ0KQorCisgICAgICAgIEFk
ZGVkICdTcGF0aWFsTmF2aWdhdGlvbkVuYWJsZWQnIGF0dHJpYnV0ZSB0byBRV2ViU2V0dGluZ3Mu
CisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoKKyAgICAgICAgKFFXZWJTZXR0aW5n
c1ByaXZhdGU6OmFwcGx5KToKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmg6CisKIDIwMTAt
MDEtMTQgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCi0tIAoxLjYuMC40Cgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>