33709 2010-01-15 02:20:46 -0800 Cleanup: Typedef DragOperation as type int 2010-06-10 20:21:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All NEW P2 Normal --- 1 dbates webkit-unassigned aroben bweinstein eric oliver oldest_to_newest 181164 0 dbates 2010-01-15 02:20:46 -0800 Following up on a remark brought up by Eric Seidel <https://bugs.webkit.org/show_bug.cgi?id=24731#c25>, we should typedef DragOperation as type int since it is also used to compose bitwise masks of multiple drag operations. Use of DragOperation as a bitwise mask appears in: Clipboard.cpp: <http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L71> <http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L73> <http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L75> <http://trac.webkit.org/browser/trunk/WebCore/dom/Clipboard.cpp?rev=53301#L83> DragController.cpp: <http://trac.webkit.org/browser/trunk/WebCore/page/DragController.cpp?rev=53296#L639> 181165 1 46660 dbates 2010-01-15 02:25:02 -0800 Created attachment 46660 Patch No functionality was changed. So, no new tests. 181166 2 46660 oliver 2010-01-15 02:27:00 -0800 Comment on attachment 46660 Patch I suspect this will break windows due to missing window export file updates 181169 3 eric 2010-01-15 02:32:33 -0800 Attachment 46660 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/189110 181170 4 46660 dbates 2010-01-15 02:42:06 -0800 Comment on attachment 46660 Patch Clearing review flag, while I look into this. There seems to be signed/unsigned mismatching issues. 181230 5 aroben 2010-01-15 07:47:43 -0800 I think it would be better to leave DragOperation as an enum, but introduce a new DragOperationMask typedef (we normally use unsigned for this). Then we'd use DragOperationMask everywhere that multiple DragOperations are combined. 46660 2010-01-15 02:25:02 -0800 2010-06-10 20:21:10 -0700 Patch Bug33709.patch text/plain 3708 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDEtMTUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzcwOQorCisgICAgICAgIFdl IHNob3VsZCBtYWtlIERyYWdPcGVyYXRpb24gYW4gaW50IGFuZCBkZWNsYXJlIHRoZSB2YXJpb3Vz IGRyYWcKKyAgICAgICAgb3BlcmF0aW9ucyBpbiBhbiBhbm9ueW1vdXMgZW51bSBzaW5jZSBhIERy YWdPcGVyYXRpb24gY2FuIGVpdGhlciBiZQorICAgICAgICBhIHNpbmdsZSBraW5kIG9mIGRyYWcg b3BlcmF0aW9uIG9yIGJlIHVzZWQgdG8gcmVwcmVzZW50IGEgYml0d2lzZQorICAgICAgICBtYXNr IG9mIG11bHRpcGxlIG9wZXJhdGlvbnMuCisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0eSB3YXMg Y2hhbmdlZC4gU28sIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIFdlYkNvcmUuRHJhZ1N1cHBv cnQuZXhwOiBSZW1vdmVkIHVubmVjZXNzYXJ5IHN5bWJvbHMuCisgICAgICAgICogZG9tL0NsaXBi b2FyZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpkcmFnT3BGcm9tSUVPcCk6CisgICAgICAgICog cGFnZS9EcmFnQWN0aW9ucy5oOiBBbm9ueW1pemVkIGVudW0gRHJhZ09wZXJhdGlvbi4gVHlwZWRl ZiBEcmFnT3BlcmF0aW9uCisgICAgICAgIHRvIGJlIG9mIHR5cGUgaW50LgorICAgICAgICAoV2Vi Q29yZTo6KToKKwogMjAxMC0wMS0xMyAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3 YXJkYmlhcy5pbj4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6 IFdlYkNvcmUvV2ViQ29yZS5EcmFnU3VwcG9ydC5leHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9X ZWJDb3JlLkRyYWdTdXBwb3J0LmV4cAkocmV2aXNpb24gNTMzMTkpCisrKyBXZWJDb3JlL1dlYkNv cmUuRHJhZ1N1cHBvcnQuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsMyBAQAotX19aTjdX ZWJDb3JlMTJFdmVudEhhbmRsZXIxN2RyYWdTb3VyY2VFbmRlZEF0RVJLTlNfMThQbGF0Zm9ybU1v dXNlRXZlbnRFTlNfMTNEcmFnT3BlcmF0aW9uRQogX19aTjdXZWJDb3JlMTJFdmVudEhhbmRsZXIx N2V2ZW50TWF5U3RhcnREcmFnRVA3TlNFdmVudAogX19aTjdXZWJDb3JlMTREcmFnQ29udHJvbGxl cjEwZHJhZ0V4aXRlZEVQTlNfOERyYWdEYXRhRQogX19aTjdXZWJDb3JlMTREcmFnQ29udHJvbGxl cjExZHJhZ0VudGVyZWRFUE5TXzhEcmFnRGF0YUUKQEAgLTYsNCArNSwzIEBAIF9fWk43V2ViQ29y ZTE0RHJhZ0NvbnRyb2xsZXIxMWRyYWdVcGRhdGUKIF9fWk43V2ViQ29yZTE0RHJhZ0NvbnRyb2xs ZXIxMXBlcmZvcm1EcmFnRVBOU184RHJhZ0RhdGFFCiBfX1pON1dlYkNvcmUxNERyYWdDb250cm9s bGVyMTRwbGFjZURyYWdDYXJldEVSS05TXzhJbnRQb2ludEUKIF9fWk43V2ViQ29yZTE0RHJhZ0Nv bnRyb2xsZXI5ZHJhZ0VuZGVkRXYKLV9fWk43V2ViQ29yZThEcmFnRGF0YUMxRVAxMW9iamNfb2Jq ZWN0UktOU184SW50UG9pbnRFUzVfTlNfMTNEcmFnT3BlcmF0aW9uRVBOU18xNlBhc3RlYm9hcmRI ZWxwZXJFCkluZGV4OiBXZWJDb3JlL2RvbS9DbGlwYm9hcmQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvZG9tL0NsaXBib2FyZC5jcHAJKHJldmlzaW9uIDUzMzE5KQorKysgV2ViQ29yZS9kb20v Q2xpcGJvYXJkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjgsMTEgKzY4LDExIEBAIHN0YXRpYyBE cmFnT3BlcmF0aW9uIGRyYWdPcEZyb21JRU9wKGNvbnMKICAgICBpZiAob3AgPT0gIm1vdmUiKQog ICAgICAgICByZXR1cm4gRHJhZ09wZXJhdGlvbkdlbmVyaWM7ICAgIC8vIEZJWE1FOiBXaHkgaXMg dGhpcyBEcmFnT3BlcmF0aW9uR2VuZXJpYz8gPGh0dHA6Ly93ZWJraXQub3JnL2IvMzM2OTc+CiAg ICAgaWYgKG9wID09ICJjb3B5TGluayIpCi0gICAgICAgIHJldHVybiAoRHJhZ09wZXJhdGlvbiko RHJhZ09wZXJhdGlvbkNvcHkgfCBEcmFnT3BlcmF0aW9uTGluayk7CisgICAgICAgIHJldHVybiBE cmFnT3BlcmF0aW9uQ29weSB8IERyYWdPcGVyYXRpb25MaW5rOwogICAgIGlmIChvcCA9PSAiY29w eU1vdmUiKQotICAgICAgICByZXR1cm4gKERyYWdPcGVyYXRpb24pKERyYWdPcGVyYXRpb25Db3B5 IHwgRHJhZ09wZXJhdGlvbkdlbmVyaWMgfCBEcmFnT3BlcmF0aW9uTW92ZSk7CisgICAgICAgIHJl dHVybiBEcmFnT3BlcmF0aW9uQ29weSB8IERyYWdPcGVyYXRpb25HZW5lcmljIHwgRHJhZ09wZXJh dGlvbk1vdmU7CiAgICAgaWYgKG9wID09ICJsaW5rTW92ZSIpCi0gICAgICAgIHJldHVybiAoRHJh Z09wZXJhdGlvbikoRHJhZ09wZXJhdGlvbkxpbmsgfCBEcmFnT3BlcmF0aW9uR2VuZXJpYyB8IERy YWdPcGVyYXRpb25Nb3ZlKTsKKyAgICAgICAgcmV0dXJuIERyYWdPcGVyYXRpb25MaW5rIHwgRHJh Z09wZXJhdGlvbkdlbmVyaWMgfCBEcmFnT3BlcmF0aW9uTW92ZTsKICAgICBpZiAob3AgPT0gImFs bCIpCiAgICAgICAgIHJldHVybiBEcmFnT3BlcmF0aW9uRXZlcnk7CiAgICAgcmV0dXJuIERyYWdP cGVyYXRpb25Qcml2YXRlOyAgLy8gcmVhbGx5IGEgbWFya2VyIGZvciAibm8gY29udmVyc2lvbiIK SW5kZXg6IFdlYkNvcmUvcGFnZS9EcmFnQWN0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGFnZS9EcmFnQWN0aW9ucy5oCShyZXZpc2lvbiA1MzMxOSkKKysrIFdlYkNvcmUvcGFnZS9EcmFn QWN0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICB9IERyYWdTb3VyY2VBY3Rpb247CiAgICAgCiAgICAgLy9tYXRjaGVzIE5TRHJh Z09wZXJhdGlvbgotICAgIHR5cGVkZWYgZW51bSB7CisgICAgZW51bSB7CiAgICAgICAgIERyYWdP cGVyYXRpb25Ob25lICAgID0gMCwKICAgICAgICAgRHJhZ09wZXJhdGlvbkNvcHkgICAgPSAxLAog ICAgICAgICBEcmFnT3BlcmF0aW9uTGluayAgICA9IDIsCkBAIC01OSw3ICs1OSwxMCBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIERyYWdPcGVyYXRpb25Nb3ZlICAgID0gMTYsCiAgICAg ICAgIERyYWdPcGVyYXRpb25EZWxldGUgID0gMzIsCiAgICAgICAgIERyYWdPcGVyYXRpb25FdmVy eSAgID0gVUlOVF9NQVgKLSAgICB9IERyYWdPcGVyYXRpb247CisgICAgfTsKKyAgICAvLyBOb3Rl LCBhIGRyYWcgb3BlcmF0aW9uIGNhbiBlaXRoZXIgcmVwcmVzZW50IGV4YWN0bHkgb25lIHRoZSBh Ym92ZSBvcGVyYXRpb25zCisgICAgLy8gb3IgdXNlZCBhcyBhIGJpdHdpc2UgbWFzayBvZiBtdWx0 aXBsZSBvcGVyYXRpb25zLgorICAgIHR5cGVkZWYgaW50IERyYWdPcGVyYXRpb247CiAgICAgCiB9 CiAK