33704 2010-01-14 22:27:58 -0800 [Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy 2010-01-14 22:56:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow webkit-unassigned oldest_to_newest 181100 0 jorlow 2010-01-14 22:27:58 -0800 [Chromium] Forgot to adopt a ref counted object in StorageNamespaceProxy 181101 1 46642 jorlow 2010-01-14 22:28:19 -0800 Created attachment 46642 Patch 181105 2 46642 oliver 2010-01-14 22:47:24 -0800 Comment on attachment 46642 Patch r=me, i really wish there were a way to detect this kind of error :-( 181107 3 jorlow 2010-01-14 22:56:13 -0800 Committed r53321: <http://trac.webkit.org/changeset/53321> 46642 2010-01-14 22:28:19 -0800 2010-01-14 22:47:24 -0800 Patch bug-33704-20100114222818.patch text/plain 1894 jorlow SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTMzMTkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMTQgIEplcmVt eSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBGb3Jnb3QgdG8gYWRvcHQgYSByZWYg Y291bnRlZCBvYmplY3QgaW4gU3RvcmFnZU5hbWVzcGFjZVByb3h5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzcwNAorCisgICAgICAgICogc3JjL1N0 b3JhZ2VOYW1lc3BhY2VQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlTmFtZXNw YWNlOjpsb2NhbFN0b3JhZ2VOYW1lc3BhY2UpOgorICAgICAgICAoV2ViQ29yZTo6U3RvcmFnZU5h bWVzcGFjZTo6c2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UpOgorCiAyMDEwLTAxLTE0ICBNYXJjdXMg QnVsYWNoICA8YnVsYWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1p dHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1N0b3JhZ2VOYW1lc3BhY2VQ cm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9TdG9yYWdlTmFtZXNw YWNlUHJveHkuY3BwCShyZXZpc2lvbiA1MzMxOSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvU3Rv cmFnZU5hbWVzcGFjZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsMTQgKzQ0LDE0IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogUGFzc1JlZlB0cjxTdG9yYWdlTmFtZXNwYWNlPiBTdG9y YWdlTmFtZXNwYWNlOjpsb2NhbFN0b3JhZ2VOYW1lc3BhY2UoY29uc3QgU3RyaW5nJiBwYXRoLCB1 bnNpZ25lZCBxdW90YSkKIHsKLSAgICByZXR1cm4gbmV3IFN0b3JhZ2VOYW1lc3BhY2VQcm94eShX ZWJLaXQ6OndlYktpdENsaWVudCgpLT5jcmVhdGVMb2NhbFN0b3JhZ2VOYW1lc3BhY2UocGF0aCwg cXVvdGEpKTsKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IFN0b3JhZ2VOYW1lc3BhY2VQcm94eShX ZWJLaXQ6OndlYktpdENsaWVudCgpLT5jcmVhdGVMb2NhbFN0b3JhZ2VOYW1lc3BhY2UocGF0aCwg cXVvdGEpKSk7CiB9CiAKIFBhc3NSZWZQdHI8U3RvcmFnZU5hbWVzcGFjZT4gU3RvcmFnZU5hbWVz cGFjZTo6c2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoUGFnZSogcGFnZSkKIHsKICAgICBXZWJLaXQ6 OkNocm9tZUNsaWVudEltcGwqIGNocm9tZUNsaWVudEltcGwgPSBzdGF0aWNfY2FzdDxXZWJLaXQ6 OkNocm9tZUNsaWVudEltcGwqPihwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCkpOwogICAgIFdlYktp dDo6V2ViVmlld0NsaWVudCogd2ViVmlld0NsaWVudCA9IGNocm9tZUNsaWVudEltcGwtPndlYlZp ZXcoKS0+Y2xpZW50KCk7Ci0gICAgcmV0dXJuIG5ldyBTdG9yYWdlTmFtZXNwYWNlUHJveHkod2Vi Vmlld0NsaWVudC0+Y3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKSk7CisgICAgcmV0dXJu IGFkb3B0UmVmKG5ldyBTdG9yYWdlTmFtZXNwYWNlUHJveHkod2ViVmlld0NsaWVudC0+Y3JlYXRl U2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2UoKSkpOwogfQogCiBTdG9yYWdlTmFtZXNwYWNlUHJveHk6 OlN0b3JhZ2VOYW1lc3BhY2VQcm94eShXZWJLaXQ6OldlYlN0b3JhZ2VOYW1lc3BhY2UqIHN0b3Jh Z2VOYW1lc3BhY2UpCg==